Jump to content
ryan

Map Marker Map

Recommended Posts

7 minutes ago, hellomoto said:

In my page editor only the map is showing for the field, no inputs. ??? PW 2.7.2

 

  • Like 2

Share this post


Link to post
Share on other sites

Hmm, I'd like to use many of these in a repeater. Or actually, 2 levels deep: MapMarker in a repeater in a repeater. (Think a travel journal with 2 or 3 locations for 14 days)

The MapMarker Map is only displayed in the editor when the inputs are expanded upon load. When I collapse one repeater or another (visibility or AJAX) then the map stays empty. This means my editor will be confusing, very long and creating new entries will require saving.

Is there an easy way to fix this?

Thanks
Martin

Share this post


Link to post
Share on other sites

@adrian Thank you, that was not the right solution. But it made me investigate in the right place:

InputfieldMapMarker's init function is never called. At the bottom, InputfieldMapMarker.js says:

$(document).ready(function() {
    $(".InputfieldMapMarkerMap").each(function() {
        var $t = $(this);
        InputfieldMapMarker.init($t.attr('id'), $t.attr('data-lat'), $t.attr('data-lng'), $t.attr('data-zoom'), $t.attr('data-type')); 
    }); 
}); 

When the $(document) is ready() there are no $(".InputfieldMapMarkerMap")s yet, as they will be AJAX-loaded later.

So I guess we need an event that is fired after each successful AJAX call, so we can InputfieldMapMarker.init() all those Maps which haven't been initialized before. Is there a way to register a listener for such events?

Share this post


Link to post
Share on other sites

Good day!

Really sorry if this has been answered - I really tried to read through 17 pages of this topic, but I could easily miss something.

I need to implement map re-center on window resize. I found this tip among others, but I just do not know where to put the code). I generate markup in php the standard way like this:

<?php
	echo $map->render($page, 'map', array('height' => '400px'));
?>

Please point me to the place I can put all those event listeners from the Google maps API.
 

Share this post


Link to post
Share on other sites

@bernhard Thanks for that. But the thing I do not understand is how to get the right map object in js. It should be instantiated already by that render method (hope I am using the right terms))

Share this post


Link to post
Share on other sites

Ok, I think I got this figured out.

When you call something like

$map->render($page, 'map', array('id' => 'jsMap',));

with the id option the wrapper MarkupGoogleMap js object is created with the same name as id provided.

The google maps object is accessible as its map property, like this:

jsMap.map;

with all the good stuff from the API at your disposal.

Share this post


Link to post
Share on other sites

I hook into Pages::saved to detect field changes, but this Fieldtype never comes up in the $changes = $event->arguments[1] array. Any idea? This should behave like any other field, so if you move the marker it is a change, right?

Share this post


Link to post
Share on other sites

Just installed PW and GoogleMapMarkup(didn't work with PW and google map for a while) and in admin map fields works fine, I have added google key... But in front end when i render map I got error Error: Please add the maps.google.com script in your document head.

I have added script to header, and everything else on the right place. But still gor error, also I have error about google namespace:"MarkupGoogleMap is not a function", before i have error: google map initMap is not a function. So I changed function in map url to MarkupGoogleMap <script src="https://maps.googleapis.com/maps/api/js?key=AIzaSyBfuPL8-V9WoZBU8fZ26NuP7I9SuZoqYmA&callback=MarkupGoogleMap" async defer></script>

I think that this has something to do with google api. Is someone have simillar problem and maybe some answer to errors?

 

Share this post


Link to post
Share on other sites

Same problem here with MapMarker and PW3. If you look at the source code, it looks messed up:

mapmarkersource.png

Share this post


Link to post
Share on other sites

I have the module installed and it seems to be working correctly. On the output to a page I have the map generating as expected. I do have a question and it's more of an annoyance that is probably an easy fix. Should the map have the following text output before the map is generated? " MarkupGoogleMap " I'd really prefer not to see this markup displayed on the page.

Gmap.png

Share this post


Link to post
Share on other sites
On 11/21/2016 at 4:55 PM, fliwatuet said:

It is working for me now, I guess it is a problem within your template file @alec.

Didn't have time to search more. I am now on leaflet map.

Share this post


Link to post
Share on other sites

I've found a bug in this module, if you set the field's settings to be closed when populated, you must trigger a resize event in order for the map to render when the field is expanded after the field has been populated and saved.

Share this post


Link to post
Share on other sites
3 hours ago, CaelanStewart said:

I've found a bug in this module, if you set the field's settings to be closed when populated, you must trigger a resize event in order for the map to render when the field is expanded after the field has been populated and saved.

Check out the top two PR's: https://github.com/ryancramerdesign/FieldtypeMapMarker/pulls

Hopefully the second one down will take care of it. I have used that for when this field is in a fieldsettab and it works.

Share this post


Link to post
Share on other sites
9 minutes ago, cyberderf said:

Is this module compatible with 3.x versions of PCW?

Yep!

  • Like 2

Share this post


Link to post
Share on other sites

I'm calling MapMarkers from 'place' pages to get a Google Map with all places, using this code:

	$map = $modules->get('MarkupGoogleMap'); 
	$places = $pages->find("template=places, MapMarker!=''"); 
	echo "<br><br>" . $map->render($places, 'MapMarker', array('height' => '400px', 'zoom' => '7')); 

It works fine in PW 2.7.2. It doesn't work in PW 3.0.36. The map starts loading then gives an error "This page didn't load Google Maps correctly. See the JavaScript console for technical details", that says "Using //@ to indicate sourceMappingURL pragmas is deprecated. Use //# instead". In the admin interface the map loads fine. Any ideas to make it work?

Share this post


Link to post
Share on other sites

For those people who cannot get this to work in PW3, the instructions say to put this in your head:

<script type='text/javascript' src='https://maps.googleapis.com/maps/api/js?sensor=false'></script>

This actually needs to be:

<script src="https://maps.googleapis.com/maps/api/js?key=<?= $modules->get('FieldtypeMapMarker')->get('googleApiKey') ?>"></script>

Or however you like to include your JS files. The sensor=false is no longer needed, but the API key is. Seemed to work for me, I havent had time to investigate the inner workings of the module to see if this should be done or not but is just a bug.

Happy mapping.

  • Like 4
  • Thanks 3

Share this post


Link to post
Share on other sites

Anyone had an issue with it getting stuck in satellite mode?  (On the admin side and on the front side?)

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By bernhard
      --- Please use RockFinder3 ---
    • By MoritzLost
      Cacheable Placeholders
      This module allows you to have pieces of dynamic content inside cached output. This aims to solve the common problem of having a mostly cacheable site, but with pieces of dynamic output here and there.  Consider this simple example, where you want to output a custom greeting to the current user:
      <h1>Good morning, <?= ucfirst($user->name) ?></h1> This snippet means you can't use the template cache (at least for logged-in users), because each user has a different name. Even if 99% of your output is static, you can only cache the pieces that you know won't include this personal greeting. A more common example would be CSRF tokens for HTML forms - those need to be unique by definition, so you can't cache the form wholesale.
      This module solves this problem by introducing cacheable placeholders - small placeholder tokens that get replaced during every request. The replacement is done inside a Page::render hook so it runs during every request, even if the response is served from the template cache. So you can use something like this:
      <h1>Good morning, {{{greeting}}}</h1> Replacement tokens are defined with a callback function that produces the appropriate output and added to the module through a simple hook:
      // site/ready.php wire()->addHookAfter('CachePlaceholders::getTokens', function (HookEvent $e) { $tokens = $e->return; $tokens['greeting'] = [ 'callback' => function (array $tokenData) { return ucfirst(wire('user')->name); } ]; $e->return = $tokens; }); Tokens can also include parameters that are parsed and passed to the callback function. There are more fully annotated examples and step-by-step instructions in the README on Github!
      Features
      A simple and fast token parser that calls the appropriate callback and runs automatically. Tokens may include multiple named or positional parameters, as well as multi-value parameters. A manual mode that allows you to replace tokens in custom pieces of cached content (useful if you're using the $cache API). Some built-in tokens for common use-cases: CSRF-Tokens, replacing values from superglobals and producing random hexadecimal strings. The token format is completely customizable, all delimiters can be changed to avoid collisions with existing tag parsers or template languages. Links
      Github Repository & documentation Module directory (pending approval) If you are interested in learning more, the README is very extensive, with more usage examples, code samples and usage instructions!
    • By Craig
      I've been using Fathom Analytics for a while now and on a growing number of sites, so thought it was about time there was a PW module for it.
      WayFathomAnalytics
      WayFathomAnalytics is a group of modules which will allow you to view your Fathom Analytics dashboard in the PW admin panel and (optionally) automatically add and configure the tracking code on front-end pages.
      Links
      GitHub Readme & documentation Download Zip Modules directory Module settings screenshot What is Fathom Analytics?
      Fathom Analytics is a simple, privacy-focused website analytics tool for bloggers and businesses.

      Stop scrolling through pages of reports and collecting gobs of personal data about your visitors, both of which you probably don't need. Fathom is a simple and private website analytics platform that lets you focus on what's important: your business.
      Privacy focused Fast-loading dashboards, all data is on a single screen Easy to get what you need, no training required Unlimited email reports Private or public dashboard sharing Cookie notices not required (it doesn't use cookies or collect personal data) Displays: top content, top referrers, top goals and more
    • By daniels
      This is a lightweight alternative to other newsletter & newsletter-subscription modules.
      You can find the Module in the Modules directory and on Github
      It can subscribe, update, unsubscribe & delete a user in a list in Mailchimp with MailChimp API 3.0. It does not provide any forms or validation, so you can feel free to use your own. To protect your users, it does not save any user data in logs or sends them to an admin.
      This module fits your needs if you...
      ...use Mailchimp as your newsletter / email-automation tool ...want to let users subscribe to your newsletter on your website ...want to use your own form, validation and messages (with or without the wire forms) ...don't want any personal user data saved in any way in your ProcessWire environment (cf. EU data regulation terms) ...like to subscribe, update, unsubscribe or delete users to/from different lists ...like the Mailchimp UI for creating / sending / reviewing email campaigns *I have only tested it with PHP 7.x so far, so use on owners risk
      EDIT:
      Since 0.0.4, instructions and changelog can be found in the README only. You can find it here  🙂
      If you have questions or like to contribute, just post a reply or create an issue or pr on github, thanks!
    • By MoritzLost
      Sorry for the convoluted title. I have a problem with Process modules that define a custom page using the page key through getModuleInfo (as demonstrated in this excellent tutorial by @bernhard). Those pages are created automatically when the module is installed. The problem is that the title of the page only gets set in the current language. That's not a problem if the current language (language of the superuser who is installing the module) is the default language; if it isn't, the Process page is missing a title in the default language. This has the very awkward effect that a user using the backend in the default language (or any other language) will see an empty entry in the setup menu:

      This screenshot comes from my Cache Control module which includes a Process page. Now I realize the description sounds obscure, but for us it's a common setup: We a multiple bilingual sites where the default language is German and the second language is English. While the clients use the CMS in German, as a developer I prefer the English interface, so whenever I install a Process module I get this problem.
      As a module author, is there a way to handle this situation? I guess it would be possible to use post-installation hooks or create the pages manually, but I very much prefer the declarative approach. The page title is already translatable (through the __ function), but of course at the time of installation there is no translation, and as far as I'm aware it's not possible to ship translations with a module so they are used automatically. Could this situation be handled better in the core? I would prefer if the module installation process would always set the title of the Process page in the default language, instead of the language of the current user.
×
×
  • Create New...