Jump to content

adrian

PW-Moderators
  • Content Count

    9,444
  • Joined

  • Last visited

  • Days Won

    312

Everything posted by adrian

  1. What about ditching the "3" ? IIRC there wasn't an API variable for the first version anyway, was there? Wouldn't this be cleaner going forward?
  2. Just to clarify, are you do a Modules > Refresh? It also works fine for me. But. again, please don't use this technique for CSS tweaks - it will result in lots of unnecessary pain when the core version of the module is updated.
  3. Ok, but overriding CSS doesn't require creating a new copy of the module. Just inject the CSS you want into the PW admin - I use AdminOnSteroids for this, but there are other ways.
  4. Hi @Mike-it - I have updated the module to fix this. I have also done a lot of code cleanup and a few improvements. Let me know how it goes.
  5. Deprecated, not yet removed, so no need to totally panic, although there are a few problematic bugs with PW and MySQL 8 that I have discovered and am notifying Ryan as I find them. Keep in mind that v8 has been the stable release for 2 years now.
  6. Just an FYI for anyone who reads this - this is deprecated since MySQL 8: https://dev.mysql.com/doc/refman/8.0/en/information-functions.html#function_found-rows I have told Ryan here: https://github.com/processwire/processwire-issues/issues/1146#issuecomment-629428382
  7. https://docs.gravityview.co/article/626-google-maps-error-referernotallowedmaperror Looks like you haven't set up your Google account to allow access from your site's domain.
  8. Firstly, are you sure you need to modify the module for "style editing"? In case you haven't read already: https://processwire.com/docs/modules/guides/comments/ Secondly, if you do find you need to modify, I would consider upgrading to the very latest dev as there have been some major changes to the comments field and an important bug fix. Consider those before worrying about why the approach you are taking isn't working yet.
  9. @gornycreative - https://github.com/rolandtoth/AdminOnSteroids/issues/118
  10. Hey @bernhard - do you have support for getting fields from a page reference field? Something like: addColumns(['title', 'pagefield.title']) I feel like this should be fairly easy if the page field is a single item only. Not sure the best approach if it is set up to store references to multiple pages though. I guess this is similar to your support for the Options fieldtype where you use: "OptionsValue:sex" in the docs example. Any thoughts on whether this could be supported? I guess I could add it myself via the "columnTypes" folder, but I feel like this will be a common enough need that it should be included. Nevermind - I really should RTFM 🙂
  11. For those not following the Rockfinder3 thread, the latest version of Tracy includes a new barEcho() / be() method that allows you to echo directly to the bar dumps panel without Tracy trying to dump it as variables / objects. You've always been able to do this directly in the Console panel with a normal echo, but now you can do the same to the bar dumps panel.
  12. @bernhard - the new barEcho() version of Tracy has been committed.
  13. @bernhard - I've added a new "Title Prefix" option for accomplishing that. I took a quick look but don't have an easy solution at the moment without hacking the Tracy core. The core actually already has a shift+click shortcut but it's for a weird popup browser window mode which I don't support - it became too painful with some of the more complex panels I've added and I didn't see the advantage. Maybe I'll take a look again later at trying to override this, but given that we have a "maximize" panel button already, I'm not too motivated on this one.
  14. One thing you should probably change is the calls to db(), bdb(), etc so \TD::dumpBig, \TD::barDumpBig, etc. Those shortcut functions are optional in Tracy and some users may have disabled them. Otherwise, looks great! I'll commit those required changes to Tracy shortly. BTW, I am making a proper barEcho() and be() shortcut method because I actually think it's quite useful in general to be able to echo / render HTML into the bar Dumps panel.
  15. Hey @bernhard - attached is a new version that loads Tabulator if someone wants to make a dump() call directly to the page within their template file. Basically it just duplicates the JSloader functionality within this module. I was also thinking about maybe making a barDump() version that would emulate bd() but with Tabulator output, but didn't get there yet. I decided to take a look at adding a barDump() option. To test you'll need the new Rockfinder and TD.php files attached. Now you can call the new barDump() method from anywhere (including template files, and the Console panel) and Tracy Dumps panel will receive the tabulated output, or the dumped object if you pass "true" for the title. Please test thoroughly and feel free to tweak behavior as needed. I should note that I changed the return for the dump method from $this to $out. I guess this will break chaining if someone wants to add another method after this. Maybe there is a better way to do this but was in a hurry. RockFinder3.module.php TD.php
  16. Yeah, I just saw your post - that's too bad - hopefully there is a solution!
  17. Yeah, please do - I think it's going to prove quite painful if we can't generate queries that work independently. I make use of the "Selector Queries" feature on the RequestInfo panel in Tracy a LOT and it's no longer as useful. Sounds like Ryan is keen to come up with a fix, but an extra voice might help motivate him 🙂
  18. Remember you have some wording in the docs that needs changing, eg "The ProcessModule of RockFinder3 does use Tracy for dumping the results, so TracyDebugger is required for the ProcessModule to run."
  19. Assume you have read these: https://github.com/ryancramerdesign/ProcessWire/issues/710 https://github.com/ryancramerdesign/ProcessWire/issues/1757 He says that "whitespace is preferred in many cases", but I just don't get it - not sure how trailing whitespace has any advantage, but maybe I am missing something 🙂
  20. Sorry you find it ugly - I know it doesn't look nice, but it's one of my favorite things in Tracy - so nice to know which browser tab has the dev version vs live version of a site.
  21. Just have VSCode set up to automatically remove trailing spaces at the end of lines. It's a pet peeve of mine and something I wish Ryan would do with the PW core. Nothing new - it's just a shame that we can no longer see the values in query - makes it impossible to easily copy / paste a query into Adminer etc to test directly. Are you going to completely remove the Process module now? Does it serve some other purpose?
  22. @bernhard - test out the attached version which avoids the need for the Process module by loading the tabulator files on demand. RockFinder3.module.php
  23. @bernhard - you might be interested in this: https://github.com/processwire/processwire-issues/issues/1173#issuecomment-632868896 and Ryan's reply. Once you upgrade to the latest PW dev and use your dumpSQL() method you'll see what I mean 🙂
  24. I might give the FA icons a go. The reason I didn't initially is because they aren't loaded on the frontend of a site, but these days I do load them with Tracy for the custom links in the PW Info panel anyway, so it wouldn't be any extra load now, although I think someone mentioned they were having issues because they were using FA 5 on the frontend and there was some conflict. I'll think about it later.
×
×
  • Create New...