Jump to content

adrian

PW-Moderators
  • Content Count

    8,880
  • Joined

  • Last visited

  • Days Won

    302

Everything posted by adrian

  1. I have linked to @teppo's fork and added him as an author on the module.
  2. Guys - I can transfer the entry in the modules directory to @teppo if you want. Or if you're planning on creating a new version with a different name, maybe it's a new module in the directory? Let me know if you want me to make any changes. BTW - I am not a fan of frontend editing tools in general, but this one I actually don't mind providing for the right site - sometimes even for frontend only users.
  3. @tires - I just tested here with a period containing email address and it worked as expected. I think you'll need to debug at your end. Start at this line: https://github.com/Notanotherdotcom/ProcessEmailToPage/blob/6b192fc6e01e50217e8be2b0e48c8745824630ed/ProcessEmailToPage.module#L470 and make sure the message is in that array. Then go inside the foreach and figure out what rule in there is preventing the message from creating a new page which happens here: https://github.com/Notanotherdotcom/ProcessEmailToPage/blob/6b192fc6e01e50217e8be2b0e48c8745824630ed/ProcessEmailToPage.module#L522 Sorry, I think Pete is no longer supporting this module and I don't have much time to help out anymore either I'm afraid. Reality is that the flourish library that this module uses is also abandoned, so this module really needs to be rewritten with an alternate mail library. That said, it still works for me, so you should be able to figure out where the problem is that is affecting you.
  4. Tracy's RequestInfo panel has all the details I think you are looking for:
  5. @tires - could you please investigate where those "period containing" email addresses get ignored? Is the email being read, but not processed, or is it not read at all? Does it help if the "Only Users" checkbox is unchecked?
  6. In case anyone is interested, cloning also doesn't update the createdUser and modifiedUser values. I have submitted an issue: https://github.com/processwire/processwire-issues/issues/927 but in the meantime, I am using: $this->addHookAfter('Pages::cloned', function(HookEvent $event) { $p = $event->arguments(1); $p->createdUser = $this->wire('user'); $p->save(array('quiet' => true)); $sql = "UPDATE `pages` SET `modified_users_id` = '".$this->wire('user')->id."' WHERE `id` = '".$p->id."';"; $this->wire('db')->query($sql); }); Modified can't be changed via the API, hence the SQL. I suppose created could also be done this way, but hopefully this is just a temporary fix assuming Ryan agrees to change the current behavior.
  7. Nice enhancement to the file filtering in the File Editor panel thanks to @tpr that lets you arrow key up and down through results and Enter to open.
  8. @ttttim - have a read of this: https://processwire.com/blog/posts/pw-3.0.135/#step-4-decide-whether-to-to-enable-hsts-section-9f
  9. @tires - that error should be fixed in the latest version - not sure if that helps your issue with deletion of the email / duplicate copies of page creation though.
  10. Hi @Deyan - sorry about that - looks like I broke it a while ago. Should be all fixed in the latest version. Let me know how you go.
  11. @tires - it should already delete messages after the page has been created: https://github.com/Notanotherdotcom/ProcessEmailToPage/blob/548c9bff1d40aee7bf049032f78b301602517772/ProcessEmailToPage.module#L716 Perhaps you can debug why this isn't working?
  12. @teppo - that is what I thought, but I was thrown by the comment for that rule: "After uncommenting, test a URL like domain.com/site/assets/files/test.jpg to make sure you are getting a 404 and not your homepage." Those conditions don't seem to prevent apache from serving up a test.jpg at that path, although it occurs to me just now that Ryan's intention was for test.jpg to be a file that doesn't actually exist - makes sense now! I was also confused by the "prevent PW from attempting to serve images or anything in /site/assets/" - I thought he was talking about subfolders of assets as well. My initial thought was that this rile was actually about preventing hotlinking, so I think I got the intention backwards, hence my confusion 🙂
  13. Yeah I know - I had a LOT of work to do to fix the queries on a large custom application of mine, but from the reading I did at the time, it was a highly recommended change to better ensure you're getting the results you were expecting. Mine was very data / calculation heavy though, so maybe not as important for typical PW queries.
  14. I know Section 18 isn't new, but it seems like it doesn't work as expected. I feel like it is missing the actual RewriteRule after the conditions, or maybe I am misunderstanding what it's meant to do?
  15. Interesting that Ryan said this when he actually decided to force removal (https://github.com/processwire/processwire/blob/649d2569abc10bac43e98ca98db474dd3d6603ca/wire/config.php#L975) of the new mysql default for "ONLY_FULL_GROUP_BY", rather than properly rewriting the queries to work with the new default.
  16. Try the new version just committed. Not currently, but it should be pretty easy to implement - do you feel like having a go at enhancing the replaceShortcodes() method to handle this? PRs greatly appreciated!
  17. As @Robin S mentioned, I'd be happy to accept a PR for this enhancement!
  18. This is now fixed in the core.
  19. IMPORTANT NOTICE!!! Hi everyone. I just discovered something pretty important with this module. If you are using the Role Name or Custom PHP Code option and matching a page name or path, you MUST be sure to check "No Access" for the "If no match, give all access or no access?" setting. If you don't do this, a site editor could change the name of their branch parent, which would result in no match and hence they could gain access to the entire page tree. I am tempted to actually remove these two matching options to improve security - is anyone using them? To make life easier, I have added a new "Role Specified Branch Parent" option which allows you to select a branch parent on a per role basis, rather than per user. I think in most cases this is the best option to use. Please be sure to check your settings and if you can please switch to the "Role specified" or "User specified" options in the new version. Let me know if you have any questions or concerns. Thanks, Adrian
  20. Actually all of the above, but yes, the Tracy dump is a key part of it - so much easier to see which parts are being added to the selector this way. I do also sometimes modify parts by key, but I also just find my code looks cleaner that concatenating a string with commas at the end of each one, plus you don't have to worry about a possible trailing comma.
  21. PS, here's the thread @Robin S was referring to:
  22. Yeah, @Robin S is mostly correct. The array approach seems like a good idea, but it will end up biting you in many cases. For ease of readability and building up complex selectors, I do build them with a regular php array and then simply implode the array with a comma to get the string selector. This is now my goto approach for any complex dynamic selectors.
  23. https://github.com/processwire/processwire-issues/issues/905
  24. I've just commented on that old closed issue: https://github.com/ryancramerdesign/ProcessWire/issues/1868#issuecomment-500081534 Note that the change needs to happen in ListerPro, rather than the core (I think).
×
×
  • Create New...