Jump to content

adrian

PW-Moderators
  • Posts

    11,172
  • Joined

  • Last visited

  • Days Won

    371

Everything posted by adrian

  1. Hey @Pete - I maintain four different Tracy core versions which are all included and used based on the version of PHP available. I have also made a real effort to ensure PHP 7 compatibility (maybe even 5 - not sure). A Tracy upgrade is basically instantaneous on all my servers/installs so I've never thought of the compiling process as an issue. Adding a namespace is probably more of a big deal with so many panels and reliance on the Tracy core itself - maybe just a matter of lots of backspaces to start loading things from the global namespace. The one other module I namespaced was AdminActions and it was a real challenge but that was mostly due to trying to support installed custom user actions whether they were namespaced or not. Still, it put me off namespacing others. I'll try to find some time to see what's involved sometime soon.
  2. It works here (if you're patient enough), but as noted above it's a pretty useless demo because the admin is so bare - basically useless and a very poor advert for PW.
  3. Hi @Pete - sorry, I haven't used EFS - I have a regular EBS setup on AWS so I don't really know why the file compiler is causing you issues - for me it's been seamless for years so I have never seen the need to add the PW namespace to any of my modules. I do it for all my template files, but figured why break modules for any old PW 2.x installations if I don't need to. For me it compiles it once when the module is updated and then it's just as quick as it would be if it was namespaced because the compiled version is loaded all the time. Is it because your EFS setup is used by multiple EC2 instances and that somehow why it needs to be re-compiled every time? You mention "it compiles otherwise when file compiler is on - which for me is most of the time as there are modules I use that are not in a namespace" - does that mean that if one module isn't namespaced it's making all recompile on every page load?
  4. You're right of course! Contentful has been the leading commerical headless CMS for quite a long time, so they are doing something right. I was asked to build a site with it about 10 years ago - I declined because I loved working with PW and couldn't understand the reason to spend so much on a commercial service like Contentful, but they are definitely successful - there are some very big names on this list: https://trends.builtwith.com/websitelist/Contentful
  5. Ok, but I think it needs an "All" button (as the default) and then "Featured" could be just the featured modules - otherwise I think it's quite confusing.
  6. Can I humbly make an overarching statement on my thoughts about website design. I think there are certain types of sites that should have artsy, flashy, animated content and large fonts - these can make the right impression and be part of the visual experience. But when it comes to technology, I think clean, simple, and free of distractions is needed. Take a look at how clean https://www.contentful.com/ is and compare with https://www.sanity.io/ which is mess of moving stuff that I just want to gloss over. I also think you might have missed a key marketing point - "headless"
  7. @ryan - can you please explain what the "Featured" modules are: https://processwire.com/modules/featured/ ? It looks like this view is actually all of the modules? Is that right? Also, it seems like the Paid button isn't showing lots of paid modules - ListerPro is just one example.
  8. I don't know if this is intentional or not, so reporting just in case - at certain screen widths, the slider has its right edge cut off. Note that the Konkat site has a similar issue with "Konkat" having no right margin at certain widths. It also has the same crazy amounts of vertical whitespace on smaller screens that I mentioned for the new PW site above. I'd also be tempted to suggest that at all sizes it should uses the smaller padding that appears on smaller screens - it makes it look much more like a monitor screen, which I assume is the idea?
  9. @ryan - my screen is the 16.2" Liquid Retina XDR display 3456 x 2234 native resolution at 254 ppi so I am definitely on a hi dpi screen. But your changes do fix the static text for me.
  10. MacOS and Chrome - latest of both. It's also an issue on Safari and Zen (firefox engine). Very obvious on a Macbook Pro M1 - maybe on an older device with a lower resolution screen it might not be as obvious? Note that I am zooming in a bit to make it look that bad (but it's still very noticeable at 100%), but if you turn off that filter then it looks great anyway - what's the point of it?
  11. Thanks @ryan - it's no longer blurry, which is great, but it's still got jagged edges due to that #pw-morph-threshold) filter. With the filter on: and with it off: Sorry, but it really looks unprofessional as is. I know it's intended, but it doesn't provide any good purpose to have it that big - it just hides the important stuff below the fold. And on bigger screens it's comically large (as noted by @psy).
  12. Along with reducing the font size of that title considerably, can you also please consider removing the blur from it - it literally hurts my eyes to read it - they are constantly trying to make it look focused and sharp.
  13. @ryan - the demo site (still linked from the new site) is still showing that .htaccess needs updating error (has been for a very long time) and running an old version of PW and the old theme. All fields and templates need to either have an icon or no icon - it looks messy with the alignment in those dropdowns when there is a mix. Maybe minor, but these details are what makes a project look professional or sloppy.
  14. Unfortunately, IMHO the only animation that conveys anything is maybe the one for "Total control over the design". The rest just don't provide any meaning to me. In general animations on websites don't engage me, they distract me from learning what I am there to learn. But maybe I am in the minority, which is fine :)
  15. Maybe on smaller screens when it's one column, the animations should always end up below the text they are related to?
  16. Gotta admit I feel really strongly about this also. This is my quick hack to find some visual peace on the homepage :) // Remove all divs whose ID ends with "-animation" document.querySelectorAll('div[id$="-animation"]').forEach(el => el.remove()); // Remove empty uk-width elements document.querySelectorAll('[class*="uk-width-"]').forEach(el => { if (!el.textContent.trim()) { el.remove(); } }); // Change all uk-width elements to full-width document.querySelectorAll('[class*="uk-width-"]').forEach(el => { el.className = el.className .split(/\s+/) .map(cls => cls.startsWith('uk-width-') ? 'uk-width-1-1' : cls) .join(' '); }); // Halve font size of all h1 and h2 elements document.querySelectorAll('h1, h2').forEach(el => { const style = window.getComputedStyle(el); const currentSize = parseFloat(style.fontSize); el.style.fontSize = (currentSize / 2) + 'px'; }); // Remove max-width on .pw-highly-scalable p elements document.querySelectorAll('.pw-highly-scalable p').forEach(el => { el.style.maxWidth = 'none'; });
  17. Regarding that image border - it looks bad with some images on the site itself, eg: Of course these old screenshots also need updating, but I guess that's a task for another day (or 20).
  18. Whitespace issues on mobile, eg: Way too much between the text and those design thingies: No vertical space between email field and button: I am sure there are lots more, but you get the idea.
  19. This border is making transparent PNGs look weird. Not sure how many are on the site itself, but there are plenty on 3rd party module pages that are impacted by this. #content-body p>a>img, #content-body p>img { border: 1px solid #999; border-radius: 10px; }
  20. OK - code examples first, just because they caught my eye immediately: It's missing the closing ")" and I also think it would look cleaner on one line: <!-- Render simple breadcrumb nav --> <ul class="breadcrumbs"> <?= $page->parents->each( '<li><a href="{url}">{title}</a>' ?> </ul> ie: <!-- Render simple breadcrumb nav --> <ul class="breadcrumbs"> <?= $page->parents->each('<li><a href="{url}">{title}</a>') ?> </ul> This won't work because of $p->url in double quotes like that without extra single quotes for href. // Render primary navigation foreach($pages->get("/")->children as $p) { echo "<a href="$p->url">$p->title</a> "; } Missing the semi-colon at the end of the second line: // Find and list tall buildings $buildings = $pages->get("/buildings/"); $skyscrapers = $buildings->find("height>1000") echo $skyscrapers->each("<li>{height}: {title}");
  21. Hi @ryan - where would you like bugs on the site to be reported - here, or Github, and if the latter do you want them as separate issues, or all lumped together?
  22. Just an FYI - the TracyExceptions panel will list all these and let you load them up much more easily.
  23. Hey @bernhard - you can put it anywhere (so long as Tracy is loaded, which basically excludes config.php, but it works in init.php, ready.php, etc. Or you could put it in any module file that is loaded everywhere. Another very simple test that adds "/test/" to the path and will work for all editor links. \Tracy\Debugger::$editorMapping['/site/templates/'] = '/site/templates/test/'; Can you share what values you've been trying to add to $editorMapping so I can maybe see why it's not working?
  24. Hi @iank - sorry, I can't reproduce here at the moment. When I bootstrap, that $p is PW's 404 page, but even if I force it to null before then there is still no error because of the if($p) check on line 171. Not really sure why it's NullPage in your case, but I have added a check which should fix things regardless.
  25. Hey @bernhard - are you happy with this solution? Can I close: https://github.com/adrianbj/TracyDebugger/pull/105 ?
×
×
  • Create New...