adrian

Regarding that image border - it looks bad with some images on the site itself, eg: Of course these old screenshots also need updating, but I guess that's a task for another day (or 20).

Whitespace issues on mobile, eg: Way too much between the text and those design thingies: No vertical space between email field and button: I am sure there are lots more, but you get the idea.

This border is making transparent PNGs look weird. Not sure how many are on the site itself, but there are plenty on 3rd party module pages that are impacted by this. #content-body p>a>img, #content-body p>img { border: 1px solid #999; border-radius: 10px; }

OK - code examples first, just because they caught my eye immediately: It's missing the closing ")" and I also think it would look cleaner on one line: <!-- Render simple breadcrumb nav --> <ul class="breadcrumbs"> <?= $page->parents->each( '<li><a href="{url}">{title}</a>' ?> </ul> ie: <!-- Render simple breadcrumb nav --> <ul class="breadcrumbs"> <?= $page->parents->each('<li><a href="{url}">{title}</a>') ?> </ul> This won't work because of $p->url in double quotes like that without extra single quotes for href. // Render primary navigation foreach($pages->get("/")->children as $p) { echo "<a href="$p->url">$p->title</a> "; } Missing the semi-colon at the end of the second line: // Find and list tall buildings $buildings = $pages->get("/buildings/"); $skyscrapers = $buildings->find("height>1000") echo $skyscrapers->each("<li>{height}: {title}");

Hi @ryan - where would you like bugs on the site to be reported - here, or Github, and if the latter do you want them as separate issues, or all lumped together?

Just an FYI - the TracyExceptions panel will list all these and let you load them up much more easily.

Hey @bernhard - you can put it anywhere (so long as Tracy is loaded, which basically excludes config.php, but it works in init.php, ready.php, etc. Or you could put it in any module file that is loaded everywhere. Another very simple test that adds "/test/" to the path and will work for all editor links. \Tracy\Debugger::$editorMapping['/site/templates/'] = '/site/templates/test/'; Can you share what values you've been trying to add to $editorMapping so I can maybe see why it's not working?

Hi @iank - sorry, I can't reproduce here at the moment. When I bootstrap, that $p is PW's 404 page, but even if I force it to null before then there is still no error because of the if($p) check on line 171. Not really sure why it's NullPage in your case, but I have added a check which should fix things regardless.

Hey @bernhard - are you happy with this solution? Can I close: https://github.com/adrianbj/TracyDebugger/pull/105 ?

Pagination buttons issue - note the missing left border on #2

I think the recent updates are really making a big improvement. One thing I like is the return of the page list action buttons, but I am confused why they use the defined "main-color", but the rest of the buttons in the admin use "text-color" but change to "main-color" on hover. Can the page list action buttons match the same behavior as the other buttons please? PS - this alignment bug is still there: Add New button dropdown still needs internal scroll feature please.

Hey @bernhard - I am not sure if this works for all your needs, but you should be able to add to the array of path replacements whenever/wherever you want. For example: \Tracy\Debugger::$editorMapping['/assets/cache/Latte/latte-includes-foo.php'] = '/templates/latte/includes/foo.latte'; I feel like you could probably build out all the replacements you need by looping over the files in /assets/cache/Latte/ and replacing the path and filename as needed with some pretty simple logic. I feel like this should allow you to handle both scenarios in your recent PRs without changes to Tracy. Sound OK, or am I missing something?

@bernhard - thanks for the explanation of the Tracy being in the body issue - makes sense. As for the localStorage issue, maybe htmx is filling up localStorage then? Can you investigate what's in there to see why it's full?

Maybe not useful for everyone, but I find I am often searching for content via Adminer and when the results are from a repeater item page, I need to figure out which is its "forPage". I have just added a new forPage row to the PageInfo section of the RequestInfo panel that lets you view or edit directly from here making things much easier.

Just a heads up for everyone to be careful with this upgrade. I had a poor piece of code that worked before but broke with these markup region changes. In my _main.php I had: <div id="main"> and in my templates I was doing: <main pw-replace id="main"> So before, the id="main" was enough to match - now it no longer matches. Obviously a mistake on my part - I have now replaced "<div" with "<main" in _main.php and everything works again.

@bernhard - I think the first issue might be something that should be fixed in the core Tracy project, but then I also don't know what you've had to do to "move the debug bar out of the swapped area" I don't think the second issue is related to htmx - sounds like maybe you have a lot of d() content stored - perhaps multiple console tabs? LocalStorage is usually limited to 5MB. I really need to move everything over to IndexedDB, but not sure when I'll be able to get to that.

Hey @bernhard - does everything work as needed if you replace all instances of $config->paths->root on these lines (https://github.com/adrianbj/TracyDebugger/blob/40cfe39239ea1fb2d6ee50920ebc9f3f86b21048/TracyDebugger.module.php#L1058-L1071) with your project root? Or are other changes needed?

Hey @bernhard - good catch. New version supports searching whatever is in the label.

Hey @bernhard - I revised the last commit so now you can use tags. The default is now set to: {name} ({email}) Hope that helps you and others.

Hey @bernhard - I didn't come to the forum to see your updated suggested about the email in brackets and already added the custom label field option, so hope that's ok.

Yeah, might be worth a strikethru of the "logs" and add "info" so it isn't too confusing when reading through, but also points to the exact issue in the title.

Thanks @iank - curious if you have Ghostscript installed - I do and don't have any issues, but some of the reading I am just done suggests it can contribute. The other thing that comes up is a missing or misconfigured font paths (e.g., /etc/fonts/fonts.conf) I did also read that IM6 is slower at this than IM7, but I am also running 6 without issues, so who knows :) Otherwise, I am really not sure at this point. I'd love to hear if anyone else has the same issue. It's possible to use an exec call to IM's convert but I didn't take that route because on some servers exec can be disabled. Maybe the best option for you is to just disable the Versions List unless we hear others having the same problems.

Thanks @iank - could you let me know what version of PHP and imagemagick and imagick you are running? Could you also figure out if it's queryformats() or getVersion() that is the main culprit. Thanks.

I don't actually cache anything for this panel - never seen any performance issues before, but perhaps PHP's OpCache is? Perhaps you would be willing to debug which component is the issue? These are the lines that populate the various versions. You could start by commenting out the MySQL ones, then the server settings, then apache modules, etc. https://github.com/adrianbj/TracyDebugger/blob/5e5d483a7f4d30c4e3f52c40921897a4603b6151/panels/ProcesswireInfoPanel.php#L205-L292

@iank - just committed a new version with a revamped panel selector - now uses a table and fixes those wrapping / alignment issues. Hopefully this will prevent future confusion as to what panel is having issues.