Jump to content

adrian

PW-Moderators
  • Content Count

    8,860
  • Joined

  • Last visited

  • Days Won

    301

adrian last won the day on April 23

adrian had the most liked content!

Community Reputation

10,936 Excellent

About adrian

  • Rank
    Hero Member

Profile Information

  • Gender
    Not Telling
  • Location
    Canada

Recent Profile Visitors

28,560 profile views
  1. Actually all of the above, but yes, the Tracy dump is a key part of it - so much easier to see which parts are being added to the selector this way. I do also sometimes modify parts by key, but I also just find my code looks cleaner that concatenating a string with commas at the end of each one, plus you don't have to worry about a possible trailing comma.
  2. PS, here's the thread @Robin S was referring to:
  3. Yeah, @Robin S is mostly correct. The array approach seems like a good idea, but it will end up biting you in many cases. For ease of readability and building up complex selectors, I do build them with a regular php array and then simply implode the array with a comma to get the string selector. This is now my goto approach for any complex dynamic selectors.
  4. https://github.com/processwire/processwire-issues/issues/905
  5. I've just commented on that old closed issue: https://github.com/ryancramerdesign/ProcessWire/issues/1868#issuecomment-500081534 Note that the change needs to happen in ListerPro, rather than the core (I think).
  6. Are other html emails from your system (sent with a wireMail) working as expected? In other words, is it only emails from this module that are the problem?
  7. What about the email provider? Can you try to a gmail address to confirm the problem?
  8. @bramwolf - does it make a difference if you use a different email client? What are you using?
  9. https://github.com/processwire/processwire-issues/issues/896
  10. I hadn't looked - thanks for posting that - it's pretty clear from that @todo that Ryan know about this and that it needs fixing. Obviously calling findOne() if it's a selector isn't enough to get it to return NullPage as things currently stand, but this really should be fixed because with the current behavior you can't simply do a normal: if($result->id) on an in memory selector that returns no results because of the null vs NullPage - this has annoyed me for a long time
  11. Thanks for chiming in! Here are some more outputs which I think help to back up the assertion that it should return a NullPage
  12. What does everyone think of this? Shouldn't they both return NullPage? I'd love to hear your thoughts. Thanks!
  13. Not testing in the context of this module, but this looks to work as expected: Does that work as expected at your end?
  14. I don't know - we'd have to get @Pete's input on why that was done, but if you want to put together a PR to add a module setting where these can be configured, I can push to the main repo.
×
×
  • Create New...