-
Posts
11,125 -
Joined
-
Last visited
-
Days Won
366
Everything posted by adrian
-
Thanks @ryan - it's no longer blurry, which is great, but it's still got jagged edges due to that #pw-morph-threshold) filter. With the filter on: and with it off: Sorry, but it really looks unprofessional as is. I know it's intended, but it doesn't provide any good purpose to have it that big - it just hides the important stuff below the fold. And on bigger screens it's comically large (as noted by @psy).
-
Along with reducing the font size of that title considerably, can you also please consider removing the blur from it - it literally hurts my eyes to read it - they are constantly trying to make it look focused and sharp.
-
@ryan - the demo site (still linked from the new site) is still showing that .htaccess needs updating error (has been for a very long time) and running an old version of PW and the old theme. All fields and templates need to either have an icon or no icon - it looks messy with the alignment in those dropdowns when there is a mix. Maybe minor, but these details are what makes a project look professional or sloppy.
-
Unfortunately, IMHO the only animation that conveys anything is maybe the one for "Total control over the design". The rest just don't provide any meaning to me. In general animations on websites don't engage me, they distract me from learning what I am there to learn. But maybe I am in the minority, which is fine :)
-
Maybe on smaller screens when it's one column, the animations should always end up below the text they are related to?
-
Gotta admit I feel really strongly about this also. This is my quick hack to find some visual peace on the homepage :) // Remove all divs whose ID ends with "-animation" document.querySelectorAll('div[id$="-animation"]').forEach(el => el.remove()); // Remove empty uk-width elements document.querySelectorAll('[class*="uk-width-"]').forEach(el => { if (!el.textContent.trim()) { el.remove(); } }); // Change all uk-width elements to full-width document.querySelectorAll('[class*="uk-width-"]').forEach(el => { el.className = el.className .split(/\s+/) .map(cls => cls.startsWith('uk-width-') ? 'uk-width-1-1' : cls) .join(' '); }); // Halve font size of all h1 and h2 elements document.querySelectorAll('h1, h2').forEach(el => { const style = window.getComputedStyle(el); const currentSize = parseFloat(style.fontSize); el.style.fontSize = (currentSize / 2) + 'px'; }); // Remove max-width on .pw-highly-scalable p elements document.querySelectorAll('.pw-highly-scalable p').forEach(el => { el.style.maxWidth = 'none'; });
-
Regarding that image border - it looks bad with some images on the site itself, eg: Of course these old screenshots also need updating, but I guess that's a task for another day (or 20).
-
Whitespace issues on mobile, eg: Way too much between the text and those design thingies: No vertical space between email field and button: I am sure there are lots more, but you get the idea.
-
This border is making transparent PNGs look weird. Not sure how many are on the site itself, but there are plenty on 3rd party module pages that are impacted by this. #content-body p>a>img, #content-body p>img { border: 1px solid #999; border-radius: 10px; }
-
OK - code examples first, just because they caught my eye immediately: It's missing the closing ")" and I also think it would look cleaner on one line: <!-- Render simple breadcrumb nav --> <ul class="breadcrumbs"> <?= $page->parents->each( '<li><a href="{url}">{title}</a>' ?> </ul> ie: <!-- Render simple breadcrumb nav --> <ul class="breadcrumbs"> <?= $page->parents->each('<li><a href="{url}">{title}</a>') ?> </ul> This won't work because of $p->url in double quotes like that without extra single quotes for href. // Render primary navigation foreach($pages->get("/")->children as $p) { echo "<a href="$p->url">$p->title</a> "; } Missing the semi-colon at the end of the second line: // Find and list tall buildings $buildings = $pages->get("/buildings/"); $skyscrapers = $buildings->find("height>1000") echo $skyscrapers->each("<li>{height}: {title}");
-
Hi @ryan - where would you like bugs on the site to be reported - here, or Github, and if the latter do you want them as separate issues, or all lumped together?
-
Just an FYI - the TracyExceptions panel will list all these and let you load them up much more easily.
-
Hey @bernhard - you can put it anywhere (so long as Tracy is loaded, which basically excludes config.php, but it works in init.php, ready.php, etc. Or you could put it in any module file that is loaded everywhere. Another very simple test that adds "/test/" to the path and will work for all editor links. \Tracy\Debugger::$editorMapping['/site/templates/'] = '/site/templates/test/'; Can you share what values you've been trying to add to $editorMapping so I can maybe see why it's not working?
-
[Solved] Console Error in Tracy debug bar when bootstrapping PW
adrian replied to iank's topic in Tracy Debugger
Hi @iank - sorry, I can't reproduce here at the moment. When I bootstrap, that $p is PW's 404 page, but even if I force it to null before then there is still no error because of the if($p) check on line 171. Not really sure why it's NullPage in your case, but I have added a check which should fix things regardless. -
-
I think the recent updates are really making a big improvement. One thing I like is the return of the page list action buttons, but I am confused why they use the defined "main-color", but the rest of the buttons in the admin use "text-color" but change to "main-color" on hover. Can the page list action buttons match the same behavior as the other buttons please? PS - this alignment bug is still there: Add New button dropdown still needs internal scroll feature please.
-
Hey @bernhard - I am not sure if this works for all your needs, but you should be able to add to the array of path replacements whenever/wherever you want. For example: \Tracy\Debugger::$editorMapping['/assets/cache/Latte/latte-includes-foo.php'] = '/templates/latte/includes/foo.latte'; I feel like you could probably build out all the replacements you need by looping over the files in /assets/cache/Latte/ and replacing the path and filename as needed with some pretty simple logic. I feel like this should allow you to handle both scenarios in your recent PRs without changes to Tracy. Sound OK, or am I missing something?
-
@bernhard - thanks for the explanation of the Tracy being in the body issue - makes sense. As for the localStorage issue, maybe htmx is filling up localStorage then? Can you investigate what's in there to see why it's full?
-
Maybe not useful for everyone, but I find I am often searching for content via Adminer and when the results are from a repeater item page, I need to figure out which is its "forPage". I have just added a new forPage row to the PageInfo section of the RequestInfo panel that lets you view or edit directly from here making things much easier.
-
Just a heads up for everyone to be careful with this upgrade. I had a poor piece of code that worked before but broke with these markup region changes. In my _main.php I had: <div id="main"> and in my templates I was doing: <main pw-replace id="main"> So before, the id="main" was enough to match - now it no longer matches. Obviously a mistake on my part - I have now replaced "<div" with "<main" in _main.php and everything works again.
- 1 reply
-
- 3
-
-
@bernhard - I think the first issue might be something that should be fixed in the core Tracy project, but then I also don't know what you've had to do to "move the debug bar out of the swapped area" I don't think the second issue is related to htmx - sounds like maybe you have a lot of d() content stored - perhaps multiple console tabs? LocalStorage is usually limited to 5MB. I really need to move everything over to IndexedDB, but not sure when I'll be able to get to that.
-
Hey @bernhard - good catch. New version supports searching whatever is in the label.
-
Hey @bernhard - I revised the last commit so now you can use tags. The default is now set to: {name} ({email}) Hope that helps you and others.