-
Posts
10,877 -
Joined
-
Last visited
-
Days Won
348
Everything posted by adrian
-
Hi @jploch - sorry for the late response - I was on vacation. Can you please point me to the line on the Github repo. I feel like it might actually be: https://github.com/adrianbj/TracyDebugger/blob/6f62b8e2c03e1520615ea654e79f4e44b61f9f20/TracyDebugger.module.php#L2847 but that isn't the line number from your error. Also can you please do a dump of parse_url($_SERVER['REQUEST_URI']); so I can see what is returned?
-
Cannot read properties of null (reading 'offsetTop')
adrian replied to bernhard's topic in Tracy Debugger
Thanks @bernhard - should be fixed in the latest version.- 1 reply
-
- 1
-
@gornycreative - I haven't used it in quite some time, but I think it should still work.
-
@MarkE - I really do think migration to use imap_open as per my above post would be a better option given the status of the flourish library.
-
@matjazp - I am getting a little off-topic here, but I found some weird issues with UIKIT 3.16 - I should probably report them, but I was getting several FOUCs on the frontend of my site when I upgraded to it - things like menu dropdowns and modal popup that was meant to be initially hidden, so I stuck with 3.15. Did you experience any issues?
-
@ryan - another issue which looks like it's just core related - I can no longer view field settings (eg Setup > Fields > body) because of this error: inputfields.js?v=33g:1049 Uncaught TypeError: Cannot read properties of undefined (reading 'toString') at parseValue (inputfields.js?v=33g:1049:13) at inputfieldChange (inputfields.js?v=33g:1370:15) at setupDependencyField (inputfields.js?v=33g:1606:3) at HTMLLIElement.<anonymous> (inputfields.js?v=33g:1614:4) at Function.each (JqueryCore.js?v=1.12.4:1:4048) at a.fn.init.each (JqueryCore.js?v=1.12.4:1:1235) at HTMLFormElement.<anonymous> (inputfields.js?v=33g:1613:70) at Function.each (JqueryCore.js?v=1.12.4:1:4048) at a.fn.init.each (JqueryCore.js?v=1.12.4:1:1235) at InputfieldDependencies (inputfields.js?v=33g:1612:10) Please let me know if you can't reproduce and I'll try to provide more info, but so far it's happening on all sites I've upgraded.
-
Thanks for the hard work on this @ryan I mentioned this in the AoS support thread as well, but I figure it's worth a mention here too in case folks can't initially figure out why their admin menu dropdowns are broken after upgrade. If you make use of AOS's excellent "Add button to check/uncheck all checkboxes" feature, it will break the top level menu dropdowns in the PW admin (and maybe other JS). The fix is to replace: ("[data-no-checkall-checkboxes="1"]") with: ([data-no-checkall-checkboxes="1"]) in: /site/modules/AdminOnSteroids/scripts/aos.min.js
- 16 replies
-
- 10
-
Just an FYI for everyone who may upgrade to the latest PW dev version today. If you make use of AOS's excellent "Add button to check/uncheck all checkboxes" feature, it will break the top level menu dropdowns in the PW admin (and maybe other JS). The fix is to replace: ("[data-no-checkall-checkboxes="1"]") with: ([data-no-checkall-checkboxes="1"]) in: /site/modules/AdminOnSteroids/scripts/aos.min.js
-
@Ivan Gretsky - if you can reproduce this reliably, I wonder if you could determine if $locked is 0 vs null: https://github.com/processwire/processwire/blob/6ff498f503db118d5b6c190b35bd937b38b80a77/wire/modules/Session/SessionHandlerDB/SessionHandlerDB.module#L90-L91 If it's null and it's a memory issue, then perhaps increasing your PHP memory limit might fix it?
-
Hi Ivan - it looks like you are also running SessionHandlerDB (as mentioned by the folks in that other thread). I have found many issues with Tracy and that module over the years so I don't run that module (except when testing) and haven't ever seen that error. For now (if you don't need it, I would suggest disabling that module), but I would like to see if @ryan has any ideas.
-
Hi @digitex - you're right about the displaying of all the child pages - this module really doesn't work well in edit with lots of children - poor design on my part :) That said, I think if you disable edit mode for branches with lots of children, you should be able to offer the CSV export mode and I think it should be ok. It won't be as capable as Lister still because Lister batches exports whereas BCE tries to do all in one batch. I really haven't used this module in a long time so I'm afraid I don't have much impetus to modify the export functionality, but hopefully it will work for you with edit mode disabled.
-
@SebastianP - fixed in the latest version - thanks to @flydev
-
Thanks for the fix @flydev - I've added it to the latest version.
-
The other thing that I think should be implemented is a better cache expiry option - given how infrequently sitemap.xml files are called by search engines, I don't really think any sort of time based expiry is much use in reality. I think it should support wireCache's selector option (set to expire when any page is saved - although on regularly updated sites, even this might not result in the cache being used very often).
-
Thanks @gebeer - I have always had a bit of a hunch this might be the case but never got around to checking.
-
Hey @bernhard - Is this how you have the complete block looking such that your new logic is only applied to objects, but when they are an array the behaviour isn't changed? BTW, this bit of code is a copy of PW's debug.inc file so you should let Ryan know about the needed change there as well. if(is_object($value)) { try { if (is_object($value)) $value = (string)$value; } catch (\Throwable $th) { try { $value = json_encode($value); } catch (\Throwable $th) { $value = $th->getMessage(); } } } if(is_array($value)) $value = print_r($value, true);
-
Currently on Digital Ocean (although will actually be moving the project to AWS shortly). I just ran a backup from the CLI and in that situation (where the timeout doesn't come into affect), it seems to have worked as expected, with both the zip and zip.enc files having the same size, but I am still confused why the .zip is kept - shouldn't that be deleted after the creation of the .zip.enc file? Actually, should both be exactly the same file size - does the encryption not result in some change? I came across the timeout when trying to run a backup from ProcessDuplicator using the native DB / local only options - I still think this need to work.
-
Just looking into that libsodium error. I see that it's being generated by Halite's isLibsodiumSetupCorrectly() function, but when I call the components from that I get the following, which suggest it should be ok. Actually, it's just a case of inverted logic in your code - note the ! where it shouldn't be. if (!\ParagonIE\Halite\Halite::isLibsodiumSetupCorrectly()) { $field->notes = __("☑️ `libsodium` setup [**OK**]"); } else { $field->notes = __("⚠️ `libsodium` setup [**FAIL**]"); }
-
Hi @flydev - thanks so much for your work on this. I've just been testing it out and have a few questions: 1) I am seeing libsodium setup [FAIL] at the bottom of the private key section in the config settings. I have libsodium-dev and php-libsodium installed so not sure where there error is coming from. Any ideas? 2) The backup seems to work as expected, but I am seeing both .zip and .zip.enc files created. Are they both supposed to remain after the backup has completed running? 3) Is is expected that the .enc version is about 2/5ths the size of the main .zip file? Actually, I think I just answered #2 and #3 - turns out I got this error Fatal Error: Maximum execution time of 300 seconds exceeded (line 23 of /paragonie/sodium_compat/src/Core/ChaCha20.php) which I suppose means the encryption didn't complete. Do you think it would make sense to override the php time limit within this process to avoid this? Thanks again!
-
The other thing you should play with is the Request Logger panel - lots of useful info collected by it.
-
Turn on Guest Dumps - "Enable Guest Dumps" button on the Panel Selector.
-
Not sure what you are making work via Admin > Access > Users, because to get BCE to work here like that, I need to replace line 185 with: if(!$this->data['allowAdminPages'] && (!in_array($this->editedPage->id, $this->wire('config')->usersPageIDs) && ($this->editedPage->template->flags & Template::flagSystem))) return;
-
I wish the sidebar actually worked well - I had hight hopes for that feature, but it just doesn't really work. Just in case you haven't ever noticed, the tree icon at the start of the breadcrumbs brings up a panel overlay with the full menu which is a really nice feature. That, together with Robin's BreadcrumbDropdown menu and life is pretty good. AdminOnSteroids does have a sticky header feature.
- 46 replies
-
- 1
-
Thanks @bernhard - not sure why I haven't seen that issue before - it's been a bug for a long time. Should be fixed in the latest version.
- 1 reply
-
- 1