Jump to content

Mike Rockett

Members
  • Content Count

    1,378
  • Joined

  • Last visited

  • Days Won

    9

Mike Rockett last won the day on November 6

Mike Rockett had the most liked content!

Community Reputation

1,137 Excellent

About Mike Rockett

  • Rank
    Hero Member
  • Birthday 03/07/1991

Profile Information

  • Gender
    Male

Recent Profile Visitors

The recent visitors block is disabled and is not being shown to other users.

  1. You're welcome. JL2 (when I get there πŸ™ˆ) will give some more control here. This case would be covered by subscribe/{path} --> @[1495]/{path}, and then there'd either be a {query} wildcard or an option on the jumplink itself to automatically carry it over.
  2. Any time πŸ™‚ I've rolled out 1.5.57 with a fix, so you should be good to go without the {!all}, which is somewhat unsafe IMO.
  3. @adrian Ok so this seems to be the wildcard cleaner. Because {all} is the equivalent of .*, it includes the query string in this case and therefore cleans it like a normal wildcard. The only option for the time being is to disable cleaning of {all}, by changing it to {!all} in the destination. I know it's not perfect, but JL doesn't actually handle query strings very well – they should actually be handled separately somehow. Edit: I'm actually going to see if I can update the cleaner to prevent query string character cleaning.
  4. Ah of course - didn't click that it would be the same as the previous query πŸ™ˆ πŸ˜† Ok I'm able to reproduce, will investigate
  5. Going to have to spin this up and see what's going on. Mind sharing your source/destination with me? Sorry, I edited that post as you were replying
  6. @adrian I wonder if database->escape_string is playing a role here? I think I'm doing it differently in JL2, but that's nowhere near done in terms of a frontend. πŸ™ˆ Scratch that, it's being used in the importer. Long day I tell you
  7. Hey @adrian Super odd, that. Will take a look.
  8. @adrian β€” Glad you're all sorted there πŸ™‚
  9. @adrian Page identifiers were never intended to be used as part of a destination. These identifiers use the full, absolute URL of the page being identified. Perhaps destination selectors could come in handy here? Haven't ever tried it this way before, but I imagine redirecting subscribe/{all} to [[1495]]{all} (or [[1495]]/{all}} if trailing slashes are turned off) would work. Anything inside the square braces is passed to pages->get and replaced with page->url, which is why I believe this will work.
  10. Thanks @teppo – have reviewed and merged in with some minor UI/textual adjustments to the config. Tested it too, works great! πŸ™‚
  11. @teppo Quick follow-up on your merge request, unless you'd like me to take care of it? πŸ™‚
  12. @apeisa I think I'll take the trimming option here, for now. I have been doing incremental work on JL2 in my very short-lived spare-time, and will be using a text column for referrers in the hits table. I'm deciding whether or not the 404 monitor should still be a separate module like I'd originally intended - still makes more sense to me, but either way, the same column type will be used there.
  13. @Ben Sayers This could indicate that something's wrong with your blog setup. To clarify, are you deleting posts or un-publishing them? Either way, whatever is going on here is preventing the 404 event from kicking in, which means Jumplinks has nothing to do. When it comes to common patterns like this (ie, "blog/*"), the only things that come to mind are urlSegments and custom htaccess directives, both of which I suspect are not the case for you. Worst case, I would try reproducing on a fresh install. On a side note: I don't know ProCache very well, but could it possibly be that?
  14. Ah ok, thanks for the clarification there. Guess the optimist in me was hanging around πŸ™‚ Good to know - thanks!
  15. @wbmnfktr - Hence why I'm needing some more info – not sure if any additional composer support has been added. Would be great if I could trigger an install during module install from the UI. πŸ™‚
Γ—
Γ—
  • Create New...