Jump to content

Mike Rockett

  • Content Count

  • Joined

  • Last visited

  • Days Won


Mike Rockett last won the day on November 6 2019

Mike Rockett had the most liked content!

Community Reputation

1,156 Excellent

About Mike Rockett

  • Rank
    Hero Member
  • Birthday 03/07/1991

Profile Information

  • Gender

Recent Profile Visitors

The recent visitors block is disabled and is not being shown to other users.

  1. @phlp The reason the cell is empty is because the parser could not determine the browser name and version, and so it's empty anyway. At best, I could simply indicate that the that browser is "unknown" in that column. Wouldn't want to not store unknown agents just because they can't be parsed - this would be getting rid of raw information that might be useful to some folks.
  2. @phlp Security Release 1.5.60 is up. Unable to test right now โ€“ please could you check to see that all's good?
  3. @phlp - Thanks for spotting this. Will push a release shortly.
  4. And done ๐Ÿ™‚ 0.5.0 released
  5. Going to go ahead and push this to master with a new release. Will update the readme soon.
  6. @OllieMackJames Okay, well I honestly don't think there's much more I can do here (unless I'm missing something staring at me in the face ๐Ÿ™ˆ). Hoping to find time soon to continue work on v2 (starting writing the frontend a little while back), which will keep track of these things a little differently (a migration table). Scary to think how long it's been around, and how long I've taken to get v2 anywhere ๐Ÿ™ƒ
  7. @OllieMackJames - hmm, something weird is going on here as this is not the first time this has come up (I don't think)... I wonder if it's something related to the module config. The schema version is set there, and it will iterate through the schema updates until it matches the current version. That particular column is way back in schema v3, which is why I think there might be a config issue going on here... Was this a new install or an upgrade?
  8. Great stuff - and does the language support hook-setup work as expected? You're quite right indeed, will sort that out some time tomorrow. ๐Ÿ™‚
  9. I actually see I did that already ๐Ÿ˜…So feel free to leave out the static method call above and let me know if it works.
  10. So I've been a bit busy this morning refactoring and brooming. A man is busy of late, but hey, gotta make some time for these things eventually. Anyways, couple of things I've done so far: Updated the underlying sitemap package. Refactor: split some code out into concerns, added support helpers, added return types and fixed up doc blocks. Dropped support for PW 2.8 and PHP < 7.1 (should be 7.2, but fine for now) Manually pulled in the merge request with an additional static method to add the language support hooks. I don't really have a good test case to work with, but this is the idea: use MarkupSitemap; wire()->addHookAfter(MarkupSitemap::getAdditionalPages, function ($event) { $page = $event->arguments(0); $language = $event->arguments(1); MarkupSitemap::applyLanguageSupportHooks(); // Add additional pages }); It should internally track whether or not they've been added, but I've simply not tested it yet, so can't say for sure. ๐Ÿ˜…That aside though, surely I can add the hooks directly in ___getAdditionalPages? If you'd like to give it a spin, please check out the develop branch directly.
  11. Thanks so much @d'Hinnisdaรซl, really appreciate the effort here ๐Ÿ™‚ Will review, test and merge this morning. Regarding videos, you might actually want to hold off on that for a bit, as I'd first like to add the additional sub-element class for it, and perhaps a few others as well. The Sitemap class itself comes from ThePixelDeveloper over at GitHub, and so I think I might want to upgrade that instead, to utilise the newer features / code-base.
  12. @teppo โ€“ Are you keen on putting together a merge request for this or would you like me to give it a bash?
  13. Note to self: When creating tags, be sure to actually click on "Create Tag" ๐Ÿคฃ Please try again ๐Ÿ™‚
  14. Have release 1.5.59 with these changes. ๐Ÿ™‚
  15. @adrian โ€“ I'd be happy to. I see from a previous discussion with Teppo that the priority was set due to a conflict with sitemaps. That being said, I do believe there is a measure in place to circumvent sitemap.xml URIs from being logged, so as a result, I don't see why we can't change the hook and priority. At the end of the day, it kinda makes sense. Modules that need to do things with 404 events should be given the opportunity to do so before JL comes in as a last resort. So I'm going to go ahead and do this โ€“ if anyone encounters any issues, we'll need to deal with them on an as-and-when basis.
  • Create New...