Jump to content

Mike Rockett

Members
  • Content Count

    1,401
  • Joined

  • Last visited

  • Days Won

    9

Mike Rockett last won the day on November 6 2019

Mike Rockett had the most liked content!

Community Reputation

1,160 Excellent

About Mike Rockett

  • Rank
    Hero Member
  • Birthday 03/07/1991

Profile Information

  • Gender
    Male

Recent Profile Visitors

The recent visitors block is disabled and is not being shown to other users.

  1. @teppo – I've pushed an update to the develop branch that adds an update policy config option. I think the sensible default is to set it to guests only, which is what I've done here. Let me know if you feel it should be the other way around. The HTTP headers now also provide a reason for skipping the cache. Would you be happy to test it out? Regarding templates without sitemap access, the idea is to only target pages. Built it way back when, so can't really remember why I did it this way, but I do remember having a reason. We could well add an option to also say that children of these templates should be excluded... 🤔 -- There are other issues on the repo at the moment, some of which discuss features people would like to see. Unfortunately, my time is very limited and so I invite module developers to contribute if they feel up to it (I'd be super grateful). Happy to spend time discussing things and reviewing PRs and issuing quick bug fixes, but am not able to get to feature development on this module right now…
  2. @teppo – fair enough, you're actually quite right. So the options are then to either have the option to turn off caching for authed users or use use role-based caching for authed users, or perhaps even dictate some more fine grained rules behind which pages can be added to the sitemap. At the end of the day, the sitemap should always resemble publicly-viewable content only, so perhaps that's a better option (though I don't know how feasible it is from an implementation perspective). Another thing to note is that individual pages can be turned off from their Sitemap settings, though perhaps in some cases, that could be quite a chore (depending on the tree-structure and whether or not said pages are all common to one parent).
  3. @teppo, interesting idea indeed. In my opinion though, I feel like that defeats the purpose of a sitemap, which is really designed for guest and search engine access (in which case, only templates of those pages should be added to the config in the first place). I don't see why items should be conditionally added based on role if the consumer won't make much use of it… If you can see a reason how/why they would, then I'm happy to add it in.
  4. @adrian Interesting point indeed, though I recall having changed the priority once or twice in the past for some reason or the other. To me, it makes sense that JL does its thing first as it acts as a user-intervention strategy in that we have to honour the user's wishes. Figuring out what those are, however, is a different story, given the different approaches/modules that are available. I wish this could be configured by the user, in the case conflicts/undesired redirects take place. Jumplinks was actually borne from a plugin I wrote for Bolt CMF, and that plugin was an absolute, undeniable 'before everything else even considers thinking of running' scenario. Before we make a decision here, I think we should get more feedback from other JL users, and perhaps get a list together of any plugin that does route-redirection along with their priorities.
  5. @nabo - Thanks for letting me know. I see I updated composer.json and not info.json as well. Update: I have made the change in the repo, but will only be able to update the module directory when I find the password.
  6. @baronmunchowsen – I think mapping collections might be what you need if you haven't declared them in the correct order. Create a collection called blog, and include only the one you would like before the catch-all takes effect. So add old-url=new-url in the collection. Then your source would be blog/{all} and your destination would be new-blog/{all|blog}. That should do it, hopefully. As for query strings, that's being added to v2, which is on hold again unfortunately.
  7. @phlp The reason the cell is empty is because the parser could not determine the browser name and version, and so it's empty anyway. At best, I could simply indicate that the that browser is "unknown" in that column. Wouldn't want to not store unknown agents just because they can't be parsed - this would be getting rid of raw information that might be useful to some folks.
  8. @phlp Security Release 1.5.60 is up. Unable to test right now – please could you check to see that all's good?
  9. @phlp - Thanks for spotting this. Will push a release shortly.
  10. And done 🙂 0.5.0 released
  11. Going to go ahead and push this to master with a new release. Will update the readme soon.
  12. @OllieMackJames Okay, well I honestly don't think there's much more I can do here (unless I'm missing something staring at me in the face 🙈). Hoping to find time soon to continue work on v2 (starting writing the frontend a little while back), which will keep track of these things a little differently (a migration table). Scary to think how long it's been around, and how long I've taken to get v2 anywhere 🙃
  13. @OllieMackJames - hmm, something weird is going on here as this is not the first time this has come up (I don't think)... I wonder if it's something related to the module config. The schema version is set there, and it will iterate through the schema updates until it matches the current version. That particular column is way back in schema v3, which is why I think there might be a config issue going on here... Was this a new install or an upgrade?
  14. Great stuff - and does the language support hook-setup work as expected? You're quite right indeed, will sort that out some time tomorrow. 🙂
  15. I actually see I did that already 😅So feel free to leave out the static method call above and let me know if it works.
×
×
  • Create New...