Jump to content

Mike Rockett

Members
  • Content Count

    1,369
  • Joined

  • Last visited

  • Days Won

    8

Everything posted by Mike Rockett

  1. Thanks @teppo – have reviewed and merged in with some minor UI/textual adjustments to the config. Tested it too, works great! πŸ™‚
  2. @teppo Quick follow-up on your merge request, unless you'd like me to take care of it? πŸ™‚
  3. @apeisa I think I'll take the trimming option here, for now. I have been doing incremental work on JL2 in my very short-lived spare-time, and will be using a text column for referrers in the hits table. I'm deciding whether or not the 404 monitor should still be a separate module like I'd originally intended - still makes more sense to me, but either way, the same column type will be used there.
  4. @Ben Sayers This could indicate that something's wrong with your blog setup. To clarify, are you deleting posts or un-publishing them? Either way, whatever is going on here is preventing the 404 event from kicking in, which means Jumplinks has nothing to do. When it comes to common patterns like this (ie, "blog/*"), the only things that come to mind are urlSegments and custom htaccess directives, both of which I suspect are not the case for you. Worst case, I would try reproducing on a fresh install. On a side note: I don't know ProCache very well, but could it possibly be that?
  5. Ah ok, thanks for the clarification there. Guess the optimist in me was hanging around πŸ™‚ Good to know - thanks!
  6. @wbmnfktr - Hence why I'm needing some more info – not sure if any additional composer support has been added. Would be great if I could trigger an install during module install from the UI. πŸ™‚
  7. I'd also like to drop support for ProcessWire 2.8. Any objections?
  8. @teppo - in regards to Jumplinks 2 and composer support: the module utilises several composer packages, which at present are kept in the vendor directory of the module, part of source control. Just to be 100% sure, if I were to drop this from source control, this would force users to install via composer? If so, I'd need to leave it in there, unless you know of another way πŸ™‚ @all - I'm putting some time aside today to continue working on Jumplinks 2 – specifically frontend stuff. I'm cool with sticking to the usage of jQuery for the time being, though I imagine at some point I would move over to something like Svelte. No point in doing it now though, as pretty much all of the functionality I need (excluding bulk actions) has already been implemented. On the topic of dependencies, I'm feeling inclined to push the minimum PHP version to the one that still has active security support, which at this point is PHP 7.1. In my experience, it's always been best to only support maintained versions of PHP. This also allows me to bump illuminate/database from 5.4 to 5.8 (I imagine there are a bunch of fixes). I don't know what the implications of this are in terms of the various hosting providers people use, but I'd be quite shocked if providers were only supporting unmaintained versions of PHP.
  9. These columns are sorted in 1.5.56. However, instead of text, I've gone with varchar(512), which should be more than long enough. :)
  10. Hey @teppo – no problem at all πŸ™‚Probably a very good idea; happy for you to submit a merge request. Thanks!
  11. I've pushed up to the master branch but won't release until I have an opportunity to test later this afternoon (SAST). :)
  12. Thanks @apeisa I'll need to add in a schema update to change the column to text. Really wish I could find the time to continue work on v2 – the minute I find a gap, something comes up. :|
  13. @Tiffany - I think this is a caching issue. If I recall correctly, you can go into the module config for PageRender and clear it from there.
  14. @entschleunigung That's correct - it doesn't give consideration to multi language. That said, /en/old/page should throw a 404, and so the redirect should still take place...
  15. @entschleunigung To make sure that jumplinks is working, go into the module settings and turn on debug mode. When you hit the old URL, you should see a log from the module, showing what it's doing. Feel free to post that log here so we can take a look :)
  16. @Lance O. Looks like it could well be a case sensitivity issue with the license field, where yours is using an upper case "L", it is actually expecting it in lowercase. Are you able to rename the field and try again? Whether or not that fixes it, I'll need to push an update that converts the casing appropriately.
  17. You're welcome @teppo :) Ah, good to know, thanks :)
  18. The module has been published to Packagist, under rockett/sitemap. :)
  19. Oh, it's under rockett/jumplinks. Will update the opening post and readme as well.
  20. @teppo I've published Jumplinks on Packagist – please let me know if all's good :)
  21. @coxharrison - Not entirely sure what's going on here. Would have thought it to be a caching issue as well… Second guess is a header problem (incorrect status code for some reason), but that doesn't make sense as the module hooks into the 404 event and throws a 301/302 if a jump is needed. Given that it's been half a month since your last post, is this still happening?
  22. Aside: Is it me, or is this text editor broken? I've been battling to navigate using the arrow keys, it's double posting as adding replies on a the second last page doesn't take me to the last page, and deleting mentions and emojis is not working properly. Tested on FF and Chrome on Mac... Weird.
  23. @teppo - sure thing, will sort this out for you πŸ™‚
  24. Hey @teppo - sorry for the delayed reply here. This can definitely be done. Good work with the composer installer - haven't been around for a while now, so didn't see it pop up. πŸ™‚ Hey @Lance O. - You're very welcome - glad you like the module! πŸ™‚ I don't think your issue is related to the URL validator, as the filter does say that URL is valid, as expected. This leads me to think that it's a spelling issue with the field name, though that seems unlikely. Would you mind doing a little debugging and checking to see if the URL does indeed get knocked out at https://gitlab.com/rockettpw/seo/markup-sitemap/blob/master/MarkupSitemap.module.php#L447?
Γ—
Γ—
  • Create New...