-
Posts
1,452 -
Joined
-
Last visited
-
Days Won
9
Everything posted by Mike Rockett
-
You're welcome @teppo :) Ah, good to know, thanks :)
-
The module has been published to Packagist, under rockett/sitemap. :)
-
Oh, it's under rockett/jumplinks. Will update the opening post and readme as well.
-
@teppo I've published Jumplinks on Packagist – please let me know if all's good :)
-
@coxharrison - Not entirely sure what's going on here. Would have thought it to be a caching issue as well… Second guess is a header problem (incorrect status code for some reason), but that doesn't make sense as the module hooks into the 404 event and throws a 301/302 if a jump is needed. Given that it's been half a month since your last post, is this still happening?
-
Aside: Is it me, or is this text editor broken? I've been battling to navigate using the arrow keys, it's double posting as adding replies on a the second last page doesn't take me to the last page, and deleting mentions and emojis is not working properly. Tested on FF and Chrome on Mac... Weird.
-
@teppo - sure thing, will sort this out for you ?
-
Hey @teppo - sorry for the delayed reply here. This can definitely be done. Good work with the composer installer - haven't been around for a while now, so didn't see it pop up. ? Hey @Lance O. - You're very welcome - glad you like the module! ? I don't think your issue is related to the URL validator, as the filter does say that URL is valid, as expected. This leads me to think that it's a spelling issue with the field name, though that seems unlikely. Would you mind doing a little debugging and checking to see if the URL does indeed get knocked out at https://gitlab.com/rockettpw/seo/markup-sitemap/blob/master/MarkupSitemap.module.php#L447?
-
And done – was a simple case of me forgeting I've switched to tag-based releases.
-
Ah, my apologies - will sort this out. ?
-
@elabx Also, v2 will support the optional trailing slash by default (configurable).
-
Under normal circumstances, contributions to OSS help out with continued development – issue on my side is exactly that: slammed with work. With that said, there are several public holidays coming up (four-day weeks for two/three weeks), so I think I can slot in some time to get things going here and at maybe even put up a testing version of sorts next month. Further on down the line, when it's stable, we'd definitely need to look at getting someone onboard to assist with maintenance.
-
Just a note on unicode support: this is vastly improved in v2, once rule 16b is in use. Not planning on bringing it to v1, unfortunately.
-
Unfortunately, this isn't built in as a feature, but I'm thinking the non-capture feature might work for you. Not tested, but try using <[-]{1}[\d*]> at the end of the source. Thanks Peter – I recall wanting to do this for v2, where you choose how many you'd like to retain in the log. I think I'm gonna need to find some time to finish v2. Will likely need to make a few changes here and there (not up to speed with all the new core-dev) before I proceed with the frontend work that's still due.
-
Hi @Zeka Did you comment out rule 16a and uncomment 16b in your htaccess? (reference)
-
-
@Karinne Cyphers I've pushed up 1.5.52 which attempts to fix the change that PHP 7.3 made to preg_*, where hyphens need to be escaped if not at the end of a character set in an expression. Not able to test on my side, so please could you update and let me know if it runs? Thanks!
-
Don't have a chance to look into this right now, but is anyone having issues on PHP 7.3? Saw a comment on the module listing from Alex Capes about it breaking. In the meantime, I've opened up an issue over at GitLab: https://gitlab.com/rockettpw/seo/jumplinks-one/issues/1 @Karinne Cyphers - only saw your note now, sorry about that! It's likely due to rules 16a/16b in htaccess. 16a limits the characters allowed in a URL, so hits would never even boot up ProcessWire. Try changing to 16b (and adding the tilde if it's not there). ——— Future Development / v2 I profusely apologise for how long it's taken to get things done for v2. As some of you know, my daily responsibilities have taken over, and committing time to open-source projects is not there as it once was. I'd love to be able to say that I can try find some time to get to it, but it's simply a promise I can't make or keep, unfortunately… The way I see it, there are two options on the table. First is to wait it out (I know, I know…) – I do have a project board on the old repo, so I know what stands where and what I'd envisioned for the module, and can pick things up where I left off last (phew, haven't touched jQuery in forever – that might be a challenge), when the time avails itself. Technically, I'm about half way there but there's still quite a bit of work to do in terms of frontend. Second option would be for someone to take over the project. It'd definitely need to be someone who can commit the time to its development, and develop in line with the way in which the module has been built so far (there's a decent amount of SoC going on, and the module is built up using packages such as Eloquent, FastRoute, etc.). Alternatively, as a third option, we could take a multi-contributor approach. So, if anyone is interested, feel free to send me a DM and we can chat about it.
-
Haha, if only the site site was PW-powered. It's just a lander running on Netlify. Might add in some sort of wildcard redirect to the new docs home. ?
-
Hey! ? Wow, what a throw-back – can't believe it's been so long, haha! Those files saved by Craig are the right ones (thanks!), except for the last one.
-
Indeed - 1.5.50 has the correct links. ?
-
Hey @Peter Knight – weird, the redirects should be working… Will take a look, thanks ? Edit: Hmm, the links appear to be correct on the latest version…
-
@bedak Thanks for your suggestion – happy to implement, but am stuck for time… ? Will open an issue on the repo in the meantime. ? Edit: If you feel you can add this in from your side, feel free to submit a merge request to https://gitlab.com/rockettpw/seo/markup-sitemap
-
@cb2004 – https://jumplinks.rockett.pw/features/smart-wildcards.html – you'll probably want to use {segments} or {all} here. ?
-
@DarsVaeda – Thanks for bringing that up. I did indeed plan to move it some time back, but then decided to only do it for v2, which, hasn't been under active development of late. I'll try find some time to sort this out on v1 soon. Sorry for the issues caused here. ? @gr00__ (sorry, not sure why it's not tagging you) – That would likely be due to PW’s htaccess rules, as the error is coming from Apache. As that's where its coming from, you'd need to create a rule that will strip out those characters. Haven't worked with htaccess for a long time now, so not confident that I can assist accurately…