Jump to content

Mike Rockett

Members
  • Posts

    1,435
  • Joined

  • Last visited

  • Days Won

    9

Everything posted by Mike Rockett

  1. Super sorry for missing your post! If my-page exists, then Jumplinks will not take effect. It only responds to 404 events within ProcessWire.
  2. @a-ok Jumplinks 1 doesn't have built in support for automatically dealing with query strings. This is planned for Jumplinks 2, but I simply haven't had the time to complete it. For the time being, I'd be inclined to use the {all} wildcard on the end. Source: chance-to-dance[/]{all} Destination: somewhere/{all} or {!all} to skip wildcard cleaning
  3. @uiui Ah you're quite right. Unfortunately, I don't have enough time to implement this right now... If you (or anyone else) would like to take a stab at it, please feel free to submit a PR to the repo. If I find some time, I'll take a look. πŸ™‚
  4. Thanks @teppo – looks good, so I'll merge it in and push a release. Thanks for spotting that as well – evidently didn't cross my mind πŸ™ƒ
  5. @joe_ma – Apologies for not getting back to you, I didn't see your post until now πŸ™ˆ I'm not quite sure why you're getting those errors, though it seems like something else is interfering with the module output and or your pages. Could you share a list of the other modules you are using and perhaps any custom code/hooks that are at play? That might help me find out what the problem is, which is important as this issue hasn't come up before and I'd like to ensure it doesn't happen to others too. Thanks! @uiui – The module supports sites with the multisite and language support modules installed. I haven't tested it it in a while, so if you have any issues, please let me know. πŸ™‚
  6. @2hoch11 - Thanks. So the reason for the redirect is to take the page away from index.php so that it isn't seen as the home page. You simply need to change the source to index_php/{id}.
  7. @Andi – interesting… I'm sure this could be achieved with a hook that gets triggered when iterating pages. Haven't worked with the hook system in a while, but I guess that adding support for addHookBefore('Sitemap::page') would be a decent idea. Unfortunately though, I don't have the time to get to this right now. If you or anyone else is willing to look into implementing this, please feel free to sumit a PR. If that hasn't happened and I find some time in the next week or so, then I'll jump on it. As a last resort, there's always the getAdditionalPages hook that was recently added. It would mean that you exclude your posts from the sitemap and use that hook to add all your posts with the correct paths.
  8. @2hoch11 – please could you share your jumplink source and destination, the htaccess code, and the debug log (debug mode is in the module config)?
  9. Hi @HerTha - you're very welcome. I really do wish I had more time to work on JL2, which would solve this problem off the bat, but I just can't squeeze it in right now. With this specific issue, I might land up having to do some trickery in relation to checking if the column exists. Means I need to dig into the information_schema table, which I hate doing. MariaDB supports alter/modify if not exists, but there's obviously no point in me adding something that will crash for most users. I'm still baffled as to why it's running that schema update in the first place. The only possible thing is that the schema version somehow got 'lost' and so it re-ran it. I'm also a little puzzled as to why the _nf table had to be deleted – that doesn't seem to have anything to do with the issue at hand, which is in relation to the main table. Before you update production, could you check the module configuration in the database for me? In the moduels table, there will be an entry for ProcessJumplinks – in the data column, there will be a _schemaVersion in the JSON payload – the value for that is what I'm looking for. I'll also need the current version of JL that you're running on the production site. Based on that, I might be able to diagnose. If we're lucky, it might resort to a simple correction of the schemaVersion, in case it didn't successfully update before.
  10. @teppo – I've pushed an update to the develop branch that adds an update policy config option. I think the sensible default is to set it to guests only, which is what I've done here. Let me know if you feel it should be the other way around. The HTTP headers now also provide a reason for skipping the cache. Would you be happy to test it out? Regarding templates without sitemap access, the idea is to only target pages. Built it way back when, so can't really remember why I did it this way, but I do remember having a reason. We could well add an option to also say that children of these templates should be excluded... πŸ€” -- There are other issues on the repo at the moment, some of which discuss features people would like to see. Unfortunately, my time is very limited and so I invite module developers to contribute if they feel up to it (I'd be super grateful). Happy to spend time discussing things and reviewing PRs and issuing quick bug fixes, but am not able to get to feature development on this module right now…
  11. @teppo – fair enough, you're actually quite right. So the options are then to either have the option to turn off caching for authed users or use use role-based caching for authed users, or perhaps even dictate some more fine grained rules behind which pages can be added to the sitemap. At the end of the day, the sitemap should always resemble publicly-viewable content only, so perhaps that's a better option (though I don't know how feasible it is from an implementation perspective). Another thing to note is that individual pages can be turned off from their Sitemap settings, though perhaps in some cases, that could be quite a chore (depending on the tree-structure and whether or not said pages are all common to one parent).
  12. @teppo, interesting idea indeed. In my opinion though, I feel like that defeats the purpose of a sitemap, which is really designed for guest and search engine access (in which case, only templates of those pages should be added to the config in the first place). I don't see why items should be conditionally added based on role if the consumer won't make much use of it… If you can see a reason how/why they would, then I'm happy to add it in.
  13. @adrian Interesting point indeed, though I recall having changed the priority once or twice in the past for some reason or the other. To me, it makes sense that JL does its thing first as it acts as a user-intervention strategy in that we have to honour the user's wishes. Figuring out what those are, however, is a different story, given the different approaches/modules that are available. I wish this could be configured by the user, in the case conflicts/undesired redirects take place. Jumplinks was actually borne from a plugin I wrote for Bolt CMF, and that plugin was an absolute, undeniable 'before everything else even considers thinking of running' scenario. Before we make a decision here, I think we should get more feedback from other JL users, and perhaps get a list together of any plugin that does route-redirection along with their priorities.
  14. @nabo - Thanks for letting me know. I see I updated composer.json and not info.json as well. Update: I have made the change in the repo, but will only be able to update the module directory when I find the password.
  15. @baronmunchowsen – I think mapping collections might be what you need if you haven't declared them in the correct order. Create a collection called blog, and include only the one you would like before the catch-all takes effect. So add old-url=new-url in the collection. Then your source would be blog/{all} and your destination would be new-blog/{all|blog}. That should do it, hopefully. As for query strings, that's being added to v2, which is on hold again unfortunately.
  16. @phlp The reason the cell is empty is because the parser could not determine the browser name and version, and so it's empty anyway. At best, I could simply indicate that the that browser is "unknown" in that column. Wouldn't want to not store unknown agents just because they can't be parsed - this would be getting rid of raw information that might be useful to some folks.
  17. @phlp Security Release 1.5.60 is up. Unable to test right now – please could you check to see that all's good?
  18. @phlp - Thanks for spotting this. Will push a release shortly.
  19. And done πŸ™‚ 0.5.0 released
  20. Going to go ahead and push this to master with a new release. Will update the readme soon.
  21. @OllieMackJames Okay, well I honestly don't think there's much more I can do here (unless I'm missing something staring at me in the face πŸ™ˆ). Hoping to find time soon to continue work on v2 (starting writing the frontend a little while back), which will keep track of these things a little differently (a migration table). Scary to think how long it's been around, and how long I've taken to get v2 anywhere πŸ™ƒ
  22. @OllieMackJames - hmm, something weird is going on here as this is not the first time this has come up (I don't think)... I wonder if it's something related to the module config. The schema version is set there, and it will iterate through the schema updates until it matches the current version. That particular column is way back in schema v3, which is why I think there might be a config issue going on here... Was this a new install or an upgrade?
  23. Great stuff - and does the language support hook-setup work as expected? You're quite right indeed, will sort that out some time tomorrow. πŸ™‚
  24. I actually see I did that already πŸ˜…So feel free to leave out the static method call above and let me know if it works.
  25. So I've been a bit busy this morning refactoring and brooming. A man is busy of late, but hey, gotta make some time for these things eventually. Anyways, couple of things I've done so far: Updated the underlying sitemap package. Refactor: split some code out into concerns, added support helpers, added return types and fixed up doc blocks. Dropped support for PW 2.8 and PHP < 7.1 (should be 7.2, but fine for now) Manually pulled in the merge request with an additional static method to add the language support hooks. I don't really have a good test case to work with, but this is the idea: use MarkupSitemap; wire()->addHookAfter(MarkupSitemap::getAdditionalPages, function ($event) { $page = $event->arguments(0); $language = $event->arguments(1); MarkupSitemap::applyLanguageSupportHooks(); // Add additional pages }); It should internally track whether or not they've been added, but I've simply not tested it yet, so can't say for sure. πŸ˜…That aside though, surely I can add the hooks directly in ___getAdditionalPages? If you'd like to give it a spin, please check out the develop branch directly.
Γ—
Γ—
  • Create New...