Jump to content

tpr

Members
 View Profile  See their activity

  • Posts

    2,320

  • Joined

  • Last visited

  • Days Won

    44

tpr last won the day on November 14 2019

tpr had the most liked content!

1 Follower

About tpr

  • Birthday 06/21/1980

Contact Methods

  • Website URL
    http://rolandtoth.hu/

Profile Information

  • Gender
    Male
  • Location
    Budapest, Hungary
  • Interests
    sports, spaghetti, portable applications, and spaghetti

Recent Profile Visitors

8,937 profile views

tpr's Achievements

Hero Member

Hero Member (6/6)

3.2k

Reputation

21

Community Answers

  1. tpr
    On a ML site I couldn't reproduce this (PW 3.0.123). I have no idea what could cause this and unfortunately I haven't touched AOS recently and unfortunately I have no time to investigate 😞 Perhaps it's because of a newer PW version or perhaps something in your languages setup (naming?), but that's only shooting in the dark.
  2. tpr
    #wrap_Inputfield_enabledSubmodules .InputfieldCheckboxesStacked input:checked+span:before
  3. tpr
    May be not the easiest thing to set up, but with AdminOnSteroids FieldOverrides this is already possible: https://github.com/rolandtoth/AdminOnSteroids/wiki/FieldOverrides
  4. tpr
    You can pull in a custom CSS (see AssetPaths), where you can add anything you want.
  5. tpr
    If someone could create a PR that would be nice, I don't have my personal notebook with me for a few days (that is, no PHP :)).
  6. tpr
    Ok fair, but that could work for a module version 🙂
  7. tpr
    Unless view was restricted to the user who created the content (or to role).
  8. tpr
    It's in AdminOnSteroids.php file 🙂 https://github.com/rolandtoth/AdminOnSteroids/blob/master/AdminOnSteroids.module#L2582
  9. tpr
    Only tried by dragging an invalid filetype to the fields. I now tried a trickyPNG.svg file and the backend responded with 500, perhaps it's a success? 🙂
  10. tpr
    Sorry for the delay - apparently no, I set the allowed extensions to "svg" and a "png" file wasn't accepted (even when setting field "Closed + Load only when opened (AJAX) †"): [Allow SVG only for field 'images'] ?field = "images" extensions = "svg"
  11. tpr
    I think it's doable with AOS, check the FieldOverrides feature: https://github.com/rolandtoth/AdminOnSteroids/wiki/FieldOverrides
  12. tpr
    Thanks for the update. This implementation is a bit weird to me: // Get previous URL segment $prev = $input->urlSegment('=bar'); Perhaps a new urlSegmentBefore() (and after) or a second parameter would be more readable.
  13. tpr
    Sounds good, although I'm not sure when I could get to it. If it's an easy PR please go on, I'll check then 🙂 (typo "unter" in your previous comment 🙂)
  14. tpr
    You would just need to add test files to your module, not the whole testing module. You or someone who is interested could install the tester module and run the tests. I can think of data saving and retrieval tests that could be tested on the backend. Frontend (e2e) testing us another thing, I used Cypress a few times but there are many other available. With Cypress it is easy to simulate user inputs and interactions. I can spend some time to set up a simple test if you wish, so you could use that as a base. But it is easy enough to just get started with the official docs.
  15. tpr
    Not my business (and no offence) but have you considered adding unit tests (there is none in the repo)? This is a sensitive area where accuracy is crucial, tests could improve the overall quality a lot. I can recommend ProcessNetteTester if you don't have any other preferred. In general tests for user supplied modules in PW are very rare (perhaps close to zero as I know, including my own modules), although it would be a sign of quality if there were some conditions to only accept modules with tests to the modules directory.
×
×
  • Create New...