-
Content Count
2,318 -
Joined
-
Last visited
-
Days Won
44
tpr last won the day on November 14 2019
tpr had the most liked content!
Community Reputation
3,235 ExcellentAbout tpr
-
Rank
Hero Member
- Birthday 06/21/1980
Contact Methods
-
Website URL
http://rolandtoth.hu/
Profile Information
-
Gender
Male
-
Location
Budapest, Hungary
-
Interests
sports, spaghetti, portable applications, and spaghetti
-
May be not the easiest thing to set up, but with AdminOnSteroids FieldOverrides this is already possible: https://github.com/rolandtoth/AdminOnSteroids/wiki/FieldOverrides
-
You can pull in a custom CSS (see AssetPaths), where you can add anything you want.
-
If someone could create a PR that would be nice, I don't have my personal notebook with me for a few days (that is, no PHP :)).
-
Ok fair, but that could work for a module version 🙂
-
Unless view was restricted to the user who created the content (or to role).
-
CKEditor - Justify Preinstalled on Textarea Fields
tpr replied to prestoav's topic in Wishlist & Roadmap
It's in AdminOnSteroids.php file 🙂 https://github.com/rolandtoth/AdminOnSteroids/blob/master/AdminOnSteroids.module#L2582- 11 replies
-
- 1
-
-
CKEditor - Justify Preinstalled on Textarea Fields
tpr replied to prestoav's topic in Wishlist & Roadmap
Only tried by dragging an invalid filetype to the fields. I now tried a trickyPNG.svg file and the backend responded with 500, perhaps it's a success? 🙂- 11 replies
-
CKEditor - Justify Preinstalled on Textarea Fields
tpr replied to prestoav's topic in Wishlist & Roadmap
Sorry for the delay - apparently no, I set the allowed extensions to "svg" and a "png" file wasn't accepted (even when setting field "Closed + Load only when opened (AJAX) †"): [Allow SVG only for field 'images'] ?field = "images" extensions = "svg"- 11 replies
-
CKEditor - Justify Preinstalled on Textarea Fields
tpr replied to prestoav's topic in Wishlist & Roadmap
I think it's doable with AOS, check the FieldOverrides feature: https://github.com/rolandtoth/AdminOnSteroids/wiki/FieldOverrides- 11 replies
-
- 1
-
-
Thanks for the update. This implementation is a bit weird to me: // Get previous URL segment $prev = $input->urlSegment('=bar'); Perhaps a new urlSegmentBefore() (and after) or a second parameter would be more readable.
-
Sounds good, although I'm not sure when I could get to it. If it's an easy PR please go on, I'll check then 🙂 (typo "unter" in your previous comment 🙂)
-
You would just need to add test files to your module, not the whole testing module. You or someone who is interested could install the tester module and run the tests. I can think of data saving and retrieval tests that could be tested on the backend. Frontend (e2e) testing us another thing, I used Cypress a few times but there are many other available. With Cypress it is easy to simulate user inputs and interactions. I can spend some time to set up a simple test if you wish, so you could use that as a base. But it is easy enough to just get started with the official docs.
-
Not my business (and no offence) but have you considered adding unit tests (there is none in the repo)? This is a sensitive area where accuracy is crucial, tests could improve the overall quality a lot. I can recommend ProcessNetteTester if you don't have any other preferred. In general tests for user supplied modules in PW are very rare (perhaps close to zero as I know, including my own modules), although it would be a sign of quality if there were some conditions to only accept modules with tests to the modules directory.
-
You definitely took it at face value 🙂