Module: ProcessWire Core Upgrade

[BFD Calendar]

Indeed Vincent, I contacted OVH about it and it turned out that 'stable' instead of 'legacy' solved the problem. I hardly use the .ovhconfig anymore since OVH opened up more settings in the client interface.

[matjazp]

I upgraded PW to the latest dev using the upgrade module from Ryan (I normally upgrade by hand) and got the message that Upgrade files are already present. Please remove them before continuing. Clicking on Remove button didn't help, had to manually delete /site/assets/cache/ProcessWireUpgrade folder. I'm on windows, I think this is important. Anyone else?

[Rudy]

3 hours ago, matjazp said:

I upgraded PW to the latest dev using the upgrade module from Ryan (I normally upgrade by hand) and got the message that Upgrade files are already present. Please remove them before continuing. Clicking on Remove button didn't help, had to manually delete /site/assets/cache/ProcessWireUpgrade folder. I'm on windows, I think this is important. Anyone else?

I encountered the same issue after upgrading to 3.0.118.

[gornycreative]

Deleting the dev.zip file seemed to work for me.

[Peejay]

On 11/2/2018 at 9:43 PM, matjazp said:

I upgraded PW to the latest dev using the upgrade module from Ryan (I normally upgrade by hand) and got the message that Upgrade files are already present. Please remove them before continuing. Clicking on Remove button didn't help, had to manually delete /site/assets/cache/ProcessWireUpgrade folder. I'm on windows, I think this is important. Anyone else?

Had the same issue, deleting the cache worked out for me.

[adrian]

@ryan - this issue still exists on 3.0.119 - any chance of a fix please?

[Gadgetto]

Same problem here! 

Removing the content of the /site/assets/cache/ProcessWireUpgrade folder wasn't enough. Needed to remove this folder completely.

[Gadgetto]

1 hour ago, Gadgetto said:

Same problem here! 

Removing the content of the /site/assets/cache/ProcessWireUpgrade folder wasn't enough. Needed to remove this folder completely.

Forgot to say, problem happens on version 3.0.118. After removing this folder and running upgrade to 3.0.119 I couldn’t reproduce the issue.

[cb2004]

Same issue. Latest dev doesn't help.

[matjazp]

The problem is in WireFileTools.php in rmdir() method in foreach loop. The $path coming into rmdir() contains ending slash, and $pathame (actual directory name) eventually contains two slashes , that makes allowPath() method to throw an WireException. The possible solution is simple: $path = rtrim($path, "/");

[gingebaker]

Hi

There is also an open issue for this problem on github with some possible fixes. 

https://github.com/processwire/processwire-issues/issues/704

 

[matjazp]

1 hour ago, gingebaker said:

There is also an open issue for this problem on github with some possible fixes. 

https://github.com/processwire/processwire-issues/issues/704

I know, I opened it ? Ryan tried to fix this issue, but introduced another one. Try:

$files->mkdir($config->paths->cache . "test/test/", true);
$files->rmdir($config->paths->cache . "test/", true, array('throw' => true));

By default throw is false, I set it to true just for you/others to see the results. The point is: rmdir() fails to remove a directory that contains subdirectories due to a bug. 

Edit: ? 

 

Edited November 26, 2018 by matjazp

[pmichaelis]

Hey,
 

I keep getting errors when I try to visit the upgrades admin page.
I thought it was a memory limit problem and increased the memory, but I still get the errors.
 

/processwire/setup/upgrades/	
Allowed memory size of 134217728 bytes exhausted (tried to allocate 4096 bytes) (Zeile 1266 in /var/www/htdocs/wire/core/WireHttp.php)

Any hints? Never had problems with the upgrade module.

[eydun]

Quote

Any hints? Never had problems with the upgrade module.

It can possibly be related to some faulty configuration in the .htaccess file.

[pmichaelis]

On 8/23/2019 at 5:29 PM, eydun said:

It can possibly be related to some faulty configuration in the .htaccess file.

Thanks. I'll give it a try

[LostKobrakai]

On 8/23/2019 at 5:29 PM, eydun said:

It can possibly be related to some faulty configuration in the .htaccess file.

What exactly would I need to be looking for? I've the problem of the memory leak as well.

[eydun]

Oh my, I am not sure I can remember that ? Do you also get memory leak with the upgrades module, or some other module?

[LostKobrakai]

On 11/28/2020 at 8:20 PM, eydun said:

Do you also get memory leak with the upgrades module

Exactly that; when visiting the admin page, which should show the updates. Not sure where this one is coming from.

[DV-JF]

Hey @ryan, hey all,

I've to update some websites in order to make them work with PHP 8.1. While doing so I've noticed, that ProcessWire is not on all sites in the listed updates. I'd expected to be on top of the list like this:

But on some websites ProcessWire doesn't appear and I see no logic behind ?

Any hints or an explanation?

Cheers ?

 

[markus-th]

@DV-JF 

I also had the same behavior that no core updates were displayed. This phenomenon was only with Processwire installations that were already somewhat older.

I then noticed that the ready.php in the site folder were different for these old installations. Replacing them with a new ready.php resulted in the coreupdates being displayed again. 

But be careful, if you already have a modified ready.php, you have to make these changes in the new file too.

 

[cb2004]

@Markus Thomas I am not sure this is the case as ready.php doesn't need to exist and it could be coincidence maybe? I think it is down to rate limiting for the Github API so sites that are on shared hosting may not display the results at one point, but they do the next, that was always my findings.

[markus-th]

@cb2004 Maybe it was a coincidence in my case, however, it worked exactly like that for me in 3 installations.

[wbmnfktr]

I am working on and thinking about automating quite some tasks in ProcessWire and just stumbled about the thought to take updates into my list of possible tasks.

Has anyone an idea if it's possible to hook LazyCron into/or hook directly into ProcessWireUpgrades to look for updates with this module (including updating the directory listings) and go from there, like sending an email with all existing updates/changes?

As far as I could tell the answer is probably: NO

Any ideas or thoughts?
First of all my main goal is receiving an email once in a while for each instance in which updates could be done/are available.
No automated updates (I am not an adrenalin enthusiast)!

 

Oh, and yes... please feel free to "steal" this idea for a module if you like or add a recipe for this. 

[monollonom]

It wouldn’t be too difficult using ProcessWireUpgradeCheck::getModuleVersions. You can also have a look at ProcessWireUpgradeCheck::loginHook to see how it's used. Something like:

$wire->addHook("LazyCron::everyMonth", function(HookEvent $event) {
    $checker = $event->modules->get("ProcessWireUpgradeCheck");
    if(!$checker) return;

    $upgrades = $checker->getModulesVersions(true); // we only want modules with new versions
    if(!count($upgrades)) return;

    $subject = "There are " . count($upgrades) . " modules to update on $config->httpHost";

    $body = "Hi!\n\nAn upgrade is available for these modules on $config->httpHost:\n\n";

    foreach($upgrades as $name => $info) {
        $body .= "- $name ($info[remote])\n";
    }

    $body .= "\nHead to " . $event->pages->get("process=ProcessWireUpgrades")->url . " to upgrade"; // not sure if this `get` would work?

    $mail = new wireMail();
    $mail->from("upgrade@$config->httpHost")
        ->to("you@mail.com")
        ->subject($subject)
        ->body($body)
        ->send();
});

(non tested code written from my phone, so please forgive the formatting and/or mistakes ?)

Edited May 13, 2023 by monollonom
Formatted code :-)

[wbmnfktr]

This is brilliant! Just minor tweaks. You already did 99,9% of the job.

Awesome! Thank you.

wire()->addHookAfter("LazyCron::every4Weeks", function(HookEvent $event) {
    $checker = $event->modules->get("ProcessWireUpgradeCheck");
    if(!$checker) return;

    $upgrades = $checker->getModuleVersions(true); // we only want modules with new versions
    if(!count($upgrades)) return;

    $subject = "There are " . count($upgrades) . " modules to update";
    
    $body = "Hi!\n\nAn upgrade is available for these modules on " . wire('config')->httpHost . ":\n\n";

    foreach($upgrades as $name => $info) {
        $body .= "- $name ($info[remote])\n";
    }

    $body .= "\nHead to " . $event->pages->get("process=ProcessWireUpgrade")->httpUrl . " to upgrade."; // not sure if this `get` would work?

    $mail = wireMail();
    $mail->from("wwwuser@example.com")
        ->to("admin@example.com")
        ->subject($subject)
        ->body($body)
        ->send();
});

Just added this to an existing site. Works perfectly fine.

 

Follow up

Added public recipe for all:
https://processwire.recipes/recipes/automate-module-upgrade-check/

Edited May 14, 2023 by wbmnfktr
Added follow up and recipe link