Jump to content

matjazp

Members
  • Posts

    685
  • Joined

  • Last visited

  • Days Won

    4

Everything posted by matjazp

  1. It's working here. That 0 is error code (and ? is error text) returned from WireHttp::GetHttpCode(). Hard to tell what went wrong. Can you provide original image?
  2. https://github.com/processwire/processwire-issues/issues/1893
  3. Thx Robin! While the Save + Close button is there (as expected), the js part makes the edit links all open home page, eg. they all have the link /processwire/page/edit/?id=1&quick_edit=1 I fixed that with: const $links = $('.PageListActionEdit a:not([data-autoclose])'); $links.each(function() { $link = $(this); $link.attr('data-autoclose', '#save-and-close').attr('href', $link.attr('href') + '&quick_edit=1'); }); Just to mention that using uk-hidden class (as a "belt and suspender" approach) would only work in AdminThemeUIkit, leaving out newer (and older) admin themes.
  4. Now that you explain it, I remember this behavior of modal.js. But, unfortunately, it doesn't work here, only the Save button is cloned. Looking at the modal.js line 417, $icontents.find(buttonSelector) only returns one button, not two as expected. It seems like the Save+Close button is added too late, after the modal has already cloned the Save button. While debugging, I added the button unconditionally and also removed the uk-hidden class, and then edited the page in a new tab with modal=1, and both buttons were there, as expected. But not in modal. I guess if I add the button directly to the ProcessPageEdit.module (or via hook), it would work. But it's working for you, so there must be something with my installation. It's a bit late here, so I'll continue testing tomorrow.
  5. Hey Robin! Thanks for this. I haven't had time to test this, but looking the code I see uk-hidden class on button. Would button even show? (and I know it's there for a reason)
  6. Just to say, that 4.0 beta is working just fine. I had to tweak jquery migrate, but this issue will be fixed soon.
  7. I don't like toggles at all. I find them confusing. I use a checkbox or radio group. It’s clear what you want, accessible and doesn’t make me think.
  8. https://github.com/processwire/processwire-issues/issues/1867 ?
  9. @Lutz I think this is addressed in https://github.com/processwire/processwire/commit/24fc229be563de0157ed18ee199dfab889286169 , but this was already fixed in 3.0.184 so I wonder if this is something new?
  10. I installed SkyScraper profile (last commit from year 2013, not compatible with PW3) on PW 3.0.221 and loaded home page: 1.10 seconds: no cache enabled 1.00 seconds: built-in cache enabled 0.35 seconds: AIOM+ enabled
  11. 1.10 seconds: no cache enabled 1.00 seconds: built-in cache enabled 0.095 seconds: AIOM+ enabled I'm not using debug timer, just timings in browser network tab. @bernhardperhaps you could test AIOM+ on the same setup as you tested with ProCache (29 seconds ???).
  12. Nope, as I don't have ProCache, but based on what I've read and info from the forum, ProCache serves static files and there might be directives needed in .htaccess. I'm on IIS so it's not an option for me. AIOM+ leverages the template page cache built in core and uses a small php file to render those files. It's not perfect as modification of index.php is needed for best results (I have a feature request open). It also works if you modify some settings in site config.php, but it's not that effective.
  13. Yes, it even works on PHP 8.3 and it's caching option is almost as fast as ProCache.
  14. You can try my fork of aiom https://github.com/matjazpotocnik/ProcessWire-AIOM-All-In-One-Minify
  15. Thanks. You can comment this line. This module is still working, but need some love and could be simplified if required PHP version is bumped up. There is also a new version of file editor (with the same namespace) written by someone else (can't remember the name), I think it's actively maintained?
  16. I'm not sure this is ok, as saveModuleConfigData is: "@deprecated Please use saveConfig() method instead". saveConfig() is hookable and it should fire, so not sure what's going on. Maybe others have an idea?
  17. https://processwire.com/talk/topic/27528-weekly-update-– 2-september-2022/
  18. It's not just quotation marks. In setAttributeValue() in InputfieldURL.module: input (dirty) value: https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTY0NjAwYmUtOGIxNy11OGI5LWExMWMtNThlMmRmZGU5YTZl%40thread.v2/0?context={"Tid"%3a"36cabc20-3b53-4a0d-be6d-1fb3a94f9786"%2c"Oid"%3a"a508db2a-aff9-475e-9cf2-e51581a58320"} sanitized value using sanititer()->url() method: https://teams.microsoft.com/l/meetup-join/19:meeting_OTY0NjAwYmUtOGIxNy11OGI5LWExMWMtNThlMmRmZGU5YTZl@thread.v2/0?context={"Tid"%3a"36cabc20-3b53-4a0d-be6d-1fb3a94f9786"%2c"Oid"%3a"a508db2a-aff9-475e-9cf2-e51581a58320"} rawurldecoded value: https://teams.microsoft.com/l/meetup-join/19:meeting_OTY0NjAwYmUtOGIxNy11OGI5LWExMWMtNThlMmRmZGU5YTZl@thread.v2/0?context={"Tid":"36cabc20-3b53-4a0d-be6d-1fb3a94f9786","Oid":"a508db2a-aff9-475e-9cf2-e51581a58320"} As sanitized and rawurldecoded values differ, PW returns an error. I'm not sure how te deal with that, perhaps open an issue report? What could you do: a) use plain text field, b) instruct users to rawurldecode the url ?
  19. Open /wire/modules/Inputfield/InputfieldTinyMCE/InputfieldTinyMCE.module.php and comment lines 289-291 and see if this helps.
  20. @teppo I just opened an issue regarding deprecation warnings.
  21. @ryan I'm attaching a standalone version for Selectize, if you decide to upgrade. Please see readme file; there are some other issues with jQuery UI and a suggested fix. selectize.zip
  22. Ryan, thank you for all the updates!!! It's a lot of work, if you think I could help you more, please let me know. Here are a few more, I'm sure that's not all: /wire/modules/Inputfield/InputfieldSelector/InputfieldSelector.js .removeAttr('disabled') -> .prop('disabled', false); /wire/modules/InputfieldTinyMCE/plugins/pwimage.js .load(), .click() /wire/modules/Jquery/JqueryUI/panel.js .resize() Those listed below are from third parties; some are staled at the development. Replacing them with the new version require more testing, so I'm not sure if it's worth your time. /wire/modules/Process/ProcessPageEditImageSelect/cropper/cropper.js .load(), .isFunction() /wire/modules/Inputfield/InputfieldDatetime/timepicker/jquery-ui-sliderAccess.js .click() /wire/modules/Inputfield/InputfieldDatetime/timepicker/jquery-ui-timepicker-addon.js multiple deprecations Consider updating jQuery Timepicker Addon from v 1.6.1 to 1.6.4 with this fork: https://github.com/DanielTOsborne/jQuery-Timepicker-Addon (see attached file) /wire/modules/Jquery/JqueryMagnific/JqueryMagnific.js .isFunction(), .focus() Consider upgrade to v1.1.0 (see attached file) and also check this potential security leak: https://github.com/dimsemenov/Magnific-Popup/issues/1189 /wire/modules/Jquery/JqueryUI/vex/scripts/vex.combined.js .click(), .bind() Latest version: https://github.com/HubSpot/vex/archive/refs/tags/v4.1.0.zip /wire/modules/Jquery/JqueryUI/selectize/js/standalone/selectize.js .focus() Latest version: https://github.com/selectize/selectize.js/archive/refs/tags/v0.15.2.zip but still with deprecated methods ? JqueryMagnific.zip timepicker.zip
  23. https://github.com/jquery/jquery-migrate/blob/main/warnings.md
×
×
  • Create New...