-
Posts
676 -
Joined
-
Last visited
-
Days Won
4
Everything posted by matjazp
-
@Lutz I think this is addressed in https://github.com/processwire/processwire/commit/24fc229be563de0157ed18ee199dfab889286169 , but this was already fixed in 3.0.184 so I wonder if this is something new?
-
PW 3.0.210 broke InputfieldForm.getErrors() with error cache
matjazp replied to da²'s topic in General Support
Please open an issue report. -
I installed SkyScraper profile (last commit from year 2013, not compatible with PW3) on PW 3.0.221 and loaded home page: 1.10 seconds: no cache enabled 1.00 seconds: built-in cache enabled 0.35 seconds: AIOM+ enabled
-
1.10 seconds: no cache enabled 1.00 seconds: built-in cache enabled 0.095 seconds: AIOM+ enabled I'm not using debug timer, just timings in browser network tab. @bernhardperhaps you could test AIOM+ on the same setup as you tested with ProCache (29 seconds ???).
-
Nope, as I don't have ProCache, but based on what I've read and info from the forum, ProCache serves static files and there might be directives needed in .htaccess. I'm on IIS so it's not an option for me. AIOM+ leverages the template page cache built in core and uses a small php file to render those files. It's not perfect as modification of index.php is needed for best results (I have a feature request open). It also works if you modify some settings in site config.php, but it's not that effective.
-
Yes, it even works on PHP 8.3 and it's caching option is almost as fast as ProCache.
-
You can try my fork of aiom https://github.com/matjazpotocnik/ProcessWire-AIOM-All-In-One-Minify
-
Thanks. You can comment this line. This module is still working, but need some love and could be simplified if required PHP version is bumped up. There is also a new version of file editor (with the same namespace) written by someone else (can't remember the name), I think it's actively maintained?
-
Modules::saveConfig Hook does not fire anymore [SOLVED]
matjazp replied to Juergen's topic in Module/Plugin Development
I'm not sure this is ok, as saveModuleConfigData is: "@deprecated Please use saveConfig() method instead". saveConfig() is hookable and it should fire, so not sure what's going on. Maybe others have an idea? -
Modules::saveConfig Hook does not fire anymore [SOLVED]
matjazp replied to Juergen's topic in Module/Plugin Development
Does hook fire on Modules::saveModuleConfigData? -
https://processwire.com/talk/topic/27528-weekly-update-– 2-september-2022/
-
It's not just quotation marks. In setAttributeValue() in InputfieldURL.module: input (dirty) value: https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTY0NjAwYmUtOGIxNy11OGI5LWExMWMtNThlMmRmZGU5YTZl%40thread.v2/0?context={"Tid"%3a"36cabc20-3b53-4a0d-be6d-1fb3a94f9786"%2c"Oid"%3a"a508db2a-aff9-475e-9cf2-e51581a58320"} sanitized value using sanititer()->url() method: https://teams.microsoft.com/l/meetup-join/19:meeting_OTY0NjAwYmUtOGIxNy11OGI5LWExMWMtNThlMmRmZGU5YTZl@thread.v2/0?context={"Tid"%3a"36cabc20-3b53-4a0d-be6d-1fb3a94f9786"%2c"Oid"%3a"a508db2a-aff9-475e-9cf2-e51581a58320"} rawurldecoded value: https://teams.microsoft.com/l/meetup-join/19:meeting_OTY0NjAwYmUtOGIxNy11OGI5LWExMWMtNThlMmRmZGU5YTZl@thread.v2/0?context={"Tid":"36cabc20-3b53-4a0d-be6d-1fb3a94f9786","Oid":"a508db2a-aff9-475e-9cf2-e51581a58320"} As sanitized and rawurldecoded values differ, PW returns an error. I'm not sure how te deal with that, perhaps open an issue report? What could you do: a) use plain text field, b) instruct users to rawurldecode the url 🙂
-
Open /wire/modules/Inputfield/InputfieldTinyMCE/InputfieldTinyMCE.module.php and comment lines 289-291 and see if this helps.
-
@teppo I just opened an issue regarding deprecation warnings.
-
@ryan I'm attaching a standalone version for Selectize, if you decide to upgrade. Please see readme file; there are some other issues with jQuery UI and a suggested fix. selectize.zip
-
Ryan, thank you for all the updates!!! It's a lot of work, if you think I could help you more, please let me know. Here are a few more, I'm sure that's not all: /wire/modules/Inputfield/InputfieldSelector/InputfieldSelector.js .removeAttr('disabled') -> .prop('disabled', false); /wire/modules/InputfieldTinyMCE/plugins/pwimage.js .load(), .click() /wire/modules/Jquery/JqueryUI/panel.js .resize() Those listed below are from third parties; some are staled at the development. Replacing them with the new version require more testing, so I'm not sure if it's worth your time. /wire/modules/Process/ProcessPageEditImageSelect/cropper/cropper.js .load(), .isFunction() /wire/modules/Inputfield/InputfieldDatetime/timepicker/jquery-ui-sliderAccess.js .click() /wire/modules/Inputfield/InputfieldDatetime/timepicker/jquery-ui-timepicker-addon.js multiple deprecations Consider updating jQuery Timepicker Addon from v 1.6.1 to 1.6.4 with this fork: https://github.com/DanielTOsborne/jQuery-Timepicker-Addon (see attached file) /wire/modules/Jquery/JqueryMagnific/JqueryMagnific.js .isFunction(), .focus() Consider upgrade to v1.1.0 (see attached file) and also check this potential security leak: https://github.com/dimsemenov/Magnific-Popup/issues/1189 /wire/modules/Jquery/JqueryUI/vex/scripts/vex.combined.js .click(), .bind() Latest version: https://github.com/HubSpot/vex/archive/refs/tags/v4.1.0.zip /wire/modules/Jquery/JqueryUI/selectize/js/standalone/selectize.js .focus() Latest version: https://github.com/selectize/selectize.js/archive/refs/tags/v0.15.2.zip but still with deprecated methods 😞 JqueryMagnific.zip timepicker.zip
-
https://github.com/jquery/jquery-migrate/blob/main/warnings.md
-
I didn't test on frontend, but here in admin it works. Of course I cound't test everything, so it's quite possible that there is some odd bug in the latest version of Uikit (likely 3.16.15 in a few days).
-
I'm testing with $config->debug="dev" and there are no major issues. Thanks for the update, @ryan I found these js files that might need some updates for the lastest jQuery (deprecations): /wire/templates-admin/scripts/install.js /wire/templates-admin/scripts/inputfields.js (focus) /wire/modules/AdminTheme/AdminThemeDefault/scripts/install.js /wire/modules/AdminTheme/AdminThemeDefault/scripts/main.js /wire/modules/AdminTheme/AdminThemeReno/scripts/main.js /wire/modules/System/SystemNotifications/Notifications.js /wire/modules/Process/ProcessRole/ProcessRole.js /wire/modules/Process/ProcessProfile/ProcessProfile.js /wire/modules/Process/ProcessPageEditLink/ProcessPageEditLink.js /wire/modules/Process/ProcessCommentsManager/ProcessCommentsManager.js /wire/modules/Inputfield/InputfieldDatetime/timepicker/jquery-ui-sliderAccess.js (upgrade to 1.6.3) /wire/modules/Inputfield/InputfieldDatetime/timepicker/jquery-ui-timepicker-addon.js (upgrade to 1.6.3) /wire/modules/Inputfield/InputfieldPageTable/InputfieldPageTable.js /wire/modules/Inputfield/InputfieldSelector/InputfieldSelector.js /wire/modules/Inputfield/InputfieldPageAutocomplete/InputfieldPageAutocomplete.js /wire/modules/Jquery/JqueryWireTabs/JqueryWireTabs.js (eq) /wire/modules/LanguageSupport/LanguageTabs.js /wire/modules/Jquery/JqueryTableSorter/widgets.js /wire/modules/Jquery/JqueryTableSorter/JqueryTableSorter.js (new version 2.31.3 also has issues with deprecated function calls) /wire/modules/AdminTheme/AdminThemeUikit/layout/source/stable/plugins/jquery.layout.buttons.js I would also update ckeditor to v4.21.0 and uikit to v3.16.14. EDIT: Ryan, I tested with this forked version of JqueryTableSorter: https://github.com/DavidAnderson684/tablesorter and there are no deprecations in the lastest version of jQuery. I'm attaching a zip file with the files to be replaced in /wire/modules/Jquery/JqueryTableSorter/ JqueryTableSorter.zip
-
I can confirm. I fixed it by adding if(typeof str == "undefined") return ""; at the top of parseValue() function in inputfields.js.
-
I can enter info@gourmets-for-nature.de without problems.
-
Page Structuring Approach Considerations (ecommerce order example)
matjazp replied to Jonathan Lahijani's topic in Dev Talk
What is your advice? I've read an article long time ago but forget what conclusions were made... -
https://github.com/processwire/processwire-issues/issues/1707
-
Sorry for not being clear. CURLOPT_SSL_VERIFYPEER is an option for curl that verify the peer's SSL certificate. When CURLOPT_SSL_VERIFYPEER is enabled, and the verification fails to prove that the certificate is authentic, the connection fails. When the option is zero, the peer certificate verification succeeds regardless. I added this in OpenAi.php, which is used to make HTTP requests to ChatGPT. We could use wireHttp class for that too. Disabling this option is not a way to go, so this was a quick fix to get the response from ChatGPT. Regarding "ChatGPT is offline" error, I couldn't log into my account from my work PC yesterday but could log in from my home PC. It happens from time to time. Try from another computer.
-
Hm, I can't make it work. curl_getinfo($curl, CURLINFO_HTTP_CODE) in OpenAi.php returns 0. I can manually curl just fine, so it's not GPT. Edit: aha, curl_error($curl) gives 'SSL certificate problem: unable to get local issuer certificate'. ok, not exactly recommended, but as a quick fix CURLOPT_SSL_VERIFYPEER => false, or download curl cert and add it to php.ini