Jump to content
ryan

Module: Video embed for YouTube/Vimeo (TextformatterVideoEmbed)

Recommended Posts

4 minutes ago, artaylor said:

@strandoo Not sure if this would help, but I notice you are using the short form url on the second example (that does not work) of https://youtu.be/LBY12usmYAA, have you tried using the actual youtube url (which I cannot link to here because it embeds the video)?

 

I haven't tested, but youtube.be should work: https://github.com/ryancramerdesign/TextformatterVideoEmbed/blob/7c8e4ddce22dc4970c17d0f63ce3d53679e7e3a8/TextformatterVideoEmbed.module#L163

Here's it working as expected:
https://regex101.com/r/aEcLl2/1

  • Like 1

Share this post


Link to post
Share on other sites

@adrian You are likely correct. I did not do any real testing. However, as an interesting note, when I posted my previous message you can see the url to youtu.be as a url, however, the link to the video using youtube.com actually embedded the video. So, I have to assume that the forum is using the plugin and it did not show the shortened version.

Share this post


Link to post
Share on other sites
Just now, artaylor said:

So, I have to assume that the forum is using the plugin

This forum is just an IPBoard forum - no PW code or use of this module. Good thought though :)

Share this post


Link to post
Share on other sites

@artaylor I've tried different URLs with similar results. I just tested the embed URL and that didn't work. And as @adrian pointed out, but short form does work (on the 'good' site). I checked other text formatters to make sure they didn't conflict. One thing I just thought of is that they are served from different hosting companies (StableHost vs HostingUK) so differing server configs could be in play...

Share this post


Link to post
Share on other sites
2 hours ago, strandoo said:

The other only works if it's a Vimeo video; YouTube URLs slow the page loading then only displays the URL.

The strange thing is though is that you have working embedded YouTube videos on that site here:

http://www.burstoncrown.com/events/easy-thursdays/jess-morgan-and-kitty-macfarlane/

Perhaps the host is running mod_security or similar and that is being triggered by particular patterns in some video URLs?

Share this post


Link to post
Share on other sites

@strandoo Add the following on top of your .htaccess file. Perhaps this will fix the problem.

<IfModule mod_security.c>
  SecFilterEngine Off
  SecFilterScanPOST Off
</IfModule>

 

  • Like 1

Share this post


Link to post
Share on other sites
3 hours ago, strandoo said:

Hi all. This has been driving me nuts: I've used this module previously and it worked perfectly. I've got it on 2 sites, but music-related. One works normally; I use the textformatter on the body text and videos display fine. The other only works if it's a Vimeo video; YouTube URLs slow the page loading then only displays the URL. I've tried a number of tests and different URLs and I can't figure this out. Both sites are not new and I'm pretty sure that it used to work where now it doesn't.

Here are two samples (they are past gigs, so I can play around with them without messing up the live sites):

Works: https://waveneyvalleyfolkcollective.co.uk/events/kirsty-merryn-jack-harris/

Doesn't Work: http://www.burstoncrown.com/events/sunday-sessions/falling-from-trees/

Any suggestions?

I've seen something similar to this on a client site when this textformatter was added to a CKEditor'd textarea field. It turned out that I was pasting in links to the video, not just the plaintext of the video address and this was causing the formatter to fail to match and then embed it. If you look at the source of the page where the video doesn't work, look to see if the text you pasted is actually a link, and if so, simply break the link, save the page and revisit it on the front-end.

I hope that is what's happening here - but there's no guarantee it is.

Share this post


Link to post
Share on other sites

I tried inserting this link and it works here. There is something that makes text formater to fail and then just plain text is rendered. As netcarver pointed, remove the link to video altogether, save the page and the insert it again. Also, the site sometimes takes a long time to load at all, but its unrelated I guess.

Share this post


Link to post
Share on other sites
10 hours ago, Robin S said:

The strange thing is though is that you have working embedded YouTube videos on that site here:

http://www.burstoncrown.com/events/easy-thursdays/jess-morgan-and-kitty-macfarlane/

Ah, I should have mentioned that. Since this is alive site, and that's an upcoming gig, I needed a workaround. I'm not using the module there, just a special field that inserts the YouTube URL in an iframe. I prefer the responsiveness of Ryan's module.

@netcarver  I've run into that problem in the past, so I've checked. All clean text. 

@PWaddict That sound promising. I've had problems with mod_security before. I'll try it out a bit later today. 

Last night I created a local version of the site and the videos loaded fine, leading me to think it's a hosting/php/config thing. 

Share this post


Link to post
Share on other sites
2 minutes ago, strandoo said:

@PWaddict That sound promising. I've had problems with mod_security before. I'll try it out a bit later today. 

Last night I created a local version of the site and the videos loaded fine, leading me to think it's a hosting/php/config thing. 

Then I'm 99.9% sure that the mod_security is causing the problem. The suggested fix will do the job.

Share this post


Link to post
Share on other sites

So, as PWaddict predicted, turning off mod_security did the trick, but I couldn't do it with the htaccess rule. I tried that first, but it didn't do anything, so I disabled it in the Plesk control panel. (It's under 'Web Application Firewall..'; I've set it to 'detection only' rather than 'on' or 'off'. If anyone knows of a downside to this or if I can target something more directly, please let me know). But the video now appears as it should. Thanks all.

  • Like 1

Share this post


Link to post
Share on other sites

Update: a couple of days later, the problem returned. I contacted support for this account and after a bit of back and forth, I gave up. I took a look at the hosting Plesk cp and saw that mod_sec is turned off. The PHP version was 5.3 (I'm pretty sure I had it at 5.6) so I changed it back to 5.6. I'm basically back where I started. Maybe I'll move the account to my reseller hosting. Everything works fine there...

Share this post


Link to post
Share on other sites

Hi

How do I center the video? If it's embed in <p>link<p>, it's display. But if we do <p style="text-align:center;">link</p>, the video doesn't display.

I just have 2 formatters, this one and Hanna.

Thanks

 

Share this post


Link to post
Share on other sites

Hello,

Found a solution via css, but I don't know how to apply to it since this iframe have no id neither class. (I have others iframe which I doesn't want to center).

So how I can apply an id or class to the video iframe?

Thanks

Share this post


Link to post
Share on other sites
3 hours ago, mel47 said:

I don't know how to apply to it since this iframe have no id neither class

I prefer the responsive embed method...

2018-03-30_101503.png.f257522cc7e412ac1c53ee55335c8f0a.png

...and this applies a class to a containing div element.

2018-03-30_101708.png.a8b15e1227e7695caa9ed894ec0c08c2.png

 

 

  • Like 1

Share this post


Link to post
Share on other sites

Thanks, but responsive tooks too much space in desktop version, even if it's was fine in mobile version. I found a way to specify some CSS rules. Thanks.

Share this post


Link to post
Share on other sites

I'm in process of upgrading PW 2.5.4, PHP 5.6.8 and using TextformatterVideoEmbed version 109. When I upgrade this module to the latest version 111 I get 

Compile Error: Cannot make static method ConfigurableModule::getModuleConfigInputfields() non static in
class TextformatterVideoEmbed (line 18 of \site\modules\TextformatterVideoEmbed\TextformatterVideoEmbed.module) 

Is it possible that this method is problematic?

version 109:

public static function getModuleConfigInputfields(array $data) {

version 111:

public function getModuleConfigInputfields(array $data) {

 

  • Like 1

Share this post


Link to post
Share on other sites

Upgrading to which PW version? 2.x or 3.x?

Share this post


Link to post
Share on other sites

My plan is to go slow: 2.5.4 -> 2.7.3 -> 2.8.62 -> 3.0.102 But it fails on 2.5.4. The module itself states it's stable and working on 2.2, 2.3, 2.4, 2.5, 2.6, 2.7, 3.0 I know the module v 111 works on PW 3 (various versions).

Share this post


Link to post
Share on other sites

I have upgraded several old (~4 yrs) PW sites straight to the latest dev version. The more you wait with upgrading, the more you'll have to change. Sometimes it just means adding PW namespaces, or upgrading modules as well. Sadly, I have no clue why this function causes problems. I just came across Ryan's announcement of this function: https://processwire.com/blog/posts/new-module-configuration-options/

This was introduced for 2.5.5. Maybe @ryan can shed some light on this...

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By bernhard
      --- Please use RockFinder3 ---
    • By MoritzLost
      Cacheable Placeholders
      This module allows you to have pieces of dynamic content inside cached output. This aims to solve the common problem of having a mostly cacheable site, but with pieces of dynamic output here and there.  Consider this simple example, where you want to output a custom greeting to the current user:
      <h1>Good morning, <?= ucfirst($user->name) ?></h1> This snippet means you can't use the template cache (at least for logged-in users), because each user has a different name. Even if 99% of your output is static, you can only cache the pieces that you know won't include this personal greeting. A more common example would be CSRF tokens for HTML forms - those need to be unique by definition, so you can't cache the form wholesale.
      This module solves this problem by introducing cacheable placeholders - small placeholder tokens that get replaced during every request. The replacement is done inside a Page::render hook so it runs during every request, even if the response is served from the template cache. So you can use something like this:
      <h1>Good morning, {{{greeting}}}</h1> Replacement tokens are defined with a callback function that produces the appropriate output and added to the module through a simple hook:
      // site/ready.php wire()->addHookAfter('CachePlaceholders::getTokens', function (HookEvent $e) { $tokens = $e->return; $tokens['greeting'] = [ 'callback' => function (array $tokenData) { return ucfirst(wire('user')->name); } ]; $e->return = $tokens; }); Tokens can also include parameters that are parsed and passed to the callback function. There are more fully annotated examples and step-by-step instructions in the README on Github!
      Features
      A simple and fast token parser that calls the appropriate callback and runs automatically. Tokens may include multiple named or positional parameters, as well as multi-value parameters. A manual mode that allows you to replace tokens in custom pieces of cached content (useful if you're using the $cache API). Some built-in tokens for common use-cases: CSRF-Tokens, replacing values from superglobals and producing random hexadecimal strings. The token format is completely customizable, all delimiters can be changed to avoid collisions with existing tag parsers or template languages. Links
      Github Repository & documentation Module directory (pending approval) If you are interested in learning more, the README is very extensive, with more usage examples, code samples and usage instructions!
    • By Craig
      I've been using Fathom Analytics for a while now and on a growing number of sites, so thought it was about time there was a PW module for it.
      WayFathomAnalytics
      WayFathomAnalytics is a group of modules which will allow you to view your Fathom Analytics dashboard in the PW admin panel and (optionally) automatically add and configure the tracking code on front-end pages.
      Links
      GitHub Readme & documentation Download Zip Modules directory Module settings screenshot What is Fathom Analytics?
      Fathom Analytics is a simple, privacy-focused website analytics tool for bloggers and businesses.

      Stop scrolling through pages of reports and collecting gobs of personal data about your visitors, both of which you probably don't need. Fathom is a simple and private website analytics platform that lets you focus on what's important: your business.
      Privacy focused Fast-loading dashboards, all data is on a single screen Easy to get what you need, no training required Unlimited email reports Private or public dashboard sharing Cookie notices not required (it doesn't use cookies or collect personal data) Displays: top content, top referrers, top goals and more
    • By daniels
      This is a lightweight alternative to other newsletter & newsletter-subscription modules.
      You can find the Module in the Modules directory and on Github
      It can subscribe, update, unsubscribe & delete a user in a list in Mailchimp with MailChimp API 3.0. It does not provide any forms or validation, so you can feel free to use your own. To protect your users, it does not save any user data in logs or sends them to an admin.
      This module fits your needs if you...
      ...use Mailchimp as your newsletter / email-automation tool ...want to let users subscribe to your newsletter on your website ...want to use your own form, validation and messages (with or without the wire forms) ...don't want any personal user data saved in any way in your ProcessWire environment (cf. EU data regulation terms) ...like to subscribe, update, unsubscribe or delete users to/from different lists ...like the Mailchimp UI for creating / sending / reviewing email campaigns *I have only tested it with PHP 7.x so far, so use on owners risk
      EDIT:
      Since 0.0.4, instructions and changelog can be found in the README only. You can find it here  🙂
      If you have questions or like to contribute, just post a reply or create an issue or pr on github, thanks!
    • By MoritzLost
      Sorry for the convoluted title. I have a problem with Process modules that define a custom page using the page key through getModuleInfo (as demonstrated in this excellent tutorial by @bernhard). Those pages are created automatically when the module is installed. The problem is that the title of the page only gets set in the current language. That's not a problem if the current language (language of the superuser who is installing the module) is the default language; if it isn't, the Process page is missing a title in the default language. This has the very awkward effect that a user using the backend in the default language (or any other language) will see an empty entry in the setup menu:

      This screenshot comes from my Cache Control module which includes a Process page. Now I realize the description sounds obscure, but for us it's a common setup: We a multiple bilingual sites where the default language is German and the second language is English. While the clients use the CMS in German, as a developer I prefer the English interface, so whenever I install a Process module I get this problem.
      As a module author, is there a way to handle this situation? I guess it would be possible to use post-installation hooks or create the pages manually, but I very much prefer the declarative approach. The page title is already translatable (through the __ function), but of course at the time of installation there is no translation, and as far as I'm aware it's not possible to ship translations with a module so they are used automatically. Could this situation be handled better in the core? I would prefer if the module installation process would always set the title of the Process page in the default language, instead of the language of the current user.
×
×
  • Create New...