Jump to content
teppo

Version Control

Recommended Posts

@Teppo,

here's the error;

i think this only happens on pages that actually have history for some fields; there is a page where we can add pages to this field, and i think possibly the only difference is that there is no history for any fields on that page

http://mysite.com/manage/page/edit/    Error:     Exception: Can't save field from page 1951: /catalogue/name-of-album-changed/: Call $page->setOutputFormatting(false) before getting/setting values that will be modified and saved.  [album_reviews] (in /home/someaccount/int/wire/core/Pages.php line 1110)  

#0 [internal function]: Pages->___saveField(Object(Page), 'album_reviews', Array)
#1 /home/someaccount/int/wire/core/Wire.php(389): call_user_func_array(Array, Array)
#2 /home/someaccount/int/wire/core/Wire.php(344): Wire->runHooks('saveField', Array)
#3 /home/someaccount/int/wire/core/Page.php(1180): Wire->__call('saveField', Array)
#4 /home/someaccount/int/wire/core/Page.php(1180): Pages->saveField(Object(Page), 'album_reviews', Array)
#5 /home/someaccount/int/wire/modules/Inputfield/InputfieldPageTable/InputfieldPageTableAjax.php(110): Page->save('album_reviews')
#6 /home/someaccount/int/wire/modules/Inputfield/InputfieldPageTable/InputfieldPageTableAjax.php(64): InputfieldPageTableAjax->addItem(Object(Page), Object(Field), Object(Page)) #7 [internal function]: Inputf

Share this post


Link to post
Share on other sites

great little module @teppo!

feature suggestions:

1. revision drafting/editing

I would absolutely love a way to create a draft for a new revision to be published in the future. Basically a way to create an unpublished revision of the document with ability to go in and work on it before pushing it live.

2. revision scheduling

And a "draft" revision scheduling would be the next on wishlist.

perhaps there is something already available to enable this without too much effort?

Share this post


Link to post
Share on other sites

great little module @teppo!

Thanks! :)

feature suggestions:

1. revision drafting/editing

I would absolutely love a way to create a draft for a new revision to be published in the future. Basically a way to create an unpublished revision of the document with ability to go in and work on it before pushing it live.

2. revision scheduling

And a "draft" revision scheduling would be the next on wishlist.

perhaps there is something already available to enable this without too much effort?

To be honest this seems to be out of the scope of this module. I've been going over your suggestions a few times in my head, and while I think I could probably implement something like that to this module if I really wanted, I don't really think it's a good idea. Drafts would most likely be easier to implement using a completely different approach.

Ryan took some steps towards drafts support a while ago, so you might want to see where that goes. If Ryan implements that as a core module, I've no interest in trying to duplicate similar behaviour here. Though I haven't used any of those that much, there's also Process Preview by Nico, Page Draft Creator by Rob, and Process Page Drafts by Jan Romero; you could always give one of these a try.

Share this post


Link to post
Share on other sites

I have two issues on my installlation running PW 2.5.20:

The first is regarding the history tab: Method Page::snapshot does not exist or is not callable in this context. It seems that Page Snapshot is not being installed. Uninstalling and re-installing the module doesn't seem to help.

Also, it seems that if I create a new field (CKEditor in this case), assign it to a template, fill it with data, and then assign it to version control, it doesn't track anything. However, after re-installing the module, it worked... I may have missed something, but somewhere, somehow, the process didn't seem right.

Share this post


Link to post
Share on other sites

@Mike: Just gave this a try, and I can't seem to reproduce either issue.

At what point exactly does the "Method Page::snapshot ..." error appear? When you load the page, when you hit preview, when you try to restore earlier revision, or somewhere else? Do you see any additional details, line numbers, etc.?

So far I'm thinking that it might be some weird compatibility issue (PHP, other modules, something) or perhaps a problem with autoload order -- though I might be totally off the track here too. Would be much easier to debug if I could somehow reproduce this :)

Another issue seems to be out of my reach too. Same workflow works for me as expected. In fact, I'm having trouble understanding how this could even happen in the first place -- if the field is enabled via Version Control module settings and other enabled fields are working as expected, this sounds really weird. If you can reproduce this, could you check that module config is actually saved to database?

Other factors that come to mind are some sort of (opcode) caching, and perhaps some installation weirdness related to either the native GUI install/update tool or modules manager. Absolutely not trying to pass the blame, but from what I've heard, both of these have had some issues. Never really used either one myself, which might or might not be the reason I've never had any installation issues either.. :)

Share this post


Link to post
Share on other sites

The error appears when I view the snapshot in the history tab.

I'm going to give this a try on a fresh dev-install tomorrow. I tried it on a dev site (with pretty much no modules installed, and no ModulesManager), and had the issues.

Will also check the config-saving. I'm sure it did though, because the module page updates, and keeps my settings after a refresh.

Share this post


Link to post
Share on other sites

I have problems with VersionControl. We use VersionControl for Textfields which conflicts with VersionControl, well actually with PageSnapShot.

VersionControl is not installed, but PageSnapShot still seems to be active. When I try to delete PageSnapShot I get a Server Error, when I try to delete VersionControl I get an error that VersionControl could not be deleted. When I refresh modules I get 

  •  Failed module dependency: PageSnapshot requires VersionControl

So I am somehow in a trap. Is it possible to remove VersionControl and PageSnapShot manually?

your help ids much appreciated.

Share this post


Link to post
Share on other sites

You can delete any module manually - just use something like PHPMyAdmin and browse/search the "modules" database table and remove the row for the module. Then remove the module folder from the server and you should be good. In the case of this module, there are also some additional db tables to remove, prefixed with "version_control", but be careful to remove the ones for the version of version control that you want to remove.

Also, note that Version Control supersedes Version Control for Textfields. The latter is only still around for older versions of PW.

  • Like 4

Share this post


Link to post
Share on other sites

Hi Adrian

will do so thanks. The thing is we use VersionControl for Textfield in an extended manner. Guess we will have to change that in due time.

Thanks a lot.

Share this post


Link to post
Share on other sites

@bbeer: additionally, if you're using the latest version of Version Control for Text Fields, there's an option in the module settings to *not* remove it's database tables when the module is uninstalled. The purpose of this is to make transition to Version Control easier: it should be able to import old data from Version Control for Text Fields during installation.

I've only done limited amount of tests with this feature, though, so I can't 100% guarantee that it will work. It has worked for me so far, but making backup copies of the module's tables might make sense if you're going to try it.

  • Like 3

Share this post


Link to post
Share on other sites

Would it be possible to add FieldtypeOptions to the supported fields? Currently it's not working.

P.S. Maybe the preview shouldn't close on clicking. It's throwing an error for me, but with SystemNotifications installed one can't look at the whole error message, because the click on the number closes the preview.

Share this post


Link to post
Share on other sites

Would it be possible to add FieldtypeOptions to the supported fields? Currently it's not working.

Added. You can add fields there locally via module settings too.

P.S. Maybe the preview shouldn't close on clicking. It's throwing an error for me, but with SystemNotifications installed one can't look at the whole error message, because the click on the number closes the preview.

I'll have to think about this a bit more. Current behaviour (closing on click) is intentional, partly to prevent weird things happening when something on the previewed page is clicked, can't remember if there were other reasons too. I'm getting some errors also; I'll take a closer look at those first :)

Edit: forget that last part. Errors were a result of local changes, the feature is working as expected again. @LostKobrakai, any chance you could tell more about the error(s) you were getting?

Either way, the click-to-close thing is something I'll take into consideration, but changing this just to make system notifications work doesn't seem reasonable. Displaying admin views in preview mode is something that shouldn't ever happen, after all :)

Edited by teppo

Share this post


Link to post
Share on other sites

I decided to not use version control for this project as this happened in the try out phase. Renobird's ActivityLog was a light alternative in this case. Therefore I can't follow up on your concerns before I'm a little bit less busy. 

Share this post


Link to post
Share on other sites

Some parts of this module, mainly those related to the cleanup features and settings, have been completely rewritten recently. I've also removed some old hacks, mainly from the UI side, that were carried over from Version Control for Text Fields. Test suite has been updated accordingly, and so far I've been unable to find any further issues, at least in the core features of this module.

While some todo items still remain, I've just bumped the version number of the module to 1.0.0, and removed the "beta" status from the modules directory and from the first post in this thread. 1.0.0 should be considered the first stable release of this module, but of course if anyone spots any issues, I'd be more than happy to hear about them, either here or via GitHub.

Big thanks to anyone who's been using this module, reporting issues, etc.!

  • Like 3

Share this post


Link to post
Share on other sites

 I'm looking for a way to move all the version control data from one page to another.

use case:

pageA= a draft page

pageB= source draft was cloned from

pageB need to replace pageA at some point but it has a shallow history.

pageA has a long and wonderful page history, but its going to get replaced by pageB and will lose it all. OH NO! (pageA will be deleted)

Trying to make a function that can copy the history from one page to another, got stuck on how to write the SQL. Wondering if you can give any tips.

 
 
  private function moveRevisionHistory($sourcePageId, $destinationPageId)
    {
        $database = $this->wire('database');
        $this->message("UPDATE version_control__revisions SET pages_id=$sourcePageId WHERE pages_id=$destinationPageId");
        $query = $database->prepare("UPDATE version_control__revisions SET pages_id=$sourcePageId WHERE pages_id=$destinationPageId");
        $query->execute();
        $query->closeCursor();
    }

This just changing the pages_id seems to break things, any tips on what else I need to update to move a page? there are a hand full of id's spanning across a few tables not sure what other id fields are storing "pages_id" information that would need to be updated. Maybe I have to update the parent field as well?

Update: Simplified way talking about it.

I am trying to move a history from one page to another page.

I am updating the pages_id, but that does not seem to do it. Do I also need to update the "parent" field some how?

Example SQL:

UPDATE version_control__revisions SET pages_id=$new_page_id_of_page_with_same_template WHERE pages_id=$page_id_to_update ;

Share this post


Link to post
Share on other sites

@Neeks: that sounds pretty much right; revisions table is the only one containing references to page ID, so changing it there should be enough. I can't think of anything else you'd need to do straight away, though I haven't attempted anything like that before either, so it's entirely possible that something isn't working quite right after this (like you've mentioned above).

Could you explain what exactly breaks after this? I might be able to help you if I knew what went wrong. Currently I'm busy with other stuff, and can't really set up a test case for this myself.

Share this post


Link to post
Share on other sites

@Teppo, thanks for confirming that is how it should work...I stepped away from my code and tried it with straight SQL and with hard coded page ID's and it worked. I did try this earlier, but I must have been working with not enough sleep (I was on the wrong server writing SQL and watching for results in the admin of another...sigh...)

Share this post


Link to post
Share on other sites

I've just tried this out using 3.0.20 and have some observations. In the setup I selected one template and several fields but left defaults for everything else. I did not select any image or file fields.

It created tables, including one in which I found information about images.

In the edit page for the template I enabled in setup just about every field has little clock icon on it, many of them no selected in setup.

edit: Many of these don't have any changes yet but still show an icon (distracting for users)

The fields I did select seem to work as intended and the others do not record changes, they just have the icons.

Any ideas about how to record changes made to a PageTableExtended field (pages saved as children, different template)?

Another question, when it installed and populated tables I wondered if that process is timeout proof (batching of some kind to handle thousands of pages).

Thanks.

Share this post


Link to post
Share on other sites

Hey @teppo, just tried the module on 2.8 and i get the error Argument 1 passed to VersionControl::isEnabledTemplate() must be an instance of Template on line 897, you have any idea of why that might be?

  • Like 1

Share this post


Link to post
Share on other sites

Just for info. The error diego reported is also in 3.x now. (Wasn't there until the last PW3 update)

Share this post


Link to post
Share on other sites
On 20.06.2016 at 5:36 PM, diogo said:

Hey @teppo, just tried the module on 2.8 and i get the error Argument 1 passed to VersionControl::isEnabledTemplate() must be an instance of Template on line 897, you have any idea of why that might be?

Got the same error on PW 3.0.25

Share this post


Link to post
Share on other sites

The issue mentioned above was related to a recent change in the core class InputfieldWrapper. I've just created an issue for this to the ProcessWire repository in GitHub (https://github.com/ryancramerdesign/ProcessWire/issues/1936) and updated VersionControl to circumvent this issue. If you update the module to the latest version, it should work again.

Sorry for the inconvenience!

/cc @diogo, @ceberlin, @Zeka

  • Like 5

Share this post


Link to post
Share on other sites

Anybody using this with Spex in their templates? When I click to preview revision in the history tab listings it accesses a url like...

/processwire/setup/version-control/preview/?pages_id=38172&revision=333

That causes...

Fatal error: Call to a member function setLayout() on null in...

Just asking in case it's come up before. Thanks.

 

Share this post


Link to post
Share on other sites

Sorry, I've never actually used Spex myself, but just a quick comment: that URL triggers the executePreview() method of ProcessVersionControl.module, which in turn tries to render the given page in a specific version. It sounds like rendering the page this way is a problem, though I have no idea why. Someone with proper understanding of Spex could probably answer that one :)

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By MoritzLost
      TrelloWire
      This is a module that allows you to automatically create Trello cards for ProcessWire pages and update them when the pages are updated. This allows you to setup connected workflows. Card properties and change handling behaviour can be customized through the extensive module configuration. Every action the module performs is hookable, so you can modify when and how cards are created as much as you need to. The module also contains an API-component that makes it easy to make requests to the Trello API and build your own connected ProcessWire-Trello workflows.
      Features
      All the things the module can do for you without any custom code: Create a new card on Trello whenever a page is added or published (you can select applicable templates). Configure the target board, target list, name and description for new cards. Add default labels and checklists to the card. Update the card whenever the page is updated (optional). When the status of the card changes (published / unpublished, hidden / unhidden, trashed / restored or deleted), move the card to a different list or archive or delete it (configurable). You can extend this through hooks in many ways: Modifiy when and how cards are created. Modify the card properties (Target board & list, title, description, et c.) before they are sent to Trello. Create your own workflows by utilizing an API helper class with many convenient utility methods to access the Trello API directly. Feedback & Future Plans
      Let me know what you think! In particular:
      If you find any bugs report them here or on Github, I'll try to fix them. This module was born out of a use-case for a client project where we manage new form submissions through Trello. I'm not sure how many use-cases there are for this module. If you do use it, tell me about it! The Trello API is pretty extensive, I'll try to add some more helper methods to the TrelloWireApi class (let me know if you need anything in particular). I'll think about how the module can support different workflows that include Twig – talk to me if you have a use-case! Next steps could be a dashboard to manage pages that are connected to a Trello card, or a new section in the settings tab to manage the Trello connection. But it depends on whether there is any interest in this 🙂 Links
      Repository on Github Complete module documentation (getting started, configuration & API documentation) [Module directory pending approval] Module configuration

    • By MoritzLost
      Process Cache Control
      This module provides a simple solution to clearing all your cache layers at once, and an extensible interface to perform various cache-related actions.
      The simple motivation behind this module was that I was tired of manually clearing caches in several places after deploying a change on a live site. The basic purpose of this module is a simple Clear all caches link in the Setup menu which clears out all caches, no matter where they hide. You can customize what exactly the module does through it's configuration menu:
      Expire or delete all cache entries in the database, or selectively clear caches by namespace ($cache API) Clear the the template render cache. Clear out specific folders inside your site's cache directory (/site/assets/cache) Clear the ProCache page render cache (if your site is using ProCache) Refresh version strings for static assets to bust client-side browser caches (this requires some setup, see the full documentation for details). This is the basic function of the module. However, you can also add different cache management action through the API and execute them through the module's interface. For this advanced usage, the module provides:
      An interface to see all available cache actions and execute them. A system log and logging output on the module page to see verify what the module is doing. A CacheControlTools class with utility functions to clear out different caches. An API to add cache actions, execute them programmatically and even modify the default action. Permission management, allowing you granular control over which user roles can execute which actions. The complete documentation can be found in the module's README.
      Plans for improvements
      If there is some interest in this, I plan to expand this to a more general cache management solution. I particular, I would like to add additional cache actions. Some ideas that came to mind:
      Warming up the template render cache for publicly accessible pages. Removing all active user sessions. Let me know if you have more suggestions!
      Links
      https://github.com/MoritzLost/ProcessCacheControl ProcessCacheControl in the Module directory CHANGELOG in the repository Screenshots


    • By Macrura
      PrevNextTabs Module
      Github: https://github.com/outflux3/PrevNextTabs
      Processwire helper modules for adding page navigation within the editor.
      Overview
      This is a very simple module that adds Previous and Next links inline with the tabs on the page editor. Hovering over the tab shows the title of the previous or next page (using the admin's built in jqueryUI tooltips.)
      Usage
      This module is typically used during development where you or your editors need to traverse through pages for the purpose of proofing, flagging and/or commenting. Rather than returning to the page tree or lister, they can navigate with these links.
      Warnings
      If you are using PW version 2.6.1 or later, the system will prevent you from leaving the page if you have unsaved edits.
      For earlier versions, to avoid accidentally losing changes made to a page that might occur if a user accidentally clicks on one of these, make sure to have the Form Save Reminder module installed.
      http://modules.processwire.com/modules/prev-next-tabs/
    • By Gadgetto
      SnipWire - Snipcart integration for ProcessWire
      Snipcart is a powerful 3rd party, developer-first HTML/JavaScript shopping cart platform. SnipWire is the missing link between Snipcart and the content management framework ProcessWire.
      With SnipWire, you can quickly turn any ProcessWire site into a Snipcart online shop. The SnipWire plugin helps you to get your store up and running in no time. Detailed knowledge of the Snipcart system is not required.
      SnipWire is free and open source licensed under Mozilla Public License 2.0! A lot of work and effort has gone into development. It would be nice if you could donate an amount to support further development:

      Status update links (inside this thread) for SnipWire development
      2020-03-21 -- SnipWire 0.8.5 (beta) released! Improves SnipWires webhooks interface and provides some other fixes and additions 2020-03-03 -- SnipWire 0.8.4 (beta) released! Improves compatibility for Windows based Systems. 2020-03-01 -- SnipWire 0.8.3 (beta) released! The installation and uninstallation process has been heavily revised. 2020-02-08 -- SnipWire 0.8.2 (beta) released! Added a feature to change the cart and catalogue currency by GET, POST or SESSION param 2020-02-03 -- SnipWire 0.8.1 (beta) released! All custom classes moved into their own namespaces. 2020-02-01 -- SnipWire is now available via ProcessWire's module directory! 2020-01-30 -- SnipWire 0.8.0 (beta) first public release! (module just submitted to the PW modules directory) 2020-01-28 -- added Custom Order Fields feature (first SnipWire release version is near!) 2020-01-21 -- Snipcart v3 - when will the new cart system be implemented? 2020-01-19 -- integrated taxes provider finished (+ very flexible shipping taxes handling) 2020-01-14 -- new date range picker, discount editor, order notifiactions, order statuses, and more ... 2019-11-15 -- orders filter, order details, download + resend invoices, refunds 2019-10-18 -- list filters, REST API improvements, new docs platform, and more ... 2019-08-08 -- dashboard interface, currency selector, managing Orders, Customers and Products, Added a WireTabs, refinded caching behavior 2019-06-15 -- taxes provider, shop templates update, multiCURL implementation, and more ... 2019-06-02 -- FieldtypeSnipWireTaxSelector 2019-05-25 -- SnipWire will be free and open source Plugin Key Features
      Fast and simple store setup Full integration of the Snipcart dashboard into the ProcessWire backend (no need to leave the ProcessWire admin area) Browse and manage orders, customers, discounts, abandoned carts, and more Multi currency support Custom order and cart fields Process refunds and send customer notifications from within the ProcessWire backend Process Abandoned Carts + sending messages to customers from within the ProcessWire backend Complete Snipcart webhooks integration (all events are hookable via ProcessWire hooks) Integrated taxes provider (which is more flexible then Snipcart own provider) Useful Links
      SnipWire in PW modules directory SnipWire Docs (please note that the documentation is a work in progress) SnipWire @GitHub (feature requests and suggestions for improvement are welcome - I also accept pull requests) Snipcart Website  
      ---- INITIAL POST FROM 2019-05-25 ----
       
×
×
  • Create New...