Soma Posted April 23 Author Posted April 23 17 minutes ago, Ivan Gretsky said: I guess this one deserves v.2.0, as we got Soma 2.0 back and finally ready for action! And it is a breaking change after all) You're absolutely right. I know where you're going with this. 😄 Is it breaking? I guess not by definition. It now requires PHP>=8.0, ProcessWire>=3.0.0. So you can't update it on older install, and it's not changing any features or API calls, so it still works with same code when you update. v2.0 would mean it has new features or breaking API changes. This is just a "maintenance" update.
Ivan Gretsky Posted April 23 Posted April 23 I have googled and ai-ed about it... We can call that a breaking change or not to our liking. Or holywar about it) My point was if someone downloads the new code to a site with PHP 7 the site will actually break 😎 But 2.0 is better anyway for marketing purpose and community spirit IMHO as it symbolizes the new era for the module) 1
tires Posted Tuesday at 09:17 PM Posted Tuesday at 09:17 PM I solved this warning (PHP 8.4, ProcessWire 3.0.255, MarkupSimpleNavigation 1.3.7😞 Warning: Undefined array key 1 in /homepages/site/assets/cache/FileCompiler/site/modules/MarkupSimpleNavigation/MarkupSimpleNavigation.module on line 313 With this change in MarkupSimpleNavigation.module on line 312 - 316: if($this->iteration == 1) { $out .= "\n" . ($this->outer_tpl[1] ?? ''); } else if(count($children)) { $out .= "\n" . ($this->inner_tpl[1] ?? '') . "\n"; }
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now