Jump to content
teppo

Version Control

Recommended Posts

Sorry for the delay, folks – been a bit busy lately, but I'm now slowly trying to work my way through your reports :)

On 26.3.2018 at 4:05 AM, Robin S said:

Another minor UI thing: the new UI can look a bit funny with AdminThemeDefault and AdminThemeReno because opening the history doesn't trigger the core column sizing JS, so the height of fields in the same row isn't updated to match. It's not a big deal, and the issue doesn't occur for AdminThemeUikit so maybe not worth doing anything about.

...

If there is a column to the right of an open history container then the history gets overlapped by 1 pixel on the right edge. Again, not a big deal, but maybe these things could be avoided by using absolute positioning for the history container so it appears in a layer over the Page Edit interface and doesn't expand the inputfield column.

Using the core panel UI could be a nice alternative too, but I don't know how easy it is to inject HTML directly into this. I think it's only set up to handle iframes (which if so is a bit of a shame because it reduces the range of things the panel can be used for).

Version 2.1.6 includes a couple of fixes related to this one:

  • Revision tables are now vertically scrollable. This isn't necessarily a perfect solution, but at least the UI is now usable even if the inputfield itself is very narrow. I've also added some UI hints to signal if/when scrolling is expected.
  • InputfieldColumnWidths() is triggered after showing/hiding a revision table, so the first thing mentioned here should be fixed now (hopefully).

I couldn't reproduce the 1px overlap. Might've already fixed that one, or perhaps I just wasn't able to recreate the setup needed, but I'll get back to that if it's still an issue. The absolute positioning thing I kind of covered in my previous post (I'd prefer to avoid that), and the panel thing is exactly as mentioned above: they seem to require an URL, which is then opened in an iframe, and that would be a bit problematic (to say the least) for my use case here.

  • Like 1

Share this post


Link to post
Share on other sites

Hey @teppo - I haven't used this module in a long time, but I am playing around with v2.0 at the moment and I see that there is no repeater/repeatermatrix support at all. I understand the old/master version does have some repeater support though.

Are you planning on support? Any possible timeframe?

Thanks!

Share this post


Link to post
Share on other sites
On 4/19/2018 at 5:35 PM, adrian said:

Hey @teppo - I haven't used this module in a long time, but I am playing around with v2.0 at the moment and I see that there is no repeater/repeatermatrix support at all. I understand the old/master version does have some repeater support though.

 Are you planning on support? Any possible timeframe?

Thanks!

@teppo Any news here?

I would very much like to use the module with a repeater on our intranet page 😉 

Share this post


Link to post
Share on other sites

Hey @adrian and @zoeck,

Sorry for not responding to this – I've been kind of tied elsewhere, and totally forgot this question. Bad excuse for bad communication, I know 🙂

I'll have to dig into this. I didn't intentionally strip any features from 2.0, but it's entirely possible that something in Admin Theme Uikit (assuming that you're using that) or the updates I did for 2.0 did indeed disable Repeater Matrix support. I had to put the development of this module on hold since there were some difficult (or at least time-consuming) UI issues to tackle, and I just didn't have the bandwidth for that.

I'll do my best to try to find some time soon(ish). Sorry, but can't really promise any kind of timeframe right now.

  • Like 2
  • Thanks 1

Share this post


Link to post
Share on other sites

Hi @teppo

We have difficulty using your module with the TemplateEngineFactory and the attribution of $view.

$view = wire("view");
$code = .....;
$view->set('myVariable',$code);

$view is NULL when trying to get a preview, so we get an error.

Any idea how to resolve this?

 

PS. This is the TemplateEngineFactory module that prevents previewing pages under /admin.

Share this post


Link to post
Share on other sites

Hi @Guy Verville.

I took a quick look at TemplateEngineFactory.module.php, and this is what I've found out so far:

Without modifying TemplateEngineFactory itself, I currently see two options: reworking the preview feature to do something else (though not quite sure what.. perhaps it could define a custom template or something like that), or trying to overwrite current page (to fix the $this->wire('page') reference in TemplateEngineFactory.module.)

Latter option sounds more feasible, yet I'd have to test this properly to make sure. I don't have a proper setup for that available right now, but I'll see if I can get to that sometime soon. That being said, if you could provide me a stripped down site profile to test this with, that'd make things easier for me 🙂

Share this post


Link to post
Share on other sites

Hi @teppo, I'm using version 1.2.9 from the modules library and having trouble with the UI: for fields that are on the left of the screen, the popup "compare" is off-screen and unusable (using UIkit). It looks like version 2 has a better UI. Is that going to make it to the 'official' library some time soon or do I need to install it from GitHub?

If I do need to install it "manually", how do I do this without losing my settings and history.

Thanks.

Share this post


Link to post
Share on other sites

@Teppo

Great Module! Are there more examples for an API call of your module? I want to track all changes and list them on a special site. Only changed pages/fields should be listed. Any ideas?

foreach($page->versionControlRevisions() as $key => $alue) {
	$page->snapshot(null,$key);
	echo $page->name;
}

How can I compare fields in the version with the current version?

 

Share this post


Link to post
Share on other sites

If anyone was wondering, this module seems to work fine with the CroppableImage3 fieldtype.

  • Like 1

Share this post


Link to post
Share on other sites

Hi all

in History, when editing a ProField Textareas, it only adds the name of the Textarea (Prodspecs) that was altert, but not the Fieldname (Voltage) inside the Textarea that was altert. That does not really help. It would be great if it would also name the altered Field name. 

We then changed a Field (Voltage) and saved it, content was added. then clicked restore version on a previous version of that Textarea (Prodspecs), what deleted all entries inside Textarea (Prodspecs) and not the Field (Voltage).

Don't really know why this happens, but a hint on how to fix that, or even having a look at the module itself would be of great help!

Share this post


Link to post
Share on other sites

Hey @bbeer,

There's no such module as "History" (as far as I'm aware), so are you perhaps talking about VersionControl – or something else entirely? Or is this a question about some built-in feature in ProFields Textareas? 🙂

The Modules/Plugins area of the forum is for dedicated module support threads only. If this is a support request for ProFields Textareas, please post the the VIP support area instead – and if it's related to another module, you should post your question directly to the support board of said module. If you're not sure where that might be, check the modules directory entry for the module in question and you'll find a link to the support board from the sidebar (on the left side).

If you tell us which module you're talking about, a moderator can move or merge this thread to the right place.

  • Like 1

Share this post


Link to post
Share on other sites

Hi Teppo

I am not talking about a module History. If I am not mistaken, VersionControl puts a table at the end of the page, see screenshot, where it adds the revision number, the author, Changes, Timestamp and Comment. is that not correct?

This entries we also found in the database, in the VersionControl Tables.

 

1834311941_ScreenShot2019-07-02025818PM.thumb.png.1bbff6f9e9f0c1aaa46dfdc844c747aa.png

Share this post


Link to post
Share on other sites

Since this is indeed related to the VersionControl module, I'll merge this thread to the VersionControl support thread 🙂

As the author of said module I should add that VersionControl has not been tested with the ProFields Table Textareas plugin, and honestly I'm not surprised if these two don't play nicely together out of the box. I will take a closer look at this, but it may take a while, so in the meantime I've opened a feature request for this at GitHub: https://github.com/teppokoivula/VersionControl/issues/23.

Quote

Don't really know why this happens, but a hint on how to fix that, or even having a look at the module itself would be of great help!

You could take a closer look at the database (particularly the version_control__data table) in case your data is still stored there. Other than that I can't really say for sure – it's possible that the data was not saved correctly, which would mean that it's no longer available.

I'm not quite sure what you mean by "having a look at the module itself" 🙂

Share this post


Link to post
Share on other sites

Hi @teppo,

first of all, thanks for this great module! But, can I have a question?
I have got a request to show the page changes in a merged list.. if it's possible. My idea is to use the official PW log to collect these changes. Is there any easy solution to implement a simple log save when your module also made a save / insert revision? For example:

$log->save("history", "The body field changed.");

perhaps with a link to the current revision, page id, or etc..

I have searched, but not found any hook which could be useful for this.

Thanks!

Tamas Gyorvary

Share this post


Link to post
Share on other sites

Hey @tthom_pw

Looks like this isn't currently possible. I'm working on version 2.0 of the module, which will include quite a few changes in fact, and I'd be happy to implement this once that's ready to be released. Sadly I can't give you an exact timeframe – probably "sometime within next few months", but that's just about it.

In the meantime you might find other modules more suitable for this purpose. For an example my ProcessChangelog creates a relatively easy-to-follow log of events – it doesn't integrate with VersionControl, so there's no way to link changelog with revision numbers etc. but if might be a more sensible way to get an idea of what changed and when.

Hope this helps a bit.

 

Share this post


Link to post
Share on other sites

Thanks @teppo!

I haven't noticed that ProcessChangelog is exist, not bad at all! Great job again. 
Yes, that would be great to be connected with VersionControl, but perhaps will be enough for this time.
Or.. I simply create a link into the ChangeLog list row with Javascript to link directly to right History page (with #VersionControlHistory hash tag). And than, it will be a simple connection between the two modules. Not 100% solution of course.. 

After all, thanks for the quick info and thanks for the modules!

Share this post


Link to post
Share on other sites

Hi @teppo

are you considering adding support for ProFieldTextArea to Version 2? Right now we can only see that something inside the whole Field changed, but not exactly what.

We would really appreciate this feature. We could also consider funding this change!

Share this post


Link to post
Share on other sites

Hey @teppo I think there's an issue with VersionControl on PW v 3.0.148. When editing a page that the module runs on or trying to change module settings I get the following error:

Argument 1 passed to ProcessWire\Modules::setModuleConfigData() must implement interface ProcessWire\Module, string given

Any thoughts? Happy New Year

Share this post


Link to post
Share on other sites

Hey @alexmercenary! Which version of VersionControl are you using?

I can see where the error is coming, and I don't think that line of code should've worked in years. Committed a fix, but the modules directory entry is not updated yet, so it may take a while for this to show up in the built-in module installer (seems that I've lost my password for this module and can't update it manually in the directory, I'll have to guess that first...)

Not sure why this popped up only now, though – so hopefully I didn't break anything with the fix 😅

  • Thanks 1

Share this post


Link to post
Share on other sites

@teppo It's version 1.2.12

I don't know either. I've literally logged in today updated ProcessWire and started doing a bit of work. Only noticed when I went to edit a page in the backend.

Thanks for the super quick fix though! 🙌I'll let ya know how I get on or if I see if anything has broken, haha.

  • Like 1

Share this post


Link to post
Share on other sites

I had upgraded to 3.0.148 successfully on my dev machine and used it without problems for a couple of weeks. So I decided to upgrade the production environment. The front end works OK and so does some of the back end. However, on attempting to edit certain pages in the back end, I get the following error message:

Fatal error: Uncaught TypeError: Argument 1 passed to ProcessWire\Modules::setModuleConfigData() must implement interface ProcessWire\Module, string given, called in /home/highmoss/public_html/processwire/wire/core/Wire.php on line 383 and defined in /home/highmoss/public_html/processwire/wire/core/Modules.php:3685 Stack trace: #0 /home/highmoss/public_html/processwire/wire/core/Wire.php(383): ProcessWire\Modules->setModuleConfigData('ProcessVersionC...') #1 /home/highmoss/public_html/processwire/wire/core/WireHooks.php(823): ProcessWire\Wire->_callMethod('setModuleConfig...', Array) #2 /home/highmoss/public_html/processwire/wire/core/Wire.php(450): ProcessWire\WireHooks->runHooks(Object(ProcessWire\Modules), 'setModuleConfig...', Array) #3 /home/highmoss/public_html/processwire/site-ncog/modules/VersionControl-2.0/ProcessVersionControl.module(75): ProcessWire\Wire->__call('setModuleConfig...', Array) #4 /home/highmoss/public_html/processwire/wire/core/Modules.php(553): ProcessWire\ProcessVersionControl->__construct() #5 in /home/highmoss/public_html/processwire/wire/core/Modules.php on line 3685

I refreshed the modules and cleared the FileCompiler, but it persists. Any ideas?

EDIT: Uninstalled version control and it works OK

Share this post


Link to post
Share on other sites

I'm pretty sure I've also fixed this issue in the 2.0 branch, so updating from there should've fixed this as well 🙂

  • Like 1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By Macrura
      PrevNextTabs Module
      Github: https://github.com/outflux3/PrevNextTabs
      Processwire helper modules for adding page navigation within the editor.
      Overview
      This is a very simple module that adds Previous and Next links inline with the tabs on the page editor. Hovering over the tab shows the title of the previous or next page (using the admin's built in jqueryUI tooltips.)
      Usage
      This module is typically used during development where you or your editors need to traverse through pages for the purpose of proofing, flagging and/or commenting. Rather than returning to the page tree or lister, they can navigate with these links.
      Warnings
      If you are using PW version 2.6.1 or later, the system will prevent you from leaving the page if you have unsaved edits.
      For earlier versions, to avoid accidentally losing changes made to a page that might occur if a user accidentally clicks on one of these, make sure to have the Form Save Reminder module installed.
      http://modules.processwire.com/modules/prev-next-tabs/
    • By Gadgetto
      SnipWire - Snipcart integration for ProcessWire
      Snipcart is a powerful 3rd party, developer-first HTML/JavaScript shopping cart platform. SnipWire is the missing link between Snipcart and the content management framework ProcessWire.
      With SnipWire, you can quickly turn any ProcessWire site into a Snipcart online shop. The SnipWire plugin helps you to get your store up and running in no time. Detailed knowledge of the Snipcart system is not required.
      SnipWire is free and open source licensed under Mozilla Public License 2.0! A lot of work and effort has gone into development. It would be nice if you could donate an amount to support further development:

      Status update links (inside this thread) for SnipWire development
      2020-03-21 -- SnipWire 0.8.5 (beta) released! Improves SnipWires webhooks interface and provides some other fixes and additions 2020-03-03 -- SnipWire 0.8.4 (beta) released! Improves compatibility for Windows based Systems. 2020-03-01 -- SnipWire 0.8.3 (beta) released! The installation and uninstallation process has been heavily revised. 2020-02-08 -- SnipWire 0.8.2 (beta) released! Added a feature to change the cart and catalogue currency by GET, POST or SESSION param 2020-02-03 -- SnipWire 0.8.1 (beta) released! All custom classes moved into their own namespaces. 2020-02-01 -- SnipWire is now available via ProcessWire's module directory! 2020-01-30 -- SnipWire 0.8.0 (beta) first public release! (module just submitted to the PW modules directory) 2020-01-28 -- added Custom Order Fields feature (first SnipWire release version is near!) 2020-01-21 -- Snipcart v3 - when will the new cart system be implemented? 2020-01-19 -- integrated taxes provider finished (+ very flexible shipping taxes handling) 2020-01-14 -- new date range picker, discount editor, order notifiactions, order statuses, and more ... 2019-11-15 -- orders filter, order details, download + resend invoices, refunds 2019-10-18 -- list filters, REST API improvements, new docs platform, and more ... 2019-08-08 -- dashboard interface, currency selector, managing Orders, Customers and Products, Added a WireTabs, refinded caching behavior 2019-06-15 -- taxes provider, shop templates update, multiCURL implementation, and more ... 2019-06-02 -- FieldtypeSnipWireTaxSelector 2019-05-25 -- SnipWire will be free and open source Plugin Key Features
      Fast and simple store setup Full integration of the Snipcart dashboard into the ProcessWire backend (no need to leave the ProcessWire admin area) Browse and manage orders, customers, discounts, abandoned carts, and more Multi currency support Custom order and cart fields Process refunds and send customer notifications from within the ProcessWire backend Process Abandoned Carts + sending messages to customers from within the ProcessWire backend Complete Snipcart webhooks integration (all events are hookable via ProcessWire hooks) Integrated taxes provider (which is more flexible then Snipcart own provider) Useful Links
      SnipWire in PW modules directory SnipWire Docs (please note that the documentation is a work in progress) SnipWire @GitHub (feature requests and suggestions for improvement are welcome - I also accept pull requests) Snipcart Website  
      ---- INITIAL POST FROM 2019-05-25 ----
       
    • By horst
      Croppable Image 3
      for PW 3.0.20+
      Module Version 1.2.0
      Sponsored by http://dreikon.de/, many thanks Timo & Niko!
      You can get it in the modules directory!
      Please refer to the readme on github for instructions.
       
      - + - + - + - + - + - + - + - + - + - NEWS - 2020/03/19 - + - + - + - + - + - + - + - + - + - 
      There is a new Version in the pipe, that supports WebP too: 
       
      - + - + - + - + - + - + - + - + - + - NEWS - 2020/03/19 - + - + - + - + - + - + - + - + - + - 
       
       
      -------------------------------------------------------------------------
       
      Updating from prior versions:
       
      Updating from Croppable Image 3 with versions prior to 1.1.7, please do this as a one time step:
      In the PW Admin, go to side -> modules -> new, use "install via ClassName" and use CroppableImage3 for the Module Class Name. This will update your existing CroppableImage3 module sub directory, even if it is called a new install. After that, the module will be recogniced by the PW updater module, what makes it a lot easier on further updates.
      -------------------------------------------------------------------------
       
      For updating from the legacy Thumbnail / CropImage to CroppableImage3 read on here.
       
      -------------------------------------------------------------------------
       
    • By Robin S
      Inspired by a recent question.
      Image Crop Ratios
      Allows preset aspect ratios to be defined per image field for the ProcessWire image crop tool.
      The module adds a select dropdown to the crop tool. Choose an aspect ratio and the crop area will be fixed to that ratio.
      Screencast

      Installation
      Install the Image Crop Ratios module.
      Configuration
      Default aspect ratios for all image fields can be defined in the module config. Aspect ratios for specific image fields can be defined on the Input tab of the field settings. You can override the ratio settings in template context if needed. Insert a hyphen as the first item in the ratio settings unless you want to force a ratio to be applied to the crop tool. The hyphen represents a blank option that allows a free crop area to be drawn. Usage
      Click the "Crop" link on the details view of an image thumbnail. Click the "Crop" icon at the top of the editor window. Choose an option from the "Ratio" select dropdown.  
      https://github.com/Toutouwai/ImageCropRatios
      https://modules.processwire.com/modules/image-crop-ratios/
×
×
  • Create New...