mr-fan Posted August 26, 2015 Posted August 26, 2015 You at the wrong place. explanation see line: https://github.com/NicoKnoll/MarkupSEO/blob/master/MarkupSEO.module#L417 you've changed the fieldname in the module settings page. change the <meta> tag itself could be done in this line: https://github.com/NicoKnoll/MarkupSEO/blob/master/MarkupSEO.module#L340 for real dublin core metas this module should get an option for this with a checkbox - to add the DC. tag to every meta tag and add additional tag like content type or created date.... could be done with a checkbox in the settings and an additional if statement to get those DC.tags. May Nico find some time, if i've got more time on my hands i would proud to contribute to this awesome module...but my calendar says Best regards mr-fan 1
Macrura Posted August 26, 2015 Posted August 26, 2015 btw in the new dublin core spec you don't need to capitalize DC
kazu Posted August 26, 2015 Posted August 26, 2015 You at the wrong place. change the <meta> tag itself could be done in this line:https://github.com/NicoKnoll/MarkupSEO/blob/master/MarkupSEO.module#L340 If I change $rendered .= '<meta name="'.$name.'" content="'.$content.'">'.PHP_EOL; also other tags will be affected, for example keywords and others?
kazu Posted August 27, 2015 Posted August 27, 2015 Therefore it will not help for adapting a single Tab. But, the single entry (description) <meta name="description" is defined somewhere. Exist to the module additional files, which may not be in the module directory? Somewhere, the entry must be ...
mr-fan Posted August 27, 2015 Posted August 27, 2015 Alternative to changing the module itself is to render the stuff yourself...so you've full control over the output meta tags like Nico wrotes: $page->seo // includes all the default values mixed with the page related seo data // e.g.: $page->seo->title $page->seo->keywords // for rendering all fields with the module $page->seo->render //example with DC and own markup echo '<meta name="DC.descritption">'.$page->seo->description.'/>'; so the tags are up to you in your frontend template. May the best solution if you don't wanna change and maintain module files. regards mr-fan 1
gebeer Posted September 8, 2015 Posted September 8, 2015 First off, thank you for this great module. I have installed the latest version (0.8.2) and assigned one template (workshop) I'm doing import of pages from a Joomla site and want to set values for SEO fields through the API. But I get this message when trying to save data to SEO fields: "Notice: Indirect modification of overloaded property Page::$seo has no effect in /var/www/qgtpw/site/templates/convert.php on line 225". My code $data = csv_to_array('inc/joomla_workshops.csv'); foreach($data as $csv) { $jid = $csv['id']; $title = $csv["title"]; $description = $csv["metadesc"]; $keywords = $csv["metakey"]; $workshop = $pages->get("template=workshop, jid={$jid}, include=all"); if ($workshop->id) { $workshop->of(false); var_dump($workshop->seo); if ($title != "") $workshop->seo->title = $title; if ($description != "") $workshop->seo->description = $description; if ($keywords != "") $workshop->seo->keywords = $keywords; $workshop->save(); $wokshop->of(true); echo "$jid<br>"; } } The var_dump gives "null"; How would I go about saving data to the SEO fields via the API?
mr-fan Posted September 8, 2015 Posted September 8, 2015 Gebeer you could try to set them - i do that with a custom script to get seo fields prefilled on publishing if users don't fill seo fields manually. example: //set seo_title on publishing $page->set ('seo_keywords', $default_keywords); //set seo_description on publishing $page->set ('seo_description', $default_desc); ... set should work for you. best regards mr-fan 4
gebeer Posted September 8, 2015 Posted September 8, 2015 @mr-fan Thanks a lot. This is working perfectly 1
OviS Posted September 10, 2015 Posted September 10, 2015 @ceberlin: Select a custom field with a fallback to title? You can use multiple smart titles. So the first one will be used if filled (https://github.com/NicoKnoll/MarkupSEO/blob/master/MarkupSEO.module#L182-L187). If not the second one is used and so on. "Smart title" will be used in case you leave the "Title" field in the SEO tab empty. I might be missing the obvious here but I can't find anywhere to configure the smartfields as shown in that image. I am using the latest version of the plugin, and the config page doesn't have anything for smartfields. Thanks for the great work!
tpr Posted September 10, 2015 Posted September 10, 2015 Uncheck "Use parent's values if empty?" and a whole new world appears. 1
OviS Posted September 11, 2015 Posted September 11, 2015 Uncheck "Use parent's values if empty?" and a whole new world appears. Wow, I thought exactly the opposite, that I had to keep that option checked! Thanks! 1
Florian Grüttner Posted September 23, 2015 Posted September 23, 2015 I really like your Module. But it worked only about 15minutes for me. After inserting Text to several pages I got: Notice: Undefined index: canonical in /site/modules/MarkupSEO/MarkupSEO.module on line 250Notice: Undefined index: title in /site/modules/MarkupSEO/MarkupSEO.module on line 266 Notice: Undefined index: description in /site/modules/MarkupSEO/MarkupSEO.module on line 268Notice: Undefined index: image in /site/modules/MarkupSEO/MarkupSEO.module on line 270Notice: Undefined index: title in /site/modules/MarkupSEO/MarkupSEO.module on line 277Notice: Undefined index: description in /site/modules/MarkupSEO/MarkupSEO.module on line 279Notice: Undefined index: image in /site/modules/MarkupSEO/MarkupSEO.module on line 280Notice: Undefined index: custom in /site/modules/MarkupSEO/MarkupSEO.module on line 28 I have no idea whats the problem. Also deleting an reinstall of the Module doesnt solves the problem. All fields are recreated and empty. Still throws that errors. I am using the latest Version 0.8.2.
adrian Posted September 23, 2015 Posted September 23, 2015 Those php notices shouldn't prevent the module from working. Admittedly they should be fixed, but are you sure that the module is no longer working? If you disable debug mode you shouldn't see the errors.
Florian Grüttner Posted September 24, 2015 Posted September 24, 2015 All SEO Tabs disappeared from Pages and there is no output anymore. Also all my inputs Ive done are not accessible anymore. I can reconfigure everything and manually add all fields to each template and place them in a own SEO-Tab. But this would be nearly the same way, as I created my own SEO-Tabs in the past. Means there are no advantages of the module anymore. Because I have to trust in the abilities of this module. If its not working properly my project would be harmed. So better I take the safe way. Would be great if there is any solution. Cause the features of this module are really exciting and would help a lot.
FrancisChung Posted October 30, 2015 Posted October 30, 2015 Just a small feature request. Any chance of added an option to do Enhanced Link Attribution? All it requires is an additional line of code to the Google Analytics code that is already generated (highlighted in Red) I will probably modify my local MarkupSEO module code for now but it would be great to see it as part of the official code branch. P/S I'm a fan of the module. Would happy to buy some beers to show my appreciation. ga('create', 'UA-XXXX-X');ga('require', 'linkid', 'linkid.js');ga('send', 'pageview'); 1
FrancisChung Posted November 20, 2015 Posted November 20, 2015 I've just noticed that removing the GA Code from MarkupSEO and saving the settings results in all the SEO data previously entered being deleted. Is this by design, or more likely a bug? Luckily, we bulk upload our SEO settings via Spreadsheet/PW Custom code so it was easy to restore the values. I've had several of these messages logged for the different SEO fields "Deleted field "seo_tab_END" data in 0 row(s) from 0 page(s). [page-by-page]"
Olli Posted November 26, 2015 Posted November 26, 2015 I really like the ease of use of this module. I'm using it on a page which I'm working on and seems to be pretty good for google searches. But I have one issue... I would like to have the page I'm working on in google searches listed as this: Main site child page 1 child page 2 child page 3 child page 4 child page 5 child page 6 child page 7 child page 8 as only one google search listing. Right now I get every page separately in the google search, making it look little messy. This might not be due to this plugin but google settings but I'm not sure. Anybody knows what I should work on to get it working? 1
Nico Knoll Posted November 26, 2015 Author Posted November 26, 2015 @Olli: It's explained here: https://support.google.com/webmasters/answer/47334?hl=en So I guess the module has no real impact on that. But try to add a sitemap and with a bit of luck Google will find fitting sitelinks Just a small feature request. Any chance of added an option to do Enhanced Link Attribution? All it requires is an additional line of code to the Google Analytics code that is already generated (highlighted in Red) I will probably modify my local MarkupSEO module code for now but it would be great to see it as part of the official code branch. P/S I'm a fan of the module. Would happy to buy some beers to show my appreciation. ga('create', 'UA-XXXX-X');ga('require', 'linkid', 'linkid.js');ga('send', 'pageview'); Hey, I'm glad that you like that module. Could you add any bugs directly on GitHub? (And I'm always happy if someone is buying me beer (There is a link under this text - just saying ))
Jason Huck Posted December 5, 2015 Posted December 5, 2015 I may have missed this, but is there any way to override a value at runtime, prior to calling ->render? I'd like to programmatically insert a page-specific value for og:image, something like: $page->seo->{"og:image"} = '/path/to/image'; $page->seo->render; Any way to do something like that? Thanks! Jason
Jason Huck Posted December 5, 2015 Posted December 5, 2015 Is it possible to reassign field values from within a template? Not save back to the database, just override in memory. I'm using the MarkupSEO module, and want to use its built-in ->render function, but I want to tweak some values first, e.g.: $page->seo->{"og:image"} = '/path/to/image.png'; $page->seo->render; Possible?
LostKobrakai Posted December 5, 2015 Posted December 5, 2015 I'd say it's not without modifying the module. $page->seo is an raw data object, where render is not actually a function, but already the prerendered result of the rendering logic.
kongondo Posted December 5, 2015 Posted December 5, 2015 Mod Note: @Jason, Please try not to double post. You asked the same question earlier today . Merging this thread with MarkupSEO's support forum since your question is really about that module. 1
Jason Huck Posted December 5, 2015 Posted December 5, 2015 Sorry for the cross-post, wasn't sure if my question was module-specific or more of a general api question. Sounds like the answer is "no", since ->render is pre-rendered. Thanks!
kongondo Posted December 5, 2015 Posted December 5, 2015 (edited) No worries. As for general API, yes you can override (and even create methods and properties) on the fly at runtime since PW is an OOP application. So (and I assume you probably know this) you can do: // where such a field does not exist (i.e. this page has no summary field but we create one at rt) $page->summary = 'My nice summary'; // and you can also do, replacing the saved page title at rt (but not saving it) $page->title = 'My replacement Title'; Edited December 5, 2015 by kongondo
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now