SiNNuT Posted October 24, 2014 Share Posted October 24, 2014 I don't have any problems running HannaCode on my 2.5.5 dev environment. Have you made sure that Hanna Code Text Formatter is applied to the field(s) that you put a Hanna on? Link to comment Share on other sites More sharing options...
Peter Knight Posted October 24, 2014 Share Posted October 24, 2014 Hi SiNNutYes, I had. Although for some reason it didn't appear to be saving and that could have been my problem. I logged out, cleared the cache and it's working now. Link to comment Share on other sites More sharing options...
Joss Posted November 15, 2014 Share Posted November 15, 2014 Separate Listing Permission Not sure if this would be totally useful or not to everyone, but it might be nice to have a separate permission for just viewing a list of hanna codes for authors. No editing, or viewing of code, but just a list. To make this work properly, they would also need descriptions, I would think. This is really just so that contributors to the site know what codes are available and where they can be used. 1 Link to comment Share on other sites More sharing options...
opalepatrick Posted November 17, 2014 Share Posted November 17, 2014 (edited) I have installed and re-installedTextFormatterHannaCode but cannot see the item under setup. It appears fine as an option in a body field for instance and indicates it is installed correctly. For info, I have just upgraded this install from 2.3 to 2.5 but have not seen any other problems. Any help appreciated. Edited November 17, 2014 by kongondo Moved Topic: Hanna Code has its own forum Link to comment Share on other sites More sharing options...
teppo Posted November 17, 2014 Share Posted November 17, 2014 @Joss: not too far-fetched, but you could always try the Hanna Code Helper module too. Not trying to advertise it or anything, but I feel it's pretty convenient to see the tags right in the context where they're actually needed. Slightly longer description would be great thing to have, either way 2 Link to comment Share on other sites More sharing options...
Joss Posted November 17, 2014 Share Posted November 17, 2014 Actually I had forgotten about that till after I wrote this and it does actually address a lot of the issues. Though, it is one of those odd things that sometimes it is nice to look at a list. Link to comment Share on other sites More sharing options...
opalepatrick Posted November 17, 2014 Share Posted November 17, 2014 Somehow got things working by adding the hanna code module? Maybe I ought to read things a bit more carefully? Baffled but happy. Link to comment Share on other sites More sharing options...
opalepatrick Posted November 19, 2014 Share Posted November 19, 2014 I have a Hanna Code question and I am putting it here as a previous post was moved from its own thread. I can't see having a great big thread about a particular module being helpful to anyone, other than as a general module development conversation, and also can't see it being seen? I could understand if it was a separate forum, but not an 11 page thread. Anyway, I am using hanna code for an item in a body field (for a blog post) However, when I publish excerpts of these posts on a summary, I dont want the hanna code to show. I tried to use a bit of php to refer to the template for the individual post if($page->template == 'works'){ echo "<div class='circle floatleft'><h2><i class='fa fa-line-chart'></i></h2></div>"; } but as I am calling the same pages in the summary page $articles = $pages->get("/blog/, limit=10")->children; and looping, then calling $article->body, I think the template of the summary page is ignored. I think the template that the hanna code snippet applies is still the one for the individual post. So, any ideas how I can code out the hanna code snippet on the summary page? Hope that makes sense. Thanks for taking a look. Link to comment Share on other sites More sharing options...
kongondo Posted November 19, 2014 Share Posted November 19, 2014 I have a Hanna Code question and I am putting it here as a previous post was moved from its own thread. I can't see having a great big thread about a particular module being helpful to anyone, other than as a general module development conversation, and also can't see it being seen? I could understand if it was a separate forum, but not an 11 page thread. Why do you think the conversation wouldn't be seen? Module developers follow the support forums of their modules and are notified of new posts If we were to open new topics just because some threads were 'long' things could become chaotic and confusing very quickly. This forum is Hanna Code's support forum. You have raised a Hanna Code support question hence it should be here . To further clarify...(not just for you): Each module has (should have) its own support forum. these are found here: https://processwire.com/talk/forum/4-modulesplugins/ If one wants to discuss general module development they should post them in this sub-forum: https://processwire.com/talk/forum/19-moduleplugin-development/ I hope these clarify things. 2 Link to comment Share on other sites More sharing options...
opalepatrick Posted November 20, 2014 Share Posted November 20, 2014 also can't see it being seen yup, wrong terminology, what I meant is that it may be lost in a diverse thread. And I notice you call it a sub-forum, but to me this looks like a big thread? If we were to open new topics just because some threads were 'long' things could become chaotic and confusing very quickly. I don't see why a proper sub-forum with multiple threads would be chaotic. It would work just like any other on-topic forum? Couldn't we just as easily say that having a bunch of different points and questions in a single thread is confusing as well? Might seem like I am carping. I am not honest - just wondering about the efficacy of threads like this. Always get great friendly support here so don't think I am being churlish. Anyway.... hopefully someone can help out re the post concerned Link to comment Share on other sites More sharing options...
kongondo Posted November 20, 2014 Share Posted November 20, 2014 Not sure you have seen this in Hanna Code's PHP usage notes? Please see the Javascript and PHP usage notes on the Hanna code entry screen. The $page API variable available to your Hanna code represents the page where the Hanna code exists. It is possible for this to be different from wire('page'), which represents the page that originated the request. Hence $page->template refers to your blog post template whereas wire('page')->template refers to your summary page template. 1 Link to comment Share on other sites More sharing options...
opalepatrick Posted November 20, 2014 Share Posted November 20, 2014 Thanks kongondo, did read but didn't connect that at all. That worked perfectly applied to the hanna code. Link to comment Share on other sites More sharing options...
Joss Posted November 20, 2014 Share Posted November 20, 2014 That has caught me out a few time ... its fine knowing all this stuff, but I am having a struggle actually remembering at the moment when it is most useful! Ouch! Link to comment Share on other sites More sharing options...
hwmaier Posted December 1, 2014 Share Posted December 1, 2014 Hi all, I found a small glitch in HannCode version 1.9. This only affects Hanna Code tag names which contain a . (dot) character and at the same time contain attributes. For example: [[admin.email]] or [[admin_email recaptcha="true"]] both work as expected and get processed and replaced. But this [[admin.email recaptcha="true"]] does not. In file TextformatterHannaCode.module change line 242 from if(preg_match('!^([-_a-z0-9]+)([\s,]|$)!i', $expression, $matches)) { to: if(preg_match('!^([\.-_a-z0-9]+)([\s,]|$)!i', $expression, $matches)) { solves the issue. What is the best way to submit bugfixes/patches? Should I fork this on github and post a pull request? 1 Link to comment Share on other sites More sharing options...
kongondo Posted December 1, 2014 Share Posted December 1, 2014 What is the best way to submit bugfixes/patches? Should I fork this on github and post a pull request? Yes. But it would also be worthwhile to first check if a similar issue has not yet been submitted. Welcome to the forums too Link to comment Share on other sites More sharing options...
hwmaier Posted January 22, 2015 Share Posted January 22, 2015 Recursive Hanna Code Hanna Code currently (version 1.9) does not support recursive Hanna tags, for example one Hanna Code tag is rendereing a partial which again contains another Hanna Code tag. As I needed that requirement I made changes to support recursion to my private repository. Is that something useful to the wider community? If yes I could issue a pull request. 1 Link to comment Share on other sites More sharing options...
mr-fan Posted January 22, 2015 Share Posted January 22, 2015 Recursive Hanna Code Is that something useful to the wider community? If yes I could issue a pull request. let's say yes we can recursive Link to comment Share on other sites More sharing options...
hwmaier Posted January 22, 2015 Share Posted January 22, 2015 let's say yes we can recursive A pull request has been issued, let's see whether Ryan adopts the change. This would likely also fix the issue reported here: https://github.com/ryancramerdesign/ProcessHannaCode/issues/8 1 Link to comment Share on other sites More sharing options...
Peter Knight Posted February 3, 2015 Share Posted February 3, 2015 I have some very simple Hanna Code placed in a body field. It gives very mixed results. This works and I've no opening or closing PHP tags. The docs say I dont need them. $suppliers = $pages->find("template=brfs-suppliers-detail"); foreach ($suppliers as $supplier) { echo " <div class=\"small-12 medium-6 large-4 columns partner-wrapper\" > <img src=\"{$supplier->supply_partner_logo->url} \" class=\"partner-thumb\" > {$supplier->title} </div> " ;} I now need to top and tail that block with an opening and closing div. To do this, I have to reinstate the opening and closing PHP tags as follows <div class="row"> <?php $suppliers = $pages->find("template=brfs-suppliers-detail"); foreach ($suppliers as $supplier) { echo " <div class=\"small-12 medium-6 large-4 columns partner-wrapper\" > <img src=\"{$supplier->supply_partner_logo->url} \" class=\"partner-thumb\" > {$supplier->title} </div> " ;} ?> </div> This gives me an error Parse error: syntax error, unexpected '<' in /var/www/vhosts/test-domain.com/site/assets/cache/HannaCode/get-supply-partners.php on line 3 Currently, line 3 is blank due to formatting. I also tried placing all the code on the same 2 lines and I still get an error re. Line 3. Do you think this is a general bug or a bug in HC 0.1.9? I'm running PW 2.5.17. Link to comment Share on other sites More sharing options...
adrian Posted February 3, 2015 Share Posted February 3, 2015 Well you could either start with a close tag: ?> //close initial php open here <div class="row"> <?php $suppliers = $pages->find("template=brfs-suppliers-detail"); foreach ($suppliers as $supplier) { echo " <div class=\"small-12 medium-6 large-4 columns partner-wrapper\" > <img src=\"{$supplier->supply_partner_logo->url} \" class=\"partner-thumb\" > {$supplier->title} </div> "; } ?> </div> or instead put your divs in the php code block and echo them out. <?php echo '<div class="row">'; $suppliers = $pages->find("template=brfs-suppliers-detail"); foreach ($suppliers as $supplier) { echo " <div class=\"small-12 medium-6 large-4 columns partner-wrapper\" > <img src=\"{$supplier->supply_partner_logo->url} \" class=\"partner-thumb\" > {$supplier->title} </div> " ;} echo '</div>'; ?> Link to comment Share on other sites More sharing options...
mr-fan Posted February 3, 2015 Share Posted February 3, 2015 (edited) echo "<div class='row'>"; $suppliers = $pages->find("template=brfs-suppliers-detail"); foreach ($suppliers as $supplier) { echo " <div class=\"small-12 medium-6 large-4 columns partner-wrapper\" > <img src=\"{$supplier->supply_partner_logo->url} \" class=\"partner-thumb\" > {$supplier->title} </div> " ;} echo "</div>"; try this one edit: adrian beat me.... Edited February 3, 2015 by mr-fan Link to comment Share on other sites More sharing options...
Joss Posted February 3, 2015 Share Posted February 3, 2015 Because you have set the code as php, the module assumes anything you write is in php, which is why you don't need to use php tags. But that means you need to close the php first before you put any pure html Link to comment Share on other sites More sharing options...
Peter Knight Posted February 3, 2015 Share Posted February 3, 2015 Well you could either start with a close tag: ?> //close initial php open here <div class="row"> <?php $suppliers = $pages->find("template=brfs-suppliers-detail"); foreach ($suppliers as $supplier) { echo " <div class=\"small-12 medium-6 large-4 columns partner-wrapper\" > <img src=\"{$supplier->supply_partner_logo->url} \" class=\"partner-thumb\" > {$supplier->title} </div> "; } ?> </div> or instead put your divs in the php code block and echo them out. <?php echo '<div class="row">'; $suppliers = $pages->find("template=brfs-suppliers-detail"); foreach ($suppliers as $supplier) { echo " <div class=\"small-12 medium-6 large-4 columns partner-wrapper\" > <img src=\"{$supplier->supply_partner_logo->url} \" class=\"partner-thumb\" > {$supplier->title} </div> " ;} echo '</div>'; ?> @Adrian - you just beat me to it Thats how I fixed too. Link to comment Share on other sites More sharing options...
hwmaier Posted February 3, 2015 Share Posted February 3, 2015 I usually use this approach for Hanna Code. A few initial lines in pure PHP code to init vars and prepare data enclosed in a <?php ... ?> tag and then follows the HTML "view" using PHP's alternative syntax to fill in variables and control structures like loops. <?php $images = wire()->page->images->findTag($tag); ?> <?foreach ($images as $image):?> <p><img src="<?=$image->url?>" alt="<?=$image->description?>"></p> <?if ($image->description):?> <small><?=$image->description?></small> <?endif?> <?endforeach?> This approach allows separation of logic from presentation but still encapsulates both within a Hanna Code component. 1 Link to comment Share on other sites More sharing options...
Peter Knight Posted February 6, 2015 Share Posted February 6, 2015 (edited) I have this really odd HannaCode bug which I've been trying to fix for about a day now. I think it's finally beaten me get-team-management is a simple loop through some team pages and outputs their name, job role, body and photo. <?php $teams = $pages->find("template=team_member,limit=10"); foreach ($teams as $team) {echo" <div class=\"team-wrapper\"> <h2>{$team->title}</h2> <h3>{$team->team_role}</h3> {$team->body} </div> ";} ?> Hitting Save and Test on HannaCode displays the content perfectly. Great ! Next it's time to add my HC tag within body field. I'm adding it after a small piece of dummy intro text as per screengrab. The resulting output is single team biography (body field) from a single team member. There should be 8 team members outputted and the dummy text before my HC tag has vanished too. There should be a small intro paragraph followed by each team members title, role, body. The next logical step is to embed my PHP directly in the template and bypass HannaCode. This works in that each team member has all the info required. Any ideas where to look on this one? I'm running the latest Dev 2.5.17. My first thought was to check the team members were all published and all had the correct template (team_member). They do. Next step was to try placing my echo directly into the template. That way I'd know if it was perhaps/or not HannaCode at fault. Edited February 6, 2015 by kongondo Moved to HC support forum Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now