Jump to content
ryan

Hanna Code

Recommended Posts

One thing I noticed, I think there should be a space after "echo". Also I'm personally not keen on multiline strings. I don't trust them to work. I've also added a test for how much teams are really found, which is what I would check first. If there are multiple teams found, but only one is displayed you can say for sure somethings wrong with your snippet.

<?php
$teams = $pages->find("template=team_member,limit=10");
// Just for debug purposes
echo "It's ".count($teams)." teams.";
$out = "";
foreach ($teams as $team) {
  $out .= "<div class=\"team-wrapper\">";
  $out .= "<h2>{$team->title}</h2>";
  $out .= "<h3>{$team->team_role}</h3>";
  $out .= $team->body;
  $out .= "</div>";
}
echo $out;
?>

Share this post


Link to post
Share on other sites

That correctly displays within HannaCode itself (Save and Test) and counts 9 teams.

Once the HC tag is added to the Body field, I get a single team biography. No name or job role either.

One thing I noticed, I think there should be a space after "echo". Also I'm personally not keen on multiline strings. I don't trust them to work. I've also added a test for how much teams are really found, which is what I would check first. If there are multiple teams found, but only one is displayed you can say for sure somethings wrong with your snippet.

$out = "";
foreach ($teams as $team) {
  $out .= 
?>

I've seen this on peoples code samples before and always wondered why they were using this. Thanks for the tip :)

Share this post


Link to post
Share on other sites

Does it show "It' s 1 teams." ? Or does it even show this line? I'm just curious if the culpit is somehow in the foreach loop or earlier in loading $teams. 

Share this post


Link to post
Share on other sites

So it seems the culpit is somewhere in the foreach loop, which is not what I expected :) Did you try the ultra failsave of using concatination instead of curly braces and single quotes for the class? I really don't see an error, but just to try it. Maybe var_dump $teams / $team inside of the loop, so check if something is messing with them.

Share this post


Link to post
Share on other sites

does team body have hanna code formatter enabled?

  • Like 1

Share this post


Link to post
Share on other sites

does team body have hanna code formatter enabled?

Yes. One of the first things I checked too after making that error last time :)

I'm going to deconstruct things tomorrow. Start off with calling just a single field in a basic template.

Will report back

Share this post


Link to post
Share on other sites

does it work if you disable the hanna code on that? i'm guessing from what you are saying, no...

Share this post


Link to post
Share on other sites

If {team->body} has hanna code formatter enabled, then it will not work as Hanna Code 1.9 does not support recursive Hanna code processing. Refer to my earlier post.

Remove the {$team->body} statement from your code snippet and check the result whether it then outputs all 9 members. Once you see that working, try using the patched version of Hanna Code I submitted on Github.

  • Like 4

Share this post


Link to post
Share on other sites

I've a feature request. As I can assign users of ProcessWire the right to view/list hanna codes it would be nice to be able to incorporate a description field, where I can add small explanations for each code. This way the list/view permission would be more useful on it's own. 

This could maybe later be incorporated in something like a small dropdown underneath hanna code textfields.

post-874-0-27543700-1423327850_thumb.jpg

  • Like 3

Share this post


Link to post
Share on other sites

If {team->body} has hanna code formatter enabled, then it will not work as Hanna Code 1.9 does not support recursive Hanna code processing. Refer to my earlier post.

Remove the {$team->body} statement from your code snippet and check the result whether it then outputs all 9 members. Once you see that working, try using the patched version of Hanna Code I submitted on Github.

Hey hwmaler

That works so I can confirm it's an issue with recursive Body fields.

Share this post


Link to post
Share on other sites

That works so I can confirm it's an issue with recursive Body fields.

Peter,

Thanks for testing and confirming the fix. I will add your confirmation to the Github issue list notes and hopefully this fix is adopted at some stage by Ryan into the main release.

Henrik

Share this post


Link to post
Share on other sites

Should clarify that removing the body field worked.

I wasn't sure how to get your own github version running. Tried manually adding your changes and that didn't work.

Share this post


Link to post
Share on other sites

I use PHP-based Hanna Code snippets for embedding certain fields from certain pages on other pages. Now I stumbled upon the fact that you cannot render fields within a Hanna Code when the Hanna Code Textformatter is applied to that field. The result is a broken output where only a small part of the page is being rendered.

How can I achieve those "recursive Hanna Codes"?

kmkmUQY.jpg

  • Like 1

Share this post


Link to post
Share on other sites

Hi all,

if I write the following code in one of my template files:

$result = $db->query("SELECT id, name FROM pages");
while($row = $result->fetch_array()) print_r($row); 

It works and prints a list of all my pages.

If I write the same code in a "php hanna code", I get no result from the query.
Is there any reason, that $db is not working in hanna codes?

thanx for your help 
/thomas

Share this post


Link to post
Share on other sites

I took your code and created a php Hanna Code from it.  I created a template (clone of basic-page) and renamed it "test1".  The body field has the hanna code text formatter assigned to it.  Here is a sample of the output:

post-756-0-50646200-1427108827_thumb.png

The code is working or is there something else you actually meant?

  • Like 1

Share this post


Link to post
Share on other sites

Thank you cstenvsjr,

that was the output I want to see.
Now that I saw that it was no hanna problem, I found the solution. There was a little include(..) before the posted lines that was responsible for the error.

you made my day
/thomas

  • Like 1

Share this post


Link to post
Share on other sites

Recursive hanna codes is mentioned already a few time in this topic. There's an open pull request on the github repo, that adds support for that, but the official release doesn't have that right now.

Share this post


Link to post
Share on other sites

I'm trying to use this simple hanna code in a CKEditor field (using PW 2.6.1):

<?php
	echo "<ul>";
	foreach ($pages->get('/contact-us/')->children as $offices) {
		echo "<li><h2>{$offices->title}</h2>{$offices->body}</li>";
	}
	echo "</ul>";

The 'contact-us' page has 4 child pages with the office info. If I add the above code to my template it works fine but if I add the HC to my body field it strips most of the content from that body field out. The only textformatter I have on that body field is the HC one. The 'Save & Test' shows the results fine so I have no idea what I'm doing wrong.

edit: for some reason if I remove the '$offices->body' from my echo it works.

edit 2: just read the previous pages and realise now it's a bug.

Share this post


Link to post
Share on other sites

Sorry folks if I missed this in the docs and threads.., but is there a way to get a regular PW template to o/p a Hanna, sort of like a Hanna being an include?

$out .= "<div id='clientCard'>";
	$out .= "<h2>Client card</h2>";
	$out .= wire('modules')->get('[[client_card_intro]]');
$out .= "</div>";

I am trying to see if I can do this so I can build a DRY (don't repeat yourself) collection of items that I can use either in the Admin in a rich text field via the usual [[the_name_of_the_hanna]] or from the API in a template via a correct version of the code above.

Thanks for any comments, cheers, -Alan

Edit:

It looks as if Ryan recommends this is not done (if I read this right) for reasons of security.

Edited by alan

Share this post


Link to post
Share on other sites

yup, just include the path to the php file in your hanna code;

<?php

include($config->paths->templates . "hannas/myhanna.php");

then you can include that same file form a template, or use as hanna code.

  • Like 1

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By teppo
      This module tracks changes, additions, removals etc. of public (as in "not under admin") pages of your site. Like it's name says, it doesn't attempt to be a version control system or anything like that - just a log of what's happened.
      At the moment it's still a work in progress and will most likely be a victim of many ruthless this-won't-work-let's-try-that-instead cycles, but I believe I've nailed basic functionality well enough to post it here.. so, once again, I'll be happy to hear any comments you folks can provide
      https://modules.processwire.com/modules/process-changelog/
      https://github.com/teppokoivula/ProcessChangelog
      How does it work?
      Exactly like it's (sort of) predecessor, Process Changelog actually consists of two modules: Process Changelog and Process Changelog Hooks. Hooks module exists only to serve main module by hooking into various functions within Pages class, collecting data of performed operations, refining it and keeping up a log of events in it's own custom database table (process_changelog.) Visible part is managed by Process Changelog, which provides users a (relatively) pretty view of the contents of said log table.
      How do you use it?
      When installed this module adds new page called Changelog under Admin > Setup which provides you with a table view of collected data and basic filtering tools See attached screenshots to get a general idea about what that page should look like after a while.
      For detailed installation instructions etc. see README.md.
       


    • By Gadgetto
      Status update links (inside this thread) for SnipWire development will be always posted here:
      2019-08-08
      2019-06-15
      2019-06-02
      2019-05-25
      If you are interested, you can test the current state of development:
      https://github.com/gadgetto/SnipWire
      Please note that the software is not yet intended for use in a production system (alpha version).
      If you like, you can also submit feature requests and suggestions for improvement. I also accept pull requests.
      ---- INITIAL POST FROM 2019-05-25 ----
      I wanted to let you know that I am currently working on a new ProcessWire module that fully integrates the Snipcart Shopping Cart System into ProcessWire. (this is a customer project, so I had to postpone the development of my other module GroupMailer).
      The new module SnipWire offers full integration of the Snipcart Shopping Cart System into ProcessWire.
      Here are some highlights:
      simple setup with (optional) pre-installed templates, product fields, sample products (quasi a complete shop system to get started immediately) store dashboard with all data from the snipcart system (no change to the snipcart dashboard itself required) Integrated REST API for controlling and querying snipcart data webhooks to trigger events from Snipcart (new order, new customer, etc.) multi currency support self-defined/configurable tax rates etc. Development is already well advanced and I plan to release the module in the next 2-3 months.
      I'm not sure yet if this will be a "Pro" module or if it will be made available for free.
      I would be grateful for suggestions and hints!
      (please have a look at the screenshots to get an idea what I'm talking about)
       




    • By apeisa
      Update 31.7.2019: AdminBar is now maintained by @teppo. Modules directory entry has been updated, as well as the "grab the code" link below.
      ***
      Latest screencast: http://www.screencas...73-ab3ba1fea30c
      Grab the code: https://github.com/teppokoivula/AdminBar
      ***
      I put this Adminbar thingy (from here: http://processwire.c...topic,50.0.html) to modules section and to it's own topic.
      I recorded quick and messy screencast (really, my first screencast ever) to show what I have made so far. You can see it from here: http://www.screencas...18-1bc0d49841b4
      When the modal goes off, I click on the "dark side". I make it so fast on screencast, so it might seem a little bit confusing. Current way is, that you can edit, go back to see the site (without saving anything), continue editing and save. After that you still have the edit window, but if you click "dark side" after saving, then the whole page will be reloaded and you see new edits live.
      I am not sure if that is best way: there are some strengths in this thinking, but it is probably better that after saving there shouldn't be a possibility to continue editing. It might confuse because then if you make edits, click on dark side -> *page refresh* -> You lose your edits.
      ***
      When I get my "starting module" from Ryan, I will turn this into real module. Now I had to make some little tweaks to ProcessPageEdit.module (to keep modal after form submits). These probably won't hurt anything:
      if($this->redirectUrl) $this->session->redirect($this->redirectUrl); if(!empty($_GET['modal'])) $this->session->redirect("./?id={$this->page->id}&modal=true"); // NEW LINE else $this->session->redirect("./?id={$this->page->id}");   and...
      if(!empty($_GET['modal'])) { $form->attr('action', './?id=' . $this->id . '&modal=true'); } else { $form->attr('action', './?id=' . $this->id); // OLD LINE }  
    • By Mike Rockett
      Jumplinks for ProcessWire
      Release: 1.5.54
      Composer: rockett/jumplinks
      Jumplinks is an enhanced version of the original ProcessRedirects by Antti Peisa.
      The Process module manages your permanent and temporary redirects (we'll call these "jumplinks" from now on, unless in reference to redirects from another module), useful for when you're migrating over to ProcessWire from another system/platform. Each jumplink supports wildcards, shortening the time needed to create them.
      Unlike similar modules for other platforms, wildcards in Jumplinks are much easier to work with, as Regular Expressions are not fully exposed. Instead, parameters wrapped in curly braces are used - these are described in the documentation.
      Under Development: 2.0, to be powered by FastRoute
      As of version 1.5.0, Jumplinks requires at least ProcessWire 2.6.1 to run.
      View on GitLab
      Download via the Modules Directory
      Read the docs
      Features
      The most prominent features include:
      Basic jumplinks (from one fixed route to another) Parameter-based wildcards with "Smart" equivalents Mapping Collections (for converting ID-based routes to their named-equivalents without the need to create multiple jumplinks) Destination Selectors (for finding and redirecting to pages containing legacy location information) Timed Activation (activate and/or deactivate jumplinks at specific times) 404-Monitor (for creating jumplinks based on 404 hits) Additionally, the following features may come in handy:
      Stale jumplink management Legacy domain support for slow migrations An importer (from CSV or ProcessRedirects) Feedback & Feature Requests
      I’d love to know what you think of this module. Please provide some feedback on the module as a whole, or even regarding smaller things that make it whole. Also, please feel free to submit feature requests and their use-cases.
      Note: Features requested so far have been added to the to-do list, and will be added to 2.0, and not the current dev/master branches.
      Open Source

      Jumplinks is an open-source project, and is free to use. In fact, Jumplinks will always be open-source, and will always remain free to use. Forever. If you would like to support the development of Jumplinks, please consider making a small donation via PayPal.
      Enjoy! :)
×
×
  • Create New...