Jump to content
ryan

Hanna Code

Recommended Posts

Agreed, this is a problem for anyone using CKEditor together with Hanna Code. Entities config setting seems like a good solution, at least I'm not aware of any serious drawbacks to that.

There's another option (config.basicEntities) for things like <, > etc. which could be potentially harmful if left unescaped. We're talking about HTML markup here, after all. If I ever needed to use comparison operators as parts of Hanna Code variables, I'd probably let CKEditor escape them and then handle decoding in the code snippet with str_replace() or html_entity_decode().

If you're wondering what these config settings can cause, I'd suggest taking a look at CKEditor source. There you can see a list of all entities separated to couple of different variables; htmlbase is only affected by config.basicEntities while encoding all the others (entities, latin, and greek) is going to be disabled if you set config.entities to false. 

Share this post


Link to post
Share on other sites

@Teppo - thanks again for your help and comments  - yeah i should definitely go with the basicEntities and decode in Hanna.. will try asap and report back...

Share this post


Link to post
Share on other sites
I recently debugged similar issue and eventually found out that it was caused by CKEditor encoding " to " (default behavior) before Hanna Code had a chance to grab it. Similar issues could be caused by other editors, textformatters placed before Hanna Code etc.

It might make sense for Hanna code's parser to just allow " as an allowed attribute container, in the same way it does unencoded quotes? I'm happy to implement this change if you guys think it would solve the issue without creating other problems (I can't think of any at the moment). 

Share this post


Link to post
Share on other sites

Yes! that would be great! - seems the only reliable way to use HC with an editor? otherwise you'd have to adjust the config settings per the above conversation...

Share this post


Link to post
Share on other sites
Yes! that would be great! - seems the only reliable way to use HC with an editor? otherwise you'd have to adjust the config settings per the above conversation...

Strangely I've not ever run into this issue, and I guess it just depends on whether the editor is entity encoding quotes or not (it looks like CKEditor does not entity encode quotes, so no problems with Hanna code). I've gone ahead and added support for " entity encoded quotes to the latest version. 

Share this post


Link to post
Share on other sites

for some reason both times i was using ckeditor and i had to either decode entities in the hanna code or change the ck editor config...

Share this post


Link to post
Share on other sites

I've just tried using it to input something from rafflecopter into my post but it does not seem to work correctly. The code from rafflecopter is:

<a id="rc-603abd0" class="rafl" href="http://www.rafflecopter.com/rafl/display/603abd0/" rel="nofollow">a Rafflecopter giveaway</a>
<script src="//d12vno17mo87cx.cloudfront.net/embed/rafl/cptr.js"></script>

but when I add to hanna code and insert the tag into my post, nothing shows up. I've selected javascript as the options as well.

Share this post


Link to post
Share on other sites

i see htmls in there

sholdunt u.use html as mode ?

their is no javascripts here

just html script link to javascript

tl;dr use.html mode

  • Like 2

Share this post


Link to post
Share on other sites

Just to follow up here in case anyone else ever runs into something similar: WillyC was correct about the issue here. It just needed to be an HTML HannaCode rather than a javascript one. 



Also wanted to mention I've posted an update to HannaCode, version 0.1.4 which fixes a couple of bugs having to do with the Ace editor. It fixes the issue where extra whitespace was getting inserted at the end of the code. It also fixes the issue where Ace sometimes wasn't active after doing a 'save & test'. 

  • Like 1

Share this post


Link to post
Share on other sites

This I almost feel like i'm building my own CMS when I use this module it is so easy! + awesome. 

Idea: it could be cool but not totally necessary of Hanna supported shorthand single arguments for easy to remember usage. ie. [[block=myblock]]  rather than [[block title=myblock]. Just idea to shorten hanna codes by a few character and make them easier to remember.  if you have an attribute that matches the name of your Hanna code it could work that way...

question: is it possible to render hannacode inside of hanna? so far I have not been able to do it, even by calling a new instance of Hanna: 

<?php

//my Hanna block
$mypage = $pages->get("/settings/blocks/".$title);
$block_hanna = $modules->get('TextformatterHannaCode'); 
echo $block_hanna->render($page->body); 

/* 
This does no seem to work as planned. 
It currently returns nothing: and breaks my existing Hanna codes.  Also does not work if I use an existing 
instance of hanna i call from my template which would look like this: echo $hanna->render($page->body); 
*/
?>

I might just be a Hanna obsessed and should chill-out with with that I want it to do, and find other ways. The main reason i'm running into this is that I am using hanna to build my css grids and call the the [[blocks]] of hanna formatted feilds from other hanna formatted fields. 

[[grid_start col=8 ]]
My left column body content
[[grid col=4 col_class=print]]
my right column content
[[block title="load my hanna formatted field"]]
[[grid_end]]

I might have been able to accomplish this all with repeaters rather than using hanna, but I liked the freedom Hanna offered.

Share this post


Link to post
Share on other sites

@Neeks,  your suggested idea sounds kind of fun, but also not very useful. [[block=myblock]] would be equal to [[myblock]], except that you'd have a lot of your "blocks" within one single Hanna Code.. which is exactly what individual Hanna Codes are meant for.

About your question: in your example code you're assigning /settings/blocks/".$title to $mypage and later asking Hanna Code to render $page->body -- while you probably meant to render $mypage->body. Is this just a typo in your example code here or could this be the issue with your original Hanna Code?

Anyway, even if this can be fixed, wouldn't it make more sense to have a [[block type=something' title='something else]] Hanna Code that finds a page (let's call it $block_page) and then renders it with $block_page->render(), i.e. by using ProcessWire's full template system? Is there a particular reason why you're trying to move your template level stuff into Hanna Codes?

I'm afraid that's not really what Hanna Code was intended for, at least as far as I'm aware. Hanna Codes are snippets you can drop in your code -- once you find yourself building complex logic with them, you'd probably be better off by using other PW features instead  :)

  • Like 1

Share this post


Link to post
Share on other sites

Strangely I've not ever run into this issue, and I guess it just depends on whether the editor is entity encoding quotes or not (it looks like CKEditor does not entity encode quotes, so no problems with Hanna code). I've gone ahead and added support for " entity encoded quotes to the latest version. 

@ryan: that definitely is strange, considering that with default config CKEditor encodes everything it possibly can; even single quotes get encoded per the entities_additional default value. Perhaps you've modified the config already? :)

Anyway, my solution for this (and most CKEditor issues I've been dealing with) was simply adding config.entities = false to CKEditor's config.js. As you can see from CKEditor source, so-called base HTML entities (nbsp, gt, lt and amp) still get encoded, making this a very good default. As long as we're dealing with UTF-8 data, there shouldn't be any reason to encode everything.

This also prevents issues such as search not working properly with Scandinavian characters ä/Ä, ö/Ö etc. Sure, searching from CKEditor fields is possible even with default config, but how many users would really try something like "Väinö" when they want to search for "Väinö"? Of course encoding search queries would be doable, but that would mean searching with both encoded and non-encoded versions.. :)

As a matter of fact, I would like to suggest this as the default value for upcoming Inputfield CKEditor releases, unless someone knows of some terrible security issue this introduces.

Edit: by the way, I do realize that the default config is much less of a problem for English speakers than us who have to deal with Scandinavian characters, umlauts etc. regularly. Still, it becomes a problem for just about everyone once they try to create multilanguage sites and/or use modules like Hanna Code, which is essentially why I believe that this would make sense as a default.

Edited by teppo

Share this post


Link to post
Share on other sites

Teppo, the way you describe the entities config option, that makes sense to me. Given these issues, I wonder why they have it true by default. I have updated the InputfieldCKEditor module to have the entities option set to false by default. I really can't think of any security issues with doing that, especially given that we're requiring HTMLPurifier for the inline editor. As for why I seem to be getting the entities=false behavior for quotes already, I have no idea. Maybe something to do with HTMLPurifier and inline mode vs. regular mode. 

Share this post


Link to post
Share on other sites

Just a little tip when working with hanna code.

I for some project prefer to have the code on file system and not db.

This can be achieved simply by including the php file in the hanna code.

For example a Hanna code:

include($config->paths->templates . "hannas/archive.php"); 

And have your Hanna code in archive.php.

  • Like 6

Share this post


Link to post
Share on other sites

Hanna Code doesn't actually execute from the DB. It writes each Hanna code to a file in /site/assets/cache/HannaCode/ and then uses the DB copy of the code to compare against the one on the file system, to make sure something hasn't changed the one on the file system. It executes the PHP code from a file in order to ensure it is as fast as possible (avoiding eval) and in the same context as a template file. That's what it does behind the scenes, but Soma's tip is just as useful either way, as Hanna Code wouldn't let you edit its own PHP files directly. 

  • Like 4

Share this post


Link to post
Share on other sites

I just noticed that the complete ACE editor is bundled with TextformatterHannaCode. Wouldn't it be nice to make it a separate js module and use it if it's installed? Also there's already a ACE editor fieldtype from Adam. Since ACE editor source comes with 1million! files I think it would be the way to go. Much like jQueryDataTables or Magnific etc.

  • Like 2

Share this post


Link to post
Share on other sites

I've just been playing around wit Hanna code for the first time, pretty cool. I think i might have discovered some bugs, or at least an error/omission in the instructions.

If you make a Hanna code with a hyphen in it and you then use parameters the Hanna code doesn't get executed. Given the example Hanna on https://github.com/ryancramerdesign/ProcessHannaCode:

if(isset($parent)) {
  // If $parent is an ID or path, lets convert it to a Page
  $parent = $pages->get($parent);
} else {
  // otherwise lets assume the current page is the parent
  $parent = $page; 
}

foreach($parent->children as $child) {
  echo "<p><a href='$child->url'>$child->title</a>";
  // echo "<p><a href='$child->url'>$child->body</a>"; does not work as i expected, it only outputs the last child->body instead of foreaching over them
}

// below is used in the body field of a fresh install from dev  2.3.15

[[menu_items]] //this works
[[menu_items, parent=1006]] //this works
[[menu-items]] //this works
[[menu-items, parent=1006]] //this does not work, it doesn't execute and just displays the literal text

Also, in the example above, if i echo $child->body the Hanna code stops working. It's looks like echoing $child->body from the body field of a parent does not work, or at least not in the example above.

Maybe this is all for obvious reasons but it took me a good while with trial and error to figure out. All tested with PW dev 2.3.15, Hanna 0.1.5 on a Win7 machine.

Share this post


Link to post
Share on other sites

Probably I'm missing something simple, but the $page variable doesn't seem to be referring to the page where the field including the HannaCode is, as the doc says:

 The $page API variable available to your Hanna code represents the page where the Hanna code exists. It is possible for this to be different from wire('page'), which represents the page that originated the request.

For example, I have a very simple code [[files_url]] to get the files directory url from a text fiel in a page:

echo $config->urls->files . $page->id . "/";

It's used for referencing page images or file from a "body" field:

<img class="video-image" onclick="play_video('NxgHAktpdF8')" src="[[files_url]]an_image.jpg" /> 

When using this code in a "body" field in page $article_page, referenced from the currently displayed page wire("page") like this

function renderArticle($article_page) {
   //...
   $out .= $article_page->body;
   //...
   return $out;
}

echo  renderArticle($article_page); 

the page id in the html page is the wrong one, i.e. the one from  wire("page") and not the article_page's id.

To clarify, here is what I get:

echo $article_page->id;
=> 1048

echo wire("page")->id;
=> 1041

echo $article_page->body
=> <img class="video-image" onclick="play_video('NxgHAktpdF8')" src="/site/assets/files/1041/an_image.jpg" />

Which causes an image-not-found error, as the expected result should have been:

echo $article_page->body
=> <img class="video-image" onclick="play_video('NxgHAktpdF8')" src="/site/assets/files/1048/an_image.jpg" /> 

I'm running version 2.3.15 from dev branch.

So bug or expected behavior? And any idea of how to make it work?

(For such a simple use case I could of course do some kind of string replacement in my template, but I would prefer to stay with HannaCodes for regularity if possible  :) ) 

Edited by jean-luc

Share this post


Link to post
Share on other sites

I read your Post atleast 5 times, But I really don't understand what you're asking.

Ok. I've tried to clarify it in the original post.

Share this post


Link to post
Share on other sites

The page that originated the request is meant the one that is rendered, and that's not your article page.

wire("page") or $page is the requested page, so doing echo $someotherpage->body won't give the hanna code on this body the $someotherpage but $page.

You would need to set the page in this case to the one you get the body from and set it back after to make it work in this case.

Something like this should work:

function renderArticle($article_page) {
    // ...
    $current_page = wire("page");
    wire()->set("page", $article_page);
    $out .= $article_page->body;
    wire()->set("page", $current_page);
    return $out;
}

Share this post


Link to post
Share on other sites

The page that originated the request is meant the one that is rendered, and that's not your article page.

Agreed: my article page is the page containing the field where the Hanna code exists.

That's why the behavior I observe don't look consistent with HannaCode module's documentation saying:

 The $page API variable available to your Hanna code represents the page where the Hanna code exists. It is possible for this to be different from wire('page'), which represents the page that originated the request.

And this behavior  would be great by the way, because this is probably what you expect when putting a Hanna code in a page field.

Thanks anyway for the suggestion. I will try it.

Share this post


Link to post
Share on other sites

Ah sorry I haven't really ever read the docu that far, seems like a bug cause I see code in there that sets $page to context specific. But I can't get it to work and it's always the same wire("page") and $page. 

I also noticed some strange behavior when using wire()->set("page", $somepage); and then use $page. So Ryan might have a look into this.

For example this code in a template

$p = wire("page");
wire()->set("page",$pages->get("/"));
$content .= "p1: " . $page->id;
wire()->set("page",$p);
$content .= "p2: " . $page->id;

is different as this:

$p = wire("page");
wire()->set("page",$pages->get("/"));
$content .= "p1: " . wire("page")->id;
wire()->set("page",$p);
$content .= "p2: " . wire("page")->id;

when used in a template for example basic-page.php.

Share this post


Link to post
Share on other sites

This turned out to be an issue with the order of variables returned by core TemplateFile::getArray. It was doing an array_merge which gave preference to API variables, preventing them from being overwritten. Maybe that's a good thing in general, but I don't think we want that limitation. I went ahead and changed it in dev. Now it gives preference to local variables, which enables Hanna Code to provide the behavior it was supposed to. 

  • Like 1

Share this post


Link to post
Share on other sites

Thanks Ryan. I tested my $article_page case with the last dev version and it works just as expected now.

This really opens a huge potential for Hanna code regarding cross-fields referencing in a page independently of the rendering context.

  • Like 1

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By Gadgetto
      SnipWire - Snipcart integration for ProcessWire
      Snipcart is a powerful 3rd party, developer-first HTML/JavaScript shopping cart platform. SnipWire is the missing link between Snipcart and the content management framework ProcessWire.
      With SnipWire, you can quickly turn any ProcessWire site into a Snipcart online shop. The SnipWire plugin helps you to get your store up and running in no time. Detailed knowledge of the Snipcart system is not required.
      SnipWire is free and open source licensed under Mozilla Public License 2.0! A lot of work and effort has gone into development. It would be nice if you could donate an amount to support further development:

      Status update links (inside this thread) for SnipWire development
      2020-01-21 -- Snipcart v3 - when will the new cart system be implemented? 2020-01-19 -- integrated taxes provider finished (+ very flexible shipping taxes handling) 2020-01-14 -- new date range picker, discount editor, order notifiactions, order statuses, and more ... 2019-11-15 -- orders filter, order details, download + resend invoices, refunds 2019-10-18 -- list filters, REST API improvements, new docs platform, and more ... 2019-08-08 -- dashboard interface, currency selector, managing Orders, Customers and Products, Added a WireTabs, refinded caching behavior 2019-06-15 -- taxes provider, shop templates update, multiCURL implementation, and more ... 2019-06-02 -- FieldtypeSnipWireTaxSelector 2019-05-25 -- SnipWire will be free and open source Plugin Key Features
      Fast and simple store setup Full integration of the Snipcart dashboard into the ProcessWire backend (no need to leave the ProcessWire admin area) Browse and manage orders, customers, discounts, abandoned carts, and more Process refunds and send customer notifications from within the ProcessWire backend Complete Snipcart webhooks integration (all events are hookable via ProcessWire hooks) Integrated taxes provider (which is more flexible then Snipcart own provider) Useful Links
      SnipWire in PW modules directory (alpha version only available via GitHub) SnipWire Docs (please note that the documentation is a work in progress) SnipWire @GitHub (feature requests and suggestions for improvement are welcome - I also accept pull requests) Snipcart Website  
      ---- INITIAL POST FROM 2019-05-25 ----
       
    • By d'Hinnisdaël
      Happy new year, everybody 🥬
      I've been sitting on this Dashboard module I made for a client and finally came around to cleaning it up and releasing it to the wider public. This is how it looks.
      ProcessWire Dashboard

      If anyone is interested in trying this out, please go ahead! I'd love to get some feedback on it. If this proves useful and survives some real-world testing, I'll add this to the module directory.
      Download
      You can find the latest release on Github.
      Documentation
      Check out the documentation to get started. This is where you'll find information about included panel types and configuration options.
      Custom Panels
      My goal was to make it really simple to create custom panels. The easiest way to do that is to use the panel type template and have it render a file in your templates folder. This might be enough for 80% of all use cases. For anything more complex (FormBuilder submissions? Comments? Live chat?), you can add new panel types by creating modules that extend the DashboardPanel base class. Check out the documentation on custom panels or take a look at the HelloWorld panel to get started. I'm happy to merge any user-created modules into the main repo if they might be useful to more than a few people.
       Disclaimer
      This is a pre-release version. Please treat it as such — don't install it on production sites. Just making sure 🍇
      Roadmap
      These are the things I'm looking to implement myself at some point. The wishlist is a lot longer, but those are the 80/20 items that I probably won't regret spending time on.
      Improve documentation & add examples ⚙️ Panel types Google Analytics ⚙️ Add new page  🔥 Drafts 🔥 At a glance / Page counter 404s  Layout options Render multiple tabs per panel panel groups with heading and spacing between ✅ panel wrappers as grid item (e.g. stacked notices) ✅ Admin themes support AdminThemeReno and AdminThemeDefault ✅ Shortcuts panel add a table layout with icon, title & summary ✅ Chart panel add default styles for common chart types ✅ load chart data from JS file (currently passed as PHP array) Collection panel support image columns ✅ add buttons: view all & add new ✅
    • By Robin S
      This module is inspired by and similar to the Template Stubs module. The author of that module has not been active in the PW community for several years now and parts of the code for that module didn't make sense to me, so I decided to create my own module. Auto Template Stubs has only been tested with PhpStorm because that is the IDE that I use.
      Auto Template Stubs
      Automatically creates stub files for templates when fields or fieldgroups are saved.
      Stub files are useful if you are using an IDE (e.g. PhpStorm) that provides code assistance - the stub files let the IDE know what fields exist in each template and what data type each field returns. Depending on your IDE's features you get benefits such as code completion for field names as you type, type inference, inspection, documentation, etc.
      Installation
      Install the Auto Template Stubs module.
      Configuration
      You can change the class name prefix setting in the module config if you like. It's good to use a class name prefix because it reduces the chance that the class name will clash with an existing class name.
      The directory path used to store the stub files is configurable.
      There is a checkbox to manually trigger the regeneration of all stub files if needed.
      Usage
      Add a line near the top of each of your template files to tell your IDE what stub class name to associate with the $page variable within the template file. For example, with the default class name prefix you would add the following line at the top of the home.php template file:
      /** @var tpl_home $page */ Now enjoy code completion, etc, in your IDE.

      Adding data types for non-core Fieldtype modules
      The module includes the data types returned by all the core Fieldtype modules. If you want to add data types returned by one or more non-core Fieldtype modules then you can hook the AutoTemplateStubs::getReturnTypes() method. For example, in /site/ready.php:
      // Add data types for some non-core Fieldtype modules $wire->addHookAfter('AutoTemplateStubs::getReturnTypes', function(HookEvent $event) { $extra_types = [ 'FieldtypeDecimal' => 'string', 'FieldtypeLeafletMapMarker' => 'LeafletMapMarker', 'FieldtypeRepeaterMatrix' => 'RepeaterMatrixPageArray', 'FieldtypeTable' => 'TableRows', ]; $event->return = $event->return + $extra_types; }); Credits
      Inspired by and much credit to the Template Stubs module by mindplay.dk.
       
      https://github.com/Toutouwai/AutoTemplateStubs
      https://modules.processwire.com/modules/auto-template-stubs/
    • By Mike Rockett
      Jumplinks for ProcessWire
      Release: 1.5.60
      Composer: rockett/jumplinks
      ⚠️ NOTICE: 1.5.60 is an important security patch-release for an XSS vulnerability discovered by @phlp. It's HIGHLY RECOMMENDED that all Jumplinks users update to the latest version as soon as possible.
      Jumplinks is an enhanced version of the original ProcessRedirects by Antti Peisa.
      The Process module manages your permanent and temporary redirects (we'll call these "jumplinks" from now on, unless in reference to redirects from another module), useful for when you're migrating over to ProcessWire from another system/platform. Each jumplink supports wildcards, shortening the time needed to create them.
      Unlike similar modules for other platforms, wildcards in Jumplinks are much easier to work with, as Regular Expressions are not fully exposed. Instead, parameters wrapped in curly braces are used - these are described in the documentation.
      Under Development: 2.0, to be powered by FastRoute
      As of version 1.5.0, Jumplinks requires at least ProcessWire 2.6.1 to run.
      View on GitLab
      Download via the Modules Directory
      Read the docs
      Features
      The most prominent features include:
      Basic jumplinks (from one fixed route to another) Parameter-based wildcards with "Smart" equivalents Mapping Collections (for converting ID-based routes to their named-equivalents without the need to create multiple jumplinks) Destination Selectors (for finding and redirecting to pages containing legacy location information) Timed Activation (activate and/or deactivate jumplinks at specific times) 404-Monitor (for creating jumplinks based on 404 hits) Additionally, the following features may come in handy:
      Stale jumplink management Legacy domain support for slow migrations An importer (from CSV or ProcessRedirects) Feedback & Feature Requests
      I’d love to know what you think of this module. Please provide some feedback on the module as a whole, or even regarding smaller things that make it whole. Also, please feel free to submit feature requests and their use-cases.
      Note: Features requested so far have been added to the to-do list, and will be added to 2.0, and not the current dev/master branches.
      Open Source

      Jumplinks is an open-source project, and is free to use. In fact, Jumplinks will always be open-source, and will always remain free to use. Forever. If you would like to support the development of Jumplinks, please consider making a small donation via PayPal.
      Enjoy! 🙂
    • By Robin S
      Add Image URLs
      Allows images/files to be added to Image/File fields by pasting URLs.

      Usage
      Install the Add Image URLs module.
      A "Paste URLs" button will be added to all image and file fields. Use the button to show a textarea where URLs may be pasted, one per line. Images/files are added when the page is saved.
       
      https://github.com/Toutouwai/AddImageUrls
      https://modules.processwire.com/modules/add-image-urls/
×
×
  • Create New...