bernhard Posted October 28, 2016 Posted October 28, 2016 hi tpr, wow - the filterbox is really cool! just one minor problem is when using the finder it only finds pages from the currently open pagination. it's obvious to me that this is because of ajax pagination and the data not being in the dom, but i'm sure it's not obvious for clients with no knowledge about all that. i think there should be at least a visual tip. don't know how to solve that in a better way - this will also be a problem in my current project so i'm curious what you think about that i would also suggest adding a link to the docs. i didn't even notice that the module is documented so great and wanted to ask you to add some more descriptive descriptions i'm always installing the module just by typing in AdminOnSteroids so i never went to github for that. and i guess i'm not the only one doing so... 1
tpr Posted October 28, 2016 Author Posted October 28, 2016 Thanks! Of course I know about the ajax issue but that's not something the filterbox feature will solve Docs link - I've thought about that but haven't figured out how to do exactly. What I have in mind to add links to docs sections to each submodule (top rectangles).
tpr Posted October 29, 2016 Author Posted October 29, 2016 Filterbox pagination workaround sneak peak (filter with ctrl-right, ctrl-left): 3
tpr Posted October 29, 2016 Author Posted October 29, 2016 Module updated to v094. The ctrl+arrow navigation was added to paginated filterboxes (AdminDataTables), and moduleFilter filterbox has also got a simiar feature to navigate between tabs having matches. There were also many small updates to the filterboxes in general, now I think they have everything that such a feature can have There are also small anchored links to GitHub readme in the top Submodules section. I'm not entirely satisfied with this because even though the links are correct the images are loaded after the page jumps to the anchor and pushes the target section out of the screen. Anyway, it's a GitHub issue imo that I can't fix. 1
tpr Posted October 30, 2016 Author Posted October 30, 2016 v095 adds a new tweak "Do not distribute modules into tabs" to ModuleTweaks. This results in a flattened module list, without duplications, which makes easier to find a module, especially when using the filter box. The "Add new module" block is in the bottom of the page. I'll probably add a jumplink to that location later for easier access. This feature is JavaScript powered and slows down the Modules page loading a bit but imo one or two extra seconds is worth for the benefits. 2
szabesz Posted October 30, 2016 Posted October 30, 2016 20 minutes ago, tpr said: I'll probably add a jumplink to that location later for easier access. +1
Robin S Posted October 31, 2016 Posted October 31, 2016 I'm seeing a layout issue in the default admin theme where tabs are overlapping the breadcrumbs. The "hasWireTabs" class is not added to the body.
tpr Posted October 31, 2016 Author Posted October 31, 2016 Another update (v097): the "Add new" block is prepended-appended to the flattened module list. I think this is more usable than a jumplink that scrolls to the bottom. 2
Zeka Posted October 31, 2016 Posted October 31, 2016 Hi @tpr Trying to access "admin/page/lister/" when lister tweaks are switched on I get: Undefined variable: listerType on line 729 719: $defaultData = self::getDefaultData(); 720: 721: // 1007: Find 722: // 29: Users 723: if ($pageID == 1007) { 724: $listerType = 'ListerTweaks_find'; 725: } elseif ($pageID == 29) { 726: $listerType = 'ListerTweaks_users'; 727: } 728: 729: $defaultFields = $defaultData[$listerType]; 730: 731: if (!empty(self::$configData[$listerType])) { 732: foreach (self::$configData[$listerType] as $ff) { 733: if ($ff == '[DEFAULTS]') { PW 3.0.39 Steroids 0.9.8
tpr Posted November 1, 2016 Author Posted November 1, 2016 Could you check the id of your Lister page? Perhaps it's not always 1007.
tpr Posted November 1, 2016 Author Posted November 1, 2016 Thanks - try v099, the lister type is determined by url instead id. 2
Macrura Posted November 1, 2016 Posted November 1, 2016 I'm seeing a small issue with the URL checker, when a field is inside a fieldset:
tpr Posted November 1, 2016 Author Posted November 1, 2016 Thanks, just uploaded a fix to GitHub and the Modules directory (no version change). I haven't noticed this because I had Tooltips turned on. 2
Macrura Posted November 2, 2016 Posted November 2, 2016 ok thanks, only thing is, how do i fix this, without version change
tpr Posted November 2, 2016 Author Posted November 2, 2016 Download AdminOnSteroids.css and replace the one in your modules folder, or edit AdminOnSteroids.module and set a lower version number, eg. '98', then Refresh modules and finally check for updates. 1
bernhard Posted November 3, 2016 Posted November 3, 2016 1 minor "issue" some modules are double listed. i guess that comes from the "new modules" tab, that shows recently installed modules. maybe you can exclude them in the list? feature suggestion (thank you for the docs-links btw): i think it should be possible to have an index on top of your github readme linking to each submodule via #mysubmodule. i suggest placing only ONE link to the docs beside the main headline (as shown in my screenshot in my previous post) and then the user could click on the relevant item and images would already be loaded and the github issue should not be an issue any more. the current help-icon could be replaced by a link icon, linking to the section of the module config, where we can define the detailed options for this submodule. do you get me? i find myself a lot enabling/disabling submodules and then having a "hard time" to find the options for that submodule. thank you for this great module 1
tpr Posted November 3, 2016 Author Posted November 3, 2016 Thanks, the duplicated modules were there because there was an extra "small" tag inside the module's name (in the "new modules" tab). I've fixed this in my working copy. The TOC is a good idea for the documentation. I know that the top submodule toggles are somewhat detached from their configuration fields but I couldn't find an easy way to make it more clear.
fbg13 Posted November 4, 2016 Posted November 4, 2016 @tpr what do you think about changing the sticky header so that it hides when scrolling down and shows when scrolling up? https://jsfiddle.net/102d1sdt/4/ headroomjs
tpr Posted November 4, 2016 Author Posted November 4, 2016 Looks fancy, but this would add another layer of complexity to the header from development POV (Default vs Reno theme, notifications, etc). Plus the header elements in the admin are not having one common wrapper so it would make things even more problematic. Or have you thought about the (dark) masthead only?
fbg13 Posted November 4, 2016 Posted November 4, 2016 15 minutes ago, tpr said: Or have you thought about the (dark) masthead only? Meant for all three (masthead, breadcrumbs, headline), but now that i think about it the headline is the most useful to me, having the button always on screen. Also didn't think about the default theme. I'll just stick to the non-sticky header. Thanks for the module.
tpr Posted November 5, 2016 Author Posted November 5, 2016 v0993 is up, incorporating bernhard's suggestions, including the github readme link and jumplinks to each submodule's configuration fields in the submodule "panels": The latest PW dev (3.0.40) has changes in some CSS classses (dropdown -> pw-dropdown) and AOS was adjusted for this. If you find that somewhere it's not working as it should, please report. 4
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now