Robin S Posted February 21, 2017 Posted February 21, 2017 10 hours ago, justb3a said: One opportunity would be to use a `label` element if it isn't a multilingual site and a `strong` tag if it is one. What do you think? Sounds good, thanks. 10 hours ago, justb3a said: The idea behind this was that some textformatter like "NewLineToBreak" or "NewLineToListItem" doesn't make that much sense applied to an one liner input element. True, but the textformatter that I'm thinking of is HTML Entity Encoder, which is important for any text field to avoid ambiguous ampersands or other invalid HTML. The string could be manually encoded in the template but more convenient to set-and-forget with a textformatter.
Jon E Posted February 23, 2017 Posted February 23, 2017 (edited) Hi, Thanks so much - that makes sense... I've tried to combine the below in a lot of different ways but keep getting an error... Any ideas? Thanks <?php if ($image->caption){ //Output markup 1 } else { //Output markup 2 } ?> <?foreach($page->images as $image) { $thumb = $image->width(1040); echo "<li><img src='$thumb->url' alt='$image->description'><p class='caption'><strong>{$image->imagetitle}</strong> <em>{$image->imagetext}</em> <span><br>{$image->role}</span></p></li>";} ?> Edited February 23, 2017 by kongondo Mod Note: Moved your question to this module's support forum
jploch Posted March 7, 2017 Posted March 7, 2017 hi! thanks for this great module! today I experienced a strange issue when using this module with the Video Fieldtype Module I get the following error when uploading a video, when the image extra module is installed: <br /> <b>Notice</b>: Trying to get property of non-object in <b>/www/htdocs/w00dd152/projekte/jp-relaunch/site/modules/ImageExtra/ImageExtra.module</b> on line <b>722</b><br /> [{"error":false,"message":"Added file: portfolio_screencap_02.mp4","file":"\/jp-relaunch\/site\/assets\/files\/1162\/portfolio_screencap_02.mp4","size":3214711,"markup":"<li id='file_c17b44756649023a42ba014c5b29202c' class='InputfieldFile InputfieldImage InputfieldVideo ui-widget'>\n\t\t<p class='InputfieldFileInfo ui-widget ui-widget-header'>\n\t\t\t<span class='ui-icon ui-icon-arrowthick-2-n-s'><\/span>\n\t\t\t<span class='InputfieldFileName'>portfolio_screencap_02.mp4<\/span> \n\t\t\t<span class='InputfieldFileStats'>• 3,139 kB • <\/span> \n\t\t\t<label class='InputfieldFileDelete'><input type='checkbox' name='delete_video_repeater1162_c17b44756649023a42ba014c5b29202c' value='1' \/><span class='ui-icon ui-icon-trash'>Delete<\/span><\/label>\n\t\t\t<a class='InputfieldFileMove InputfieldFileMoveBottom' href='#'><span class='ui-icon ui-icon-arrowthickstop-1-s'><\/span><\/a> \n\t\t\t<a class='InputfieldFileMove InputfieldFileMoveTop' href='#'><span class='ui-icon ui-icon-arrowthickstop-1-n'><\/span><\/a> \n\t\t<\/p>\n\t\t\t<div class='InputfieldFileDescription'><label for='description_video_repeater1162_c17b44756649023a42ba014c5b29202c' class='detail'>Description<\/label><input type='text' name='description_video_repeater1162_c17b44756649023a42ba014c5b29202c' id='description_video_repeater1162_c17b44756649023a42ba014c5b29202c' value='' \/><\/div>\n\t\t<br \/><label class='InputfieldFileDescription'><span class='detail'>Subtitles<\/span>\n\t\t<br \/><br \/>In templates, you can access this subtitles file (portfolio_screencap_02.srt) using: <code>$page->video->eq(0)->subtitles<\/code><br \/>In templates you can access a formatted transcript (converted from subtitles entered in SRT format), by using: <code>$page->video->eq(0)->transcript<\/code>\n\t\t<br \/><br \/><textarea rows='10' name='subtitles_video_repeater1162_c17b44756649023a42ba014c5b29202c' \/><\/textarea>\n\t\t\t<input class='InputfieldFileSort' type='text' name='sort_video_repeater1162_c17b44756649023a42ba014c5b29202c' value='0' \/>\n\t\t<\/p><\/li>","replace":false,"overwrite":0}] I testes this in PW 3.0 with the newest versions of both modules installed. Not sure why its even interfering with the video field.. When I disable the image extra module, everything works fine.
adrian Posted March 7, 2017 Posted March 7, 2017 @jploch - I'd like to see a dump of $event after line 718 because $field is not an object and it should be. That said, a quick fix might be to change the hook on line 97 to: InputfieldImage::processInputFile 1
jploch Posted March 8, 2017 Posted March 8, 2017 20 hours ago, adrian said: @jploch - I'd like to see a dump of $event after line 718 because $field is not an object and it should be. That said, a quick fix might be to change the hook on line 97 to: InputfieldImage::processInputFile Thx! this fixed it for me 1
justb3a Posted March 9, 2017 Author Posted March 9, 2017 @Jon E Just use the comparison inside the foreach loop: foreach ($page->images as $image) { $caption = ''; if ($image->imagetitle) { $caption = "<p class='caption'>{$image->imagetitle}</p>"; } echo "<li><img src='{$image->width(1040)->url}' alt='{$image->description}'>$caption</li>"; } Or if you want to combine multiple parts: you can check every extra field individually and concatenate the caption before outputting it. foreach ($page->images as $image) { $caption = ''; if ($image->imagetitle) $caption .= "<strong>{$image->imagetitle}</strong>"; if ($image->imagetext) $caption .= "<em>{$image->imagetext}</em>"; if ($image->role) $caption .= "<span>{$image->role}</span>"; if ($caption) $caption = "<p class='caption'>$caption</p>"; echo "<li><img src='{$image->width(1040)->url}' alt='{$image->description}'>$caption</li>"; } 1
justb3a Posted March 9, 2017 Author Posted March 9, 2017 New Version 1.0.4: @Robin S use label tag if it isn't a multilangual site @jploch, @adrian changed hook InputfieldFile::processInputFile to InputfieldImage::processInputFile 5
theoretic Posted March 20, 2017 Posted March 20, 2017 Hi there! And, as always, thanks for a perfect product! Would like to discuss an interesting case. Let's suppose we have some images attached to different pages, each image having some extra fields including uid field which is unique. We have to build an api page which should receive requests like /api?uid=efv97yg and it should return some JSON about the image with that uid. Is there any possibility to find an image by its extrafield value (e.g. uid)? Well, i know that we can do something like this: $pages_ = $pages->find('template=page_with_fotos'); foreach($pages_ as $page_) { $images = $page_->images; foreach($images as $image) { if($image->uid !== $uid) continue; $json = json_encode($image); break; } } echo $json; But its not very elegant. And even worse: $sql = "select * from field_foto where uid=$uid"; $query = $database->prepare($sql); $query->execute(); ... What is on my wishlist: //pseudocode, will NOT work for sure! $foto = $field_fotos->get("uid=$uid"); ... Will appreciate any advice. Thanks!
tpr Posted April 19, 2017 Posted April 19, 2017 Just used this module for adding a video link to images. There was a glitch that there was no indication on the thumbnails whether there is a link added or not, so I put together a small js/css combo to add an icon: Here is the corresponding code - dirty but works Spoiler var fieldname = 'video_url_project_images'; function updateVideoItems() { $('.gridImage__hover.has-video').removeClass('has-video'); $('input[id*="video_url_project_images"][value!=""]').each(function() { var $item = $(this), seekId = $item.attr('id').replace(fieldname, 'file'), $target = $('#' + seekId); if($target.length) { $target.find('.gridImage__hover').addClass('has-video'); } }); } $(document).ready(function() { updateVideoItems(); }); $(document).on('keyup change', 'input[id*="' + fieldname + '"]', function() { updateVideoItems(); }); .gridImage__hover.has-video .gridImage__inner::after { content: ""; position: absolute; right: 2px; bottom: 2px; width: 30px; height: 30px; background: #333 url('/site/templates/images/icons/play-circle.svg') center center no-repeat; background-size: 30px; border-radius: 100%; border: 2px solid white; background-clip: content-box; } 1
Alf S. Posted July 14, 2017 Posted July 14, 2017 There are two different ways to get the label of any input Field: echo "This is the field label: {$page->fields->get("simple_slider")->label}"; echo "This is the field label: {$page->fields->get("simple_slider")->getLabel()}"; Let's pretend I added to my image field an extra field "location" with the label "This was in:". So if I want the value of the "location" field I do it like this: echo "This is was in: {$page->simple_slider->location}"; // Outputs "Barcelona" How can I get the LABEL of the location field? Something like: // not working code: echo "{$page->fields->get("simple_slider")->location->getLabel()}: {$page->simple_slider->location}"; // Should output "This was in: Barcelona"
justb3a Posted July 14, 2017 Author Posted July 14, 2017 Hi, since extra fields aren't regular ProcessWire fields you cannot access the labels using `->getLabel()` method or `->label` property. The extra field labels are saved in the regarding field settings (table fields, column data) using json and looks like this: {"otherFieldSettings":"{\"cf_label\":{\"cf_label__location\":\"Location\",\"cf_label__location__1012\":\"Ort\",\"cf_label__custom__1013\":\"Paikka\"}}"} You can get the label using this functionality: $fieldSettings = $fields->get('images')->otherFieldSettings; $settings = json_decode($fieldSettings); echo $settings->cf_label->cf_label__location; As you can see there is no error handling or fallback strategy. Therefore I updated the module and added a method called getExtraLabel(). Usage example: // outputs something like: "Location: Munich" echo $image->getExtraLabel('location') . ': ' . $image->location; // outputs something like: "Ort: München" echo $image->getExtraLabel('location', 'de') . ': ' . $image->location; 3
mr-fan Posted August 4, 2017 Posted August 4, 2017 just tested with 3.0.65 and it seems that the pagelink field is not working? Best regards mr-fan
justb3a Posted August 7, 2017 Author Posted August 7, 2017 Thanks @mr-fan: there was a little bug figuring out, whether the user is working in the backend or not (differentiate between int(0) und false ). The belonging JavaScript file wasn't loaded. 1
mr-fan Posted August 8, 2017 Posted August 8, 2017 Thank you for this great module and for fixing so fast...often when it come to the javascript debuging i'm a little lost...;) best regards mr-fan
The G Posted August 21, 2017 Posted August 21, 2017 Thank you for the module! I'm using it to add a Markdown enhanced captions for some blog images. I have a problem - the text is processed by the Mardown module only for the first image (in ProcessWire 3.0.72 multi language). Could someone give me a hint about where to look, please? I'm stumped. I'm retrieving them like this: <?php foreach (pages('parent=8888') as $item) { ?> <div> <div class="uk-card uk-card-default"> <?php if (count($item->images)) { $item_image = $item->images->getRandom(); ?> <div class="uk-card-media-top"> <figure> <img src="<?=$item_image->size(580, 384, ['quality' => 75])->url?>" title="<?=$item_image->description?>" alt="<?=$item_image->description?>"> <figcaption class="uk-text-meta uk-padding uk-padding-remove-vertical"><?=$item_image->caption?></figcaption> </figure> </div> <?php } ?> <div class="uk-card-body"> <h3 class="uk-card-title"><a href="<?=$item->url?>" title=""><?=$item->title?></a></h3> <p><?=$item->summary?></p> </div> </div> </div> <?php } ?>
The G Posted August 23, 2017 Posted August 23, 2017 OK, found the culprit, is the static variable $alreadyFormatted which is set to true at line 527 (module version 106): 525 public function formatExtraValue(HookEvent $event) { 526 if (!self::$alreadyFormatted) { 527 self::$alreadyFormatted = true; I don't know its purpose, but in my case (a loop retrieving captions for an image from every blog post) it stops the text formatter from processing any item after the first one. So I commented it out, I'll see if anything goes wrong.
justb3a Posted August 28, 2017 Author Posted August 28, 2017 @geedamed I took me some time but I figured out, what the problem might be. I found a fix, but I do not understand exactly why this is happening. So if anybody could explain this behaviour, feel free to share it I added the `already formatted` check because in some cases the formatter was called twice (which could break the output). Let's define `in some cases`: images are outputted on the same page as saved to it just counts for the first/one image field I compared the passed HookEvents. The only difference was that in the first argument, which contains the current Page object, the page title was missing. So I added a check whether the Page object does contain a title, otherwise skip the formatter. I tested different cases (multiple images, multiple image fields, output from another page and so on). Seems to work – or every extra field the formatter is only called once.
PWaddict Posted September 3, 2017 Posted September 3, 2017 Hi @justb3a I just found your module and I was wondering if you could add a cropping option field with all of it's values: northwest, north, northeast, west, center, east, southwest, south, southeast.
theo Posted September 4, 2017 Posted September 4, 2017 Very useful Module. Is there a way to hide / unpublish a single image temporarily instead of deleting (trashing) the entire image + information? A checkbox for this would be great. Thank you.
justb3a Posted September 6, 2017 Author Posted September 6, 2017 On 03/09/2017 at 11:43 PM, PWaddict said: Hi @justb3a I just found your module and I was wondering if you could add a cropping option field with all of it's values: northwest, north, northeast, west, center, east, southwest, south, southeast. @PWaddict: There is already a module for cropping images: CroppableImage3 On 04/09/2017 at 10:29 PM, theo said: Very useful Module. Is there a way to hide / unpublish a single image temporarily instead of deleting (trashing) the entire image + information? A checkbox for this would be great. Thank you. @theo: Actually the core/module do support it in a way that's not immediately obvious or as straightforward as checking a checkbox, but it's still quite useful and worthwhile when you need the capability. You could use tags or any other image extra field to achieve this. Edit any existing files/images field, or create a new one. When editing the field settings, check the box to enable “tags”, or create a new extra field named “hidden“ or something like that. In the “tags” or “hidden“ field for the image (which should be unpublished), enter a specific phrase like “hidden" (tags field) or “1“ (hidden field). Now you need to check if the file should be shown on the front-end of your site. Here's how you do that: // tag usage example if (!$image->hasTag('hidden')) echo "<img src='$image->url' alt=''>"; // extra field hidden example if (!$image->hidden) echo "<img src='$image->url' alt=''>"; You could also send a feature request to add this as a core feature (so you do not need to check manually whether the image is hidden and as an extra bonus the hidden images would be visible at first glance using opacity to indicate that). 1
PWaddict Posted September 6, 2017 Posted September 6, 2017 @justb3a Yep already using CroppableImage3 but it was acting weird and I was looking for alternatives but I don't think I will need them.
theo Posted September 6, 2017 Posted September 6, 2017 @justb3a: I had this idea before, but it is not really convenient for users (editors) and looks a bit "half-baked". I think this feature should really go into core, as you suggest. Thank you. Edit: Feature request: https://github.com/processwire/processwire-requests/issues/117 1
benbyf Posted October 3, 2017 Posted October 3, 2017 seem to be getting a number "1" added to the first custom field for some reason.
Kiwi Chris Posted October 19, 2017 Posted October 19, 2017 I'm having an issue with the module. When I add an additional field to an existing image field and try to edit the page I get an error like: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'field_headerImage.title' in 'field list' I get a similar but more verbose error on the frontend trying to view the page. Removing the additional field resumes normal behaviour for the page. I have other fields that I've added a title field to that work fine, so it's worked in the past, and image fields that already have custom fields have no problem, but I can't add more. I'm working with the latest build of PW (3.0.79)
justb3a Posted October 23, 2017 Author Posted October 23, 2017 On 17/02/2016 at 9:33 PM, justb3a said: Could you please try to rename the field so that it doesn't contain camelCase (capital letters)? For example field_backgroundImages to field_background_images. Have a look at the description: "Any combination of ASCII letters [a-z], numbers [0-9], or underscores (no dashes or spaces)." Please rename headerImage to header_image (or something like this) and try again.
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now