Jump to content
justb3a

Module: Image Extra

Recommended Posts

Sorry @justb3a - another small but critical bug for you. Everything was working fine on my PHP 7.1 local dev, but when I updated a live server running 5.4, the Image Extra fields weren't being inserted.

I have to replace this line: https://github.com/justb3a/processwire-imageextra/blob/master/ImageExtra.module#L1092

    $out = preg_replace('/(<input\sclass=\'InputfieldFileSort\')/', $this->escape_backreference($outAdditional) . '$1', $out);

with:

    $out = preg_replace('/(<input\sclass="InputfieldFileSort")/', $this->escape_backreference($outAdditional) . '$1', $out);

Notice the change: \' to "

Not sure if there have been some updates to PHP's regex engine between 5.4 and 7.1 that are causing this, but that is my guess.

Anyway, that change seems to fix things, but I didn't test the Description field because I have that disabled, so it might be worth checking all regexes. 

You can see here: https://regex101.com/r/0kTOmt/1 how that initial version fails, but this one: https://regex101.com/r/0kTOmt/2 works.

Hope that helps.

Share this post


Link to post
Share on other sites
7 hours ago, adrian said:

Notice the change: \' to "

I don't think that this has something to do with the change of the regex engine. The source code contains in one case single quotes in the other one double quotes. While writing the regex I thought about adding a check for double or single quotes - either way, the code now checks both occurrences, so it doesn't matter if the html contains single or double quotes. You can see it here: https://regex101.com/r/emj9Ie/1

  • Like 1

Share this post


Link to post
Share on other sites
15 minutes ago, justb3a said:

I don't think that this has something to do with the change of the regex engine. The source code contains in one case single quotes in the other one double quotes. While writing the regex I thought about adding a check for double or single quotes - either way, the code now checks both occurrences, so it doesn't matter if the html contains single or double quotes. You can see it here: https://regex101.com/r/emj9Ie/1

Yes, of course :) I was thrown off by it working on dev server but not live even though both had identical codebase and db content.

Thanks for the fix!

Share this post


Link to post
Share on other sites

@justb3a Thanks for the great modules. Just what I needed for my last project.

One thing I stumbled upon: I cannot delete text that has been inserted before. Since the existence of the input is a condition for outputting a caption or not it is necessary to have an empty field again.

Doesn't matter if placed inside a repeater or not.

Can you repoduce that, or do I miss something.

Thanks in advance!

  • Like 1

Share this post


Link to post
Share on other sites

You're right, somehow there was a missing equal sign :lol: Thanks for the feedback, please pull the latest version from Github!

  • Like 2

Share this post


Link to post
Share on other sites

Hello there! And thanks for a perfect module.

I have an interesting question. How can i programmatically set the values for multilanguage custom image fields? Tried several approaches, everything fails. Will appreciate any help. Thanks in advance!

Approach 1. Trying to switch current lang:

//...somethere inside a module...
$this->page->of(false);
$languageCurr = $this->user->language; //russian
$this->user->language = $this->languages->get("en");
//image retrievinig skipped
$image->title = 'an english title';
$image->save();
$this->user->language = $languageCurr;
$this->page->of(true);

Approach 2. Trying to use setLanguageValue():

$en = $this->languages->get("en");
$image->title->setLanguageValue($en,''an english title'') ; //gives error

Approach 3. Trying to use special names for needed field:

$this->page->of(false);
$image->title_en = 'an english title'; //not stored at fact
$this->page->of(true);

Thanks in advance!

Share this post


Link to post
Share on other sites

hi

from the API side you can set the values like this:

$page->setOutputFormatting(false);
$page->images->trackChange('title');
$img = $page->images->first(); // or whatever image you want
$img->title = 'Title in default language';
$img->title($languages->get('fi'), 'Title in Finish');
$img->title($languages->get('de'), 'Title in German');
$page->save();
$page->setOutputFormatting(true);

 

  • Like 4

Share this post


Link to post
Share on other sites

Thanks justb3a! Works like a charm.

Another tricky question. Let's suppose that i decided to fetch some images with language fields via Ajax request. The endpoint which receives that request is a Processwire page so all Processwire API functions are available. The data structure for each image is like this:

{"name":"dscXXXX.jpg","title":"A multi-language title","uid":"2aa1"}

The endpoint call may include something like ?uid=XXXX&lang=en , so the endpoint is language-aware and should return the title in the desired language.

Fetching image by uid is not a problem, but how to force our endpoint to fetch the multi-lang title for the desired language?

At the moment i found the only solution which is quite hacky. Let's suppose we have the "english" lang page id = 1000. So the data structure for the $image object will be like this:

...
title->'The title in default language',
title1000->'The title in english'
...

So i can get English title like this:

$title_en = $image->title1000;

Could You give me any advice how to fetch the multi-lang image field value for desired language in a less hacky way? Thanks in advance!

 

Share this post


Link to post
Share on other sites

This works pretty straight forward :)

echo $image->title($languages->get('en'));
// $image->title($languages->get($input->get('lang'));

 

  • Like 3

Share this post


Link to post
Share on other sites

Hi @Zeka, what do you exactly want to do?  A "Page reference" field references to another page, I'm not quite sure how this is related to image extra fields. 

Share this post


Link to post
Share on other sites
4 hours ago, justb3a said:

Hi @Zeka, what do you exactly want to do?  A "Page reference" field references to another page, I'm not quite sure how this is related to image extra fields. 

Hi @justb3a Sorry for being not clear enough. I want to extend image field by page reference field. But if I do so, I get just regular text field instead of page field. So it makes me thinking that your module works only with text-based fields and not with some more complicated.

 

Share this post


Link to post
Share on other sites

Ok, that is not possible. If you want to reference to another page, why not using the internal page link field (enable checkbox in field settings in Image Extra Tab)? This saves also a reference to a page, what do you do with that reference is up to you :) The only drawback: you can use it only once and it's not possible to define an entry point / parent page, so all pages will be listet. 

Share this post


Link to post
Share on other sites

Hello,

Thanks for your module; I read all the thread. Last year, it seems impossible to have some html in extra fields, does it works now? Anyway, if so, I'm unable, it always strip out my <a href[...]

Furthermore, I'm seems unable to add more than 1 textformatter, I can just choose one (and I'm not really sure it was applied).

Thanks

Mel

PW 3.0.51

Sélection_149.png

Share this post


Link to post
Share on other sites

@mel47 You can only apply one textformatter for a field.

Quote

.. it always strip out my <a href[...]

You're right, I'm using sanitizer textarea to sanitize the input values. And the default option – which will be provided to the textarea() sanitizer – is: 

// strip markup tags
'stripTags' => true,

Therefore all tags are gone. I updated the sanitizer usage and set this option to `false`.

Please update the module and try again! :)

  • Like 1

Share this post


Link to post
Share on other sites

@justb3a - what about using the "purify" sanitizer instead of "textarea". Not sure if it suits your needs, but thought I should mention it.

Share this post


Link to post
Share on other sites
19 hours ago, adrian said:

@justb3a - what about using the "purify" sanitizer instead of "textarea". Not sure if it suits your needs, but thought I should mention it.

You're completely right. Thanks for the hint, I'll change it. ^_^

`core/Sanitizer.php` function textarea:

/**
 * Sanitize input string as multi-line text without no HTML tags
 *
 * - This sanitizer is useful for user-submitted text from a plain-text `<textarea>` field, 
 *   or any other kind of string value that might have multiple-lines.
 * 
 * - Don't use this sanitizer for values where you want to allow HTML (like rich text fields). 
 *   For those values you should instead use the `$sanitizer->purify()` method. 
 [...]
 */

 

  • Like 1

Share this post


Link to post
Share on other sites

Hi @justb3a,

Do you think the extra field headings could be styled more like the Description label? This might be easier to do if it were a <label> element rather than <strong>. The difference between them looks a bit odd to me:

2017-02-20_143813.png.c5f07fd895566bb2a39bfbc7b74d06e2.png

Also, I'm not sure about this but it looks like the additional fields markup is not placed inside the "InputfieldImageEdit__additional" wrapper div. Is it meant to be?

2017-02-20_143858.png.5041cf6212c38bf8d9d9b230ccdda54d.png

 

Edit: one more thing...:)

What is the intention behind this part where the inputfield type is set based on whether or not a textformatter is applied? Is that meant to be a way to choose the type of inputfield you want? What if you would like a Text input but still want a textformatter applied? Maybe the choice between Text and Textarea could be a separate setting alongside the Textformatter dropdown in the table?

Share this post


Link to post
Share on other sites

Hi there,

Little stuck on something and have looked around.

I have used the image field extender module but when I'm outputting images in my gallery I want to check if there is a caption before I output the markup.

How would I go about this?

Thanks

 


echo "<li><img src='{$thumbnail1->url}' alt='{$image1->description}' /><p class='caption'><strong>{$image1->imagetitle}</strong> <em>{$image1->imagetext}</em> <span><br>{$image1->role}</span></p></li> ";

 

Share this post


Link to post
Share on other sites
15 hours ago, Jon E said:

I want to check if there is a caption before I output the markup

I think this can be done with a simple if statement.... Don't have the time to provide a snippet for you at the moment, I'm sorry.

Something like this:

if ($image->caption){
	//Output markup 1
}
else {
	//Output markup 2
}

 

Share this post


Link to post
Share on other sites

@Robin S Thanks for your feedback!

1. Label vs. Strong

I'm totally with you, semantically it should be a label but I had a reason why I wrapped it inside a strong tag:
If you have a multilingual installation, the label of the extra field is no longer the title of the field, it'll look something like this (core behaviour, I tried to stand as close as possible):

<div class="InputfieldImageEdit__core">
  <div class="hasLangTabs langTabsContainer">
    <div class="langTabs ui-tabs ui-widget ui-widget-content ui-corner-all">
      <ul class="ui-tabs-nav ui-helper-reset ui-helper-clearfix ui-widget-header ui-corner-all" role="tablist">
        ... <li>...</li> ... 
      </ul>
      <div class="InputfieldFileDescription LanguageSupport ui-tabs-panel ui-widget-content ui-corner-bottom" data-language="1010" id="langTab_images_34c8cc73419393a219a5cb218ebcc4b2__1010" aria-labelledby="ui-id-13" role="tabpanel" aria-expanded="true" aria-hidden="false">
        <label for="description_images_34c8cc73419393a219a5cb218ebcc4b2" class="detail LanguageSupportLabel">English</label>
        <input type="text" name="description_images_34c8cc73419393a219a5cb218ebcc4b2" id="description_images_34c8cc73419393a219a5cb218ebcc4b2" value="">
      </div>
      <div class="InputfieldFileDescription LanguageSupport ui-tabs-panel ui-widget-content ui-corner-bottom" data-language="1012" id="langTab_images_34c8cc73419393a219a5cb218ebcc4b2__1012" aria-labelledby="ui-id-14" role="tabpanel" aria-expanded="false" aria-hidden="true" style="display: none;">
        <label for="description1012_images_34c8cc73419393a219a5cb218ebcc4b2" class="detail LanguageSupportLabel">German</label>
        <input type="text" name="description1012_images_34c8cc73419393a219a5cb218ebcc4b2" id="description1012_images_34c8cc73419393a219a5cb218ebcc4b2" value="">
      </div>
    </div>
  </div>
</div>

For each language you'll have a label and input field wrapped inside a div tag. The label is the currently selected language.
If you haven't only the description field, it's important to mark the field with a title. I chose the `<strong>` tag because it looked the best comparing with headlines. I didn't want to add additional css or inline styles. 

labels.png.5c7a8252bbc150caa21595cfea168bfc.png

This is how it would look using h1-h4. The `h1` looks most similar to the label, but I don't want to use `h1`'s because semantically it doesn't make any sense at all.
One opportunity would be to use a `label` element if it isn't a multilingual site and a `strong` tag if it is one.  What do you think?

2. Wrapping

On 20/02/2017 at 2:42 AM, Robin S said:

Also, I'm not sure about this but it looks like the additional fields markup is not placed inside the "InputfieldImageEdit__additional" wrapper div. Is it meant to be?

You're right, I'll fix it.

3. type="text" vs textarea

At the moment as soon as a textformatter is applied, `type="text"` will be changed to `textarea`. The idea behind this was that some textformatter like "NewLineToBreak" or "NewLineToListItem" doesn't make that much sense applied to an one liner input element. This could be an additional setting, but I'm not quite sure if it's necessary. I tried to keep it as simple as possible ^_^

  • Like 2

Share this post


Link to post
Share on other sites

Update 2. Wrapping

Thanks! Having a look where this wrapper comes from, I found another hook which fits the module needs much better.

`<div class="InputfieldImageEdit__additional"></div>` is part of the core (wire/modules/Inputfield/InputfieldImage/InputfieldImage.module).

~/Projects/pw/wire
❯ ag __additional
modules/Inputfield/InputfieldImage/InputfieldImage.module
600: <div class='InputfieldImageEdit__additional'>$additional</div>
634: <div class='InputfieldImageEdit__additional'>$additional</div>

Having a further look, `$additional` comes from a hookable method which is just perfect for this module :) :)

$additional = $this->renderAdditionalFields($pagefile, $id, $n);

/**
 * Render any additional fields (for hooks)
 */
protected function ___renderAdditionalFields($pagefile, $id, $n) { }

Using this hook and rewriting a bit, the HTML looks now this way:

<div class="ImageData" style="width: 77%;">
  <h2 class="InputfieldImageEdit__name"><span contenteditable="true">align-left-2x</span>.png</h2>
  <span class="InputfieldImageEdit__info">143 bytes, 44×30 </span>
  <div class="InputfieldImageEdit__errors">..</div>
  <div class="InputfieldImageEdit__buttons">..</div>
  <div class="InputfieldImageEdit__core">..</div>
  <div class="InputfieldImageEdit__additional">
    <div class="InputfieldImageEdit__additional--custom">..</div>
    <div class="InputfieldImageEdit__additional--title">..</div>
    <div class="InputfieldImageEdit__additional--foo">..</div>
    <div class="InputfieldImageEdit__additional--orientation">..</div>
    <div class="InputfieldImageEdit__additional--link">..</div>
  </div>
  <input class="InputfieldFileSort" type="text" name="sort_images_34c8cc73419393a219a5cb218ebcc4b2" value="0">
  <input class="InputfieldFileReplace" type="hidden" name="replace_images_34c8cc73419393a219a5cb218ebcc4b2">
  <input class="InputfieldFileRename" type="hidden" name="rename_images_34c8cc73419393a219a5cb218ebcc4b2">
</div>

 

  • Like 2

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By Robin S
      Repeater Images
      Adds options to modify Repeater fields to make them convenient for "page-per-image" usage. Using a page-per-image approach allows for additional fields to be associated with each image, to record things such as photographer, date, license, links, etc.
      When Repeater Images is enabled for a Repeater field the module changes the appearance of the Repeater inputfield to be similar (but not identical) to an Images field. The collapsed view shows a thumbnail for each Repeater item, and items can be expanded for field editing.
      Screencast

      Installation
      Install the Repeater Images module.
      Setup
      Create an image field to use in the Repeater field. Recommended settings for the image field are "Maximum files allowed" set to 1 and "Formatted value" set to "Single item (null if empty)". Create a Repeater field. Add the image field to the Repeater. If you want additional fields in the Repeater create and add these also. Repeater Images configuration
      Tick the "Activate Repeater Images for this Repeater field" checkbox. In the "Image field within Repeater" dropdown select the single image field. You must save the Repeater field settings to see any newly added Image fields in the dropdown. Adjust the image thumbnail height if you want (unlike the core Images field there is no slider to change thumbnail height within Page Edit). Note: the depth option for Repeater fields is not compatible with the Repeater Images module.
      Image uploads feature
      There is a checkbox to activate image uploads. This feature allows users to quickly and easily add images to the Repeater Images field by uploading them to an adjacent "upload" field.
      To use this feature you must add the image field selected in the Repeater Images config to the template of the page containing the Repeater Images field - immediately above or below the Repeater Images field would be a good position.
      It's recommended to set the label for this field in template context to "Upload images" or similar, and set the visibility of the field to "Closed" so that it takes up less room when it's not being used. Note that when you drag images to a closed Images field it will automatically open. You don't need to worry about the "Maximum files allowed" setting because the Repeater Images module overrides this for the upload field.
      New Repeater items will be created from the images uploaded to the upload field when the page is saved. The user can add descriptions and tags to the images while they are still in the upload field and these will be retained in the Repeater items. Images are automatically deleted from the upload field when the page is saved.
      Tips
      The "Use accordion mode?" option in the Repeater field settings is useful for keeping the inputfield compact, with only one image item open for editing at a time. The "Repeater item labels" setting determines what is shown in the thumbnail overlay on hover. Example for an image field named "image": {image.basename} ({image.width}x{image.height})  
      https://github.com/Toutouwai/RepeaterImages
      https://modules.processwire.com/modules/repeater-images/
    • By EyeDentify
      Hello There Guys.

      I am in the process of getting into making my first modules for PW and i had a question for you PHP and PW gurus in here.

      I was wondering how i could use an external library, lets say TwitterOAuth in my PW module.
      Link to library
      https://twitteroauth.com/

      Would the code below be correct or how would i go about this:
      <?PHP namespace ProcessWire; /* load the TwitterOAuth library from my Module folder */ require "twitteroauth/autoload.php"; use Abraham\TwitterOAuth\TwitterOAuth; class EyeTwitter extends WireData,TwitterOAuth implements Module { /* vars */ protected $twConnection; /* extend parent TwitterOAuth contructor $connection = new TwitterOAuth(CONSUMER_KEY, CONSUMER_SECRET, $access_token, $access_token_secret); */ public function myTwitterConnection ($consumer_key, $consumer_secret, $access_token, $access_token_secret) { /* save the connection for use later */ $this->twConnection = TwitterOAuth::__construct($consumer_key, $consumer_secret, $access_token, $access_token_secret); } } ?> Am i on the right trail here or i am barking up the wrong tree?
      I don´t need a complete solution, i just wonder if i am including the external library the right way.
      If not, then give me a few hint´s and i will figure it out.

      Thanks a bunch.

      /EyeDentify
    • By dimitrios
      Hello,
      this module can publish content of a Processwire page on a Facebook page, triggered by saving the Processwire page.
      To set it up, configure the module with a Facebook app ID, secret and a Page ID. Following is additional configuration on Facebook for developers:
      Minimum Required Facebook App configuration:
      on Settings -> Basics, provide the App Domains, provide the Site URL, on Settings -> Advanced, set the API version (has been tested up to v3.3), add Product: Facebook Login, on Facebook Login -> Settings, set Client OAuth Login: Yes, set Web OAuth Login: Yes, set Enforce HTTPS: Yes, add "http://www.example.com/processwire/page/" to field Valid OAuth Redirect URIs. This module is configurable as follows:
      Templates: posts can take place only for pages with the defined templates. On/Off switch: specify a checkbox field that will not allow the post if checked. Specify a message and/or an image for the post.
      Usage
      edit the desired PW page and save; it will post right after the initial Facebook log in and permission granting. After that, an access token is kept.
       
      Download
      PW module directory: http://modules.processwire.com/modules/auto-fb-post/ Github: https://github.com/kastrind/AutoFbPost   Note: Facebook SDK for PHP is utilized.


    • By kongondo
      FieldtypeRuntimeMarkup and InputfieldRuntimeMarkup
       
      Modules Directory: http://modules.processwire.com/modules/fieldtype-runtime-markup/
      GitHub: https://github.com/kongondo/FieldtypeRuntimeMarkup
      As of 11 May 2019 ProcessWire versions earlier than 3.x are not supported
      This module allows for custom markup to be dynamically (PHP) generated and output within a page's edit screen (in Admin).
       
      The value for the fieldtype is generated at runtime. No data is saved in the database. The accompanying InputfieldRuntimeMarkup is only used to render/display the markup in the page edit screen.
       
      The field's value is accessible from the ProcessWire API in the frontend like any other field, i.e. it has access to $page and $pages.
       
      The module was commissioned/sponsored by @Valan. Although there's certainly other ways to achieve what this module does, it offers a dynamic and flexible alternative to generating your own markup in a page's edit screen whilst also allowing access to that markup in the frontend. Thanks Valan!
       
      Warning/Consideration
      Although access to ProcessWire's Fields' admin pages is only available to Superusers, this Fieldtype will evaluate and run the custom PHP Code entered and saved in the field's settings (Details tab). Utmost care should therefore be taken in making sure your code does not perform any CRUD operations!! (unless of course that's intentional) The value for this fieldtype is generated at runtime and thus no data is stored in the database. This means that you cannot directly query a RuntimeMarkup field from $pages->find(). Usage and API
       
      Backend
      Enter your custom PHP snippet in the Details tab of your field (it is RECOMMENDED though that you use wireRenderFile() instead. See example below). Your code can be as simple or as complicated as you want as long as in the end you return a value that is not an array or an object or anything other than a string/integer.
       
      FieldtypeRuntimeMarkup has access to $page (the current page being edited/viewed) and $pages. 
       
      A very simple example.
      return 'Hello'; Simple example.
      return $page->title; Simple example with markup.
      return '<h2>' . $page->title . '</h2>'; Another simple example with markup.
      $out = '<h1>hello '; $out .= $page->title; $out .= '</h1>'; return $out; A more advanced example.
      $p = $pages->get('/about-us/')->child('sort=random'); return '<p>' . $p->title . '</p>'; An even more complex example.
      $str =''; if($page->name == 'about-us') { $p = $page->children->last(); $str = "<h2><a href='{$p->url}'>{$p->title}</a></h2>"; } else { $str = "<h2><a href='{$page->url}'>{$page->title}</a></h2>"; } return $str; Rather than type your code directly in the Details tab of the field, it is highly recommended that you placed all your code in an external file and call that file using the core wireRenderFile() method. Taking this approach means you will be able to edit your code in your favourite text editor. It also means you will be able to type more text without having to scroll. Editing the file is also easier than editing the field. To use this approach, simply do:
      return wireRenderFile('name-of-file');// file will be in /site/templates/ If using ProcessWire 3.x, you will need to use namespace as follows:
      return ProcessWire\wireRenderFile('name-of-file'); How to access the value of RuntimeMarkup in the frontend (our field is called 'runtime_markup')
       
      Access the field on the current page (just like any other field)
      echo $page->runtime_markup; Access the field on another page
      echo $pages->get('/about-us/')->runtime_markup; Screenshots
       
      Backend
       

       

       
      Frontend
       

×
×
  • Create New...