Jump to content

Recommended Posts

Replace:

        $recipients = $this->wire('pages')->find($options['pages'])->children();

with:

        $recipients = $this->wire('pages')->get($options['pages'])->children();

You can't get the children of an array of pages. find() returns an array, get() returns a single page.

Also, since you have Tracy installed, please use bd() instead of print_r() and make your life a little easier :)

  • Like 1
Link to post
Share on other sites

All good now, thanks. 👍

I've got quite a bit more I want to do with this action like be able to use a PageTable field to be able to compose emails from a mix of existing pages and typed content, preview the email before sending, attach files uploaded to pages, and log email sends, but I think I'm probably better creating a new thread for that as it won't really be specific to your module, but more my limited coding abilities and inexperience working with the API.

Link to post
Share on other sites

I actually want a Repeater Matrix field, not PageTable. I'm trying to implement this now and have created a field in PW then gone to Export and copied the output and then pasted it into my action converting it from JSON to PHP format. Is that the right way to go about it? Or can I point the field in the action to an already existing field? Will I be able to use any fieldtype in an action?

Link to post
Share on other sites
1 minute ago, Tyssen said:

Will I be able to use any fieldtype in an action?

You can use any type of field directly, but if you have more questions, I think your hunch to start a new thread is probably a good idea - this isn't really AdminActions specific anymore.

Link to post
Share on other sites

How would you go about adding markup to an action outside a form field? For instance for an action I'm working on which sends emails, I'd like to be able to provide a button to preview the email in a modal window.

Would it be with addHookAfter and if so, would I be targetting the action's class::method or the module's?

Link to post
Share on other sites
1 hour ago, Tyssen said:

How would you go about adding markup to an action outside a form field? For instance for an action I'm working on which sends emails, I'd like to be able to provide a button to preview the email in a modal window.

Would it be with addHookAfter and if so, would I be targetting the action's class::method or the module's?

            array(
                'name' => 'markup',
                'label' => 'Markup',
                'description' => '',
                'notes' => '',
                'type' => 'markup',
                'value' => '<strong>Test Markup</strong>'
            ),

 

  • Like 1
Link to post
Share on other sites
  • 1 month later...

Hi @adrian,

I have a request for an enhancement to this module. I think it would be useful if the options form for an action was validated before executeAction() fires. So the required/requiredIf conditions are evaluated and executeAction() only fires if the form submission is successful.

At the moment executeAction() fires even when the required/requiredIf conditions are not met, which means you have to do extra validation inside executeAction() and that can get quite tricky with some requiredIf setups.

What do you think?

  • Like 1
Link to post
Share on other sites

I had a quick look and validating the form is straightforward. After the form input is processed... 

if(count($form->getErrors())) {
    // There were some form errors so do not proceed with action
}

But at this point we are already in executeExecute() because the action of the form is the execute URL segment, and the page headings are different in this method. Maybe it would be better if the action of the options form was options URL segment, and then if successful redirect to execute segment? Not sure, there are probably several different ways to handle it and I'm sure you'll know the best approach.

Link to post
Share on other sites

Hey Robin - thanks for thoughts - makes sense. I am heading on vacation this morning for a couple of weeks, but I'll add this to my list for when I'm back.

  • Like 2
Link to post
Share on other sites
  • 4 weeks later...
2 minutes ago, matjazp said:

May I say how handy is this module? Thx @adrian

Glad you like it - thanks for letting me 🙂

@Robin S - I haven't forgotten about your request for validation - just no time at the moment - sorry!

Link to post
Share on other sites

Hey @adrian

today I had to move one repeaterfield with several items into a repeaterfield inside another repeater matrix on another page. I thought I'll have a look at your admin actions module, but it seems it does not support such a special task. I came up with this solution:

// $page is the repeater matrix page (found by inspecting the repeater matrix item and looking for the id and then pasting this id manually in the page edit url
$page->of(false);
$page->quotes->removeAll();
$page->setAndSave('quotes', '');

// pages(123) is the page with the populated repeater
foreach(pages(123)->quotes as $old) {
    $quote = $page->quotes->getNew();
    $quote->title = $old->title;
    $quote->person = $old->person;
    $quote->body = $old->body;
    $quote->of(false);
    $quote->save();
    $quote->image->add($old->getUnformatted('image')->first()->filename);
    $quote->save();
    $page->quotes->add($quote);
    $page->save();
}

Not too complicated - I thought I share it if anybody else has the need. Not sure if that would make sense as an action in your module? Guess the need is VERY limited...

Thanks again for your great modules! In this case Admin Actions didn't do the job but with the help of tracy I moved the content within 10minutes 🙂

  • Like 2
Link to post
Share on other sites

Hey @bernhard - I think it could be a very useful action actually. These are the sorts of things that I come across fairly regularly and an action makes it so much easier. Would you like to create an action and submit a PR?

  • Like 1
Link to post
Share on other sites
On 6/1/2018 at 4:54 AM, matjazp said:

Ahm, any action module laying around that would recreate admin thumbnails 0x260 and delete the old ones?

The InputfieldImage::getAdminThumb() method with the "remove legacy thumbnail file" argument is what you want to use.

You'd loop over all the images in your site and call that method on each one. I think this will do the job...

$if_image = $this->modules->InputfieldImage;
foreach($fields->find('type=FieldtypeImage') as $field) {
    foreach($pages->find("{$field->name}.count>0") as $p) {
        foreach($p->getUnformatted($field->name) as $image) $if_image->getAdminThumb($image, false, true);
    }
}

 

  • Like 2
Link to post
Share on other sites
On 6/2/2018 at 7:10 PM, adrian said:

Hey @bernhard - I think it could be a very useful action actually. These are the sorts of things that I come across fairly regularly and an action makes it so much easier. Would you like to create an action and submit a PR?

Actually I think this should already work. Not enough time to test it, but it should work if you select the old page as source and the new page's repeater page as destination. Only tricky part is to find that page via the page tree - but the existing repeater-copy-action itself should work already.

Link to post
Share on other sites
On 6/4/2018 at 1:40 AM, Robin S said:

The InputfieldImage::getAdminThumb() method with the "remove legacy thumbnail file" argument is what you want to use.

You'd loop over all the images in your site and call that method on each one. I think this will do the job...

Created and sent action module to @adrian via PM if he would consider including it in Admin Actions module. Thanks @Robin S!

  • Like 2
Link to post
Share on other sites
4 minutes ago, matjazp said:
On 6/3/2018 at 4:40 PM, Robin S said:

 

Created and sent action module to @adrian via PM if he would consider including it in Admin Actions module.

Thanks and sorry for not getting back to you yet - crazy deadlines here at the moment. Will try to look at it early next week.

Link to post
Share on other sites
  • 2 weeks later...
On 6/21/2018 at 9:17 AM, adrian said:

Hey @Robin S - could you please try the latest version and let me know if it now handles errors how you need?

Yes, the handling of form errors is great now, thanks.

  • Like 1
Link to post
Share on other sites

@adrian I would really love to have the possibility to have "lock" and "un-lock" as well in the "Page Manipulator" action available.

In a certain PW-instance, I have dozens of pages that only act as attributes, which are used as categorization via page-references. I have used page-locks to disable editing these pages for non-superusers. Removing locks via Batch Child Editor is not possible, so I thought it was possible with your great module. But that option doesn't show up.

Could you consider adding this as well? Or do you see any security implications? The use of your module is (and always will) of course be strictly limited to super-users. But I think it would be really a great time-saver in some scenarios.

Link to post
Share on other sites
1 minute ago, dragan said:

I would really love to have the possibility to have "lock" and "un-lock" as well in the "Page Manipulator" action available.

I think it's probably too rare of a need to add to BatchChildEditor, but happy to have it in AdminActions. Just committed it to the latest version.

 

  • Like 2
  • Thanks 1
Link to post
Share on other sites

Awesome. Thank you!

I simply used now a few lines to do the same with Tracy. I guess we're getting spoiled with all the lovely tools and options here in PW land 🙂

  • Like 1
Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By monollonom
      (once again I was surprised to see a work of mine pop up in the newsletter, this time without even listing the module on PW modules website 😅. Thx @teppo !)
      Github: https://github.com/romaincazier/FieldtypeQRCode
      Modules directory: https://processwire.com/modules/fieldtype-qrcode/
      This is a simple module I made so a client could quickly grab a QR Code of the page's url in the admin.
      There's not much to it for now, but if need be you can output anything using a hook:
      $wire->addHookAfter("FieldtypeQRCode::getQRText", function($event) { $event->return = "Your custom text"; }) You can also output the QR code on your front-end by calling the field:
      echo $page->qr_code_field; The module uses the PHP library QR Code Generator by Kazuhiko Arase. When looking for a way to generate a QR Code in PW I came across @ryan's integration in his TFA module. I'm not very familiar with fieldtype/inputfield module development so I blindly followed @bernhard (great) tutorial and his BaseFieldtypeRuntime. At some point I'll take a deeper look to make a module on my own.
      Some ideas for improvements :
      add the ability to choose what to ouput : page's url / editUrl / file(s) / image(s) / ... allow to output multiple QR codes ?
    • By Chris Bennett
      https://github.com/chrisbennett-Bene/AdminThemeTweaker
      Inspired by @bernhard's excellent work on the new customisable LESS CSS getting rolled into the core soon, I thought I would offer up the module for beta testing, if it is of interest to anyone.

      It takes a different approach to admin styling, basically using the Cascade part of CSS to over-ride default UiKit values.
      Values are stored in ModuleConfig Module creates a separate AdminThemeTweaker Folder at root, so it can link to AdminThemeTweaker.php as CSS AdminThemeTweaker.php reads the module values, constructs the CSS variables then includes the CSS framework Can be switched on and off with a click. Uninstall removes everything, thanks to bernhard's wonderful remove dir & contents function.
      It won't touch your core. It won't care if stuff is upgraded. You won't need to compile anything and you don't need to touch CSS unless you want to.

      It won't do much at all apart from read some values from your module config, work out the right CSS variables to use (auto contrast based on selected backgrounds) and throw it on your screen.
      You can configure a lot of stuff, leave it as it comes (dark and curvy), change two main colors (background and content background) or delve deep to configure custom margins, height of mastheads, and all manner of silly stuff I never use.

      Have been developing it for somewhere around 2 years now. It has been (and will continue to be) constantly tweaked over that time, as I click on something and find something else to do.
      That said, it is pretty solid and has been in constant use as my sole Admin styling option for all of those 2 years.

      If nothing else, it would be great if it can provide any assistance to @bernhard or other contributor's who may be looking to solve some of the quirkier UiKit behavior.
      Has (in my opinion) more robust and predictable handling of hidden Inputfields, data-colwidths and showIf wrappers.
      I am very keen to help out with that stuff in any way I can, though LESS (and any css frameworks/tools basically) are not my go.
      I love CSS variables and banging-rocks-together, no-dependency CSS you can write with notepad.



       

    • By opalepatrick
      I see old posts saying that repeaters are not the way to go in Custom Process Modules. If that is the case, when using forms (as I am trying to do) how would one tackle things like repeat contact fields where there can be multiple requirements for contact details with different parameters? (Like point of contact, director, etc) or even telephone numbers that have different uses?
      Just for background I am creating a process module that allows me to create types of financial applications in the admin area (no need to publish any of this, pure admin) that require a lot of personal or company information.
      Maybe I am thinking about this incorrectly?
    • By HMCB
      I ran across a reference to IftRunner module. The post was 6 years ago. I cant find it in available modules. Has it been pulled?
    • By tcnet
      PageViewStatistic for ProcessWire is a module to log page visits of the CMS. The records including some basic information like IP-address, browser, operating system, requested page and originate page. Please note that this module doesn't claim to be the best or most accurate.
      Advantages
      One of the biggest advantage is that this module doesn't require any external service like Google Analytics or similar. You don't have to modify your templates either. There is also no Javascript or image required.
      Disadvantages
      There is only one disadvantage. This module doesn't record visits if the browser loads the page from its browser cache. To prevent the browser from loading the page from its cache, add the following meta tags to the header of your page:
      <meta http-equiv="Cache-Control" content="no-cache, no-store, must-revalidate" /> <meta http-equiv="Pragma" content="no-cache" /> <meta http-equiv="Expires" content="0" /> How to use
      The records can be accessed via the Setup-menu of the CMS backend. The first dropdown control changes the view mode.

      Detailed records
      View mode "Detailed records" shows all visits of the selected day individually with IP-address, browser, operating system, requested page and originate page. Click the update button to see new added records.

      Cached visitor records
      View modes other than "Detailed records" are cached visitor counts which will be collected on a daily basis from the detailed records. This procedure ensures a faster display even with a large number of data records. Another advantage is that the detailed records can be deleted while the cache remains. The cache can be updated manually or automatically in a specified time period. Multiple visits from the same IP address on the same day are counted as a single visitor.

      Upgrade from older versions
      Cached visitor counts is new in version 1.0.8. If you just upgraded from an older version you might expire a delay or even an error 500 if you display cached visitor counts. The reason for this is that the cache has to be created from the records. This can take longer if your database contains many records. Sometimes it might hit the maximally execution time. Don't worry about that and keep reloading the page until the cache is completely created.
      Special Feature
      PageViewStatistic for ProcessWire can record the time a visitor viewed the page. This feature is deactivated by default. To activate open the module configuration page and activate "Record view time". If activated you will find a new column "S." in the records which means the time of view in seconds. With every page request, a Javascript code is inserted directly after the <body> tag. Every time the visitor switches to another tab or closes the tab, this script reports the number of seconds the tab was visible. The initial page request is recorded only as a hyphen (-).

      Settings
      You can access the module settings by clicking the Configuration button at the bottom of the records page. The settings page is also available in the menu: Modules->Configure->ProcessPageViewStat.
      IP2Location
      This module uses the IP2Location database from: http://www.ip2location.com. This database is required to obtain the country from the IP address. IP2Location updates this database at the begin of every month. The settings of ProcessPageViewStat offers the ability to automatically download the database monthly. Please note, that automatically download will not work if your webspace doesn't allow allow_url_fopen.
      Dragscroll
      This module uses DragScroll. A JavaScript available from: http://github.com/asvd/dragscroll. Dragscroll adds the ability in view mode "Day" to drag the records horizontally with the mouse pointer.
      parseUserAgentStringClass
      This module uses the PHP class parseUserAgentStringClass available from: http://www.toms-world.org/blog/parseuseragentstring/. This class is required to filter out the browser type and operating system from the server request.
×
×
  • Create New...