tpr Posted August 30, 2016 Author Posted August 30, 2016 Fortunately I have a maximum of 1 dev site and 1 live, and I mostly work on the dev and merge changes. But I see your pain This is where your red-colored admin header will be of great help 1
tpr Posted August 30, 2016 Author Posted August 30, 2016 v054 is up. There were many updates under the hood so make sure to clear browser and module cache. module settings are exported to settings.php on uninstall and restored on install load admin.js and admin.css from /site/templates/ directory if exist new tweak "NavItems" (experimental): add pages to main nav or sidebar (depending on theme) HTML classes added by AOS are added by PHP instead JavaScript: faster and eliminates initial page jump so the loader is no longer needed loader removed added "cog" icon to footer to jump to AOS settings fix: keep sidebar menu colors for non-inline mode (Reno theme) module CSS classnames were abbreviated 2
netcarver Posted August 30, 2016 Posted August 30, 2016 You do realise that if you (and Adrian with Tracy) keep developing your modules at this rate, they will become sentient before I do. 4
tpr Posted August 31, 2016 Author Posted August 31, 2016 No, it's the other way: we just try to bring you the most of what the module is capable before you get sentient 2
bernhard Posted August 31, 2016 Posted August 31, 2016 hi tpr, short (maybe) bugreport: i think the field-name-tooltips do not get loaded when using ajax collapsed fields. can you confirm that?
tpr Posted August 31, 2016 Author Posted August 31, 2016 Yes, it fails because the labels aren't surrounded by span tags but can't figure out why. I'll try to find it out or solve this by Js.
adrian Posted August 31, 2016 Posted August 31, 2016 Here's another one: Seems to happen after a field has been collapsed. 1
tpr Posted August 31, 2016 Author Posted August 31, 2016 Yep, just discovered that, it's been fixed, thanks. Anyone knows why ajax-loaded fields doesn't allow modifying the label with Inputfield::render (or renderValue)? I can add link to the inputfield and other things too but this one doesn't work. Its value is set before thea ajax event runs, and of course it doesn't modify the existing label markup on the page. But where does it come from then? I could solve this issue with JS but it's not pretty.
Noboru Posted August 31, 2016 Posted August 31, 2016 Hi tpr, for me v054 gives an error just after updating: Parse error: syntax error, unexpected '.', expecting ',' or ';' in /Users/armin/Websites/pwreiter/site/assets/cache/FileCompiler/site/modules/AdminOnSteroids/AdminOnSteroids.module on line 23 I'm running on PW 3.0.32 in local environment (MAMP). I had no issues with past versions of AdminOnSteroids. 1
tpr Posted August 31, 2016 Author Posted August 31, 2016 Thanks, that was a PHP version syntax error which was fixed. v055 is up: module settings restore is optional (disabled by default) JS workaround for field edit links for ajax-loaded fields syntax error fix (thanks to TomasKostadinov) 1
gmclelland Posted August 31, 2016 Posted August 31, 2016 Just wanted to let you know that the sticky header isn't sticking for me with the latest 3.0.32 devns and the default theme. Seems like it started after I upgraded to 3.0.32. I'm also using the latest AOS. I have hard refresh the browser several times.
tpr Posted August 31, 2016 Author Posted August 31, 2016 I can't reproduce this. Have you tried clearing the module cache (at the bottom of the Modules page)? If that doesn't help, could you post the body and html classes your admin has?
gmclelland Posted August 31, 2016 Posted August 31, 2016 Strange. It still didn't work. I clicked the clear compiled files button at /admin/module/. I also did a module refresh. I'm using the latest Google Chrome on a mac. Here are my body classes when editing a page. id-10 template-admin hasWireTabs AdminThemeDefault ProcessPageEdit-id-1002 ProcessPageEdit-template-basic-page pw-ready InputfieldColumnWidthsInit
tpr Posted August 31, 2016 Author Posted August 31, 2016 Thanks - could you post the classes on the "html" tag? That would be more helpful.
gmclelland Posted August 31, 2016 Posted August 31, 2016 There isn't any classes on the html element. 1
tpr Posted August 31, 2016 Author Posted August 31, 2016 I was afraid of that Anyway, try v056, hopefully this is solved now. You should see classes appear on the html element.
gmclelland Posted August 31, 2016 Posted August 31, 2016 I just updated to v056 and here are my html element classes <html class=" headSticky HoverDropdown moduleCompact moduleModal" lang="en"> and <body class="id-10 template-admin hasWireTabs AdminThemeDefault ProcessPageEdit-id-1015 ProcessPageEdit-template-left-sidebar pw-ready InputfieldColumnWidthsInit"> So I have classes now, but the header still isn't sticking. Sorry... I'm trying to find the problem as well.
gmclelland Posted August 31, 2016 Posted August 31, 2016 The default theme is missing the "AdminThemeDefault" class on the html element. After I added that manually it worked.
gmclelland Posted August 31, 2016 Posted August 31, 2016 Actually I bet what is happening is the AOS css is targeting the html element when it should be targeting the body element on line 2166 of AdminOnSteriods.scss
gmclelland Posted August 31, 2016 Posted August 31, 2016 After reading the comment in the scss file // AdminTweaks (default theme tweaks) // note: the default theme adds theme name class only to body, AOS adds to html maybe AOS isn't adding the class "AdminThemeDefault" to the html element in the default admin theme in AdminOnSteriods.module line 243?
tpr Posted August 31, 2016 Author Posted August 31, 2016 It's intentional to use html.AdminThemeDefault (as you figured out already). What I don't get how your html classes doesn't contain 'AdminThemeDefault' because it should be added by AOS. echo wire('user')->admin_theme; This should echo "AdminThemeDefault", could you try it?
gmclelland Posted August 31, 2016 Posted August 31, 2016 I added that snippet to a template file, but it didn't output anything. I also have Tracy debugger and tried using the php console, but it didn't output anything either.
tpr Posted August 31, 2016 Author Posted August 31, 2016 No idea then atm... do you have other PW installation where you could check AOS? 1
szabesz Posted September 1, 2016 Posted September 1, 2016 8 hours ago, tpr said: What I don't get how your html classes doesn't contain 'AdminThemeDefault' because it should be added by AOS. I've just updated to 0.5.6, and I do get the AdminThemeReno class and the sticky header. 1
tpr Posted September 1, 2016 Author Posted September 1, 2016 Well it's the AdminThemeDefault class what's in question when using the default theme. 1
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now