Jump to content
Pete

Module: XML Sitemap

Recommended Posts

I updated my client's website with new version 1.0.5 of this module and my sitemap.xml doesn't work anymore, when I launch http://www.fmmhindusociety.com/sitemap.xml, it give me 404 error so I reverted back to version 1.0.3 which work as expected.

Hosting is on windows platform with godaddy, just for your info.

Share this post


Link to post
Share on other sites

Ah, I will have a look at it tomorrow again :(

Share this post


Link to post
Share on other sites
I updated my client's website with new version 1.0.5 of this module and my sitemap.xml doesn't work anymore, when I launch http://www.fmmhindusociety.com/sitemap.xml, it give me 404 error so I reverted back to version 1.0.3 which work as expected.

Hosting is on windows platform with godaddy, just for your info.

Have you LanguageLocalizedURL module installed? I guess not. I can't see where that 404 is coming from. I'm currently trying around and it works.

If you don't have language urls installed there's no need to update to 1.0.5 already. Sorry for the confusion I created here.

Share this post


Link to post
Share on other sites

Soma, I don't have LanguageLocalizedURL module installed. I already reverted to v1.0.3 which I had before.

Just wondering if I want to install latest & greatest XMLSitemap module then I need to have LanguageLocalizedURL module installed? correct? I think if its then probably Pete needs to update installation instructions with dependencies of other modules.

Share this post


Link to post
Share on other sites

No there is no dependencies it just looks if it is installed. Theres no other significant changes.

Share this post


Link to post
Share on other sites

Yeah its the 404 page. So no error.

The only thing I can imagine is that this code doesn't work for you and so since sitemap.xml isnt a page it shows 404 page. I don't know why it wouldn't work.

if (strpos($_SERVER['REQUEST_URI'],  '/sitemap.xml') !== FALSE) {
    $this->addHookAfter("Page::render",$this,"renderSitemap");
}

Share this post


Link to post
Share on other sites

This has now been bumped to 1.0.6 as I missed a change from Soma. Not sure if it will fix your issue though!

Share this post


Link to post
Share on other sites

Pete. There's a missing $langname = ''; #36, the sitemap won't work if debug mode enabled, as the markupcache uses $langname and throws a warning that will give a header already sent error.



SOmehow fmgujju seems another problem as if it shows a 404 page, which means the modules doesn't get executed at all or the most likely the init code strpos check doesn't hold true for some reason (the only I changed)

Share this post


Link to post
Share on other sites

Added and committed that line - thanks.

Yep - no idea what the 404 issue is as I compared the strpos and it should just work as far as I can tell.

Share this post


Link to post
Share on other sites

It's not working with v1.0.6 either. Because I have installed PW on windows platform that's why it may not be working.I have rollback to v1.0.3 again.

Share this post


Link to post
Share on other sites

Yep! it worked. Thank you so much Soma & Pete for your help!

Share this post


Link to post
Share on other sites

Merged pull request - thaks Soma.

Share this post


Link to post
Share on other sites

hi pete,

thanks for your module. just wanted to ask if there is a way to update the sitemap as the site evolves (i.e. new pages are added)?

best, christoph

Share this post


Link to post
Share on other sites

Just wanted to say big thanks for this module, pete!

Share this post


Link to post
Share on other sites

@totoff, it keeps the cache for an hour and then re-caches the entire sitemap so it does 24 updates a day to keep current on even the most active sites.

@Georgson - no problem!

  • Like 1

Share this post


Link to post
Share on other sites

Pete, just a heads-up that I sent you a pull request regarding Multisite support and a pile of other changes I thought were necessary/useful.. :)

Edit: as an afterthought, should probably have sent those as separate pull requests. Not familiar enough with GitHub yet. I hope there's some way to choose which commits you're willing to merge (if any.)

Also: didn't read this thread properly before making changes, so I've managed to miss all this 404-related stuff.

One of those commits would change hook from Page::render to ProcessPageView::pageNotFound, which shouldn't break anything (except that it changes slightly those cases where sitemap gets rendered, which was exactly my intention) but that might be slightly dangerous still. Works OK on those platforms where I've had the chance to test it, but that may not be good enough yet.

Edited by teppo
  • Like 1

Share this post


Link to post
Share on other sites

Hi there - 

I'm having a little trouble getting this to work. I'm getting the same error that was mentioned earlier, namely this:

Error: Exception: Unable to create path: /f5/thesharktankproducts/public/site/assets/cache/MarkupCache/MarkupSitemapXML/ (in /f5/thesharktankproducts/public/wire/core/CacheFile.php line 62)
 

My site/assets/cache folder's permissions are currently set to 777.

I also uninstalled Markup Cache and Markup XML, then reinstalled them (Cache first, and newest version of XML), with no luck.

I'm running PW 2.3.0.

I have what I think is the PW default site-map available here: http://thesharktankproducts.com/site-map/ but that's not readable by Google Webmaster Tools.

I would be very grateful for any insights. Thanks!

Share this post


Link to post
Share on other sites

Hi there - 

I'm having a little trouble getting this to work. I'm getting the same error that was mentioned earlier, namely this:

Error: Exception: Unable to create path: /f5/thesharktankproducts/public/site/assets/cache/MarkupCache/MarkupSitemapXML/ (in /f5/thesharktankproducts/public/wire/core/CacheFile.php line 62)
 

My site/assets/cache folder's permissions are currently set to 777.

I also uninstalled Markup Cache and Markup XML, then reinstalled them (Cache first, and newest version of XML), with no luck.

Just to make sure: does /site/assets/cache/MarkupCache/ directory exist and if it does, is it also writable (either 777 permissions or writable by web server?)

Share this post


Link to post
Share on other sites
Just to make sure: does /site/assets/cache/MarkupCache/ directory exist and if it does, is it also writable (either 777 permissions or writable by web server?)

Yes it exists and the permission is set to 777.

Not sure if this is helpful/relevant, but I only just migrated it from my local server to the host server last night. I just copied the files to the host server, and changed the config.php file to connect to the correct server. Is this possibly something that could be causing the error?

EDIT: Just checked the XML sitemap on my local install and it is working there.

Share this post


Link to post
Share on other sites

OK, so i also just discovered I am not able to upload images. I had Filezilla set all the directories in my site to 777 and tried again with no luck. This now seems like a separate issue. Something with my host I'm guessing.

I'll start a new thread. Sorry!

Share this post


Link to post
Share on other sites

I am getting the following error after attempting to access website.com/sitemap.xml

Running ProcessWire 2.3 on local machine.

post-609-0-41969500-1370888735_thumb.png

************

EDIT: I downloaded and replaced the *.module with the latest one from github, still error persists.

I'll uninstall in the meantime

:)

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By bernhard
      --- Please use RockFinder3 ---
    • By MoritzLost
      Cacheable Placeholders
      This module allows you to have pieces of dynamic content inside cached output. This aims to solve the common problem of having a mostly cacheable site, but with pieces of dynamic output here and there.  Consider this simple example, where you want to output a custom greeting to the current user:
      <h1>Good morning, <?= ucfirst($user->name) ?></h1> This snippet means you can't use the template cache (at least for logged-in users), because each user has a different name. Even if 99% of your output is static, you can only cache the pieces that you know won't include this personal greeting. A more common example would be CSRF tokens for HTML forms - those need to be unique by definition, so you can't cache the form wholesale.
      This module solves this problem by introducing cacheable placeholders - small placeholder tokens that get replaced during every request. The replacement is done inside a Page::render hook so it runs during every request, even if the response is served from the template cache. So you can use something like this:
      <h1>Good morning, {{{greeting}}}</h1> Replacement tokens are defined with a callback function that produces the appropriate output and added to the module through a simple hook:
      // site/ready.php wire()->addHookAfter('CachePlaceholders::getTokens', function (HookEvent $e) { $tokens = $e->return; $tokens['greeting'] = [ 'callback' => function (array $tokenData) { return ucfirst(wire('user')->name); } ]; $e->return = $tokens; }); Tokens can also include parameters that are parsed and passed to the callback function. There are more fully annotated examples and step-by-step instructions in the README on Github!
      Features
      A simple and fast token parser that calls the appropriate callback and runs automatically. Tokens may include multiple named or positional parameters, as well as multi-value parameters. A manual mode that allows you to replace tokens in custom pieces of cached content (useful if you're using the $cache API). Some built-in tokens for common use-cases: CSRF-Tokens, replacing values from superglobals and producing random hexadecimal strings. The token format is completely customizable, all delimiters can be changed to avoid collisions with existing tag parsers or template languages. Links
      Github Repository & documentation Module directory (pending approval) If you are interested in learning more, the README is very extensive, with more usage examples, code samples and usage instructions!
    • By Craig
      I've been using Fathom Analytics for a while now and on a growing number of sites, so thought it was about time there was a PW module for it.
      WayFathomAnalytics
      WayFathomAnalytics is a group of modules which will allow you to view your Fathom Analytics dashboard in the PW admin panel and (optionally) automatically add and configure the tracking code on front-end pages.
      Links
      GitHub Readme & documentation Download Zip Modules directory Module settings screenshot What is Fathom Analytics?
      Fathom Analytics is a simple, privacy-focused website analytics tool for bloggers and businesses.

      Stop scrolling through pages of reports and collecting gobs of personal data about your visitors, both of which you probably don't need. Fathom is a simple and private website analytics platform that lets you focus on what's important: your business.
      Privacy focused Fast-loading dashboards, all data is on a single screen Easy to get what you need, no training required Unlimited email reports Private or public dashboard sharing Cookie notices not required (it doesn't use cookies or collect personal data) Displays: top content, top referrers, top goals and more
    • By daniels
      This is a lightweight alternative to other newsletter & newsletter-subscription modules.
      You can find the Module in the Modules directory and on Github
      It can subscribe, update, unsubscribe & delete a user in a list in Mailchimp with MailChimp API 3.0. It does not provide any forms or validation, so you can feel free to use your own. To protect your users, it does not save any user data in logs or sends them to an admin.
      This module fits your needs if you...
      ...use Mailchimp as your newsletter / email-automation tool ...want to let users subscribe to your newsletter on your website ...want to use your own form, validation and messages (with or without the wire forms) ...don't want any personal user data saved in any way in your ProcessWire environment (cf. EU data regulation terms) ...like to subscribe, update, unsubscribe or delete users to/from different lists ...like the Mailchimp UI for creating / sending / reviewing email campaigns *I have only tested it with PHP 7.x so far, so use on owners risk
      EDIT:
      Since 0.0.4, instructions and changelog can be found in the README only. You can find it here  🙂
      If you have questions or like to contribute, just post a reply or create an issue or pr on github, thanks!
    • By MoritzLost
      Sorry for the convoluted title. I have a problem with Process modules that define a custom page using the page key through getModuleInfo (as demonstrated in this excellent tutorial by @bernhard). Those pages are created automatically when the module is installed. The problem is that the title of the page only gets set in the current language. That's not a problem if the current language (language of the superuser who is installing the module) is the default language; if it isn't, the Process page is missing a title in the default language. This has the very awkward effect that a user using the backend in the default language (or any other language) will see an empty entry in the setup menu:

      This screenshot comes from my Cache Control module which includes a Process page. Now I realize the description sounds obscure, but for us it's a common setup: We a multiple bilingual sites where the default language is German and the second language is English. While the clients use the CMS in German, as a developer I prefer the English interface, so whenever I install a Process module I get this problem.
      As a module author, is there a way to handle this situation? I guess it would be possible to use post-installation hooks or create the pages manually, but I very much prefer the declarative approach. The page title is already translatable (through the __ function), but of course at the time of installation there is no translation, and as far as I'm aware it's not possible to ship translations with a module so they are used automatically. Could this situation be handled better in the core? I would prefer if the module installation process would always set the title of the Process page in the default language, instead of the language of the current user.
×
×
  • Create New...