Ivan Gretsky Posted August 2, 2017 Share Posted August 2, 2017 Just read your comment here and found out AOS now has some profound documentation. You're a monster, @tpr! The wiki is awesome! I saw it and said to myself: "Ha, but he probably does not have changelog!" But I was wrong (and astonished)! I think the main PW repo could benefit from a CHANGELOG.md like this. Especially that there are enough of nice changes to be mentioned almost every week. Sorry for offtop)) 3 Link to comment Share on other sites More sharing options...
szabesz Posted August 14, 2017 Share Posted August 14, 2017 Hi @tpr Has this been reported yet? FileFieldTweaks icons cover the trash icon making it "impossible" (for a client...) to delete. Turning off the options temporarily fixed the delete issue, but the download icon is a good feature, we are missing it... Link to comment Share on other sites More sharing options...
tpr Posted August 14, 2017 Author Share Posted August 14, 2017 Yep, several times though the download icons was not harmed at all Update to v151 to fix. 1 Link to comment Share on other sites More sharing options...
szabesz Posted August 15, 2017 Share Posted August 15, 2017 Thanks for the quick update! I didn't even had time to blink 1 Link to comment Share on other sites More sharing options...
Macrura Posted August 17, 2017 Share Posted August 17, 2017 On 8/14/2017 at 6:24 PM, tpr said: Yep, several times though the download icons was not harmed at all Update to v151 to fix. speaking of download icons – there is a (probably not used much, but nonetheless awesome) module called Secure File - for that module, the download button doesn't work, i guess AOS is not compatible with that module; I disabled the "Add Asset Download Button", since that module already provides a download link for the file. Just wanted to post that here in case someone else uses secure file and comes across the non-working download (if they have AOS add asset download enabled)... 2 Link to comment Share on other sites More sharing options...
adrian Posted August 28, 2017 Share Posted August 28, 2017 @tpr - nice job on the AddNewChildFirst functionality - very cool! A couple of minor things: 1) This sentence needs the "of" added: "Add new page as first child instead of last" 2) There are several locations where the PW file compiler is causing problems in your text, eg: This is due to this bug: https://github.com/processwire/processwire-issues/issues/98 I have come across this in my own modules and I just end up re-wording things to avoid parentheses near PW variable names, but of course it would be great if this could be fixed properly, but I don't think it's high on Ryan's priorities. 1 Link to comment Share on other sites More sharing options...
adrian Posted August 28, 2017 Share Posted August 28, 2017 Actually just found an easy solution for these, eg: replace: Shortcuts to templates and fields(SuperUser only) with: Shortcuts to templates and fields (SuperUser only) Note that it has to be a - an ordinary space won't work. Link to comment Share on other sites More sharing options...
tpr Posted August 28, 2017 Author Share Posted August 28, 2017 Thanks @adrian, I haven't came across these issues, good to know. The AddNewChildFirst submodule works pretty neat, thanks for your contributions in this topic - I only collected all the goodies from there 2 Link to comment Share on other sites More sharing options...
szabesz Posted August 29, 2017 Share Posted August 29, 2017 Is it just me who has strange looking AdminDataTable filter box in AOS 1.5.2? See: I tried different browsers in incognito/private browsing but it stays like that The label introduced is not too useful btw, it takes up space however most users can recognize a filter box these days. 1 Link to comment Share on other sites More sharing options...
Juergen Posted August 29, 2017 Share Posted August 29, 2017 @szabesz I can confirm this behaviour. 1 Link to comment Share on other sites More sharing options...
tpr Posted August 29, 2017 Author Share Posted August 29, 2017 Thanks, that's coming from the latest PR I merged yesterday, will fix soon. 1 Link to comment Share on other sites More sharing options...
szabesz Posted September 3, 2017 Share Posted September 3, 2017 Hi @tpr I'm having a real pita issue when AOS is enabled. In the screen capture when the mouse pointer stops I single click as well. Whenever I click into the editor the content moves. I could have clicked on the toolbar items too, as it jumps back to its proper position in that case too: [image removed] The moving content of the editor makes it hard to edit things. I tried disabling all CKE plugins I had turned on in the AOS settings but that did not make any difference. I can only get rid of this behavior if I disable AOS. Unluckily this glitch is not present all the time, making it time consuming to test it. Sometimes the content jumps, other times it does not. I could not see a pattern in this, looks like it is randomly happening. I also tried without the custom editor css I use but did not help either, it happens without that one too. Has anyone ever seen this? Link to comment Share on other sites More sharing options...
tpr Posted September 4, 2017 Author Share Posted September 4, 2017 This is the "Sticky CKE toolbar" feature located in the RenoTweaks. I'm also using it and most of the ime it works fine but sometimes there's a jump when the toolbar goes to fixed position and its height is changing. There's a "Fixed" CKEditor plugin that never worked well for me (even with the fix in their forums) so I revisited this again today and found a nice and easy solution using position:sticky. This works in latest browsers only but I think it's still better than the current one - no hacky JS/CSS, and works with multiple editors too. I'll upload this new version soon, until that you can uncheck this feature. 2 Link to comment Share on other sites More sharing options...
szabesz Posted September 5, 2017 Share Posted September 5, 2017 Thanks for the fix and the explanation. Link to comment Share on other sites More sharing options...
tpr Posted September 5, 2017 Author Share Posted September 5, 2017 v1.5.4 is available with the fixed sticky CKE toolbar and some other fixes. 1 Link to comment Share on other sites More sharing options...
dotnetic Posted September 7, 2017 Share Posted September 7, 2017 Hi @tpr. Do you know how to set another theme for Codemirror? If I use it, my HTML source code becomes unreadable of the theme (which seems to be moono-lisa). Link to comment Share on other sites More sharing options...
tpr Posted September 7, 2017 Author Share Posted September 7, 2017 Check this: https://github.com/rolandtoth/AdminOnSteroids/issues/25 1 Link to comment Share on other sites More sharing options...
tpr Posted September 18, 2017 Author Share Posted September 18, 2017 v1.5.7 is up, containing the Trash pagelist action for non-SuperUsers too (from Robin S), with an inline confirm feature: 4 Link to comment Share on other sites More sharing options...
szabesz Posted September 18, 2017 Share Posted September 18, 2017 2 hours ago, tpr said: v1.5.7 is up, containing the Trash pagelist action for non-SuperUsers too (from Robin S), with an inline confirm feature: Who-hoooo, I've been dreaming of this! Thank you very much, Sir! 1 1 Link to comment Share on other sites More sharing options...
szabesz Posted September 19, 2017 Share Posted September 19, 2017 Hi @tpr Tiny issue today which was "discovered" by me long time ago, I just did not find the time to post it... Do you happen to have Forgot Password module installed? Button centering is missing here: Link to comment Share on other sites More sharing options...
tpr Posted September 19, 2017 Author Share Posted September 19, 2017 I saw this once but I was lazy to make the adjustments will do later 1 Link to comment Share on other sites More sharing options...
Mike Rockett Posted September 20, 2017 Share Posted September 20, 2017 Hi @tpr - there also seems to be an issue with the Reno tweaks. When guest is using Reno, for the login, and I've turned on the fixed header, the "Login" header is offset by the width of the sidebar, which does not exist on the login screen, so it just has an empty space to the left. Link to comment Share on other sites More sharing options...
tpr Posted September 20, 2017 Author Share Posted September 20, 2017 Are you using the latest version? A similar bug was fixed there and I can't reproduce. If it still exists, could you send a screenshot of your RenoTweaks? And is "Center login form" (under Misc) checked? Link to comment Share on other sites More sharing options...
SiWhitt Posted September 20, 2017 Share Posted September 20, 2017 I'm using PW 3.0.62 and the latest (1.5.7) version of AOS, and I get this error message when I try and go to the Users page – Error: Using $this when not in object context (line 722 of /var/www/xxx/modules/AdminOnSteroids/AdminOnSteroids.module) Link to comment Share on other sites More sharing options...
Mike Rockett Posted September 20, 2017 Share Posted September 20, 2017 10 hours ago, tpr said: Are you using the latest version? A similar bug was fixed there and I can't reproduce. If it still exists, could you send a screenshot of your RenoTweaks? And is "Center login form" (under Misc) checked? Ah, you're quite right - was one of my sites that hasn't upgraded yet (missed it!). Thanks 1 Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now