szabesz

Ok, I've tested it, deprecated is colored green, looks great. I just do not know what to ask the Nette devs for. My limited knowledge of Tracy Debugger is restricted to Adrian's module, which is configurable extensively while core Tarcy does not seem to be configurable at all: https://tracy.nette.org/en/guide However, the idea is that Adrian's module should provide settings for separating "low level of importance" and "high level of importance" (what should these be called, btw?). So what should be the feature request to the Nette devs in the first place?

I will first check what Adrian shared, next, I will gather my thoughts and share them with you guys so that I can present something convincing...

Yes, that was the issue. Some time ago I added some a template code based "sort url" logic to the home page using URL segments, so that was it when the RSS feed stopped working. Now I am wondering how else I should go about implementing "short urls", something like this: example.com/xyz-promotion Do you think that I can use this https://github.com/apeisa/ProcessRedirects/releases for such a thing? I've never seen/used this module before, that's why I'm asking.

Wait, this might be the issue, I go and check it....

$this->input->get is empty in init()so the hook never gets added. What should I check next?

I see :) looks like I do not dare touching certain buttons :)

Thanks Adrian, I was really just brainstorming here but will surely test what you've done. Do you have any idea whether the Nette devs like filing feature request as "issues" or not?

Thanks Teppo, all your answers are very helpful! I will track my feature request at GitHub, thanks for creating them. BTW, did you know that there is a Discussion feature of GitHub so that requests and ideas do not have to "pollute" the "issues"? Maybe you like remembering request by using issues, I do not know, I just wanted to point out this possibility. Regarding ProDafts, thanks for the hints, first me and my client need to discuss if she can make use of ProDafts in the first place, and if so, then I can at least tell her that I will probably be able to setup the two modules in a way that can support their workflow. As for the Public RSS feed, I will look into it today following your tips, thanks for that too! (Sidenote: on other sites the feed works fine, only this one and only site which fails for some reason.)

Hello @teppo, me again :) Ok, instead of asking I should peek under the hood: So yeah, we just need to manually edit the query string. Still, my client should be able to do it too, but she will never edit a query string for sure. That is just too alien to her. So could you please add it as a configurable option to the module settings page? The site in question has no extensive log but changes are made weeks and months apart, and my client would like to track them this way. I tested it manually and adding "field" makes no difference for us. Regarding the RSS link leading to 404, I still have no idea what to check. Maybe you have? As for the above, it would be easier and "safer" to ass an "open all/collapse all" button somewhere so that all "more/less" event can be performed in one go. What do you think? And one more question: have you ever used Changelog and ProDafts alongside? Do they work together? We are planning to purchase ProDafts but it would be great to know how these modules can be useful when run on the same site. For example, Changelog should only record ProDafts changes published by ProDafts and not "temporary: changes not yet published by ProDafts. This is because as long as we work with drafts, ProDafts shows the changes anyway, but as son as those changes are published, Changelog track what fields were published, therefore actually changed. I hope it makes sense.

@horst I did not mean your "request" belongs to that category but I was probaly not that clear about that, sorry....

Well, since there is no "just a five minute task" – even though our clients often firmly believe in such a thing –, I have not yet wanted to turn this idea into a feature request but I would be happy to hear Adrien's reply. The last time I checked what PHP error level constants exist there were fewer than currently, so as the language evolves, these constants evolve too. Which means there are differences between PHP versions in this regards as well, so dealing with error level constant differences might mean some extra effort on Adrian's part, I guess.

Thanks Horst! The thing is, Tracy Debugger does deal with all "errors" for us, so it might be a better idea to ask @adrian to take special care of deprecated (and maybe warning) messages so that they do not show up in Tracy's debug bar as "errors", highlighted with red labels. Maybe Tracy could maintain two "bags", I mean sets of php error messages for us, one for low level of importance and one for high level of importance, and each set could show up in the debug bar under its own "label". High level of importance errors should be red as currently, while the low level of importance "errors" could be under a green label. On the Tracy settings page we could configure what goes where, and a sensible default would be set for us, of course. So whenever I see some "green error" messages in Tracy and its log, I know that currently there is nothing urgent to check out, but if I want to, all the messages are there for me to examine.

Thanks Horst for looking into it. If it is a library, then it is a library :) I do not think that any in release version of a library/framework a developer should leave in their code anything spitting out messages no matter what the error reporting settings are. It is because users of libs are interested in their own code issues as well, and suppressing messages is counter-productive. Let's imagine a lib that spits out loads of messages and I have to find among them the ones that were the results of my own code. I sometimes run into this issue with other libs/framework and it is not fun at all. Suppressing the messages does not solve the issue during development so it makes development less fun. Anyway, since PHP 7.4 is history in 9 months and this issue is not a big deal and the best you/we could do is to "complain" to the dev, I can sure live with it. Thanks for you contribution and the module! I always use it in production.

https://github.com/horst-n/WireMailSmtp/issues/14 "I" get them too, in php 7.4 In php 7.4 get_magic_quotes_runtime() is deprecated but still exists, so function_exists("get_magic_quotes_runtime") has no effect to stop the deprication message from appearing. https://www.php.net/manual/en/function.get-magic-quotes-runtime.php "REMOVED as of PHP 8.0.0." so function_exists("get_magic_quotes_runtime") bit works as expected in PHP 8 and up.

And I forgot to ask about the "filtering results by edited field" feature. I see it being mentioned in the changelog but how can one use it? I need to deal with a relatively small log, but still too long for clicking around so it shoud work in my case, I guess. I also wonder why we can't see the edited field's name listed in the "What" column. Currently, I have to click on "more" just to see what was edited, but the What column would have a lot of room for this bit of information on my 2k monitor, and even on my laptop screen there is enough room for field names.

Hello @teppo For some reason, on a site running Changelog the public RSS gets redirected to PW's 404 page. Any I idea how I should troubleshoot this? I do not know where to look. Thanks in advance!

You can't do it in those files, use init.php instead, as opposed to _init.php. The latter is just a convention and often used like this: /** * _init.php initializes variables output in _main.php * * This file is automatically prepended to all template files as a result of: * $config->prependTemplateFile = '_init.php'; in /site/config.php. * * Automatic inclusion for any given template can be disabled: * in admin: Setup > Templates > [some-template] -> "Files" tab -> "Disable automatic prepend file". */ In config.php the user is not yet known, as it runs before PW populates the $user and other API variables.

Hello @pmx, welcome to the PW forums Personally I prefer using Markup Regions, as that method produces easy to read template code: Official docs: https://processwire.com/docs/front-end/output/markup-regions/ My cheat sheet: https://processwire.com/talk/topic/23641-markup-regions-pw-vs-data-pw-different-behavior/#comment-201538 Good example on the basics: https://processwire.com/talk/topic/23641-markup-regions-pw-vs-data-pw-different-behavior/?do=findComment&comment=201505 How to debug Markup Regions tip: https://processwire.com/talk/topic/24398-markup-regions-template-strategy-is-this-normal/?do=findComment&comment=206568 As an advanced technique, it is even possible to hook into the rendering process but you probably won't need it: https://processwire.com/talk/topic/21852-markup-regions-in-hooks/?do=findComment&comment=208104 I hope this helps.

I do not think any of us asked for nor even thought of something like that.

+1 Well, we all know that Ryan is not interested in attracting hordes of developers to ProcessWire, and I agree, as I also prefer quality over quantity. However, making sure he keeps the current community he already has is vital to ProcessWire. If his standpoint is something like "Guys, I am not much interested in what you think is one of the most important things in order not to loose you by turning you towards other systems, but I am here to help to make mods to the core when you need them." than that approach will hurt ProcessWire, I think.

Sure, I did it a few times but clients always have to pay the price :) Just kidding... Yes, it can sometimes be a real issue for sure. Anyway, I work solo and my projects/clients are somewhat "special" and most of the time clients just rely on all my decisions. Still, thanks for your insights! You have clearly explained your motivations which are more than reasonable, I think. I would be more than happy to join a crowd funding initiative if YOU were the one to lead it, but first someone needs to make Ryan firmly believe he also needs this... Sounds impossible, but never say never.

I was explaining the very same needs above, I think. I think we can all agree that this would be dead useful. Ryan does the same but manually, as he enjoys redoing manual clicking work in production. While I can imagine that it can be fun for him, I always avoid this, as it is boring to do it IMHO. That is why I make changes to templates/fields in production, clone the db to local afterwards, and work in code in local staging. When all is ok, I just need to apply the code changes to production because the production db is already up-to-date in the first place. While it works for a one man show, starts to be an issue for a team. Still, even a solo developer would be better off if our feature request could become reality one day.

Personally, I'm not after versioning, I have never ever reverted back my code/database to any previous state, anyway, as I only sometimes copy some useful lines from a few hours ago and that's it. I painstakingly test all what I implement, so in the end there is no need to revert to anything. What I am after is being able to edit templates/fields in the admin on my local machine and when I am done (and has already thoroughly tested all my work), I would like to push all the changes to the production site with a single click. That's it.

I firmly believe that Ryan should be the one to do it, even thought he does not (yet) need it for some reason. I would only be willing to add money to the "pool" if he is the one who implements AND maintains it. So why don't we just pledge that we collect the amount he asks for its initial development and ask him to do it? New features for ProDevTools perhaps?

That would be great! Please also make it "FormBuilder friendly" becasue - just as you suggested – it makes perfect sense.