Jump to content
horst

CroppableImage

Recommended Posts

This is on the ToDo already. But we ("we" == "Martijn" in this case) haven't had time to rebuild the UI of the editor. It is still how it was in Thumbnails just with the two selects for quality and sharpening added.

Share this post


Link to post
Share on other sites

Hi Horst

I'm running CroppableImage on 2.5.17 for the first time.

I've created a field Type of CroppableImage and set Input Type to CroppableImage too.

When I set the Image name and dimensions in Crop Settings, I get the following error

Table 'brfsel_prowire.field_Supply_Partner_Logo' doesn't exist SELECT pages_id,count(pages_id) FROM field_Supply_Partner_Logo GROUP BY pages_id ORDER BY pages_id

Share this post


Link to post
Share on other sites

Table 'brfsel_prowire.field_Supply_Partner_Logo' doesn't exist SELECT pages_id,count(pages_id) FROM field_Supply_Partner_Logo GROUP BY pages_id ORDER BY pages_id

I looked at my database and there was no field called Supply_Partner_Logo

But there was a supply_partner_logo (lower case). Having updated the field name to lower case, I can now see the Crop button.

Share this post


Link to post
Share on other sites

Hi Peter, thanks for reporting that.

I have looked into that, but it seems it is related to PW core, not croppableimages fields in special, or maybe I have to transform the fieldname to lowercase at some point in the modules code.

  • I have created a new field of type text and given it a capitalized name: My_New_Field
  • The table was created as: field_my_new_field
  • In the fields table it is registered with name = My_New_Field

I will further test it with core images field and others and look how it is handled there.

So, when creating a new field you can read in the description of the Name* input:

Any combination of ASCII letters [a-z], numbers [0-9], or underscores (no dashes or spaces).

But one can enter uppercase letters. Is this intended or should it be sanitized by PW to a-z_0-9 ?

Share this post


Link to post
Share on other sites

But one can enter uppercase letters. Is this intended or should it be sanitized by PW to a-z_0-9 ?

I use a mix of upper and lowercase for my field names. I should really settle on lowercase, I guess.

  • Like 1

Share this post


Link to post
Share on other sites

Thank you for this great module. So far ik works very well.

One little thing  I noticed is that in the modules log file with every page load (site not admin) it writes the line:

2015-02-05 16:21:06 ? ? Saved module 'FieldtypeCroppableImage' config data.

The logfile contains more than 12000 lines since I installed the module 5 days ago (2.5.16 dev)

If you want more info I'll be happy to help you

Alfred

  • Like 1

Share this post


Link to post
Share on other sites

@Alfred: OMG! I will have a look to this very soon. Also I already know where I have to look at first, I believe. I will come back to this ASAP with a result or with further questions.

Thank you.

Share this post


Link to post
Share on other sites

@Alfred: Now I can confirm that this is a new behave from PW. With PW 2.5.11 I have not have this messages in modules.txt, but after updating to version 2.5.17 I get this too. You said you run PW 2.5.16, so it is something between 2.5.12 and 2.5.16. I remember that there were many changes with the notifier and log functions in PW, so I will post an issue at Github to tell Ryan about it.

Edited by horst
added link to Github
  • Like 3

Share this post


Link to post
Share on other sites

This one is fixed now:

The PW $config with recent dev versions now contains or can contain a variable logs:

/*** 9. MISC ************************************************************************************/

/**
 * Additional core logs
 * 
 * All activities from the API functions corresponding with the given log names will be logged. 
 * Options that can be specified are: pages, fields, templates, modules
 * 
 * @var array
 * 
 */
$config->logs = array(
	'modules',
);

Per default it is set to include "modules".

I have changed the croppableimage module to suppress loggin if this is enabled. If you use it with a recent dev version please update: https://github.com/horst-n/CroppableImage

And I have tested it with PHP 5.3 and it works, so the requirements are updated too.

  • Like 6

Share this post


Link to post
Share on other sites

Hi Horst,

I'm having an issue when I upload an image (I'm running PW 2.5.18) which doesn't give me the initial crop. Instead I get a scaled down version of the full image. If I attempt to make a crop I get a larger version of the crop I just made.

Edit: When I rolled my install back to 2.5.17 it functioned correctly again.

Screen-Shot-2015-02-09-12-54-28.png

Share this post


Link to post
Share on other sites

One thing when cropping to large sizes (eg 1000px or so), then on hover preview won't fit on the screen - perhaps it can be displayed at a smaller size when it is greater than a certain percentage of the viewport size? 

Sorry in a rush, but if this doesn't make sense, please let me know.

  • Like 1

Share this post


Link to post
Share on other sites

@Adrian: Makes sense and I hear you. 

Have been sick for a looong time but feeling a little bit better after a week of antibiotics. This week I'll dive in your 'issue'.

Share this post


Link to post
Share on other sites

Thanks Martijn - hope you're feeling much better soon.

I have another issue for you:

Notice: Undefined property: CroppableImageKeepCoords::$cropH in/site/modules/ProcessCroppableImage/classes/CroppableImageKeepCoords.class.php on line 93

  • Like 1

Share this post


Link to post
Share on other sites

On a roll today - looks like there is a permission issue when using a croppable image field in the system user template. When the field has been added to "What fields can a user edit in their own profile?" at /module/edit?name=ProcessProfile then the user gets a blank page.

Thanks guys!

Share this post


Link to post
Share on other sites

@adrian I'm cropping to a smaller size (200,200). Plus, the cropped image displayed at a larger size (2x) when viewed on the front-end too. On 2.5.17 it doesn't behave like this.

Share this post


Link to post
Share on other sites

There were changes from Ryan to the core image field with the commits to PW 2.5.18. I need to look to this but am not able before tommorow evening.

@adrian: have put it on my todo.

@martijn: regarding your PM, I try to add this within the init method from InputfieldCroppableImage.

  • Like 2

Share this post


Link to post
Share on other sites

We've also experienced serious performance issues since the 2.5.18 update. It looks like crops aren't cached anymore but beeing generated on every visit. Also processing in general is painfully slow (wasn't the case with 2.5.17).

Share this post


Link to post
Share on other sites

This is not directly an issue with this module, but I would like for users to be able to upload and crop their profile pictures. Ryan talks about the HTML uploader being disabled for profile editing (https://processwire.com/talk/topic/5644-images-in-user-profile/?p=60172), but I honestly think this needs to change as this is a common need on sites.

Do you guys have any thoughts on how "we" can make croppable image work properly on an image field in the user template when a user is editing their profile?

Share this post


Link to post
Share on other sites

Hi Horst, like Felix I've been running into serious performance issues when using 2.5.18. I'll try rolling back a version - am sure you're already aware of this. Thanks.

Share this post


Link to post
Share on other sites

We've also experienced serious performance issues since the 2.5.18 update. It looks like crops aren't cached anymore but beeing generated on every visit. Also processing in general is painfully slow (wasn't the case with 2.5.17).

Same here...

Any reason why the thumbnail suffix is different then the original Thumbnail module. I'm using 2.5.19 atm and instead of rolling back a version I'm using now

$imgUrl = 'site/assets/files/'.$pageId.'/'.$basename.'.-small'.$extension;

if, in my case, 'small' was added before the $basename, no hassle with extension stuff... 

I confirm Marty Walker, it's OK for me, for the moment I set half the thumbnail size I actually want to use :-)

Overall... I'm very happy with this module... 

Share this post


Link to post
Share on other sites

Hey, regarding the serious performance issues, can you please tell a bit more about what it is what you have done etc?

  • Is it in the Backend with displaying the items in the Inputfield,
  • or is it in the Frontend
  • or is it on Uploading
  • or with the CropEditor?

I have installed the PW 2.5.19 and run some tests where I cannot see differences between PW 2.5.11. So, I don't have had PW 2.5.18 at hand.

Please can someone confirm that the performance issues consists with PW 2.5.19 and explain a bit more detailed what the issues are. (reproducable!)

Caching of the cropvariations does work as expected here.

Edited by horst

Share this post


Link to post
Share on other sites

Notice: Undefined property: CroppableImageKeepCoords::$cropH in/site/modules/ProcessCroppableImage/classes/CroppableImageKeepCoords.class.php on line 93

@adrian: this is a bit weird. I cannot think of any possibility how you got this.

In the __construct() it is explicitly set, at least it get populated with null. And there is no code in the whole class where it is unset. So, after initiating the class, it is set. The function where the notice came from isn't a static one, so ...? Can you reproduce it?

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By jploch
      Hey folks,
      for a module (a pagebuilder based on PageTable) I need to save some settings as JSON. The values are saved for each page table item (a pw page). It's working well, but I am looking for ways to improve the structure I have. As I'm not that experienced with JSON, maybe someone more experienced can take a look and tell me if my approach is good practice. 

      My goal is to make all the items accessible by page id, without looping over them (using objects instead of arrays):
      // access from template with pw page var $jsonObject->items->{$page}->cssClass; Her is an example of my JSON structure:
      { "items": { "3252": { "id": "3252", "cssClass": "pgrid-main", "breakpoints": { "base": { "css": { "grid-column-end": "auto", "grid-row-end": "auto", "grid-column-start": "auto", "grid-row-start": "auto", "align-self": "auto", "z-index": "auto", "padding-left": "60px", "padding-right": "60px", "padding-top": "60px", "padding-bottom": "60px", "background-color": "rgb(255, 255, 255)", "color": "rgb(0, 0, 0)" }, "size": "@media (min-width: 576px)", "name": "base" } } }, "3686": { "id": "3686", "cssClass": "test_global", "breakpoints": { "base": { "css": { "grid-column-end": "-1", "grid-row-end": "span 1", "grid-column-start": "1", "grid-row-start": "auto", "align-self": "auto", "z-index": "auto", "padding-left": "0px", "padding-right": "0px", "padding-top": "0px", "padding-bottom": "0px", "background-color": "rgba(0, 0, 0, 0)", "color": "rgb(0, 0, 0)" }, "size": "@media (min-width: 576px)", "name": "base" } } }, "3687": { "id": "3687", "cssClass": "block_editor-3687", "breakpoints": { "base": { "css": { "grid-column-end": "span 2", "grid-row-end": "span 1", "grid-column-start": "auto", "grid-row-start": "auto", "align-self": "auto", "z-index": "auto", "padding-left": "0px", "padding-right": "0px", "padding-top": "0px", "padding-bottom": "0px", "background-color": "rgba(0, 0, 0, 0)", "color": "rgb(0, 0, 0)" }, "size": "@media (min-width: 576px)", "name": "base" } } }, "3696": { "id": "3696", "cssClass": "block_editor-3696", "breakpoints": { "base": { "css": { "grid-column-end": "span 2", "grid-row-end": "span 1", "grid-column-start": "auto", "grid-row-start": "auto", "align-self": "auto", "z-index": "auto", "padding-left": "0px", "padding-right": "0px", "padding-top": "0px", "padding-bottom": "0px", "background-color": "rgba(0, 0, 0, 0)", "color": "rgb(0, 0, 0)" }, "size": "@media (min-width: 576px)", "name": "base" } } } }, "breakpointActive": "base", "breakpointActiveSize": "@media (min-width: 576px)" }  
    • By jploch
      Fieldtype Page Table Grid
      This is a sneak preview of a side project I've been working on for quite some time now. A lot of work and thought has gone into this, so I will most likely release this as a commercial module at some point in the near future. 

      As a designer (and developer) I get the appeal of a WYSIWYG editor. After playing around with some WYSIWYG page builder tools, I always felt something was wrong about them. So I decided to build my own PW version based on PageTable.

      Here is a small demo (using AdminThemeCanvas, but its working with other admin themes as well) :
      There is also a complete website that I built for a friend of mine using this module and some custom blocks.
      Concept
      This fieldtype shares a lot of features with PageTableExtended: it's also an extension of PageTable and renders the block templates in the backend and frontend (native PW templates and fields). You can also add your own css via module settings.
      The difference is, this fieldtype also gives you the ability to rearrange and resize elements in a visual way as well as enable inline editing for text, ckeditor and file fields. Similar (and promising) attempts have been made, but I wanted something based on native CSS grid instead of a CSS framework...so I built my own version. Most CSS frameworks are based on flexbox, which is great for layouting elements horizontally. With CSS grid, you can place elements horizontally and vertically, allowing for layouts that were not previously possible with CSS. Similar to webflow, this fieldtype uses javascript (in the backend) to let you manipulate CSS grid in a visual way to design fully responsive websites (or parts of them). It should still be possible to include a CSS framework if you like (just add the classes to your block markup and include the CSS via module settings).
      The CSS grid layout manipulations are saved in a single field as a JSON array and used to generate a dynamic stylesheet that you simply include in your main template (no inline styles). The styles are saved within the breakpoint you select and cascade down to smaller breakpoints. That means you can specify just the basic breakpoint and adjust other breakpoints if needed. The exception is the mobile breakpoint which will display everything in one column as a default (you can change the layout here too).
      The fieldtype also comes with an optional style panel to manipulate some additional CSS properties directly on the page. You can customize the panel or disable it completely from the module settings (and just use a CSS file that you include via module settings). The style panel is based on inputfields (nothing is saved to the database). This means that you just have to install the module and all fields are available to all blocks automatically (this can be customized). It also has the benefit that your installation is not flooded with fields; this module only installs one field.
      Don't want to give your customer all that power? Design features can be disabled for certain roles. The grid editor role can just edit the content and use the inline editing feature to edit content quickly. You can then also grant access individually to the style panel, resize or drag functionality.
      Features
      Blocks are just pages Blocks are defined by native PW templates and fields Manipulate CSS grid in a visual way to design fully responsive websites (or parts of them) Design features can be disabled for certain roles Inline editing of text, ckeditor and file fields The layout is 100% CSS grid (very small css file size) Simply drag and resize to manipulate grid items directly inside the backend Manipulate grid columns and rows directly on the page (use any number of columns you want) All style manipulations are saved as JSON and used to generate a dynamic stylesheet that you just include in your main template (no inline styles) Nested groups/grids (child pages of nested blocks are created under group parent) Global blocks work with page reference field (changes on one page, changes all blocks on all pages) Manual and auto placement of grid items Define custom icons for your blocks via native template settings (template -> advanced -> icon) Option to load lazysizes in the backend to enable lazy loading of assets with class lazyload Works with all default and ui-kit based admin themes If you have any questions or feedback, let me know.
    • By bernhard
      I built this module because I needed a versatile solution to replace tags and simple if-blocks in some E-Mails and PDF documents.
      If you only need to replace static tags (no if-conditions), then you can use default PW api and need no module:
      $str = "My favourite color is {color}."; $texttools = $sanitizer->getTextTools(); echo $texttools->populatePlaceholders($str, ['color' => 'red']); // output: My favourite color is red. Usage:
      See the two example Files in the folder /replacements

       
      Methods:
      replacementsTable()
      Renders an overview of all available replacements (see the example in the Module's config file:
       
      Create new Replacements:
      Simply copy the sample file and adopt to your needs.
       
      Download:
      https://gitlab.com/baumrock/RockReplacer
    • By bernhard
      DEPRECATED
      I'm using this module in several projects, but it will likely not see any updates in the future. I'm not happy with it and I'm looking for ways to develop better solutions. RockTabulator was my first try, but I'm also not 100% happy with that. The tabulator library is great, but my module implementation is not. I hope to get a good solution soon, but it will be a lot of work...
      ---
      Some of you might have followed the development of this module here: https://processwire.com/talk/topic/15524-previewdiscussion-rockdatatables/ . It is the successor of "RockDataTables" and requires RockFinder to get the data for the grid easily and efficiently. It uses the open source part of agGrid for grid rendering.
       
      WHY?
      ProcessWire is awesome for creating all kinds of custom backend applications, but where it is not so awesome in my opinion is when it comes to listing this data. Of course we have the built in page lister and we have ListerPro, but none of that solutions is capable of properly displaying large amounts of data, for example lists of revenues, aggregations, quick and easy sorts by the user, instant filter and those kind of features. RockGrid to the rescue 😉 
       
      Features/Highlights:
      100k+ rows Instant (client side) filter, search, sort (different sort based on data type, eg "lower/greater than" for numbers, "contains" for strings) extendable via plugins (available plugins at the moment: fullscreen, csv export, reload, batch-processing of data, column sum/statistics, row selection) all the agGrid features (cell renderers, cell styling, pagination, column grouping etc) vanilla javascript, backend and frontend support (though not all plugins are working on the frontend yet and I don't plan to support it as long as I don't need it myself)  
      Limitations:
      While there is an option to retrieve data via AJAX the actual processing of the grid (displaying, filtering, sorting) is done on the client side, meaning that you can get into troubles when handling really large datasets of several thousands of rows. agGrid should be one of the most performant grid options in the world (see the official example page with a 100k row example) and does a lot to prevent problems (such as virtual row rendering), but you should always have this limitation in mind as this is a major difference to the available lister options that do not have this limitation.
      Currently it only supports AdminThemeUikit and I don't plan to support any other admin theme.
       
      Download: https://gitlab.com/baumrock/FieldtypeRockGrid
      Installation: https://gitlab.com/baumrock/RockGrid/wikis/Installation
      Quikckstart: https://gitlab.com/baumrock/RockGrid/wikis/quickstart
      Further instructions: https://gitlab.com/baumrock/RockGrid/wikis/quickstart#further-instructions
      German Translation File: site--modules--fieldtyperockgrid--fieldtyperockgrid-module-php.json
      Changelog: https://gitlab.com/baumrock/FieldtypeRockGrid/raw/master/changelog.md
       
      Module status: alpha, License: MIT
      Note that every installation and uninstallation sends an anonymous google analytics event to my google analytics account. If you don't want that feel free to remove the appropriate lines of code before installation/uninstallation.
       
      Contribute:
      You can contribute to the development of this and other modules or just say thank you by
      testing, reporting issues and making PRs at gitlab liking this post buying me a drink: paypal.me/baumrock/5 liking my facebook page: facebook.com/baumrock hiring me for pw work: baumrock.com  
      Support: Please note that this module might not be as easy and plug&play as many other modules. It needs a good understanding of agGrid (and JavaScript in general) and it likely needs some looks into the code to get all the options. Please understand that I can not provide free support for every request here in the forum. I try to answer all questions that might also help others or that might improve the module but for individual requests I offer paid support (please contact me via PM).
       
      Use Cases / Examples:
      Colored grid cells, Icons, Links etc. The Grid also has a "batcher" feature built in that helps communicating with the server via AJAX and managing resource intensive tasks in batches:

      Filters, PW panel links and instant reload on panel close:

      You can combine the grid with a chart library like I did with the (outdated) RockDataTables module:

    • By Paul Greinke
      Hi there. I wrote a custom module for one of my projects. In fact I maybe want to use my module in other projects too. In order to be variable and customizable  I need to implement some custom hooks into my module. So I can afterwards hook into the my functions in order to modify them to match the needs of the new project.
      I tried simply defining functions with the '__' prefix. But that did not work. I'm imagining something like the following:
      <?php class MyClass { public function ___someFunction() { // Do something } } // ready.php $this->addHookBefore('MyClass::someFunction', function($event) { // some customization }); Is there a way to accomplish that? 
×
×
  • Create New...