Jump to content

Recommended Posts

27 minutes ago, dragan said:

@Ben Sayers I'm by no means an expert on hooks, but I usually put hooks in ready.php, not init.php.

Hi Dragan, I'm not sure if it matters, but I use the beginner profile, I don't see a ready.php file - I only see that file in the Default or Regular profiles. 

Share this post


Link to post
Share on other sites
11 hours ago, Ben Sayers said:

I don't understand why the Jumplinks work with any page that doesn't contain "blog/".

Edit: I had the file named incorrectly (/site/_init.php) so I removed the underscore in the name and now I can see the dump is working but only for URLs that don't have "blog/" in them and I'm not redirected to the blog landing page, I get a 404. If I try a link with "blog/" in it, I see the blog landing page but the URL is still the old one instead of domain.com/blog/.

I have no experience with the blog module(s), but if a hook method attached to ProcessPageView::pageNotFound doesn't get executed at all for /blog/ URLs, this likely means one of two things: either there's no 404 exception when the user visits those URLs (i.e. the template of the page at /blog/ has URL segments enabled, but it isn't throwing 404 exception when a non-existing URL segment is accessed), or the module itself has some hook that prevents this from working.

The first option seems more likely to me, but again I don't have any experience with this module, so can't say for sure. This could also be by design, so maybe @kongondo could step in and see if he has an idea about what's going on here? 🙂

  • Like 1

Share this post


Link to post
Share on other sites
43 minutes ago, teppo said:

This could also be by design, so maybe @kongondo could step in and see if he has an idea about what's going on here? 🙂

 

43 minutes ago, teppo said:

module itself has some hook that prevents this from working.

Blog has only one hook, used in the backend, limited to save of a single blog post (addHookAfter) to set its blog published date (@note: this is NOT the PW published field but the blog pages date field)

 

43 minutes ago, teppo said:

(i.e. the template of the page at /blog/ has URL segments enabled, but it isn't throwing 404 exception when a non-existing URL segment is accessed),

The following blog templates have URL segments enabled:

  1. Blog Archives (blog-archives) [virtual parent of blog archives; virtual since no real children; works becaue of URL Segments]
  2. Blog Authors (blog-authors) [virtual parent of blog authors; can also display multiple authors]
  3. Blog Comments (List) (blog-comments) [virtual parent of blog comments; can also display multiple comments]
  4. Blog Posts (blog-posts) [parent of posts; can also display all posts]
  5. Blog Tag (blog-tag) [a single blog tag]

Cross-reference

 

Edited by kongondo
  • Like 1

Share this post


Link to post
Share on other sites

@teppo, @Ben Sayers,

Given my conversation with Ben in the blog module forum and given the correction made therein (?what?) and given Teppo's suspicion of URL Segments, I now wonder whether Ben's issue has to do with the term 'blog' at all. I suspect it is the 'posts' in the URL Segment since the posts templates utilises URL Segments as I listed above.

Edit: for clarification, Ben's correct address to the blog posts, is, f.ex. domain.com/blog/posts/some-post/ 

Edited by kongondo

Share this post


Link to post
Share on other sites
1 hour ago, kongondo said:

Given my conversation with Ben in the blog module forum and given the correction made therein (?what?) and given Teppo's suspicion of URL Segments, I now wonder whether Ben's issue has to do with the term 'blog' at all. I suspect it is the 'posts' in the URL Segment since the posts templates utilises URL Segments as I listed above.

Edit: for clarification, Ben's correct address to the blog posts, is, f.ex. domain.com/blog/posts/some-post/ 

My apologies for the confusion, Kongondo. I updated the post format in my original post on this forum. So if my issue is indeed related to the 'posts' URL segment, do you (or anyone else) have any idea how to resolve it? All suggestions are welcome, I've been fiddling with this for almost two weeks, lol.

Edit: I can confirm that it is the "posts" part of the URL that is causing the issue, I tried redirecting "blog/test/" and it redirected just fine but "blog/posts/test/" does not.

Edited by kongondo
Further explanation of issue

Share this post


Link to post
Share on other sites
1 hour ago, Ben Sayers said:

I can confirm that it is the "posts" part

I edited this to read "posts" NOT "post" to avoid further confusion 😃.

1 hour ago, Ben Sayers said:

do you (or anyone else) have any idea how to resolve it?

I think the key is in what @teppo stated above:

On 10/27/2019 at 8:42 AM, teppo said:

if a hook method attached to ProcessPageView::pageNotFound doesn't get executed at all for /blog/ URLs, this likely means one of two things: either there's no 404 exception when the user visits those URLs (i.e. the template of the page at /blog/ has URL segments enabled, but it isn't throwing 404 exception when a non-existing URL segment is accessed)

Your blog-posts template (file) is not throwing a 404 exception for the missing (deleted) posts. I am not sure whether manually throwing a 404 will resolved the issue but I am sure the other guys will have better knowledge of this. Meanwhile, please show us the contents of your blog-posts template file.

Edited by kongondo

Share this post


Link to post
Share on other sites
34 minutes ago, kongondo said:

Meanwhile, please show us the contents of your blog-posts template file.

Sure thing, here is my 'blog-posts' template file, it's identical to my 'blog' template file. 

<?php namespace ProcessWire;
	
  include('./_head.php'); // include header markup ?>
  
  <!-- Page title -->
  <section id="page-title">
    <div class="container-fluid">
      <div class="page-title">
        <?php echo "<h1>" . $page->get('headline|title') . "</h1>";?>
      </div>
      <div class="breadcrumb">
		<?php
		echo "<ul>";
		$parents = $page->parents;
		foreach($parents as $parent) {
			$url = $parent->url;
			echo "<li><a href='$url'>{$parent->title}</a></li>\n";
		}
		// show current / "we are here" page as well, but not as link: (last element)
		echo "<li>{$page->title}</li>\n";
		echo "</ul>"; ?>
      </div>
    </div>
  </section>
  <!-- end: Page title --> 
  
  <!-- Content -->
  <section id="page-content">
    <div class="container-fluid"> 
      <!-- post content --> 
	  <?php
		// Change options for pagination
		$options = array(
		  'numPageLinks' => 5,
		  'listMarkup' => "<ul class='pagination justify-content-center'>{out}</ul>",
		  'itemMarkup' => "<li class='page-item {class}'>{out}</li>",
		  'linkMarkup' => '<a href="{url}" class="page-link">{out}</a>',
		  'currentItemClass' => 'active',
		  'separatorItemLabel' => '...',
		  'separatorItemClass' => 'page-link',
		  'currentLinkMarkup' => '<a href="{url}" class="page-link">{out}</a>',
		  'nextItemLabel' => '<i class="fa fa-angle-right"></i>',
		  'nextItemClass' => '',
		  'previousItemLabel' => '<i class="fa fa-angle-left"></i>',
		  'previousItemClass' => '',
		  'lastItemClass' => '',
		);	
		$blogposts = $pages->find("template=blog-post, sort=-blog_date, limit=9");
		setlocale(LC_ALL,"en_US.UTF8");
		$pagination = $blogposts->renderPager($options);
	  ?>
      <?php if(count($blogposts)): ?>
      <!-- Blog -->
      <div id="blog" class="grid-layout post-3-columns m-b-30" data-item="post-item">
		  <?php
			foreach ($blogposts as $b) {
				if(count($b->blog_images)) {
					$firstimage = $b->blog_images->first();
					$thumb = $firstimage->width(640);
				}
				echo "<div class='post-item'>
				  <div class='post-item-wrap border shadow'>";
				if(count($b->blog_images)) {
				echo "<div class='post-image'><a href='{$b->url}'><img alt='{$b->title}' src='{$thumb->url}'></a></div>";}
				echo "<div class='post-item-description'> <span class='post-meta-date'><i class='fa fa-calendar-alt'></i>{$b->blog_date}</span> <span class='post-meta-comments'><a href='{$b->blog_author->url}'><i class='fa fa-user-circle'></i>{$b->blog_author->title}</a></span>
					  <h2><a href='{$b->url}'>{$b->title}</a></h2>
					  <p>{$b->summary}</p>
					  <a href='{$b->url}' class='item-link'>Read More <i class='fa fa-arrow-right'></i></a>
					</div>
				  </div>
				</div>";
			}			
		  ?>		  
      </div>
      <!-- end: Blog --> 
      <?php echo $pagination; ?>
	  <?php endif; ?>
      
    </div>
    <!-- end: post content --> 
    
  </section>
  <!-- end: Content --> 
  
	<?php include('./_foot.php'); // include footer markup ?>	

 

Share this post


Link to post
Share on other sites
On 10/25/2019 at 8:54 PM, Mike Rockett said:

@adrian Page identifiers were never intended to be used as part of a destination. These identifiers use the full, absolute URL of the page being identified. Perhaps destination selectors could come in handy here? Haven't ever tried it this way before, but I imagine redirecting subscribe/{all} to [[1495]]{all} (or [[1495]]/{all}} if trailing slashes are turned off) would work. Anything inside the square braces is passed to pages->get and replaced with page->url, which is why I believe this will work.

Thanks @Mike Rockett - using the page ID like that does work. This was the combo I needed:

image.png.2ff18b17783e740f4e3f7b656f50c502.png

Note that the first one showing "sign-up/" is from the selected page, not manually entered. With this, all seems to work as expected.

  • Like 1

Share this post


Link to post
Share on other sites

@Mike Rockett - I've come across an issue with the way that Jumplinks sanitizes the URL. I have partners linking in to the site with campaign info in the query string, but Jumplinks is removing the "?" so that:

mysite.com/subscribe/partner/?utm=123

becomes:

mysite.com/sign-up/partner/-utm-123 

which of course looks like a second urlsegment to PW and therefore breaks things.

Any chance of revising the sanitizer that makes that change please?

Share this post


Link to post
Share on other sites

@adrian I wonder if database->escape_string is playing a role here? I think I'm doing it differently in JL2, but that's nowhere near done in terms of a frontend. 🙈

Scratch that, it's being used in the importer. Long day I tell you

Share this post


Link to post
Share on other sites
6 minutes ago, Mike Rockett said:

Hey @adrian Super odd, that. Will take a look.

Thanks very much - let me know if you have any trouble reproducing.

Share this post


Link to post
Share on other sites
3 minutes ago, Mike Rockett said:

@adrian I wonder if database->escape_string is playing a role here? I think I'm doing it differently in JL2, but that's nowhere near done in terms of a frontend. 🙈

I just removed all those calls and it doesn't seem to be coming from them as it didn't help.

Actually, those calls only seem to be in the import from csv logic, so I don't think they are relevant at all, are they?

Share this post


Link to post
Share on other sites
3 minutes ago, adrian said:

Thanks very much - let me know if you have any trouble reproducing.

Going to have to spin this up and see what's going on. Mind sharing your source/destination with me?

Just now, adrian said:

I just removed all those calls and it doesn't seem to be coming from them as it didn't help.

Sorry, I edited that post as you were replying

  • Like 1

Share this post


Link to post
Share on other sites

Source: subscribe/{all}
Destination: [[1495]]{all}

Share this post


Link to post
Share on other sites
4 minutes ago, adrian said:

Source: subscribe/{all}
Destination: [[1495]]{all}

Ah of course - didn't click that it would be the same as the previous query 🙈 😆

Ok I'm able to reproduce, will investigate

  • Like 1

Share this post


Link to post
Share on other sites

@adrian Ok so this seems to be the wildcard cleaner. Because {all} is the equivalent of .*, it includes the query string in this case and therefore cleans it like a normal wildcard. The only option for the time being is to disable cleaning of {all}, by changing it to {!all} in the destination. I know it's not perfect, but JL doesn't actually handle query strings very well – they should actually be handled separately somehow.

Edit: I'm actually going to see if I can update the cleaner to prevent query string character cleaning.

  • Like 1

Share this post


Link to post
Share on other sites

Thanks @Mike Rockett - the {!all} does the trick, but thanks for looking into updating the cleaner!

Thanks for the superfast response!

Share this post


Link to post
Share on other sites
3 minutes ago, adrian said:

Thanks @Mike Rockett - the {!all} does the trick, but thanks for looking into updating the cleaner!

Thanks for the superfast response!

Any time 🙂 I've rolled out 1.5.57 with a fix, so you should be good to go without the {!all}, which is somewhat unsafe IMO.

  • Like 1

Share this post


Link to post
Share on other sites

You're a legend - thank you - works perfectly!

  • Like 1

Share this post


Link to post
Share on other sites
3 minutes ago, adrian said:

You're a legend - thank you - works perfectly!

You're welcome. JL2 (when I get there 🙈) will give some more control here. This case would be covered by subscribe/{path} --> @[1495]/{path}, and then there'd either be a {query} wildcard or an option on the jumplink itself to automatically carry it over.

  • Like 1

Share this post


Link to post
Share on other sites
On 10/28/2019 at 11:10 AM, kongondo said:

Meanwhile, please show us the contents of your blog-posts template file.

Hi @kongondo, did you have a chance to review my blog-posts template above?

Share this post


Link to post
Share on other sites
14 hours ago, Ben Sayers said:

Hi @kongondo, did you have a chance to review my blog-posts template above?

Hi @Ben Sayers. Actually, yes, I have. I was to write something earlier this week but didn't get time to get to it. I have two suggestions. Could I please get back to you here over the weekend? Thanks.

Share this post


Link to post
Share on other sites
26 minutes ago, kongondo said:

Could I please get back to you here over the weekend? Thanks.

Hi @kongondo, no problem at all! I'm just happy to have your support 😃 - I'll stay tuned, thanks!!

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By MoritzLost
      This is a new module that provides a simple solution to clearing all your cache layers at once, and an extensible interface to perform various cache-related actions.
      The simple motivation behind this module was that I was tired of manually clearing caches in several places after deploying a change on a live site. The basic purpose of this module is a simple Clear all caches link in the Setup menu which clears out all caches, no matter where they hide. You can customize what exactly the module does through it's configuration menu:
      Expire or delete all cache entries in the database, or selectively clear caches by namespace ($cache API) Clear the the template render cache. Clear out specific folders inside your site's cache directory (/site/assets/cache) Refresh version strings for static assets to bust client-side browser caches (this requires some setup, see the full documentation for details). This is the basic function of the module. However, you can also add different cache management action through the API and execute them through the module's interface. For this advanced usage, the module provides:
      An interface to see all available cache actions and execute them. A system log and logging output on the module page to see verify what the module is doing. A CacheControlTools class with utility functions to clear out different caches. An API to add cache actions, execute them programmatically and even modify the default action. Permission management, allowing you granular control over which user roles can execute which actions. The complete documentation can be found in the module's README.
      Beta release
      Note that I consider this a Beta release. Since the module is relatively aggressive in deleting some caches, I would advise you to install in on a test environment before using it on a live site.
      Let me know if you're getting any errors, have trouble using the module or if you have suggestions for improvement!
      In particular, can someone let me know if this module causes any problems with the ProCache module? I don't own or use it, so I can't check. As far as I can tell, ProCache uses a folder inside the cache directory to cache static pages, so my module should be able to clear the ProCache site cache as well, I'd appreciate it if someone can test that for me.
      Future plans
      If there is some interest in this, I plan to expand this to a more general cache management solution. I particular, I would like to add additional cache actions. Some ideas that came to mind:
      Warming up the template render cache for publicly accessible pages. Removing all active user sessions. Let me know if you have more suggestions!
      Links
      https://github.com/MoritzLost/ProcessCacheControl ProcessCacheControl in the Module directory

    • By joshua
      This module is (yet another) way for implementing a cookie management solution.
      Of course there are several other possibilities:
      - https://processwire.com/talk/topic/22920-klaro-cookie-consent-manager/
      - https://github.com/webmanufaktur/CookieManagementBanner
      - https://github.com/johannesdachsel/cookiemonster
      - https://www.oiljs.org/
      - ... and so on ...
      In this module you can configure which kind of cookie categories you want to manage:

      You can also enable the support for respecting the Do-Not-Track (DNT) header to don't annoy users, who already decided for all their browsing experience.
      Currently there are four possible cookie groups:
      - Necessary (always enabled)
      - Statistics
      - Marketing
      - External Media
      All groups can be renamed, so feel free to use other cookie group names. I just haven't found a way to implement a "repeater like" field as configurable module field ...
      When you want to load specific scripts ( like Google Analytics, Google Maps, ...) only after the user's content to this specific category of cookies, just use the following script syntax:
      <script type="optin" data-type="text/javascript" data-category="statistics" data-src="/path/to/your/statistic/script.js"></script> <script type="optin" data-type="text/javascript" data-category="marketing" data-src="/path/to/your/mareketing/script.js"></script> <script type="optin" data-type="text/javascript" data-category="external_media" data-src="/path/to/your/external-media/script.js"></script> <script type="optin" data-type="text/javascript" data-category="marketing">console.log("Inline scripts are also working!");</script> The type has to be "optin" to get recognized by PrivacyWire, the data-attributes are giving hints, how the script shall be loaded, if the data-category is within the cookie consents of the user. These scripts are loaded asynchronously after the user made the decision.
      If you want to give the users the possibility to change their consent, you can use the following Textformatter:
      [[privacywire-choose-cookies]] It's planned to add also other Textformatters to opt-out of specific cookie groups or delete the whole consent cookie.
      You can also add a custom link to output the banner again with a link / button with following class:
      <a href="#" class="privacywire-show-options">Show Cookie Options</a> <button class="privacywire-show-options">Show Cookie Options</button> This module is still in development, but we already use it on several production websites.
      You find it here: https://github.com/blaueQuelle/privacywire/tree/master
      Download: https://github.com/blaueQuelle/privacywire/archive/master.zip
      I would love to hear your feedback 🙂
      Edit: Updated URLs to master tree of git repo
       
    • By David Karich
      Admin Page Tree Multiple Sorting
      ClassName: ProcessPageListMultipleSorting
      Extend the ordinary sort of children of a template in the admin page tree with multiple properties. For each template, you can define your own rule. Write each template (template-name) in a row, followed by a colon and then the additional field names for sorting.
      Example: All children of the template "blog" to be sorted in descending order according to the date of creation, then descending by modification date, and then by title. Type:
      blog: -created, -modified, title  Installation
      Copy the files for this module to /site/modules/ProcessPageListMultipleSorting/ In admin: Modules > Check for new modules. Install Module "Admin Page Tree Multible Sorting". Alternative in ProcessWire 2.4+
      Login to ProcessWire backend and go to Modules Click tab "New" and enter Module Class Name: "ProcessPageListMultipleSorting" Click "Download and Install"   Compatibility   I have currently tested the module only under PW 2.6+, but think that it works on older versions too. Maybe someone can give a feedback.     Download   PW-Repo: http://modules.processwire.com/modules/process-page-list-multiple-sorting/ GitHub: https://github.com/FlipZoomMedia/Processwire-ProcessPageListMultipleSorting     I hope someone can use the module. Have fun and best regards, David
    • By dimitrios
      Hello,
      this module can publish content of a Processwire page on a Facebook page, triggered by saving the Processwire page.
      To set it up, configure the module with a Facebook app ID, secret and a Page ID. Following is additional configuration on Facebook for developers:
      Minimum Required Facebook App configuration:
      on Settings -> Basics, provide the App Domains, provide the Site URL, on Settings -> Advanced, set the API version (has been tested up to v3.3), add Product: Facebook Login, on Facebook Login -> Settings, set Client OAuth Login: Yes, set Web OAuth Login: Yes, set Enforce HTTPS: Yes, add "https://www.example.com/processwire/page/" to field Valid OAuth Redirect URIs. This module is configurable as follows:
      Templates: posts can take place only for pages with the defined templates. On/Off switch: specify a checkbox field that will not allow the post if checked. Specify a message and/or an image for the post.
      Usage
      edit the desired PW page and save; it will post right after the initial Facebook log in and permission granting. After that, an access token is kept.
       
      Download
      PW module directory: http://modules.processwire.com/modules/auto-fb-post/ Github: https://github.com/kastrind/AutoFbPost   Note: Facebook SDK for PHP is utilized.


×
×
  • Create New...