Jump to content
fbg13

File Editor

Recommended Posts

@matjazp Just sent in a pull request for your consideration.

I was in need of an admin edit option that would allow me to specify files in the templates/styles/skin subdirectory of a site under development. I therefore added a recursive scan of the templates/ directory to the config options for the root of the editable files.

I also noticed that whenever I used the module to edit one of the files (hosted on a linux server) , git would pick up every line of the file as having changed, not just the little edits that had actually been made. It seems that the post of the file through to the back end was converting all the original linux end-of-line characters into Windows end-of-lines. This makes finding and describing edits made by clients very difficult. I therefore added a config option for you to specify what line endings to use on save (Win/Mac/*nix) so the files show no eol differences and git diff shows only what was really changed.

Small update to the choice of font-awesome icon too.

Thanks for considering!

  • Like 3

Share this post


Link to post
Share on other sites

Thanks for PR. Bumped to v1.6.7:

- Control for line endings 
- Extend directory start list with a scan of the templates subfolder
- Change icon to pencil-square-o
- CodeMirror update to 5.30.0  

  • Like 3

Share this post


Link to post
Share on other sites

Thank you!

I'd also like to throw in a request for the module to optionally make backups of files before overwriting. A simple copy to .<filename>.<definable extension> would be great.

Best wishes,
Steve

  • Like 2

Share this post


Link to post
Share on other sites

@matjazpThank you!

I've also issued a couple of very minor pull requests on top of this new feature.

Nevermind, I see you already pulled them. Thanks again!

  • Like 1

Share this post


Link to post
Share on other sites

What do you guys think about ignoring old backed up versions of modules?

Currently the old versions of site modules that were created by Ryan's PW Upgrades module show up when browsing /site/modules. I am not sure there would ever be a reason to edit these via this module. It might clean things up a little to remove them.

Same goes for .wire-x.x.x and .htaccess-x.x.x and .index-x.x.x

PS I wouldn't want to remove all .* files though in case someone does want to use this to edit the active .htaccess file.

Share this post


Link to post
Share on other sites
2 hours ago, matjazp said:

@adrian please update to v1.7.2 and check module config options. Lete me know if that works for you.

Thanks @matjazp - it works well!

Just a few things:

1) You actually need to specify "htaccess" in the Extension filter setting as well as the dotfilesWhitelist. Not sure if this should be necessary or not?

2) Should the dotfilesWhitelist settings be labeled "Dotfiles Whitelist" ?

3) You have left in an unused "removeDotFiles()" method.

 

Share this post


Link to post
Share on other sites
24 minutes ago, adrian said:

1) You actually need to specify "htaccess" in the Extension filter setting as well as the dotfilesWhitelist. Not sure if this should be necessary or not?

Don't know either. What do you suggest?

24 minutes ago, adrian said:

2) Should the dotfilesWhitelist settings be labeled "Dotfiles Whitelist" ?

Ah, forgot the label, will fix.

24 minutes ago, adrian said:

3) You have left in an unused "removeDotFiles()" method.

Yeah, in my language I was "šlampast". Now go on and translate that word :-) I was programming between making a lunch and was like a bee, flying from a flower to a flower...

Share this post


Link to post
Share on other sites
27 minutes ago, matjazp said:

Don't know either. What do you suggest?

Really not sure either. It seems redundant to have to enter htaccess and then .htaccess in two different settings though. Maybe the Extensions filter should automatically allow files that are extension-only, like htaccess, gitignore, etc. Or maybe there is no need for the Dotfiles Whitelist and any extension that is listed in the Extensions filter should automatically be allowed? I think perhaps the latter makes most sense?

 

27 minutes ago, matjazp said:

"šlampast". Now go on and translate that word

Google seems a bit confused by that one :)

Share this post


Link to post
Share on other sites
17 hours ago, adrian said:

Or maybe there is no need for the Dotfiles Whitelist and any extension that is listed in the Extensions filter should automatically be allowed?

Sounds good. Please check v1.7.3.

Share this post


Link to post
Share on other sites
5 hours ago, matjazp said:

Sounds good. Please check v1.7.3.

Thanks - I think that is much cleaner. The only thing I would suggest is adding a note to dotfiles checkbox to say that you can add htaccess and other extensions to the extensions filter to allow those.

Share this post


Link to post
Share on other sites

Sorry - another request - what about the ability to create a new file in the current folder?

Thanks for considering!

Share this post


Link to post
Share on other sites

Of course, both new files and new folders should be set using the chmod values defined in the site/config.php file. wireMkDir() should take care of the folders, but file creation might have to be manually set?

Share this post


Link to post
Share on other sites
6 hours ago, adrian said:

Sorry - another request - what about the ability to create a new file in the current folder?

 

5 hours ago, tpr said:

While at it, perhaps a new folder too?

I'm not sure about that. This is file editor, not file manager. If one needs to create/delete/move/copy/rename files/folders etc. then it's better to use ftp manager or some php based file manager, maybe http://www.gerd-tentler.de/tools/filemanager/

Share this post


Link to post
Share on other sites
2 hours ago, matjazp said:

 

I'm not sure about that. This is file editor, not file manager. If one needs to create/delete/move/copy/rename files/folders etc. then it's better to use ftp manager or some php based file manager, maybe http://www.gerd-tentler.de/tools/filemanager/

I see your point, and I use PYDIO (https://pydio.com) for that (and sharing files with clients), but my needs for your module are for editing a site when I am not at my dev machine and don't have FTP setup. I think it would be really helpful to be able to create a new file. I don't think I would really ever need a new directory, but it couldn't hurt :)

Let me know if you're really against the idea - I might consider creating my own fork, because this could be really handy to get out of a bind every now and then.

Share this post


Link to post
Share on other sites

Thanks for the suggestions @Pixrael - I wasn't planning on swapping editors, but I must admit that I do actually like AceEditor (use in Tracy's Console and Template Editor panels). The documentation and API are not great/consistent, but it seems to have the best PHP linting and code completion, at least compared with code mirror. Monaco might be another good option though.

  • Like 1

Share this post


Link to post
Share on other sites

Hi @matjazp - I discovered a bug when you have blank lines at the top of your file. Because you are using a PW InputfieldTextarea, the blank lines at the top are trimmed, here: 
https://github.com/processwire/processwire/blob/aa1f7dbd4718532896e209d694db0340c2d30067/wire/modules/Inputfield/InputfieldTextarea.module#L119

The problem is that when you save, these lines are removed. This probably won't ever cause any issues, but I don't think it's polite behavior for this to happen unexpectedly. The other issue relates to my new feature in Tracy which allows opening up errors/files to an exact line number - the line number can be off because of this bug.

I actually wonder whether maybe the PW textarea shouldn't do that in the first place. What do you think? I think blank lines at the top should be valid?

If you think this is a PW bug, or if you think there should be an option to not remove them, I'll file it with Ryan. Otherwise, maybe ProcessFileEdit needs to use a standard manually coded textarea.

Any thoughts?

  • Like 2

Share this post


Link to post
Share on other sites

Thanks for pointing it out. While I think in most circumstances trimming is ok, in this particular case it is not ok. I want the file I like, not what PW thinks I like :-) So I fixed it (hopefully) please try v1.7.4

  • Like 1

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By Mike Rockett
      Jumplinks for ProcessWire
      Release: 1.5.56
      Composer: rockett/jumplinks
      Jumplinks is an enhanced version of the original ProcessRedirects by Antti Peisa.
      The Process module manages your permanent and temporary redirects (we'll call these "jumplinks" from now on, unless in reference to redirects from another module), useful for when you're migrating over to ProcessWire from another system/platform. Each jumplink supports wildcards, shortening the time needed to create them.
      Unlike similar modules for other platforms, wildcards in Jumplinks are much easier to work with, as Regular Expressions are not fully exposed. Instead, parameters wrapped in curly braces are used - these are described in the documentation.
      Under Development: 2.0, to be powered by FastRoute
      As of version 1.5.0, Jumplinks requires at least ProcessWire 2.6.1 to run.
      View on GitLab
      Download via the Modules Directory
      Read the docs
      Features
      The most prominent features include:
      Basic jumplinks (from one fixed route to another) Parameter-based wildcards with "Smart" equivalents Mapping Collections (for converting ID-based routes to their named-equivalents without the need to create multiple jumplinks) Destination Selectors (for finding and redirecting to pages containing legacy location information) Timed Activation (activate and/or deactivate jumplinks at specific times) 404-Monitor (for creating jumplinks based on 404 hits) Additionally, the following features may come in handy:
      Stale jumplink management Legacy domain support for slow migrations An importer (from CSV or ProcessRedirects) Feedback & Feature Requests
      I’d love to know what you think of this module. Please provide some feedback on the module as a whole, or even regarding smaller things that make it whole. Also, please feel free to submit feature requests and their use-cases.
      Note: Features requested so far have been added to the to-do list, and will be added to 2.0, and not the current dev/master branches.
      Open Source

      Jumplinks is an open-source project, and is free to use. In fact, Jumplinks will always be open-source, and will always remain free to use. Forever. If you would like to support the development of Jumplinks, please consider making a small donation via PayPal.
      Enjoy! :)
    • By BitPoet
      As threatened in Ryan's announcement for 3.0.139, I built a little module for sliding toggles as a replacement for checkboxes. Styling of the input is CSS3 only (with all the usual caveats about older browsers), no JS necessary, and may still be a bit "rough around the edges", so to speak, since I didn't have much time for testing on different devices or brushing things up enough so I'd feel comfortable pushing it to the module directory. But here's the link to the GitHub repo for now:
      InputfieldSlideToggle
      Fieldtype and Inputfield that implements smartphone-style toggles as replacement for checkbox inputs. The visualization is CSS-only, no additional JS necessary.
      Status
      Still very alpha, use with caution!
      Features / Field Settings
      Size
      You can render the toggles in four different sizes: small, medium, large and extra large.
      Off Color
      Currently, "unchecked" toggles can be displayed either in grey (default) or red.
      On Color
      "Checked" toggles can be rendered in one of these colors: blue (default), black, green, grey, orange or red.
      Screenshots

      Some examples with checkbox label


      View all Size and Color Combinations
      Small toggles Medium toggles Big toggles Extra big toggles  









    • By Orkun
      Hi Guys
      I needed to add extended functionalities for the InputfieldDatetime Module (module is from processwire version 2.7.3) because of a Request of Customer.
      So I duplicated the module and placed it under /site/modules/.
      I have added 3 new Settings to the InputfieldDatetime Module.
      1. Day Restriction - Restrict different days based on weekdays selection (e.g. saturday, sunday) - WORKING

       
      2. Time Slots - Define Time slots based on custom Integer Value (max is 60 for 1 hour) - WORKING

       
      3. Time Range Rules per Weekday - Define a minTime and MaxTime per Weekday (e.g. Opening Hours of a Restaurant) - NOT WORKING PROPERLY

       
      The Problem
      Time Slots and Day Restriction working fine so far. But the Time Range Rules per Weekday doesn't work right.
      What should happen is, that when you click on a date, it should update the minTime and maxTime of the Time Select.
      But the change on the select only happens if you select a date 2 times or when you select a date 1 time and then close the datepicker and reopen it again.
      The time select doesn't get change when you select a date 1 time and don't close the picker.
      Here is the whole extended InputfieldDatetime Module.
      The Files that I have changed:
      InputfieldDatetime.module InputfieldDatetime.js jquery-ui-timepicker-addon.js (https://trentrichardson.com/examples/timepicker/) - updated it to the newest version, because minTime and maxTime Option was only available in the new version  
      Thats the Part of the JS that is not working correctly:
      if(datetimerules && datetimerules.length){ options.onSelect = function(date, inst) { var day = $(this).datetimepicker("getDate").getDay(); day = day.toString(); var mintime = $(this).attr('data-weekday'+day+'-mintime'); var maxtime = $(this).attr('data-weekday'+day+'-maxtime'); console.log("weekday: "+day); console.log("minTime: "+mintime); console.log("maxTime: "+maxtime); var optionsAll = $(this).datetimepicker( "option", "all" ); optionsAll.minTime = mintime; optionsAll.maxTime = maxtime; $(this).datetimepicker('destroy'); $(this).datetimepicker(optionsAll); $(this).datetimepicker('refresh'); //$.datepicker._selectDate($(this).attr("id"),date); //$.datepicker._base_getDateDatepicker(); // var inst = $.datepicker._getInst($(this)); // $.datepicker._updateDatepicker(inst); /*$(this).datetimepicker('destroy'); InputfieldDatetimeDatepicker($(this), mintime, maxtime); $(this).datetimepicker('refresh'); */ // $(this).datetimepicker('option', {minTime: mintime, maxTime: maxtime}); } } Can you have a look and find out what the Problem is?
      InputfieldDatetime.zip
       
      Kind Regards
      Orkun
    • By teppo
      This module tracks changes, additions, removals etc. of public (as in "not under admin") pages of your site. Like it's name says, it doesn't attempt to be a version control system or anything like that - just a log of what's happened.
      At the moment it's still a work in progress and will most likely be a victim of many ruthless this-won't-work-let's-try-that-instead cycles, but I believe I've nailed basic functionality well enough to post it here.. so, once again, I'll be happy to hear any comments you folks can provide
      https://modules.processwire.com/modules/process-changelog/
      https://github.com/teppokoivula/ProcessChangelog
      How does it work?
      Exactly like it's (sort of) predecessor, Process Changelog actually consists of two modules: Process Changelog and Process Changelog Hooks. Hooks module exists only to serve main module by hooking into various functions within Pages class, collecting data of performed operations, refining it and keeping up a log of events in it's own custom database table (process_changelog.) Visible part is managed by Process Changelog, which provides users a (relatively) pretty view of the contents of said log table.
      How do you use it?
      When installed this module adds new page called Changelog under Admin > Setup which provides you with a table view of collected data and basic filtering tools See attached screenshots to get a general idea about what that page should look like after a while.
      For detailed installation instructions etc. see README.md.
       


    • By Gadgetto
      Status update links (inside this thread) for SnipWire development will be always posted here:
      2019-08-08
      2019-06-15
      2019-06-02
      2019-05-25
      If you are interested, you can test the current state of development:
      https://github.com/gadgetto/SnipWire
      Please note that the software is not yet intended for use in a production system (alpha version).
      If you like, you can also submit feature requests and suggestions for improvement. I also accept pull requests.
      ---- INITIAL POST FROM 2019-05-25 ----
      I wanted to let you know that I am currently working on a new ProcessWire module that fully integrates the Snipcart Shopping Cart System into ProcessWire. (this is a customer project, so I had to postpone the development of my other module GroupMailer).
      The new module SnipWire offers full integration of the Snipcart Shopping Cart System into ProcessWire.
      Here are some highlights:
      simple setup with (optional) pre-installed templates, product fields, sample products (quasi a complete shop system to get started immediately) store dashboard with all data from the snipcart system (no change to the snipcart dashboard itself required) Integrated REST API for controlling and querying snipcart data webhooks to trigger events from Snipcart (new order, new customer, etc.) multi currency support self-defined/configurable tax rates etc. Development is already well advanced and I plan to release the module in the next 2-3 months.
      I'm not sure yet if this will be a "Pro" module or if it will be made available for free.
      I would be grateful for suggestions and hints!
      (please have a look at the screenshots to get an idea what I'm talking about)
       




×
×
  • Create New...