Jump to content
fbg13

File Editor

Recommended Posts

@matjazp Just sent in a pull request for your consideration.

I was in need of an admin edit option that would allow me to specify files in the templates/styles/skin subdirectory of a site under development. I therefore added a recursive scan of the templates/ directory to the config options for the root of the editable files.

I also noticed that whenever I used the module to edit one of the files (hosted on a linux server) , git would pick up every line of the file as having changed, not just the little edits that had actually been made. It seems that the post of the file through to the back end was converting all the original linux end-of-line characters into Windows end-of-lines. This makes finding and describing edits made by clients very difficult. I therefore added a config option for you to specify what line endings to use on save (Win/Mac/*nix) so the files show no eol differences and git diff shows only what was really changed.

Small update to the choice of font-awesome icon too.

Thanks for considering!

  • Like 3

Share this post


Link to post
Share on other sites

Thanks for PR. Bumped to v1.6.7:

- Control for line endings 
- Extend directory start list with a scan of the templates subfolder
- Change icon to pencil-square-o
- CodeMirror update to 5.30.0  

  • Like 3

Share this post


Link to post
Share on other sites

Thank you!

I'd also like to throw in a request for the module to optionally make backups of files before overwriting. A simple copy to .<filename>.<definable extension> would be great.

Best wishes,
Steve

  • Like 2

Share this post


Link to post
Share on other sites

@matjazpThank you!

I've also issued a couple of very minor pull requests on top of this new feature.

Nevermind, I see you already pulled them. Thanks again!

  • Like 1

Share this post


Link to post
Share on other sites

What do you guys think about ignoring old backed up versions of modules?

Currently the old versions of site modules that were created by Ryan's PW Upgrades module show up when browsing /site/modules. I am not sure there would ever be a reason to edit these via this module. It might clean things up a little to remove them.

Same goes for .wire-x.x.x and .htaccess-x.x.x and .index-x.x.x

PS I wouldn't want to remove all .* files though in case someone does want to use this to edit the active .htaccess file.

Share this post


Link to post
Share on other sites

@adrian please update to v1.7.2 and check module config options. Lete me know if that works for you.

  • Like 1

Share this post


Link to post
Share on other sites
2 hours ago, matjazp said:

@adrian please update to v1.7.2 and check module config options. Lete me know if that works for you.

Thanks @matjazp - it works well!

Just a few things:

1) You actually need to specify "htaccess" in the Extension filter setting as well as the dotfilesWhitelist. Not sure if this should be necessary or not?

2) Should the dotfilesWhitelist settings be labeled "Dotfiles Whitelist" ?

3) You have left in an unused "removeDotFiles()" method.

 

Share this post


Link to post
Share on other sites
24 minutes ago, adrian said:

1) You actually need to specify "htaccess" in the Extension filter setting as well as the dotfilesWhitelist. Not sure if this should be necessary or not?

Don't know either. What do you suggest?

24 minutes ago, adrian said:

2) Should the dotfilesWhitelist settings be labeled "Dotfiles Whitelist" ?

Ah, forgot the label, will fix.

24 minutes ago, adrian said:

3) You have left in an unused "removeDotFiles()" method.

Yeah, in my language I was "šlampast". Now go on and translate that word :-) I was programming between making a lunch and was like a bee, flying from a flower to a flower...

Share this post


Link to post
Share on other sites
27 minutes ago, matjazp said:

Don't know either. What do you suggest?

Really not sure either. It seems redundant to have to enter htaccess and then .htaccess in two different settings though. Maybe the Extensions filter should automatically allow files that are extension-only, like htaccess, gitignore, etc. Or maybe there is no need for the Dotfiles Whitelist and any extension that is listed in the Extensions filter should automatically be allowed? I think perhaps the latter makes most sense?

 

27 minutes ago, matjazp said:

"šlampast". Now go on and translate that word

Google seems a bit confused by that one :)

Share this post


Link to post
Share on other sites
17 hours ago, adrian said:

Or maybe there is no need for the Dotfiles Whitelist and any extension that is listed in the Extensions filter should automatically be allowed?

Sounds good. Please check v1.7.3.

Share this post


Link to post
Share on other sites
5 hours ago, matjazp said:

Sounds good. Please check v1.7.3.

Thanks - I think that is much cleaner. The only thing I would suggest is adding a note to dotfiles checkbox to say that you can add htaccess and other extensions to the extensions filter to allow those.

Share this post


Link to post
Share on other sites

Sorry - another request - what about the ability to create a new file in the current folder?

Thanks for considering!

Share this post


Link to post
Share on other sites

While at it, perhaps a new folder too?

  • Like 1

Share this post


Link to post
Share on other sites

Of course, both new files and new folders should be set using the chmod values defined in the site/config.php file. wireMkDir() should take care of the folders, but file creation might have to be manually set?

Share this post


Link to post
Share on other sites
6 hours ago, adrian said:

Sorry - another request - what about the ability to create a new file in the current folder?

 

5 hours ago, tpr said:

While at it, perhaps a new folder too?

I'm not sure about that. This is file editor, not file manager. If one needs to create/delete/move/copy/rename files/folders etc. then it's better to use ftp manager or some php based file manager, maybe http://www.gerd-tentler.de/tools/filemanager/

Share this post


Link to post
Share on other sites
2 hours ago, matjazp said:

 

I'm not sure about that. This is file editor, not file manager. If one needs to create/delete/move/copy/rename files/folders etc. then it's better to use ftp manager or some php based file manager, maybe http://www.gerd-tentler.de/tools/filemanager/

I see your point, and I use PYDIO (https://pydio.com) for that (and sharing files with clients), but my needs for your module are for editing a site when I am not at my dev machine and don't have FTP setup. I think it would be really helpful to be able to create a new file. I don't think I would really ever need a new directory, but it couldn't hurt :)

Let me know if you're really against the idea - I might consider creating my own fork, because this could be really handy to get out of a bind every now and then.

Share this post


Link to post
Share on other sites

Thanks for the suggestions @Pixrael - I wasn't planning on swapping editors, but I must admit that I do actually like AceEditor (use in Tracy's Console and Template Editor panels). The documentation and API are not great/consistent, but it seems to have the best PHP linting and code completion, at least compared with code mirror. Monaco might be another good option though.

  • Like 1

Share this post


Link to post
Share on other sites

Hi @matjazp - I discovered a bug when you have blank lines at the top of your file. Because you are using a PW InputfieldTextarea, the blank lines at the top are trimmed, here: 
https://github.com/processwire/processwire/blob/aa1f7dbd4718532896e209d694db0340c2d30067/wire/modules/Inputfield/InputfieldTextarea.module#L119

The problem is that when you save, these lines are removed. This probably won't ever cause any issues, but I don't think it's polite behavior for this to happen unexpectedly. The other issue relates to my new feature in Tracy which allows opening up errors/files to an exact line number - the line number can be off because of this bug.

I actually wonder whether maybe the PW textarea shouldn't do that in the first place. What do you think? I think blank lines at the top should be valid?

If you think this is a PW bug, or if you think there should be an option to not remove them, I'll file it with Ryan. Otherwise, maybe ProcessFileEdit needs to use a standard manually coded textarea.

Any thoughts?

  • Like 2

Share this post


Link to post
Share on other sites

Thanks for pointing it out. While I think in most circumstances trimming is ok, in this particular case it is not ok. I want the file I like, not what PW thinks I like :-) So I fixed it (hopefully) please try v1.7.4

  • Like 1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By MoritzLost
      This is a new module that provides a simple solution to clearing all your cache layers at once, and an extensible interface to perform various cache-related actions.
      The simple motivation behind this module was that I was tired of manually clearing caches in several places after deploying a change on a live site. The basic purpose of this module is a simple Clear all caches link in the Setup menu which clears out all caches, no matter where they hide. You can customize what exactly the module does through it's configuration menu:
      Expire or delete all cache entries in the database, or selectively clear caches by namespace ($cache API) Clear the the template render cache. Clear out specific folders inside your site's cache directory (/site/assets/cache) Refresh version strings for static assets to bust client-side browser caches (this requires some setup, see the full documentation for details). This is the basic function of the module. However, you can also add different cache management action through the API and execute them through the module's interface. For this advanced usage, the module provides:
      An interface to see all available cache actions and execute them. A system log and logging output on the module page to see verify what the module is doing. A CacheControlTools class with utility functions to clear out different caches. An API to add cache actions, execute them programmatically and even modify the default action. Permission management, allowing you granular control over which user roles can execute which actions. The complete documentation can be found in the module's README.
      Beta release
      Note that I consider this a Beta release. Since the module is relatively aggressive in deleting some caches, I would advise you to install in on a test environment before using it on a live site.
      Let me know if you're getting any errors, have trouble using the module or if you have suggestions for improvement!
      In particular, can someone let me know if this module causes any problems with the ProCache module? I don't own or use it, so I can't check. As far as I can tell, ProCache uses a folder inside the cache directory to cache static pages, so my module should be able to clear the ProCache site cache as well, I'd appreciate it if someone can test that for me.
      Future plans
      If there is some interest in this, I plan to expand this to a more general cache management solution. I particular, I would like to add additional cache actions. Some ideas that came to mind:
      Warming up the template render cache for publicly accessible pages. Removing all active user sessions. Let me know if you have more suggestions!
      Links
      https://github.com/MoritzLost/ProcessCacheControl ProcessCacheControl in the Module directory

    • By joshua
      This module is (yet another) way for implementing a cookie management solution.
      Of course there are several other possibilities:
      - https://processwire.com/talk/topic/22920-klaro-cookie-consent-manager/
      - https://github.com/webmanufaktur/CookieManagementBanner
      - https://github.com/johannesdachsel/cookiemonster
      - https://www.oiljs.org/
      - ... and so on ...
      In this module you can configure which kind of cookie categories you want to manage:

      You can also enable the support for respecting the Do-Not-Track (DNT) header to don't annoy users, who already decided for all their browsing experience.
      Currently there are four possible cookie groups:
      - Necessary (always enabled)
      - Statistics
      - Marketing
      - External Media
      All groups can be renamed, so feel free to use other cookie group names. I just haven't found a way to implement a "repeater like" field as configurable module field ...
      When you want to load specific scripts ( like Google Analytics, Google Maps, ...) only after the user's content to this specific category of cookies, just use the following script syntax:
      <script type="optin" data-type="text/javascript" data-category="statistics" data-src="/path/to/your/statistic/script.js"></script> <script type="optin" data-type="text/javascript" data-category="marketing" data-src="/path/to/your/mareketing/script.js"></script> <script type="optin" data-type="text/javascript" data-category="external_media" data-src="/path/to/your/external-media/script.js"></script> <script type="optin" data-type="text/javascript" data-category="marketing">console.log("Inline scripts are also working!");</script> The type has to be "optin" to get recognized by PrivacyWire, the data-attributes are giving hints, how the script shall be loaded, if the data-category is within the cookie consents of the user. These scripts are loaded asynchronously after the user made the decision.
      If you want to give the users the possibility to change their consent, you can use the following Textformatter:
      [[privacywire-choose-cookies]] It's planned to add also other Textformatters to opt-out of specific cookie groups or delete the whole consent cookie.
      You can also add a custom link to output the banner again with a link / button with following class:
      <a href="#" class="privacywire-show-options">Show Cookie Options</a> <button class="privacywire-show-options">Show Cookie Options</button> This module is still in development, but we already use it on several production websites.
      You find it here: https://github.com/blaueQuelle/privacywire/tree/master
      Download: https://github.com/blaueQuelle/privacywire/archive/master.zip
      I would love to hear your feedback 🙂
      Edit: Updated URLs to master tree of git repo
       
    • By David Karich
      Admin Page Tree Multiple Sorting
      ClassName: ProcessPageListMultipleSorting
      Extend the ordinary sort of children of a template in the admin page tree with multiple properties. For each template, you can define your own rule. Write each template (template-name) in a row, followed by a colon and then the additional field names for sorting.
      Example: All children of the template "blog" to be sorted in descending order according to the date of creation, then descending by modification date, and then by title. Type:
      blog: -created, -modified, title  Installation
      Copy the files for this module to /site/modules/ProcessPageListMultipleSorting/ In admin: Modules > Check for new modules. Install Module "Admin Page Tree Multible Sorting". Alternative in ProcessWire 2.4+
      Login to ProcessWire backend and go to Modules Click tab "New" and enter Module Class Name: "ProcessPageListMultipleSorting" Click "Download and Install"   Compatibility   I have currently tested the module only under PW 2.6+, but think that it works on older versions too. Maybe someone can give a feedback.     Download   PW-Repo: http://modules.processwire.com/modules/process-page-list-multiple-sorting/ GitHub: https://github.com/FlipZoomMedia/Processwire-ProcessPageListMultipleSorting     I hope someone can use the module. Have fun and best regards, David
    • By dimitrios
      Hello,
      this module can publish content of a Processwire page on a Facebook page, triggered by saving the Processwire page.
      To set it up, configure the module with a Facebook app ID, secret and a Page ID. Following is additional configuration on Facebook for developers:
      Minimum Required Facebook App configuration:
      on Settings -> Basics, provide the App Domains, provide the Site URL, on Settings -> Advanced, set the API version (has been tested up to v3.3), add Product: Facebook Login, on Facebook Login -> Settings, set Client OAuth Login: Yes, set Web OAuth Login: Yes, set Enforce HTTPS: Yes, add "https://www.example.com/processwire/page/" to field Valid OAuth Redirect URIs. This module is configurable as follows:
      Templates: posts can take place only for pages with the defined templates. On/Off switch: specify a checkbox field that will not allow the post if checked. Specify a message and/or an image for the post.
      Usage
      edit the desired PW page and save; it will post right after the initial Facebook log in and permission granting. After that, an access token is kept.
       
      Download
      PW module directory: http://modules.processwire.com/modules/auto-fb-post/ Github: https://github.com/kastrind/AutoFbPost   Note: Facebook SDK for PHP is utilized.


×
×
  • Create New...