Jump to content
horst

Croppable Image 3

Recommended Posts

On 12/6/2016 at 4:00 PM, horst said:

I have upgraded a site yesterday too. Here everything is working as expected. With both, existing and new created images.

(PW 3.0.39 to 3.0.43)

 I have no time to investigate further but this fixes it (line 344)

// if ($image->pagefiles === $pagefiles) {
if ($image->pagefiles->page->id === $pagefiles->page->id) {

Perhaps "===" is the culprit? PHP docs says

Quote

When using the identity operator (===), object variables are identical if and only if they refer to the same instance of the same class.

  • Like 1

Share this post


Link to post
Share on other sites
7 hours ago, horst said:

This is not intended, but its previous state is only saved for jpegs, not for png or gif formats.

Thanks Horst

Just tried it with a jpeg and it works a treat.

Any plans to get this working for PNG / GIFs?

Share this post


Link to post
Share on other sites
5 hours ago, joey102030 said:

Thanks Horst

Just tried it with a jpeg and it works a treat.

Any plans to get this working for PNG / GIFs?

Plans yes, - but currently no time. It will need a complete redesign of the storage. Currently it is stored with the original files in IPTC, and thats not supported by PNG and GIF.

  • Like 1

Share this post


Link to post
Share on other sites
13 hours ago, tpr said:

 I have no time to investigate further but this fixes it (line 344)


// if ($image->pagefiles === $pagefiles) {
if ($image->pagefiles->page->id === $pagefiles->page->id) {

Perhaps "===" is the culprit? PHP docs says

Have updated it now to version 0.9.17. There was another one pending with this part of the code. I thought I had already comitted it. Sorry!

  • Like 2

Share this post


Link to post
Share on other sites

Having an issue here too after upgrading from PW 3.X to PW 3.0.44

Firstly I was getting an error about the width of a crop so I replaced the entire site>modules>CroppableImage3 folder with the latest 0.9.17

Now I'm getting the following error 

Error: Uncaught Error: Call to a member function getCrop() on null in /var/www/vhosts/site.com/httpdocs/site/templates/blog-post.php:104
Stack trace:
#0 /var/www/vhosts/site.com/httpdocs/wire/core/TemplateFile.php(268): require()
#1 /var/www/vhosts/site.com/httpdocs/wire/core/Wire.php(374): ProcessWire\TemplateFile->___render()
#2 /var/www/vhosts/site.com/httpdocs/wire/core/WireHooks.php(682): ProcessWire\Wire->_callMethod('___render', Array)
#3 /var/www/vhosts/site.com/httpdocs/wire/core/Wire.php(402): ProcessWire\WireHooks->runHooks(Object(ProcessWire\TemplateFile), 'render', Array)
#4 /var/www/vhosts/site.com/httpdocs/wire/modules/PageRender.module(514): ProcessWire\Wire->__call('render', Array)
#5 [internal function]: ProcessWire\PageRender->___renderPage(Object(ProcessWire\HookEvent))
#6 /var/www/vhosts/site.com/httpdocs/wire/core/Wire.php(376): call_user_func_array(Array, Array)
#7 /var/www/vhosts/site.com/httpdocs/wire/core/WireHooks.php(682): ProcessWire\Wire->_callMethod('___ (line 104 of /var/www/vhosts/site.com/httpdocs/site/templates/blog-post.php) 

This error message was shown because: you are logged in as a Superuser. Error has been logged.

Any suggestions on this one?

 

Share this post


Link to post
Share on other sites
On 12/16/2016 at 10:30 AM, tpr said:

Modules refresh?

Yep - worked, thanks.

It was more like 'Modules refresh' X 5 but I got there

Share this post


Link to post
Share on other sites

Anyone using this module with the latest dev (3.051)? After updating from the master branch (3.042 at the time of writing), it no longer points to the full URL of the crops, i.e.

URL in Master: "/site/assets/files/9168/death-of-a-fisherman.675x0-landscape.jpg"
Truncated URL in Dev: "/site/assets/files/9168/"

A modules refresh hasn't fixed this issue.

Share this post


Link to post
Share on other sites
On 30.1.2017 at 11:58 AM, jacmaes said:

Anyone using this module with the latest dev (3.051)? After updating from the master branch (3.042 at the time of writing), it no longer points to the full URL of the crops, i.e.


URL in Master: "/site/assets/files/9168/death-of-a-fisherman.675x0-landscape.jpg"
Truncated URL in Dev: "/site/assets/files/9168/"

A modules refresh hasn't fixed this issue.

Can't reproduce that. All is working as expected with 3.0.52 (fresh install from scratch)

How have you updated the version? Have you tried to clear / recreate other caches too? (Modules-Cache, FileCompilercache, etc.)

Share this post


Link to post
Share on other sites

That truncated URL suggests to me that you are calling an array of images rather than a single image. Is upgrading PW the only thing you did?

  • Like 1

Share this post


Link to post
Share on other sites

@horst Yes, I've refreshed the modules a couple of times, and I've made sure to clear the cache (browser cache + "cache" folder in "assets"). I've tried on three different sites that are very similar, and same problem. 

@adrian Upgrading PW is indeed the only thing I did. Reverting back to the master branch fixes the issue immediately. My field setting is as such: 

field.png

And I'm calling the image this way:

<img alt="<?= $page->title; ?>" src="<?= $page->image->first->getCrop('landscape')->url; ?>">

 

Share this post


Link to post
Share on other sites
On 30/01/2017 at 10:58 AM, jacmaes said:

Anyone using this module with the latest dev (3.051)? After updating from the master branch (3.042 at the time of writing), it no longer points to the full URL of the crops, i.e.


URL in Master: "/site/assets/files/9168/death-of-a-fisherman.675x0-landscape.jpg"
Truncated URL in Dev: "/site/assets/files/9168/"

A modules refresh hasn't fixed this issue.

I just had same issue after an upgrade to 3.0.51 and it couldn't be fixed by flushing the Modules.

 

 

 

Share this post


Link to post
Share on other sites

Has anyone managed to hide the Crop button? I tried with Admin Custom Files but with no success.

EDIT: Ok I did it with Admin Custom Files.

Share this post


Link to post
Share on other sites
On 1/31/2017 at 0:35 PM, Peter Knight said:

I just had same issue after an upgrade to 3.0.51 and it couldn't be fixed by flushing the Modules.

I have the same issue. The module was working great on 3.0.33, then i upgraded to 3.0.52 and the frontend method of getting the crop no longer works;
the images are there in the folders with the suffix, and the backend stuff all works; just can't get the crops to output on the front end for some reason; the method is just returning null;

I have another site on a different server where this is running on 3.0.52 and does work...

Share this post


Link to post
Share on other sites
15 hours ago, Macrura said:

I have the same issue. The module was working great on 3.0.33, then i upgraded to 3.0.52 and the frontend method of getting the crop no longer works;
the images are there in the folders with the suffix, and the backend stuff all works; just can't get the crops to output on the front end for some reason; the method is just returning null;

I have another site on a different server where this is running on 3.0.52 and does work...

On one server it is running after upgrading to 3.0.52, on another one not! This is not really a pattern, or is it one?

@Macrura, can you give me access to that one where it is returning null? I use it on my installs and it works all as expected.

Share this post


Link to post
Share on other sites

one of these was upgraded from the old cropping module to the new one, and one was started on 3x branch, and just added the cropping module; the module was probably installed after the upgrade to 3.0.52; not sure if any of those things make any difference;

I can get you access to the admin and the FTP - i'm assuming you need both; will PM you in a bit.

  • Like 1

Share this post


Link to post
Share on other sites

in the meantime i can see from some quick testing that the getCrop method is getting stuck here:

// return InputfieldCroppableImage3 or null if not found
$inputFieldInstance = $this->_getInputFieldInstance($event);

  • Like 1

Share this post


Link to post
Share on other sites
2 minutes ago, Macrura said:

in the meantime i can see from some quick testing that the getCrop method is getting stuck here:

// return InputfieldCroppableImage3 or null if not found
$inputFieldInstance = $this->_getInputFieldInstance($event);

Any chance you are running an old version of the module. That method is no longer used:

https://github.com/horst-n/CroppableImage3/blob/e87b602cffbbdd648a48aa7a4975f927ff58f4d7/FieldtypeCroppableImage3/FieldtypeCroppableImage3.module#L80-L81

  • Like 3

Share this post


Link to post
Share on other sites

ok well yes, i was apparently running an older version (weird, just downloaded this from modules directory), but no idea how i had an out-of-date version, and the upgrades module shows nothing about this module...

so this is fixed, by upgrading manually to the version on github

  • Like 3

Share this post


Link to post
Share on other sites
2 minutes ago, Macrura said:

the upgrades module shows nothing about this module

I wonder if it has anything to do with using a string for the version number? I am switching my modules over to string version numbers as well, so would be good to know if that is the problem?

Share this post


Link to post
Share on other sites

@Macrura thanks, I can confirm that I no longer have the issue after downloading the module from Github manually. 

  • Like 2

Share this post


Link to post
Share on other sites

I guess we need to do some testing, with regards to the version number issue? not sure how to conveniently test it though, but could have a look at the upgrades module and try and see why it doesn't even list the CroppableImage3 module...

  • Like 1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By joshua
      This module is (yet another) way for implementing a cookie management solution.
      Of course there are several other possibilities:
      - https://processwire.com/talk/topic/22920-klaro-cookie-consent-manager/
      - https://github.com/webmanufaktur/CookieManagementBanner
      - https://github.com/johannesdachsel/cookiemonster
      - https://www.oiljs.org/
      - ... and so on ...
      In this module you can configure which kind of cookie categories you want to manage:

      You can also enable the support for respecting the Do-Not-Track (DNT) header to don't annoy users, who already decided for all their browsing experience.
      Currently there are four possible cookie groups:
      - Necessary (always enabled)
      - Statistics
      - Marketing
      - External Media
      All groups can be renamed, so feel free to use other cookie group names. I just haven't found a way to implement a "repeater like" field as configurable module field ...
      When you want to load specific scripts ( like Google Analytics, Google Maps, ...) only after the user's content to this specific category of cookies, just use the following script syntax:
      <script type="text/plain" data-type="text/javascript" data-category="statistics" data-src="/path/to/your/statistic/script.js"></script> <script type="text/plain" data-type="text/javascript" data-category="marketing" data-src="/path/to/your/mareketing/script.js"></script> <script type="text/plain" data-type="text/javascript" data-category="external_media" data-src="/path/to/your/external-media/script.js"></script> <script type="text/plain" data-type="text/javascript" data-category="marketing">console.log("Inline scripts are also working!");</script> The type has to be "optin" to get recognized by PrivacyWire, the data-attributes are giving hints, how the script shall be loaded, if the data-category is within the cookie consents of the user. These scripts are loaded asynchronously after the user made the decision.
      If you want to give the users the possibility to change their consent, you can use the following Textformatter:
      [[privacywire-choose-cookies]] It's planned to add also other Textformatters to opt-out of specific cookie groups or delete the whole consent cookie.
      You can also add a custom link to output the banner again with a link / button with following class:
      <a href="#" class="privacywire-show-options">Show Cookie Options</a> <button class="privacywire-show-options">Show Cookie Options</button> This module is still in development, but we already use it on several production websites.
      You find it here: PrivacyWire Git Repo
      Download as .zip
      I would love to hear your feedback 🙂
      CHANGELOG
      0.1.1 Debugging: fixed error during uninstall 0.1.0 Added new detection of async scripts for W3C Validation 0.0.6 CSS-Debugging for hiding unused buttons, added ProCache support for the JavaScript tag 0.0.5 Multi-language support included completely (also in TextFormatter). Added possibility to async load other assets (e.g. <img type="optin" data-category="marketing" data-src="https://via.placeholder.com/300x300">) 0.0.4 Added possibility to add an imprint link to the banner 0.0.3 Multi-language support for module config (still in development) 0.0.2 First release 0.0.1 Early development
    • By bernhard
      --- Please use RockFinder3 ---
    • By MoritzLost
      Cacheable Placeholders
      This module allows you to have pieces of dynamic content inside cached output. This aims to solve the common problem of having a mostly cacheable site, but with pieces of dynamic output here and there.  Consider this simple example, where you want to output a custom greeting to the current user:
      <h1>Good morning, <?= ucfirst($user->name) ?></h1> This snippet means you can't use the template cache (at least for logged-in users), because each user has a different name. Even if 99% of your output is static, you can only cache the pieces that you know won't include this personal greeting. A more common example would be CSRF tokens for HTML forms - those need to be unique by definition, so you can't cache the form wholesale.
      This module solves this problem by introducing cacheable placeholders - small placeholder tokens that get replaced during every request. The replacement is done inside a Page::render hook so it runs during every request, even if the response is served from the template cache. So you can use something like this:
      <h1>Good morning, {{{greeting}}}</h1> Replacement tokens are defined with a callback function that produces the appropriate output and added to the module through a simple hook:
      // site/ready.php wire()->addHookAfter('CachePlaceholders::getTokens', function (HookEvent $e) { $tokens = $e->return; $tokens['greeting'] = [ 'callback' => function (array $tokenData) { return ucfirst(wire('user')->name); } ]; $e->return = $tokens; }); Tokens can also include parameters that are parsed and passed to the callback function. There are more fully annotated examples and step-by-step instructions in the README on Github!
      Features
      A simple and fast token parser that calls the appropriate callback and runs automatically. Tokens may include multiple named or positional parameters, as well as multi-value parameters. A manual mode that allows you to replace tokens in custom pieces of cached content (useful if you're using the $cache API). Some built-in tokens for common use-cases: CSRF-Tokens, replacing values from superglobals and producing random hexadecimal strings. The token format is completely customizable, all delimiters can be changed to avoid collisions with existing tag parsers or template languages. Links
      Github Repository & documentation Module directory (pending approval) If you are interested in learning more, the README is very extensive, with more usage examples, code samples and usage instructions!
    • By Craig
      I've been using Fathom Analytics for a while now and on a growing number of sites, so thought it was about time there was a PW module for it.
      WayFathomAnalytics
      WayFathomAnalytics is a group of modules which will allow you to view your Fathom Analytics dashboard in the PW admin panel and (optionally) automatically add and configure the tracking code on front-end pages.
      Links
      GitHub Readme & documentation Download Zip Modules directory Module settings screenshot What is Fathom Analytics?
      Fathom Analytics is a simple, privacy-focused website analytics tool for bloggers and businesses.

      Stop scrolling through pages of reports and collecting gobs of personal data about your visitors, both of which you probably don't need. Fathom is a simple and private website analytics platform that lets you focus on what's important: your business.
      Privacy focused Fast-loading dashboards, all data is on a single screen Easy to get what you need, no training required Unlimited email reports Private or public dashboard sharing Cookie notices not required (it doesn't use cookies or collect personal data) Displays: top content, top referrers, top goals and more
    • By daniels
      This is a lightweight alternative to other newsletter & newsletter-subscription modules.
      You can find the Module in the Modules directory and on Github
      It can subscribe, update, unsubscribe & delete a user in a list in Mailchimp with MailChimp API 3.0. It does not provide any forms or validation, so you can feel free to use your own. To protect your users, it does not save any user data in logs or sends them to an admin.
      This module fits your needs if you...
      ...use Mailchimp as your newsletter / email-automation tool ...want to let users subscribe to your newsletter on your website ...want to use your own form, validation and messages (with or without the wire forms) ...don't want any personal user data saved in any way in your ProcessWire environment (cf. EU data regulation terms) ...like to subscribe, update, unsubscribe or delete users to/from different lists ...like the Mailchimp UI for creating / sending / reviewing email campaigns *I have only tested it with PHP 7.x so far, so use on owners risk
      EDIT:
      Since 0.0.4, instructions and changelog can be found in the README only. You can find it here  🙂
      If you have questions or like to contribute, just post a reply or create an issue or pr on github, thanks!
×
×
  • Create New...