Jump to content
horst

Croppable Image 3

Recommended Posts

6 hours ago, Robin S said:

@horst, what if you create a new module file/class in the root of the CroppableImage3 directory named 'CroppableImage3', and that class does nothing apart from auto-install the other classes?

Not ideal of course but might be an okay workaround seeing as you are stuck with the existing directory name.

Was allready done. It resulted in not correctly installing all needed dependencies (with a wrapper class: three). It only installed two out of three, then complaining about the missing one. System broken! :(

Share this post


Link to post
Share on other sites
2 hours ago, horst said:

It resulted in not correctly installing all needed dependencies (with a wrapper class: three). It only installed two out of three, then complaining about the missing one.

Taking the current version of CI3 and adding this 'CroppableImage3.module' file in the module root enabled all the dependent modules to be installed/uninstalled in one go without any major problem for me:

<?php namespace ProcessWire;

class CroppableImage3 extends WireData implements Module {

    public static function getModuleInfo() {
        return array(
            'title'    => 'Croppable Image 3',
            'summary'  => 'One or more image uploads (optional predefined crops)',
            'author'   => 'Horst Nogajski',
            'version'  => '1.1.5',
            'requires' => 'ProcessWire>=3.0.20, PHP>=5.3.8',
            'installs' => 'FieldtypeCroppableImage3, InputfieldCroppableImage3, ProcessCroppableImage3',
            'icon'     => 'crop'
        );
    }

    public function ___uninstall() {
        // Remove related modules on uninstall - not essential
        $this->modules->uninstall('FieldtypeCroppableImage3');
        $this->modules->uninstall('InputfieldCroppableImage3');
        $this->modules->uninstall('ProcessCroppableImage3');
    }

}

Tracy picks up a few minor PHP notices coming from ProcessCroppableImage3 during install/uninstall but should be simple enough to iron those out. Lines 344 & 349 on install, lines 48 & 49 on uninstall - I think these notices occur with the current version too.

If you went this way you could consider moving FieldtypeCroppableImage3.module back into a subfolder just to keep things tidy.

Also, after adding this file the Upgrades module detects CroppableImage3.

  • Like 1

Share this post


Link to post
Share on other sites

That's what I made in Version 1.1.0: https://github.com/horst-n/CroppableImage3/commit/6a52e7726170bf3d81981c1d0da9cc247bbaa1b0

-------

Ok, your test was on a first install of the module, and not as an upgrade, yes?

How does it work out for those who have installed a version prior to 1.0.0? Thats the most common and important situation!

You have installed the 3 modules, each in its subfolder or not, but Fieldtype... is the main module, than you use the update module button, (you will need an existing wrapperclass CroppableImage3.module in the github repo for this to work!). <= Thats what I have tried already and it hasn't worked for me. Always left one dependency uninstalled.

But I will try this once more, as 1.1.6, - just to check if my test with 1.1.0 / 1.1.1 wasn't interfered with another issue that made it broken.

Many thanks for your support @Robin S ! :)

Share this post


Link to post
Share on other sites
41 minutes ago, horst said:

Ok, your test was on a first install of the module, and not as an upgrade, yes?

Yes, it was just a test of a first install. But just now I forked the module and added the new CroppableImage3.module to the module root (nothing else). With the current CI3 version already installed I installed the modified module via "Add Module From URL": https://github.com/Toutouwai/CroppableImage3/archive/master.zip

This seemed to work without a hitch. Installing via the Upgrades module is perhaps a little different, but I have no way to test that.

  • Like 1

Share this post


Link to post
Share on other sites

Anyone else experiencing this issue with the UiKit backend? :-( Any fixes? 

croppableimage3-uikit.jpg

Share this post


Link to post
Share on other sites

Due to less time, I will wait until the UIKit Admin is official / stable, before trying to locate and fix incompatibilities. But any pull request is welcomed.

Share this post


Link to post
Share on other sites
Just now, horst said:

Due to less time, I will wait until the UIKit Admin is official / stable, before trying to locate and fix incompatibilities. But any pull request is welcomed.

Thank you! :-)

  • Like 1

Share this post


Link to post
Share on other sites
3 hours ago, Robin S said:

This seemed to work without a hitch. Installing via the Upgrades module is perhaps a little different, but I have no way to test that.

I will test that again later on, thanks Robin!

Share this post


Link to post
Share on other sites

@Robin S, please can you test an update from an installed version prior to 1.1.0?

I have updated the github repo to 1.1.7.

The first "update" has to be done by installing via ClassName in side -> modules -> new: Module Class Name = CroppableImage3

It has worked for me this way. Existing directory was changed / updated with all new files, old unused files were removed.

And now, after that, it is recognized by the updater module! Yeah!

  • Like 3

Share this post


Link to post
Share on other sites
5 hours ago, horst said:

The first "update" has to be done by installing via ClassName in side -> modules -> new: Module Class Name = CroppableImage3

Yep, all went smoothly with an update from v1.0.0 beta - nice one :-)

  • Like 2

Share this post


Link to post
Share on other sites

Here are the latest "official" notes ;)

 

-------------------------------------------------------------------------

 

Updating from prior versions:

 

Updating from Croppable Image 3 with versions prior to 1.1.7, please do this as a one time step:

In the PW Admin, go to side -> modules -> new, use "install via ClassName" and use CroppableImage3 for the Module Class Name. This will update your existing CroppableImage3 module sub directory, even if it is called a new install. After that, the module will be recogniced by the PW updater module, what makes it a lot easier on further updates. :)

 

-------------------------------------------------------------------------

 

Sticking with a PW legacy 2.8.20+ Version (none namespaced)?

- I have created a CroppableImage2 snapshot, which you can get from the github repo branch: CroppableImage2 


-------------------------------------------------------------------------

  • Like 3

Share this post


Link to post
Share on other sites
On 15.10.2016 at 5:00 PM, horst said:

Maybe the setting is not relevant, but saving it one time before open the cropper modal?

I need to test this.

Hey horst.

Really awesome module!! Guess I stumbled upon it once before, but sadly didn't take the time to really check it out.

Anyways... just installed it and saw the same warning as ukyo before "Notice: Undefined property: stdClass::$manualSelectionDisabled". Going to settings screen and hit Submit resolved it. I'm on 3.0.62.

Keep up the good work!

  • Like 1

Share this post


Link to post
Share on other sites
On 3.9.2016 at 7:59 PM, horst said:

It isn't designed to support this. But I also don't see much disadvantage for this usecase. Lets assume the width you want to support is 1400, 960, 480.

  • Setup the image field with min-width: 1400 and min-height: 788  (= 1400 / 16 * 9)
  • Create a cropsetting image16x9,
  • call it with 100% quality as master-source for the variations

$master = $page->images->first()->getCrop("image16x9", "quality=100");
$large = $master->width(1400);
$medium = $master->width(960);
$small = $master->width(480);

Or directly use the markup srcset module from @tpr and only pass the master to it!

This is what also works for me! But my problem now is, when the user changes the cropping area and saves the image the thumbnail variations are not reset / deleted. Any way this could be done automatically? 

593f99cea0be2_Bildschirmfoto2017-06-13um09_52_12.png.49fc66baf51d7dc7380c3a7665bbaad8.png

Share this post


Link to post
Share on other sites

Not really sure about it, but your cropnames uses - chars, what may conflict with the pageimage suffixes. Suffixes are concatenated with the - char. Maybe you can try to change your names from 3-zu-1 to 3zu1?

Share this post


Link to post
Share on other sites

No, that does not make a difference. I have to manually delete the variations anyway. 

In the file FieldtypeCroppableImage3ConfAdaptor.php there is a unused function called doTheDishes($deleteVariations=false) but as I see it this is nowhere called.

 

Share this post


Link to post
Share on other sites

It isn't unused, it is called everytime the settings get changed. And it do the dishes. :)

Share this post


Link to post
Share on other sites
On 6/13/2017 at 1:51 PM, horst said:

Oh, sorry, your are right. This one is old stuff. It is superseeded by: https://github.com/horst-n/CroppableImage3/blob/0946fdce7b1c9859f94adf764df80d73c201bbbc/FieldtypeCroppableImage3/FieldtypeCroppableImage3.module#L364-L365

And this one cleans out every obsolete variation on setting changes.

I think it's a different thing what @dreerr is talking about.

Consider this scenario:

  1. Set a crop setting on an Image field, eg. "work-thumb, 320, 270"
  2. Use it with a srcset solution (either with a module or manually) and that will make you a 320x270 image and some variations - let's assume only one, 160x135:
    image.-work-thumb.jpg
    image.-work-thumb.160x135.jpg

     

  3. Now edit the image again and crop a different part. The results:

    image.-work-thumb.jpg <- changes according to the new crop
    image.-work-thumb.160x135.jpg <- no change!

     

I'm also interested in a solution because CI3 can't be used for srcset purposes atm if I get it right. What I could imagine as a simple fix is that when CI3 saves a new crop it would delete any size variation of it (in this example all images that are named "image.-work-thumb.WIDTHxHEIGHT.jpg"). Then the srcset generators could re-create these size variations again. Perhaps this behavior could be optionally set in the module's settings.

  • Like 5

Share this post


Link to post
Share on other sites

Hi @tpr,
I will look into this and add a solution that will work properly together with markup-srcset, (and other cases).
Thanks for the clarification. :)

  • Like 6

Share this post


Link to post
Share on other sites

Awesome, thanks!

Share this post


Link to post
Share on other sites
42 minutes ago, horst said:

@mauricemoss, @ukyo, @dreerr, @tpr

I have uploaded an update to the github repo that fixed the PHP notices and added removal of CropImage children after creating a new CropImage.

I've just upgrade it to the new version. I selected my thumbnail predefined crop and then I cropped a new area of the thumbnail but NONE of the variations removed. What I'm doing wrong?

Share this post


Link to post
Share on other sites

Thanks @horst, just checked and I can verify it works as expected!

A few things (nothing biggie):

  • the original image seems to get a new modified date in the filesystem. Is it necessary or a bug?
  • I would love to see a tiny preview of the cropped image (without hover). Would it be possible to append eg. a 0x48px (or so) thumbnail image to the crop size name? Just to have a small indication how it looks like.
  • Tracy shows a PHP notice in the main module's settings page: "PHP Notice: Undefined index: sharpening in .../FieldtypeCroppableImage3ConfAdaptor.php:96"

Anyway I'm happy this issue is fixed, now I can continue uploading images to a site that I put aside. Thanks again!

  • Like 2

Share this post


Link to post
Share on other sites
1 hour ago, tpr said:

Thanks @horst, just checked and I can verify it works as expected!

A few things (nothing biggie):

  • the original image seems to get a new modified date in the filesystem. Is it necessary or a bug?
  • I would love to see a tiny preview of the cropped image (without hover). Would it be possible to append eg. a 0x48px (or so) thumbnail image to the crop size name? Just to have a small indication how it looks like.
  • Tracy shows a PHP notice in the main module's settings page: "PHP Notice: Undefined index: sharpening in .../FieldtypeCroppableImage3ConfAdaptor.php:96"

Anyway I'm happy this issue is fixed, now I can continue uploading images to a site that I put aside. Thanks again!

The originals timestamp gets updated because the new settings for the croprectangle (x/ypos & width/height), and sharpening & quality values get stored into dedicated IPTC-fields. (ATM, for jpeg only, what also is the reason for thinking about other solutions)

Tiny previews is a nice idea. If you don't mind I will take your suggestion and bring it into the module.

Will fix that asap.

Many thanks for checking and suggestions! <3

  • Like 2

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By Gadgetto
      SnipWire - Snipcart integration for ProcessWire
      Snipcart is a powerful 3rd party, developer-first HTML/JavaScript shopping cart platform. SnipWire is the missing link between Snipcart and the content management framework ProcessWire.
      With SnipWire, you can quickly turn any ProcessWire site into a Snipcart online shop. The SnipWire plugin helps you to get your store up and running in no time. Detailed knowledge of the Snipcart system is not required.
      SnipWire is free and open source licensed under Mozilla Public License 2.0! A lot of work and effort has gone into development. It would be nice if you could donate an amount to support further development:

      Status update links (inside this thread) for SnipWire development
      2020-07-03 -- SnipWire 0.8.7 (beta) released! Fixes some small bugs and adds an indicator for TEST mode 2020-04-06 -- SnipWire 0.8.6 (beta) released! Adds support for Snipcart subscriptions and also fixes some problems 2020-03-21 -- SnipWire 0.8.5 (beta) released! Improves SnipWires webhooks interface and provides some other fixes and additions 2020-03-03 -- SnipWire 0.8.4 (beta) released! Improves compatibility for Windows based Systems. 2020-03-01 -- SnipWire 0.8.3 (beta) released! The installation and uninstallation process has been heavily revised. 2020-02-08 -- SnipWire 0.8.2 (beta) released! Added a feature to change the cart and catalogue currency by GET, POST or SESSION param 2020-02-03 -- SnipWire 0.8.1 (beta) released! All custom classes moved into their own namespaces. 2020-02-01 -- SnipWire is now available via ProcessWire's module directory! 2020-01-30 -- SnipWire 0.8.0 (beta) first public release! (module just submitted to the PW modules directory) 2020-01-28 -- added Custom Order Fields feature (first SnipWire release version is near!) 2020-01-21 -- Snipcart v3 - when will the new cart system be implemented? 2020-01-19 -- integrated taxes provider finished (+ very flexible shipping taxes handling) 2020-01-14 -- new date range picker, discount editor, order notifiactions, order statuses, and more ... 2019-11-15 -- orders filter, order details, download + resend invoices, refunds 2019-10-18 -- list filters, REST API improvements, new docs platform, and more ... 2019-08-08 -- dashboard interface, currency selector, managing Orders, Customers and Products, Added a WireTabs, refinded caching behavior 2019-06-15 -- taxes provider, shop templates update, multiCURL implementation, and more ... 2019-06-02 -- FieldtypeSnipWireTaxSelector 2019-05-25 -- SnipWire will be free and open source Plugin Key Features
      Fast and simple store setup Full integration of the Snipcart dashboard into the ProcessWire backend (no need to leave the ProcessWire admin area) Browse and manage orders, customers, discounts, abandoned carts, and more Multi currency support Custom order and cart fields Process refunds and send customer notifications from within the ProcessWire backend Process Abandoned Carts + sending messages to customers from within the ProcessWire backend Complete Snipcart webhooks integration (all events are hookable via ProcessWire hooks) Integrated taxes provider (which is more flexible then Snipcart own provider) Useful Links
      SnipWire in PW modules directory SnipWire Docs (please note that the documentation is a work in progress) SnipWire @GitHub (feature requests and suggestions for improvement are welcome - I also accept pull requests) Snipcart Website  

       
      ---- INITIAL POST FROM 2019-05-25 ----
       
    • By Sten
      Hello
      Till now I hacked something with the twig template but it works no more with new PW versions so I look forward to create a module. I am working on a site in multiple languages : French, English, Italian, German, Spanish, Portuguese, Hebrew, Russian. The new posts are entered in any language with a field for language. Till now, I got twig files to get the translations with constants defined for each part of the pages.
      So I'd like to create a module to include theses files added according to the url /fr/en/...
      Have you some observations to do before I begin about the direction to take ?
      Thank you
    • By ukyo
      Mystique Module for ProcessWire CMS/CMF
      Github repo : https://github.com/trk/Mystique
      Mystique module allow you to create dynamic fields and store dynamic fields data on database by using a config file.
      Requirements
      ProcessWire 3.0 or newer PHP 7.0 or newer FieldtypeMystique InputfieldMystique Installation
      Install the module from the modules directory:
      Via Composer:
      composer require trk/mystique Via git clone:
      cd your-processwire-project-folder/ cd site/modules/ git clone https://github.com/trk/Mystique.git Module in live reaction with your Mystique config file
      This mean if you remove a field from your config file, field will be removed from edit screen. As you see on youtube video.
      Using Mystique with your module or use different configs path, autoload need to be true for modules
      Default configs path is site/templates/configs/, and your config file name need to start with Mystique. and need to end with .php extension.
      Adding custom path not supporting anymore !
      // Add your custom path inside your module class`init` function, didn't tested outside public function init() { $path = __DIR__ . DIRECTORY_SEPARATOR . 'configs' . DIRECTORY_SEPARATOR; Mystique::add($path); } Mystique module will search site/modules/**/configs/Mystique.*.php and site/templates/Mystique.*.php paths for Mystique config files.
      All config files need to return a PHP ARRAY like examples.
      Usage almost same with ProcessWire Inputfield Api, only difference is set and showIf usage like on example.
      <?php namespace ProcessWire; /** * Resource : testing-mystique */ return [ 'title' => __('Testing Mystique'), 'fields' => [ 'text_field' => [ 'label' => __('You can use short named types'), 'description' => __('In file showIf working like example'), 'notes' => __('Also you can use $input->set() method'), 'type' => 'text', 'showIf' => [ 'another_text' => "=''" ], 'set' => [ 'showCount' => InputfieldText::showCountChars, 'maxlength' => 255 ], 'attr' => [ 'attr-foo' => 'bar', 'attr-bar' => 'foo' ] ], 'another_text' => [ 'label' => __('Another text field (default type is text)') ] ] ]; Example:
      site/templates/configs/Mystique.seo-fields.php <?php namespace ProcessWire; /** * Resource : seo-fields */ return [ 'title' => __('Seo fields'), 'fields' => [ 'window_title' => [ 'label' => __('Window title'), 'type' => Mystique::TEXT, // or InputfieldText 'useLanguages' => true, 'attr' => [ 'placeholder' => __('Enter a window title') ] ], 'navigation_title' => [ 'label' => __('Navigation title'), 'type' => Mystique::TEXT, // or InputfieldText 'useLanguages' => true, 'showIf' => [ 'window_title' => "!=''" ], 'attr' => [ 'placeholder' => __('Enter a navigation title') ] ], 'description' => [ 'label' => __('Description for search engines'), 'type' => Mystique::TEXTAREA, 'useLanguages' => true ], 'page_tpye' => [ 'label' => __('Type'), 'type' => Mystique::SELECT, 'options' => [ 'basic' => __('Basic page'), 'gallery' => __('Gallery'), 'blog' => __('Blog') ] ], 'show_on_nav' => [ 'label' => __('Display this page on navigation'), 'type' => Mystique::CHECKBOX ] ] ]; Searching data on Mystique field is limited. Because, Mystique saving data to database in json format. When you make search for Mystique field, operator not important. Operator will be changed with %= operator.
      Search example
      $navigationPages = pages()->find('my_mystique_field.show_on_nav=1'); $navigationPages = pages()->find('my_mystique_field.page_tpye=gallery');
    • By Robin S
      This is a module I made as an experiment a while ago and never got around to releasing publicly. At the time it was prompted by discussions around using Repeater fields for "page builder" purposes, where the depth feature could possibly be used for elements that would be nested inside other elements. I thought it would be useful to enforce some depth rules and translate the depth data into a multi-dimensional array structure.
      I'm not using this module anywhere myself but maybe it's useful to somebody.
      Repeater Depth Helper
      This module does two things relating to Repeater fields that have the "Item depth" option enabled:
      It enforces some depth rules for Repeater fields on save. Those rules are:
      The first item must have a depth of zero. Each item depth must not be more than one greater than previous item depth. It provides a RepeaterPageArray::getDepthStructure helper method that returns a nested depth structure for a Repeater field value.
      Helper method
      The module adds a RepeaterPageArray::getDepthStructure method that returns a multi-dimensional array where the key is the page ID and the value is an array of nested "child" items, or null if there are no nested children.
      Example

      The module doesn't make any assumptions about how you might want to use the depth structure array, but here is a way you might use it to output a nested unordered list.
      // Output a nested unordered list from a depth structure array function outputNestedList($depth_structure, $repeater_items) { $out = "<ul>"; foreach($depth_structure as $page_id => $nested_children) { $out .= "<li>" . $repeater_items->get("id=$page_id")->title; // Go recursive if there are nested children if(is_array($nested_children)) $out .= outputNestedList($nested_children, $repeater_items); $out .= "</li>"; } $out .= "</ul>"; return $out; } $repeater_items = $page->my_repeater; $depth_structure = $repeater_items->getDepthStructure(); echo outputNestedList($depth_structure, $repeater_items);
       
      https://github.com/Toutouwai/RepeaterDepthHelper
      https://modules.processwire.com/modules/repeater-depth-helper/
    • By MoritzLost
      Cacheable Placeholders
      This module allows you to have pieces of dynamic content inside cached output. This aims to solve the common problem of having a mostly cacheable site, but with pieces of dynamic output here and there.  Consider this simple example, where you want to output a custom greeting to the current user:
      <h1>Good morning, <?= ucfirst($user->name) ?></h1> This snippet means you can't use the template cache (at least for logged-in users), because each user has a different name. Even if 99% of your output is static, you can only cache the pieces that you know won't include this personal greeting. A more common example would be CSRF tokens for HTML forms - those need to be unique by definition, so you can't cache the form wholesale.
      This module solves this problem by introducing cacheable placeholders - small placeholder tokens that get replaced during every request. The replacement is done inside a Page::render hook so it runs during every request, even if the response is served from the template cache. So you can use something like this:
      <h1>Good morning, {{{greeting}}}</h1> Replacement tokens are defined with a callback function that produces the appropriate output and added to the module through a simple hook:
      // site/ready.php wire()->addHookAfter('CachePlaceholders::getTokens', function (HookEvent $e) { $tokens = $e->return; $tokens['greeting'] = [ 'callback' => function (array $tokenData) { return ucfirst(wire('user')->name); } ]; $e->return = $tokens; }); Tokens can also include parameters that are parsed and passed to the callback function. There are more fully annotated examples and step-by-step instructions in the README on Github!
      Features
      A simple and fast token parser that calls the appropriate callback and runs automatically. Tokens may include multiple named or positional parameters, as well as multi-value parameters. A manual mode that allows you to replace tokens in custom pieces of cached content (useful if you're using the $cache API). Some built-in tokens for common use-cases: CSRF-Tokens, replacing values from superglobals and producing random hexadecimal strings. The token format is completely customizable, all delimiters can be changed to avoid collisions with existing tag parsers or template languages. Links
      Github Repository & documentation Module directory If you are interested in learning more, the README is very extensive, with more usage examples, code samples and usage instructions!
×
×
  • Create New...