Jump to content
horst

Croppable Image 3

Recommended Posts

15 hours ago, PWaddict said:

@horst I fixed the cache problem on cropping by replacing the 145 line on ProcessCroppableImage3.module with this:


'imageUrl' => $imageUrl . "?nc=" . $img->mtime,

 

I added the timestamp to the url. So I wasn't able to reproduce this issue, but cannot see any harm by adding the timestamp to the url.

If you think this should be added to the core Variations Page, please make an issue at Github.

  • Like 1

Share this post


Link to post
Share on other sites
1 hour ago, tpr said:

@horst Could you add this JS fix too?

 

 

Using this js fix or not when I press "Accept Crop" and the modal closes the icon-size thumb disappears. I'm getting this error on console: Failed to load resource: the server responded with a status of 404 () testing.-thumbnailn.jpg. This issue happens only after you saved the page.

It should load the file as testing.-thumbnail.0x48n.jpg. The timestamp also must be used on that too in order to get always the last modified thumb and not the very first cached one.

Share this post


Link to post
Share on other sites
1 hour ago, PWaddict said:

It should load the file as testing.-thumbnail.0x48n.jpg

No. After you make a crop and close the modal (Accept), no 0x48 image is generated (perhaps the module should do this?). That's why I load the original thumb instead (this is fast because it's cached by the browser). On next crops I toggle the "?v=1" "?v=2" params, in my tests it was enough to bypass the browser cache.

It's hard to tell what goes wrong for you until I can duplicate the issue. Could you share your settings and workflow exactly? (PM is ok too)

  • Like 1

Share this post


Link to post
Share on other sites
56 minutes ago, tpr said:

No. After you make a crop and close the modal (Accept), no 0x48 image is generated (perhaps the module should do this?). That's why I load the original thumb instead (this is fast because it's cached by the browser). On next crops I toggle the "?v=1" "?v=2" params, in my tests it was enough to bypass the browser cache.

It's hard to tell what goes wrong for you until I can duplicate the issue. Could you share your settings and workflow exactly? (PM is ok too)

I'm currently testing it on localhost. It doesn't load the original thumb. It loads an image that doesn't exists.

Original thumb
testing.-thumbnail.jpg

Currently loads this non available image
testing.-thumbnailn.jpg

You have to modify the js code to remove the cropping values too. I'm using cropping = north. That's why the "n".

Share this post


Link to post
Share on other sites

@tpr if this is right, (I haven't tested it), we would need something that works with all possible variation names. On weekend I can setup a test system, (also online), and check all combinations. (and give you access to it if you like).

Share this post


Link to post
Share on other sites

Yes, crop orientation is the culprit (added via $config->imageSizerOptions array, at least that's how I could see it).

I've made the fixes here, please try:

https://github.com/rolandtoth/CroppableImage3

This should be a generic fix, I pass the image url from the crop review modal to the js. Additionally, only the current preview btn image is refreshed and not all (unlike before).

  • Like 2

Share this post


Link to post
Share on other sites
46 minutes ago, tpr said:

Yes, crop orientation is the culprit (added via $config->imageSizerOptions array, at least that's how I could see it).

I've made the fixes here, please try:

https://github.com/rolandtoth/CroppableImage3

This should be a generic fix, I pass the image url from the crop review modal to the js. Additionally, only the current preview btn image is refreshed and not all (unlike before).

Works great. One small fix from me. After saving the page or revisiting it I'm seeing a previous cached icon-size thumb. This happening even on localhost. So, I fixed it by replacing the 155 line on InputfieldCroppableImage3.module with this:

$out .= $warning ? '' : " <img src='{$pagefile->getCrop($suffix)->height(48)->url}?nc={$pagefile->mtime}' alt='' />";  // added a small indicator thumb to each crop-button

 

  • Like 2

Share this post


Link to post
Share on other sites

@horst @tpr After closing the modal the hover tooltip appears and it feels like a glitch cause it also half-cover the button preview.

I fixed it by replacing the 34 line on InputfieldCroppableImage3.js with this:

items: 'a:hover'

Thank you very much guys for your work :)

  • Like 1

Share this post


Link to post
Share on other sites

Yes, please do. will merge it later today and do a more indepth test on weekend.

Thanks you both. :)

Share this post


Link to post
Share on other sites

I've made a few CSS changes, now preview buttons look the same in all 3 image grid modes and I've fixed some other glitches too. The CSS file was a bit overcomplicated, I could eliminate large blocks so I hope I haven't broken anything :) 

I also checked the preview images with more than one crop setting (multiple buttons) and it's working fine here. All is in the PR.

  • Like 4

Share this post


Link to post
Share on other sites

Hi, I have a problem with the automatic cropping of pictures which are in other orientations. The automatic correction of pw works like a charm and the manual cropping works also fine. But the automatic cropping gives me the other orientation in which the picture was uploaded. Is there any fix for this?

Share this post


Link to post
Share on other sites
On 29.5.2017 at 3:06 PM, noodles said:

Anyone else experiencing this issue with the UiKit backend? :-( Any fixes?

 

Just in time with the new AdminThemeUiKit and RenoSkin, there is a fixed version of CroppableImage3 pushed to the repo today.

Many thanks for his help goes to @tpr !! ^-^

 

screen_cai3_uikit.png.711b59c9bd51986ebcd0a0317ac86aa5.png

  • Like 3
  • Thanks 1

Share this post


Link to post
Share on other sites
On 12.9.2017 at 5:26 PM, hheyne said:

Hi, I have a problem with the automatic cropping of pictures which are in other orientations. The automatic correction of pw works like a charm and the manual cropping works also fine. But the automatic cropping gives me the other orientation in which the picture was uploaded. Is there any fix for this?

@hheyne the orientation problem is core related. Whereas it is no problem in all core related api image handling, it is one in CAI3. But there is no simple fix known atm. Maybe one should hook into upload and save those images rotated (with quality 100 and sharpening 'none') as original replacement?! At least as workaround until there is found a system wide solution for the orientation problem.

Share this post


Link to post
Share on other sites

Hi Horst, I saw from a screenshot you posted earlier that you found a way to remove the PW Crop button (next to the Variations button).

(My users get confused by the cropping the module requires and they need to do -  and the additional generic PW cropping button.)

How did you hide that generic PW crop button? Did I miss a setting somewhere?

Share this post


Link to post
Share on other sites
38 minutes ago, ceberlin said:

Hi Horst, I saw from a screenshot you posted earlier that you found a way to remove the PW Crop button (next to the Variations button).

(My users get confused by the cropping the module requires and they need to do -  and the additional generic PW cropping button.)

How did you hide that generic PW crop button? Did I miss a setting somewhere?

Install the Admin Custom Files module. On site/templates/AdminCustomFiles folder create a css file named ProcessPageEdit.css and add the following code:

.InputfieldImageButtonCrop {
	display: none !important;
}

Then on the Admin Custom Files module settings at the "Activate for process" section select ProcessPageEdit, (Page Edit).

  • Like 2
  • Thanks 1

Share this post


Link to post
Share on other sites
21 hours ago, ceberlin said:

Hi Horst, I saw from a screenshot you posted earlier that you found a way to remove the PW Crop button (next to the Variations button).

(My users get confused by the cropping the module requires and they need to do -  and the additional generic PW cropping button.)

How did you hide that generic PW crop button? Did I miss a setting somewhere?

I used this line, (uncommented), to hide them. But maybe this will have side-efects if you use it together with core imagefields in your pages.

Better to use it the way @PWaddict said!

  • Thanks 1

Share this post


Link to post
Share on other sites

Thanks for this great module! I am finding responsive image solutions and then I luckily come here.

I have encountered an issue after I install the module. I tried to change the inputfield type of an existing image field to croppable image3. The croppable image3 specific crop setting is not there after switching. So, in the edit, it is just look the same as the normal image field. Sorry if it has been reported before as I did not read all replies one by one.

Share this post


Link to post
Share on other sites

I know this behave. You need to save it 2 - 3 times during the switch process. I believe this has to do with pw core, not only that module.

  • Thanks 1

Share this post


Link to post
Share on other sites

Hi there. I have encounter another issue that what ever I change the sharpen and quality during cropping, the sharpen and quality are always showing soft and 90 respectively after confirm the crop. The resulting images are the same too, so it is simply not a display issue.

Share this post


Link to post
Share on other sites

Bump. I confirm the same issue in a fresh installed latest PW3. I want to debug but TracyDebugger is not loading in this module.

Share this post


Link to post
Share on other sites

please can you describe a bit precise:

wich version are you using

what are you doing exactly (how do you do it)

what is the desired output / behave

and what is the real output / behave

Share this post


Link to post
Share on other sites

The module is installed by module installer using module name. The module version is 1.1.10. PW version 3.0.83.

Step1: Change the seting and hit "Crop And Go".

step1.jpg.242c70b00358733e6971f93513b3a555.jpg

Step2: Jump to the confirmation. The quality and sharpening remain unchanged. (Should be changed to 75 and none as above here)

step2.jpg.21170f339552b6fe410a0cb68aafead0.jpg

Step3: Repeat above steps with default setting(soft, 90).

Step4: Check the image cropped by changed setting and default setting. They have the same file size.

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By d'Hinnisdaël
      Happy new year, everybody 🥬
      I've been sitting on this Dashboard module I made for a client and finally came around to cleaning it up and releasing it to the wider public. This is how it looks.
      ProcessWire Dashboard

      If anyone is interested in trying this out, please go ahead! I'd love to get some feedback on it. If this proves useful and survives some real-world testing, I'll add this to the module directory.
      Download
      You can find the latest release on Github.
      Documentation
      Check out the documentation to get started. This is where you'll find information about included panel types and configuration options.
      Custom Panels
      My goal was to make it really simple to create custom panels. The easiest way to do that is to use the panel type template and have it render a file in your templates folder. This might be enough for 80% of all use cases. For anything more complex (FormBuilder submissions? Comments? Live chat?), you can add new panel types by creating modules that extend the DashboardPanel base class. Check out the documentation on custom panels or take a look at the HelloWorld panel to get started. I'm happy to merge any user-created modules into the main repo if they might be useful to more than a few people.
       Disclaimer
      This is a pre-release version. Please treat it as such — don't install it on production sites. Just making sure 🍇
      Roadmap
      These are the things I'm looking to implement myself at some point. The wishlist is a lot longer, but those are the 80/20 items that I probably won't regret spending time on.
      Improve documentation & add examples ⚙️ Panel types Google Analytics ⚙️ Add new page  🔥 Drafts 🔥 At a glance / Page counter 404s  Layout options Render multiple tabs per panel panel groups with heading and spacing between ✅ panel wrappers as grid item (e.g. stacked notices) ✅ Admin themes support AdminThemeReno and AdminThemeDefault ✅ Shortcuts panel add a table layout with icon, title & summary ✅ Chart panel add default styles for common chart types ✅ load chart data from JS file (currently passed as PHP array) Collection panel support image columns ✅ add buttons: view all & add new ✅
    • By Gadgetto
      Status update links (inside this thread) for SnipWire development will be always posted here:
      2020-01-14 --> new date range picker, discount editor, order notifiactions, order statuses, and more ... 2019-11-15 --> orders filter, order details, download + resend invoices, refunds 2019-10-18 --> list filters, REST API improvements, new docs platform, and more ... 2019-08-08 --> dashboard interface, currency selector, managing Orders, Customers and Products, Added a WireTabs, refinded caching behavior 2019-06-15 --> taxes provider, shop templates update, multiCURL implementation, and more ... 2019-06-02 --> FieldtypeSnipWireTaxSelector 2019-05-25 --> SnipWire will be free and open source If you are interested, you can test the current state of development:
      https://github.com/gadgetto/SnipWire
      Please note that the software is not yet intended for use in a production system (alpha version).
      If you like, you can also submit feature requests and suggestions for improvement. I also accept pull requests.
      ---- INITIAL POST FROM 2019-05-25 ----
      I wanted to let you know that I am currently working on a new ProcessWire module that fully integrates the Snipcart Shopping Cart System into ProcessWire. (this is a customer project, so I had to postpone the development of my other module GroupMailer).
      The new module SnipWire offers full integration of the Snipcart Shopping Cart System into ProcessWire.
      Here are some highlights:
      simple setup with (optional) pre-installed templates, product fields, sample products (quasi a complete shop system to get started immediately) store dashboard with all data from the snipcart system (no change to the snipcart dashboard itself required) Integrated REST API for controlling and querying snipcart data webhooks to trigger events from Snipcart (new order, new customer, etc.) multi currency support self-defined/configurable tax rates etc. Development is already well advanced and I plan to release the module in the next 2-3 months.
      I'm not sure yet if this will be a "Pro" module or if it will be made available for free.
      I would be grateful for suggestions and hints!
      Please have a look at the screenshots to get an idea what I'm talking about (open spoiler):
      (Please note: these screenshots are from an early development state of SnipWire. To see actual screens please have a look at later posts below!)
       
    • By Robin S
      This module is inspired by and similar to the Template Stubs module. The author of that module has not been active in the PW community for several years now and parts of the code for that module didn't make sense to me, so I decided to create my own module. Auto Template Stubs has only been tested with PhpStorm because that is the IDE that I use.
      Auto Template Stubs
      Automatically creates stub files for templates when fields or fieldgroups are saved.
      Stub files are useful if you are using an IDE (e.g. PhpStorm) that provides code assistance - the stub files let the IDE know what fields exist in each template and what data type each field returns. Depending on your IDE's features you get benefits such as code completion for field names as you type, type inference, inspection, documentation, etc.
      Installation
      Install the Auto Template Stubs module.
      Configuration
      You can change the class name prefix setting in the module config if you like. It's good to use a class name prefix because it reduces the chance that the class name will clash with an existing class name.
      The directory path used to store the stub files is configurable.
      There is a checkbox to manually trigger the regeneration of all stub files if needed.
      Usage
      Add a line near the top of each of your template files to tell your IDE what stub class name to associate with the $page variable within the template file. For example, with the default class name prefix you would add the following line at the top of the home.php template file:
      /** @var tpl_home $page */ Now enjoy code completion, etc, in your IDE.

      Adding data types for non-core Fieldtype modules
      The module includes the data types returned by all the core Fieldtype modules. If you want to add data types returned by one or more non-core Fieldtype modules then you can hook the AutoTemplateStubs::getReturnTypes() method. For example, in /site/ready.php:
      // Add data types for some non-core Fieldtype modules $wire->addHookAfter('AutoTemplateStubs::getReturnTypes', function(HookEvent $event) { $extra_types = [ 'FieldtypeDecimal' => 'string', 'FieldtypeLeafletMapMarker' => 'LeafletMapMarker', 'FieldtypeRepeaterMatrix' => 'RepeaterMatrixPageArray', 'FieldtypeTable' => 'TableRows', ]; $event->return = $event->return + $extra_types; }); Credits
      Inspired by and much credit to the Template Stubs module by mindplay.dk.
       
      https://github.com/Toutouwai/AutoTemplateStubs
      https://modules.processwire.com/modules/auto-template-stubs/
    • By Mike Rockett
      Jumplinks for ProcessWire
      Release: 1.5.60
      Composer: rockett/jumplinks
      ⚠️ NOTICE: 1.5.60 is an important security patch-release for an XSS vulnerability discovered by @phlp. It's HIGHLY RECOMMENDED that all Jumplinks users update to the latest version as soon as possible.
      Jumplinks is an enhanced version of the original ProcessRedirects by Antti Peisa.
      The Process module manages your permanent and temporary redirects (we'll call these "jumplinks" from now on, unless in reference to redirects from another module), useful for when you're migrating over to ProcessWire from another system/platform. Each jumplink supports wildcards, shortening the time needed to create them.
      Unlike similar modules for other platforms, wildcards in Jumplinks are much easier to work with, as Regular Expressions are not fully exposed. Instead, parameters wrapped in curly braces are used - these are described in the documentation.
      Under Development: 2.0, to be powered by FastRoute
      As of version 1.5.0, Jumplinks requires at least ProcessWire 2.6.1 to run.
      View on GitLab
      Download via the Modules Directory
      Read the docs
      Features
      The most prominent features include:
      Basic jumplinks (from one fixed route to another) Parameter-based wildcards with "Smart" equivalents Mapping Collections (for converting ID-based routes to their named-equivalents without the need to create multiple jumplinks) Destination Selectors (for finding and redirecting to pages containing legacy location information) Timed Activation (activate and/or deactivate jumplinks at specific times) 404-Monitor (for creating jumplinks based on 404 hits) Additionally, the following features may come in handy:
      Stale jumplink management Legacy domain support for slow migrations An importer (from CSV or ProcessRedirects) Feedback & Feature Requests
      I’d love to know what you think of this module. Please provide some feedback on the module as a whole, or even regarding smaller things that make it whole. Also, please feel free to submit feature requests and their use-cases.
      Note: Features requested so far have been added to the to-do list, and will be added to 2.0, and not the current dev/master branches.
      Open Source

      Jumplinks is an open-source project, and is free to use. In fact, Jumplinks will always be open-source, and will always remain free to use. Forever. If you would like to support the development of Jumplinks, please consider making a small donation via PayPal.
      Enjoy! 🙂
    • By Robin S
      Add Image URLs
      Allows images/files to be added to Image/File fields by pasting URLs.

      Usage
      Install the Add Image URLs module.
      A "Paste URLs" button will be added to all image and file fields. Use the button to show a textarea where URLs may be pasted, one per line. Images/files are added when the page is saved.
       
      https://github.com/Toutouwai/AddImageUrls
      https://modules.processwire.com/modules/add-image-urls/
×
×
  • Create New...