Module AdminOnSteroids

[tpr]

No, I haven't noticed this. I'll check it some day, I don't understand all of it atm ?

[adrian]

Hey @tpr

I have been seeing this a bit lately:

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in /site/modules/AdminOnSteroids/AdminOnSteroids.module on line 2622

 

[tpr]

@adrian Probably yes, I've changed that, thanks.

Yesterday I added a "translatorModal" tweak to Misc that allows editing translations in a modal, hope you find it useful.

[adrian]

Hey @tpr - not sure what its purpose is, but:

html.aos {
    overflow: overlay;
}

does weird things to fixed position elements. For example, when Tracy is disabled, the icon that appears in place of the debug bar (to re-enable it) is positioned under the vertical scrollbar. If I remove this overflow rule, it is positioned as expected.

Thanks!

[bernhard]

hey @tpr, is there a way to disable the filterbox on some admindatatables, eg via adding "nofilterbox" class to the table?

Edit: Created a PR

[tpr]

Thanks @adrian and @bernhard, I'll take care of these in the following days.

[tpr]

All done. @bernhard I had to modify return false to true to to keep processing other tables in the loop (if any).

[ottogal]

Hi @tpr,

I found an irritating behaviour when using the submodule ListerTweaks. If I make a custom selection of the Users lister columns,

it will not be reflected in the columns selection on the Users page:
There the default selection is displayed, and trying to change it has no effect.

[tpr]

I remember seeing this bug earlier but couldn't fix it. I'll give it another try some day, thanks for bringing this up.

[rafaoski]

Hi, @tpr and thanks you for adding this useful module.
After switching on AdminOnSteroids I noticed a small problem appearing when opening and closing the repeater, but only in Mozilla Firefox and Admi Theme Uikit. After opening the single repeater, it remains in the open position.
I'm not fluent in JS and I do not know where the error is, but the console shows me information as below.

Error: Permission denied to access property "apply"

SERVER DETAILS
ProcessWire: 3.0.126
PHP: 7.3.1
Webserver: Apache/2.4.35 (Win64) OpenSSL/1.1.1a
MySQL: 5.7.24

MODULE DETAILS
AdminOnSteroids: 2.0.13
ProcessTracyAdminer: 1.0.6
TracyDebugger: 4.17.22

[tpr]

I'm not sure but perhaps it's a cross-domain issue, perhaps caused by a Firefox addon, I got the idea from here:

Quote

This only happens with Firefox addons that try to insert a <script> tag that points to an external cross-domain script.

 

[rafaoski]

Thanks for the answer ...
It seems that the LastPass plugin generate error ...
After turning off the add-on LastPass  everything has returned to normal ...

[tpr]

What do you think about appending the field type to the Fields asmSelect list options? I often don't remember the type by the name so it would come handy. However, since it's a plain select HTML element it cannot be styled and in the rendered asmSelect the type appears twice (also at the end of the bars).

[szabesz]

8 hours ago, tpr said:

What do you think about appending the field type to the Fields asmSelect list options?

I like it ? Not beautiful but does the trick.

[tpr]

Actually having the field type appended to the name is quite handy when used together with the "add search box to asmSelect" feature because field types can also be searched.

So for example you can easily find CroppableImage3 image o CKEditor fields, etc, which is a huge help when there are a lot of fields.

[tpr]

OK, due to the popular demand towards this feature it's been added to v2.0.14 ? 

Some changes:

• the new suffix contains the field type (eg. "Textarea"), and the inputfield class if it's different from it (eg. "CKEditor")
• the optional inputfieldClass is not added if it's the language variant (to avoid situations like "excerpt - TextareaLanguage (Textarea)"
• on the right side of the bars the original field type string is removed (before the percentage) not to display it twice

[szabesz]

12 hours ago, tpr said:

due to the popular demand

Thanks a lot for caring! I'm pretty sure that those who could not click the like button are just away for a long weekend ?

[tpr]

I've added data-attributes to field wrappers in v2.0.15 containing information about the included field. Unlike the info currently available it's not on the inputfield itself but on its wrapper, making admin CSS/JS customizations easier to apply.

https://github.com/rolandtoth/AdminOnSteroids/wiki/Misc

[Brian Peat]

Hello!

I'm brand new to ProcessWire (having been a Joomla! guy for many years and then adding Wordpress to my toolkit more recently). I've taken on a new client and their site uses ProcessWire. Last night I got the joy (lol) of moving their site to my large VPS and learning the ins and outs of PW. They were running PHP 7.0 and I bumped them to PHP 7.3. After fixing a bunch of front end issues with their theme, everything looks good except that in the admin, AdminOnSteroids is throwing some notices:

PHP Notice: Trying to get property 'template' of non-object in .../AdminOnSteroids/AdminOnSteroids.module:2970   
PHP Notice: Trying to get property 'name' of non-object in .../AdminOnSteroids/AdminOnSteroids.module:2970

Does anyone know how to fix this? I can hack my way around some PHP, but I'm not a programmer, so this one is a bit beyond my understanding. Any help would be appreciated.

[netcarver]

@Brian Peat Hello Brian,

Welcome to the forum & thank you for your first post. I hope @tpr - the author of this module - picks this up quickly for you (he's usually very responsive.) Although I'm reluctant to suggest a fix for that line in the module (I'm not wholly familiar with TPR's intention there and simply suppressing the notice might be hiding a larger issue) I do hope you end up enjoying working with ProcessWire and interacting here in the forums!

Best wishes,
Steve

[horst]

@Brian Peat welcome. One thought regarding the module: what version is the AOS module?  When going in admin under modules site adminonsteroids, there is a feature to directly check for newer versions. Maybe you are not running the latest version, where these issues are already fixed? At least there is no harm with updating AOS to the latest.  

 

[Brian Peat]

@horst I'm up to date as far as I know. It's running 2.0.15.

I may edit my hosts file so I can see their old site again and check in there. It's possible they've been ignoring the errors for a while, but I'm not sure.

Thanks!

[tpr]

Hi @Brian Peat,

that line fails if a template doesn't have a name

I was wrong, it's the editedPage being null, will add a check.

[Brian Peat]

@tpr No, I haven't fiddled in the database. I'm thinking this template is old though, and is likely missing some things. I had to add the name space to a few files and also fix a few things that wouldn't play nice with PHP 7.3.

[MilenKo]

Hey there. This morning I upgraded AOS for a project to latest version 2.0.15 and started noticing some issue viewing the hidden/unpublished pages in the admin. Tried to uninstall the module and grabbed a fresh copy, however the same issue appeared.

If I move my mouse over those that are not showing but only ID's are listed, they all appear fine:

Started disabling options of AOS in order to check which one would be causing the issue and it appeared that it is the PageList tweaks and more specifically: Show page IDs (SuperUser only) . I did not set any other options, however if I remove this one, the list shows properly. The issue seems to appear on both themes - default and uikit. Any ideas how could I keep the page ID's showing but keeping the hidden pages visible? Is this a feature/option I've missed or else?