Jump to content
adrian

Tracy Debugger

Recommended Posts

Hi @bernhard - I have upped them to 9999 here locally - I'll commit it to the next version.

Hi @rick - that might be possible, but I am curious about why you want this - for me it's about quickly and temporarily getting every Tracy related hidden so I can see what's behind on the main page content. 

  • Thanks 1

Share this post


Link to post
Share on other sites

When I have a panel maximized, sometimes the 3 or 4 lines of the tracy bar cover some content. It's no biggie, I just expected the panel to remain in view and surprised me when it kept closing after minimizing the toolbar.

 

Share this post


Link to post
Share on other sites
On 8/10/2018 at 11:24 AM, rick said:

When I have a panel maximized, sometimes the 3 or 4 lines of the tracy bar cover some content. It's no biggie, I just expected the panel to remain in view and surprised me when it kept closing after minimizing the toolbar.

Typically the simple solution for this would be to drag the Tracy debug bar out of the way - this will work so long as you don't have the "Fixed Position" option checked in the config settings.

 

Share this post


Link to post
Share on other sites

Hi everyone - @netcarver has mentioned to me that he's not a fan of some of the ambiguity of the icon colors in the debug bar - mostly the blue for the System Info icon and the PW pink color used by the PW Info and Captain Hook panels, and the purple used by the PHP Info panel. I have quickly mocked up a version where these are all grey:

image.thumb.png.523ac587c1e3956e5d7715c3fed14eff.png

He wanted me to poll you guys to get some input on this change and also any other changes you might like to see. 

In general the idea with icon colors is:

grey - no significance
green - everything ok - no attention needed
orange - warning or attention to a new entry/item of interest
red - warning, fail, or something else that you should be aware of

So please post your thoughts - what do you think can be done to make it look cleaner and also more meaningful/useful?

Thanks!

  • Like 2
  • Thanks 2

Share this post


Link to post
Share on other sites
1 hour ago, adrian said:

In general the idea with icon colors is:

grey - no significance
green - everything ok - no attention needed
orange - warning or attention to a new entry/item of interest
red - warning, fail, or something else that you should be aware of

I haven't found the icons ambiguous so far, but the colour scheme you're suggesting sounds like it would be a good enhancement.

  • Like 1

Share this post


Link to post
Share on other sites
7 hours ago, Robin S said:

I haven't found the icons ambiguous so far, but the colour scheme you're suggesting sounds like it would be a good enhancement.

+1

  • Like 1

Share this post


Link to post
Share on other sites

Just to clarify my request to Adrian, it's not the icons that I'm finding ambiguous - there's nothing wrong with them IMO - it's what the colours are signalling in the current version of Tracy that I find a little confusing.

This is what I'm trying to avoid - particularly the part between 24 and 43 seconds...

Here's the current state of play...

screeny-0049.png.d1efee3239fdf9e9fdbd91afa7b79617.png

To me - with my now aging eyes - the colours of...

  • 2, 5 & 7 seem to be signalling an error condition or something that needs my attention and that this icon could be another colour when the error is sorted out.
  • 3, D & H are warning me of something and these icons could be another colour at other times.
  • 4, 6, 8, 9, A, (all the green ones) have no error - but they could have warnings or errors at other times.
  • All the grey ones are - well, I don't know - are they OK? Or Off? Or just buttons to press when I need them?
  • 1 & F are signalling something else to me that's different to all the above.

Whilst some of the above is correct, I don't think it's clear in the current incarnation.

I also think that the decision to colour some icons green rather than grey when there are no warnings or errors, might, arguably, need revisiting. (For example - I think B (Mail interceptor) and C (Module switcher) would probably be better as Grey in the above if there is no interception or disabling going on.)

Basically I'd like to have Tracy only use non-grey colour signalling to me if there is something that needs my attention or constant reminder. I think that would stop me feeling a little like Richmond from the IT Crowd.

BTW - I'm not dishing Tracy or the work Adrian's put in. I think one of the top modules there are for PW and I'm very pleased that Adrian's produced it and for all the hard work he's put in on it.

Hope that clarifies where I'm coming from,
Steve

 

  • Like 4

Share this post


Link to post
Share on other sites
13 hours ago, adrian said:

grey - no significance
green - everything ok - no attention needed
orange - warning or attention to a new entry/item of interest
red - warning, fail, or something else that you should be aware of

Sounds great, just one question: how will you decide which "warning color" to use, orange vs red? I guess red should not be used for warnings at all. On the same account: "something else that you should be aware of" will be "fail / error / you-MUST-be-aware-of", right?

Share this post


Link to post
Share on other sites

I just wanted to clarify that the grey/green/orange/red color scheme is already in place and has been since the beginning of the module. As per my mockup above I am more than happy to make all the icons that don't need this scheme grey instead of PW pink or PHP purple, or blue (the System Info icon). Hopefully we're all good with that change.

7 hours ago, netcarver said:

I also think that the decision to colour some icons green rather than grey when there are no warnings or errors, might, arguably, need revisiting. (For example - I think B (Mail interceptor) and C (Module switcher) would probably be better as Grey in the above if there is no interception or disabling going on.)

Basically I'd like to have Tracy only use non-grey colour signalling to me if there is something that needs my attention or constant reminder. I think that would stop me feeling a little like Richmond from the IT Crowd.

I think this approach of grey instead of green to indicate no attention needed will be fine - I can't currently see any reason not to make this change. 

 

4 hours ago, szabesz said:

just one question: how will you decide which "warning color" to use, orange vs red? I guess red should not be used for warnings at all.

I think there will always be some difficulties in determining what should be orange and what should be red, although I do think that if we get rid of green altogether it will actually be simpler, for example I always felt a bit weird about debug mode set to on resulting in red. I think a new grey / orange only combo is probably much nicer. Orange being a warning that you need to be aware of the fact that it's on and this is a security concern on a live site.

 

8 hours ago, netcarver said:

BTW - I'm not dishing Tracy or the work Adrian's put in. I think one of the top modules there are for PW and I'm very pleased that Adrian's produced it and for all the hard work he's put in on it.

No problem at all - as with most things, Tracy has evolved and wasn't really planned from the beginning, so more than happy to revisit this stuff now and I really appreciate everyone's input.

  • Like 3

Share this post


Link to post
Share on other sites

Also, if there are any icon geeks out there, I'd love some help to revamp the icons on the debug bar - many of them are very ugly 🙂 

Any takers?

Share this post


Link to post
Share on other sites
19 minutes ago, adrian said:

Any takers?

I can do it on a one-by-one basis. Not too much free time these days but if we are not in a hurry... 🙂 

  • Like 2

Share this post


Link to post
Share on other sites
3 minutes ago, szabesz said:

I can do it on a one-by-one basis. Not too much free time these days but if we are not in a hurry... 🙂 

Sounds good - I don't think you need to go creating them - probably just need to spend some time looking around for better free ones, but whatever you think would be great.

I think regardless of how you go about creating or finding them we should wait till you have them all ready before committing any changes.

  • Like 2

Share this post


Link to post
Share on other sites

Just the default icons to give you guys an idea, but how's this looking?

image.png.46fba262511a7dabcee0bc52d56c8aff.png

Still not sure if Debug Mode icon on should be orange or red?

Perhaps I should check if on local dev or live server and go with grey for the former and red for the latter where it really is important!

  • Like 2

Share this post


Link to post
Share on other sites
1 hour ago, adrian said:

local dev or live server and go with grey for the former and red for the latter

+1

2 hours ago, adrian said:

Sounds good - I don't think you need to go creating them - probably just need to spend some time looking around for better free ones, but whatever you think would be great.

I think regardless of how you go about creating or finding them we should wait till you have them all ready before committing any changes.

I don wanna reinvent the wheel 🙂 but even free ones should be used as starting points only and most importantly they must look like one family, so that is where most efforts should be put into (besides pleasing the eye, of course...).

Edited by szabesz
typo
  • Like 1

Share this post


Link to post
Share on other sites

New version just committed contains all the icon color changes. Mostly it's just consolidating the default color to grey and changing a few instances of when orange (WARN) vs red (ALERT) is used.

Let me know if you find anything I have missed or any inconsistencies.

image.thumb.png.a70e0d1703859d163101324b5a2370d4.png 

  • Like 5

Share this post


Link to post
Share on other sites
4 minutes ago, bernhard said:

thanks - already using it and i like it! 🙂 

Thanks!

Also, just an FYI that your bdb and db 999 has been changed to 9999 in that version.

  • Thanks 1

Share this post


Link to post
Share on other sites
1 minute ago, adrian said:

Also, just an FYI that your bdb and db 999 has been changed to 9999 in that version.

Thank you. Actually I came up with a somewhat different idea. I had to debug something yesterday and needed ['debugInfo' => false] several times. In fact I need it that often that I can even remember it by heart 😄 

My Idea: What if we had a bdv() method instead of bdb, meaning barDumpVerbose() that has a limit of 9999 AND debuginfo set to false?

Share this post


Link to post
Share on other sites
1 minute ago, bernhard said:

Thank you. Actually I came up with a somewhat different idea. I had to debug something yesterday and needed ['debugInfo' => false] several times. In fact I need it that often that I can even remember it by heart 😄 

My Idea: What if we had a bdv() method instead of bdb, meaning barDumpVerbose() that has a limit of 9999 AND debuginfo set to false?

I am getting a little annoyed with the debugInfo output myself actually - there are lots of holes in it's output - there is a bit of a discussion about it here: https://github.com/processwire/processwire-issues/issues/575 but it would be a lot of work for Ryan to go through all of PW and set this up properly. 

Of course there is a config setting to make the default behavior show the full PW object, but there are times when the debugInfo output is better/easier.

I mentioned above somewhere that I was thinking about having an option to dump both versions automatically with any dump/bardump call - best of both worlds. What do you think about this as an alternative?

Not saying I don't like the verbose idea - I just want to make sure we don't end up with more options than we need. It might also be confusing if you already have debugInfo off by default in the config settings. I don't know - anyone else have any thoughts?

  • Like 2

Share this post


Link to post
Share on other sites
2 minutes ago, adrian said:

I mentioned above somewhere that I was thinking about having an option to dump both versions automatically with any dump/bardump call - best of both worlds. What do you think about this as an alternative?

not sure how that should look like exactly but it sounds good to me 🙂

  • Like 2

Share this post


Link to post
Share on other sites
44 minutes ago, adrian said:

New version just committed contains all the icon color changes. Mostly it's just consolidating the default color to grey and changing a few instances of when orange (WARN) vs red (ALERT) is used.

Let me know if you find anything I have missed or any inconsistencies.

image.thumb.png.a70e0d1703859d163101324b5a2370d4.png 

Thank you for working on this, Adrian. Looks a lot clearer now.

  • Like 3

Share this post


Link to post
Share on other sites
5 hours ago, bernhard said:
5 hours ago, adrian said:

I mentioned above somewhere that I was thinking about having an option to dump both versions automatically with any dump/bardump call - best of both worlds. What do you think about this as an alternative?

not sure how that should look like exactly but it sounds good to me 🙂

Would it mean that we have to click twice to see one of them? First a click on the arrow next to the class name, after that another click on either debugInfo or PW object? Or maybe you "extend" debug info and PW object gets injected into it?

Either way, I think it would be nice to see the id of a Page object without clicking on anything, somewhere between the class name and the arrow. Is that possible?

Share this post


Link to post
Share on other sites
7 hours ago, adrian said:

New version just committed contains all the icon color changes. Mostly it's just consolidating the default color to grey and changing a few instances of when orange (WARN) vs red (ALERT) is used.

Let me know if you find anything I have missed or any inconsistencies.

image.thumb.png.a70e0d1703859d163101324b5a2370d4.png 

I think non-grey default icons would look nicer, eg. a darker blue like #354B60 (borrowed from the Uikit admin theme).

tracysvgicons.png.4bd4c5241745b78c8c8a8f3b19bd811c.png

It's just a quick devtools preview but for me the current grey is too pale, and rather suggests that those icons are in an "off" state.

To further complicate things, here is an inverted version where the whole bar is blue and icons/texts are white:

tracysvgicons-invert.png.55458fbc83752f44e9cf2a898f1714ed.png

I'm not sure this would be better but wanted to share. The biggest advantage would be that it would pop out more from the rest of the page. Orange and red icons would require some brightening to be more visible though.

  • Like 4

Share this post


Link to post
Share on other sites
8 minutes ago, tpr said:

I'm not sure this would be better but wanted to share. The biggest advantage would be that it would pop out more from the rest of the page. Orange and red icons would require some brightening to be more visible though.

I like both actually - the first option really does look a lot nicer than the grey which is pretty awful now that I see the difference 🙂

The second one is nice but you're right, it will be problematic for the orange and red icons.

Anyone have any thoughts?

 

1 hour ago, szabesz said:

Would it mean that we have to click twice to see one of them? First a click on the arrow next to the class name, after that another click on either debugInfo or PW object? Or maybe you "extend" debug info and PW object gets injected into it?

Either way, I think it would be nice to see the id of a Page object without clicking on anything, somewhere between the class name and the arrow. Is that possible?

Not sure yet - I don't think I can hook into debugInfo though - I'll see what I can do about this sometime soon.

Share this post


Link to post
Share on other sites
4 minutes ago, adrian said:

grey which is pretty awful now that I see the difference

So did I on my very old designs 🙂

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   1 member

  • Similar Content

    • By Robin S
      A community member raised a question and I thought a new sanitizer method for the purpose would be useful, hence...
      Sanitizer Transliterate
      Adds a transliterate method to $sanitizer that performs character replacements as defined in the module config. The default character replacements are based on the defaults from InputfieldPageName, but with uppercase characters included too.
      Usage
      Install the Sanitizer Transliterate module.
      Customise the character replacements in the module config as needed.
      Use the sanitizer on strings like so:
      $transliterated_string = $sanitizer->transliterate($string);
       
      https://github.com/Toutouwai/SanitizerTransliterate
      https://modules.processwire.com/modules/sanitizer-transliterate/
       
    • By dimitrios
      Hello,
      this module can publish content of a Processwire page on a Facebook page, triggered by saving the Processwire page.
      To set it up, configure the module with a Facebook app ID, secret and a Page ID. Following is additional configuration on Facebook for developers:
      Minimum Required Facebook App configuration:
      on Settings -> Basics, provide the App Domains, provide the Site URL, on Settings -> Advanced, set the API version to 2.10, add Product: Facebook Login, on Facebook Login -> Settings, set Client OAuth Login: Yes, set Web OAuth Login: Yes, set Enforce HTTPS: Yes, add "http://www.example.com/processwire/page/" to field Valid OAuth Redirect URIs. This module is configurable as follows:
      Templates: posts can take place only for pages with the defined templates. On/Off switch: specify a checkbox field that will not allow the post if checked. Specify a message and/or an image for the post.
      Usage
      edit the desired PW page and save; it will post right after the initial Facebook log in and permission granting. After that, an access token is kept.
       
      Download
      PW module directory: http://modules.processwire.com/modules/auto-fb-post/ Github: https://github.com/kastrind/AutoFbPost   Note: Facebook SDK for PHP is utilized.


    • By thomasaull
      I created a little helper module to trigger a CI pipeline when your website has been changed. It's quite simple and works like this: As soon as you save a page the module sets a Boolean via a pages save after hook. Once a day via LazyCron the module checks if the Boolean is set and sends a POST Request to a configurable Webhook URL.
      Some ideas to extend this:
      make request type configurable (GET, POST) make the module trigger at a specified time (probably only possible with a server cronjob) trigger manually Anything else? If there's interest, I might put in some more functionality. Let me know what you're interested in. Until then, maybe it is useful for a couple of people 🙂
      Github Repo: https://github.com/thomasaull/CiTrigger
    • By Robin S
      I created this module a while ago and never got around to publicising it, but it has been outed in the latest PW Weekly so here goes the support thread...
      Unique Image Variations
      Ensures that all ImageSizer options and focus settings affect image variation filenames.

      Background
      When using methods that produce image variations such as Pageimage::size(), ProcessWire includes some of the ImageSizer settings (height, width, cropping location, etc) in the variation filename. This is useful so that if you change these settings in your size() call a new variation is generated and you see this variation on the front-end.
      However, ProcessWire does not include several of the other ImageSizer settings in the variation filename:
      upscaling cropping, when set to false or a blank string interlace sharpening quality hidpi quality focus (whether any saved focus area for an image should affect cropping) focus data (the top/left/zoom data for the focus area) This means that if you change any of these settings, either in $config->imageSizerOptions or in an $options array passed to a method like size(), and you already have variations at the requested size/crop, then ProcessWire will not create new variations and will continue to serve the old variations. In other words you won't see the effect of your changed ImageSizer options on the front-end until you delete the old variations.
      Features
      The Unique Image Variations module ensures that any changes to ImageSizer options and any changes to the focus area made in Page Edit are reflected in the variation filename, so new variations will always be generated and displayed on the front-end.
      Installation
      Install the Unique Image Variations module.
      In the module config, set the ImageSizer options that you want to include in image variation filenames.
      Warnings
      Installing the module (and keeping one or more of the options selected in the module config) will cause all existing image variations to be regenerated the next time they are requested. If you have an existing website with a large number of images you may not want the performance impact of that. The module is perhaps best suited to new sites where image variations have not yet been generated.
      Similarly, if you change the module config settings on an existing site then all image variations will be regenerated the next time they are requested.
      If you think you might want to change an ImageSizer option in the future (I'm thinking here primarily of options such as interlace that are typically set in $config->imageSizerOptions) and would not want that change to cause existing image variations to be regenerated then best to not include that option in the module config after you first install the module.
       
      https://github.com/Toutouwai/UniqueImageVariations
      https://modules.processwire.com/modules/unique-image-variations/
    • By Sebi
      I've created a small module which lets you define a timestamp after which a page should be accessible. In addition you can define a timestamp when the release should end and the page should not be accessable any more.
      ProcessWire-Module: http://modules.processwire.com/modules/page-access-releasetime/
      Github: https://github.com/Sebiworld/PageAccessReleasetime
      Usage
      PageAccessReleasetime can be installed like every other module in ProcessWire. Check the following guide for detailed information: How-To Install or Uninstall Modules
      After that, you will find checkboxes for activating the releasetime-fields at the settings-tab of each page. You don't need to add the fields to your templates manually.
      Check e.g. the checkbox "Activate Releasetime from?" and fill in a date in the future. The page will not be accessable for your users until the given date is reached.
      If you have $config->pagefileSecure = true, the module will protect files of unreleased pages as well.
      How it works
      This module hooks into Page::viewable to prevent users to access unreleased pages:
      public function hookPageViewable($event) { $page = $event->object; $viewable = $event->return; if($viewable){ // If the page would be viewable, additionally check Releasetime and User-Permission $viewable = $this->canUserSee($page); } $event->return = $viewable; } To prevent access to the files of unreleased pages, we hook into Page::isPublic and ProcessPageView::sendFile.
      public function hookPageIsPublic($e) { $page = $e->object; if($e->return && $this->isReleaseTimeSet($page)) { $e->return = false; } } The site/assets/files/ directory of pages, which isPublic() returns false, will get a '-' as prefix. This indicates ProcessWire (with activated $config->pagefileSecure) to check the file's permissions via PHP before delivering it to the client.
      The check wether a not-public file should be accessable happens in ProcessPageView::sendFile. We throw an 404 Exception if the current user must not see the file.
      public function hookProcessPageViewSendFile($e) { $page = $e->arguments[0]; if(!$this->canUserSee($page)) { throw new Wire404Exception('File not found'); } } Additionally we hook into ProcessPageEdit::buildForm to add the PageAccessReleasetime fields to each page and move them to the settings tab.
      Limitations
      In the current version, releasetime-protected pages will appear in wire('pages')->find() queries. If you want to display a list of pages, where pages could be releasetime-protected, you should double-check with $page->viewable() wether the page can be accessed. $page->viewable() returns false, if the page is not released yet.
      If you have an idea how unreleased pages can be filtered out of ProcessWire selector queries, feel free to write an issue, comment or make a pull request!
×
×
  • Create New...