matjazp

Links to the Community, Docs, Download, Blog at the footer are incorrect (links on the home page are ok).

I'm using a keyboard and can't access menu items. I can, for an example, tab to "The CMS", Enter (or Space) opens a menu, but how to go to (focus on) "Features"?

I'm on Edge 138.0.3351.121 and can't replicate. Maybe I'm not fast enough?

Maybe this should be an option in the default theme?

As someone already mentioned, there are accessibility issues. I miss focus indicators on inputs. The blue main color lacks contrast, so I'm using #2374e2 instead of #2380e6. Also, muted color seem to have a low contrast in the page list.

Should be fixed now: https://github.com/processwire/processwire-issues/issues/1823#issuecomment-2494183074

https://github.com/processwire/processwire-issues/issues/1516 https://github.com/processwire/processwire-issues/issues/1823

It's working here. That 0 is error code (and ? is error text) returned from WireHttp::GetHttpCode(). Hard to tell what went wrong. Can you provide original image?

https://github.com/processwire/processwire-issues/issues/1893

Thx Robin! While the Save + Close button is there (as expected), the js part makes the edit links all open home page, eg. they all have the link /processwire/page/edit/?id=1&quick_edit=1 I fixed that with: const $links = $('.PageListActionEdit a:not([data-autoclose])'); $links.each(function() { $link = $(this); $link.attr('data-autoclose', '#save-and-close').attr('href', $link.attr('href') + '&quick_edit=1'); }); Just to mention that using uk-hidden class (as a "belt and suspender" approach) would only work in AdminThemeUIkit, leaving out newer (and older) admin themes.

Now that you explain it, I remember this behavior of modal.js. But, unfortunately, it doesn't work here, only the Save button is cloned. Looking at the modal.js line 417, $icontents.find(buttonSelector) only returns one button, not two as expected. It seems like the Save+Close button is added too late, after the modal has already cloned the Save button. While debugging, I added the button unconditionally and also removed the uk-hidden class, and then edited the page in a new tab with modal=1, and both buttons were there, as expected. But not in modal. I guess if I add the button directly to the ProcessPageEdit.module (or via hook), it would work. But it's working for you, so there must be something with my installation. It's a bit late here, so I'll continue testing tomorrow.

Hey Robin! Thanks for this. I haven't had time to test this, but looking the code I see uk-hidden class on button. Would button even show? (and I know it's there for a reason)

Just to say, that 4.0 beta is working just fine. I had to tweak jquery migrate, but this issue will be fixed soon.

I don't like toggles at all. I find them confusing. I use a checkbox or radio group. It’s clear what you want, accessible and doesn’t make me think.

https://github.com/processwire/processwire-issues/issues/1867 ?