Jump to content
adrian

Custom Upload Names

Recommended Posts

I just committed an update that brings full support for repeater fields (images and images embedded into RTE fields inside repeaters).

I also fixed a bug with the new core cropping functionality if you set a filename format that is not available on file upload, such as $file->description.

There were some significant changes to hooks and logic to get the repeaters working, so please test and let me know if you come across any problems.

  • Like 5

Share this post


Link to post
Share on other sites

Adrian thanks for this module.

I'm having some problems with images inside repeater. It acts very strange. It gives errors when i try to add o remove images from the repeater field, and then save the page. And if i try to add a new repeater item, the image field in it is already populated with an image i thought i had deleted. 

I attach some screenshots with various errors i'm receiving.

Let me know how can i help to make this more clear.

post-2122-0-77584400-1427737342_thumb.pn

post-2122-0-29706400-1427737355_thumb.pn

post-2122-0-17649700-1427737362_thumb.pn

Share this post


Link to post
Share on other sites

Sorry about the errors you are seeing. Repeater support is very new, but I am not seeing any issues at my end. Can you please let me know the filename format you defined. Also what other field types do you have on the page and also in the repeater. Do you have more than one repeater field on the page. What version of PW are you using.

Also, would you mind trying a little debugging for me - try logging the value of $this->pages and also $field just before line 312.

Share this post


Link to post
Share on other sites

Sure, Adrian.

This is the filename format: {$page->title}-##

These are the fields on that template:

- the field slideshow_repeater, that gives those problems has an image_field (that has maximum files allowed = 1) and a url field. 

- an image field with maximum files allowed = 1 (i had no problems with this field)

- an image field with maximum files allowed = 0 (i had no problems with this field)

- 2 files field

- a lot of text and textarea fields

- all the seo fields from the Seo Module

There are no other repeaters on that template (i'm attaching a screenshot).

I'm also using the image extra module on InputfieldImage and InputfieldFile

I'm using PW 2.5.23 dev

I'm sorry, i'm not so sure how to log the errors you asked, i'm not a php developer, so i tried with error_log() and i just get "Pages" for $this->pages and i get "1.jpg" or "2.jpg" etc for $this->pages->get($pageid)->$field

Thanks a lot!

post-2122-0-95213100-1427740880_thumb.pn

Share this post


Link to post
Share on other sites

Thanks for all that info - I tried to replicate your image fields setup but still can't get the error.

Sorry I didn't ask for quite the correct things for the log output.

Can you please try replacing:

//filename format can support $page, $template, $field, and $file variables in the format as defined in the module config settings
//if repeater page, need to use parent page for determining name
$page = $repeaterPage !== null ? $repeaterPage->getForpage() : $this->pages->get($pageid);
$field = $this->fields->get($fieldid);
$template = $page->template;
$file = $this->pages->get($pageid)->$field->get("name={$path_parts['basename']}");

with:

//filename format can support $page, $template, $field, and $file variables in the format as defined in the module config settings
//if repeater page, need to use parent page for determining name
error_log('pageid: ' . $pageid);
$page = $repeaterPage !== null ? $repeaterPage->getForpage() : $this->pages->get($pageid);
error_log('page->id: ' . $page->id);  
error_log('page->name: ' . $page->name);                
$field = $this->fields->get($fieldid);
error_log('fieldid: ' . $fieldid);  
error_log('field->name: ' . $field->name);         
$template = $page->template;
error_log('template->name: ' . $template->name);
$file = $this->pages->get($pageid)->$field->get("name={$path_parts['basename']}");

and send me all the logged output.

Hopefully that will help me figure out where the issue might be.

Share this post


Link to post
Share on other sites

These are the logged errors in a page with two repeater items, one image per each:

pageid: 1372
page->id: 1053
page->name: digital-compositing-nuke
fieldid: 98
field->name: single_image
template->name: corso
pageid: 1373
page->id: 1053
page->name: digital-compositing-nuke
fieldid: 98
field->name: single_image
template->name: corso
pageid: 1373
page->id: 1373
page->name: 1427738337-12-1
fieldid: 120
field->name: cover_image
template->name: repeater_slideshow

I'm not sure, but maybe there is something strange with this: "page->name: 1427738337-12-1" (that's not the page name), and this "field->name: cover_image" because cover_image is not a field inside the repeater, it's outside. 

If it can help you I can give you access to the admin page, or to the project directories.

Thanks!

Share this post


Link to post
Share on other sites

Thanks for debug report - I was able to reproduce the problem here and I have committed a fix.

I hope I haven't broken anything else - it's a little complicated dealing with repeaters sometimes :)

Please let me know if it works for you and if you find any other issues.

BTW, I am assuming you have "Rename on Save" checked - that seemed to be when the issue showed up for me, although not always.

I also improved the behavior for checking existing numbered suffixes on the same main page, so now you won't end up with two images of the same filename, one inside a repeater and one on the main page, which was possible before.

  • Like 1

Share this post


Link to post
Share on other sites

Hi Adrian,

I'm wondering if it's possible to use this with Form Builder - which I've set to automatically create pages from submissions. When I set up a rule to only look at the page template (of the page being created) and two image fields my FB form starts to give me server 500 errors. If I remove the rule my FB form starts working again.

Cheers

Marty

Share this post


Link to post
Share on other sites

Hey Marty,

I am not a Formbuilder user so I don't know all the ins and outs, but I just set up a form and tested with CustomUploadNames and the page was created and the filename was changed as it should have been.

I have a feeling because CUN and FB both have so many config options, it might be just the combination you have that is causing problems.

Perhaps you could export the form for me to test and also take a screenshot of your CUN rule so I can duplicate.

I am sure we can get it sorted out for you.

Share this post


Link to post
Share on other sites

Hi Adrian,

I've got a problem when using fields in the filename format that are populated at the same time as the upload field (PDF in my case). The format looks like this:

customer-{$page->customer_id}

When a new page is created, the user fills in a value into the customer_id field and then uploads a PDF, which should get renamed. However, the value inside customer_id is not respected, as the PDF gets renamed right after upload and before hitting Save. A click on Save also doesn't rename it again.

I remember this worked a couple of versions ago, but not anymore. Did you change something in that area?

Using "Rename on Save" isn't an option as I need the filename to stay the same and not add a -1 suffix every second save.

Share this post


Link to post
Share on other sites

Sorry about that @charger. I had to change on of the hooks when I added support for repeaters which resulted in the issue you saw.

It should be fixed now and actually the new method is better and more reliable in other situations too.

Please grab the latest version and let me know.

On another note, I am curious about your comment regarding the -1 suffix on every second save - that actually shouldn't happen with this module, so if you are seeing that, please let me know and I'll investigate further. That said, I avoid the "Rename on Save" option whenever possible, so not suggesting you should use it, but I do want to make sure that using it doesn't result in the numbered suffix.

Thanks for reporting this.

Share this post


Link to post
Share on other sites

Thanks for the quick update, it again works as expected!

The -1 suffix still happens though with the "Rename on Save" option enabled. So whenever I hit Save, the filename alternates between having the suffix and not.

Let me know if you need other specific info.

Share this post


Link to post
Share on other sites

Glad to hear that it's working again for you!

I am still baffled about the -1 suffix with "Rename on Save" though. Could you maybe post screenshots of your settings for this module as well as letting me know the settings for your PDF field, eg:

  • Max Files Allowed
  • Overwrite existing files

I have tried lots of different combinations and it keeps the filename without the numbered suffix for me. Any chance you are on a Windows server - just wondering if maybe there is a directory separator issue.

Is there only one files field on the page? If it allows more than one file to be uploaded, are you actually still only uploading one or are there several?

Is there anything else you can think of that might contribute to this?

Thanks!

EDIT: One other thing to check - it there any chance that there is an extra file in the page's assets/files/1234 directory. Perhaps when it wasn't being renamed correctly I duplicate was left over - this would cause the behavior you are seeing, so please empty the files folder and try again. And/or try on a new page where you know the files folder is empty / without duplicates.

Share this post


Link to post
Share on other sites

I've attached the screenshot of my settings.

The PDF allows max one file and does overwrite existing files.

There's also just this file field on the page.

I created multiple new pages to make sure there are no leftover duplicates in the assets/files folder.

The website is not hosted on a Windows server.

Hmm.. I don't have any clue what else could cause it.

post-2284-0-23987200-1432129258_thumb.pn

Share this post


Link to post
Share on other sites

I noticed that the module also renames the files of a language pack during upload (if no fields are listed under Enabled Fields). Maybe this should be prevented by default.

Share this post


Link to post
Share on other sites

I noticed that the module also renames the files of a language pack during upload (if no fields are listed under Enabled Fields). Maybe this should be prevented by default.

Thanks for reporting. I have fixed this. I was thinking about disabling the module from affecting any pages under the admin, but thought some users may store some settings type pages, so for the moment I have just excluded pages with the "language" template.

Please let me know if you have any problems.

Share this post


Link to post
Share on other sites

Good day, Adrian!

I am adding images to an ImageField with CustomUploadNames hook enabled via API like this:

$images->add($file_path);

"Maximum files allowed" = 1. If "Formatted value" is set to automatic I get this error:

Error: Call to a member function getVariations() on a non-object (line 245 of /var/www/***/site/modules/ProcessCustomUploadNames/ProcessCustomUploadNames.module)

If "Formatted value" is set to Array of items, there is no error. Am I doing something wrong or is it a bug?

  • Like 1

Share this post


Link to post
Share on other sites

Hi Ivan,

Thanks for reporting that - it should be fixed in the version I just committed.

Please let me know how it goes.

  • Like 2

Share this post


Link to post
Share on other sites

This issue turned out to be related to this module. In short: As long as Custom Upload Names is installed, I get a fatal error when I try to view an entry within the Entries tab within a FormBuilder form.

  • Like 3

Share this post


Link to post
Share on other sites

Sorry everyone for the delay on fixing this - I was on vacation. It was related to a recent change to prevent it affecting language file uploads. 

Please let me know if anyone still has any issues.

Share this post


Link to post
Share on other sites

Dear Adrian,

I have strange issue with pages which have numbers and hyphens in $page->name (ex. foret-17).

Each save one of pictures becomes empty with error "file cannot be displayed". That mean, if I save page 10 times it lost 10 images.

After changing page name everything working fine.

  • Like 1

Share this post


Link to post
Share on other sites

Hi Alexander,

I just tried to replicate here and can't seem to. Could you maybe post some screenshots of your CUN settings and also the tree of pages. Or better yet can you set up an example on lightning.pw so I can see the issue in action?

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By Mike Rockett
      Jumplinks for ProcessWire
      Release: 1.5.56
      Composer: rockett/jumplinks
      Jumplinks is an enhanced version of the original ProcessRedirects by Antti Peisa.
      The Process module manages your permanent and temporary redirects (we'll call these "jumplinks" from now on, unless in reference to redirects from another module), useful for when you're migrating over to ProcessWire from another system/platform. Each jumplink supports wildcards, shortening the time needed to create them.
      Unlike similar modules for other platforms, wildcards in Jumplinks are much easier to work with, as Regular Expressions are not fully exposed. Instead, parameters wrapped in curly braces are used - these are described in the documentation.
      Under Development: 2.0, to be powered by FastRoute
      As of version 1.5.0, Jumplinks requires at least ProcessWire 2.6.1 to run.
      View on GitLab
      Download via the Modules Directory
      Read the docs
      Features
      The most prominent features include:
      Basic jumplinks (from one fixed route to another) Parameter-based wildcards with "Smart" equivalents Mapping Collections (for converting ID-based routes to their named-equivalents without the need to create multiple jumplinks) Destination Selectors (for finding and redirecting to pages containing legacy location information) Timed Activation (activate and/or deactivate jumplinks at specific times) 404-Monitor (for creating jumplinks based on 404 hits) Additionally, the following features may come in handy:
      Stale jumplink management Legacy domain support for slow migrations An importer (from CSV or ProcessRedirects) Feedback & Feature Requests
      I’d love to know what you think of this module. Please provide some feedback on the module as a whole, or even regarding smaller things that make it whole. Also, please feel free to submit feature requests and their use-cases.
      Note: Features requested so far have been added to the to-do list, and will be added to 2.0, and not the current dev/master branches.
      Open Source

      Jumplinks is an open-source project, and is free to use. In fact, Jumplinks will always be open-source, and will always remain free to use. Forever. If you would like to support the development of Jumplinks, please consider making a small donation via PayPal.
      Enjoy! :)
    • By BitPoet
      As threatened in Ryan's announcement for 3.0.139, I built a little module for sliding toggles as a replacement for checkboxes. Styling of the input is CSS3 only (with all the usual caveats about older browsers), no JS necessary, and may still be a bit "rough around the edges", so to speak, since I didn't have much time for testing on different devices or brushing things up enough so I'd feel comfortable pushing it to the module directory. But here's the link to the GitHub repo for now:
      InputfieldSlideToggle
      Fieldtype and Inputfield that implements smartphone-style toggles as replacement for checkbox inputs. The visualization is CSS-only, no additional JS necessary.
      Status
      Still very alpha, use with caution!
      Features / Field Settings
      Size
      You can render the toggles in four different sizes: small, medium, large and extra large.
      Off Color
      Currently, "unchecked" toggles can be displayed either in grey (default) or red.
      On Color
      "Checked" toggles can be rendered in one of these colors: blue (default), black, green, grey, orange or red.
      Screenshots

      Some examples with checkbox label


      View all Size and Color Combinations
      Small toggles Medium toggles Big toggles Extra big toggles  









    • By Orkun
      Hi Guys
      I needed to add extended functionalities for the InputfieldDatetime Module (module is from processwire version 2.7.3) because of a Request of Customer.
      So I duplicated the module and placed it under /site/modules/.
      I have added 3 new Settings to the InputfieldDatetime Module.
      1. Day Restriction - Restrict different days based on weekdays selection (e.g. saturday, sunday) - WORKING

       
      2. Time Slots - Define Time slots based on custom Integer Value (max is 60 for 1 hour) - WORKING

       
      3. Time Range Rules per Weekday - Define a minTime and MaxTime per Weekday (e.g. Opening Hours of a Restaurant) - NOT WORKING PROPERLY

       
      The Problem
      Time Slots and Day Restriction working fine so far. But the Time Range Rules per Weekday doesn't work right.
      What should happen is, that when you click on a date, it should update the minTime and maxTime of the Time Select.
      But the change on the select only happens if you select a date 2 times or when you select a date 1 time and then close the datepicker and reopen it again.
      The time select doesn't get change when you select a date 1 time and don't close the picker.
      Here is the whole extended InputfieldDatetime Module.
      The Files that I have changed:
      InputfieldDatetime.module InputfieldDatetime.js jquery-ui-timepicker-addon.js (https://trentrichardson.com/examples/timepicker/) - updated it to the newest version, because minTime and maxTime Option was only available in the new version  
      Thats the Part of the JS that is not working correctly:
      if(datetimerules && datetimerules.length){ options.onSelect = function(date, inst) { var day = $(this).datetimepicker("getDate").getDay(); day = day.toString(); var mintime = $(this).attr('data-weekday'+day+'-mintime'); var maxtime = $(this).attr('data-weekday'+day+'-maxtime'); console.log("weekday: "+day); console.log("minTime: "+mintime); console.log("maxTime: "+maxtime); var optionsAll = $(this).datetimepicker( "option", "all" ); optionsAll.minTime = mintime; optionsAll.maxTime = maxtime; $(this).datetimepicker('destroy'); $(this).datetimepicker(optionsAll); $(this).datetimepicker('refresh'); //$.datepicker._selectDate($(this).attr("id"),date); //$.datepicker._base_getDateDatepicker(); // var inst = $.datepicker._getInst($(this)); // $.datepicker._updateDatepicker(inst); /*$(this).datetimepicker('destroy'); InputfieldDatetimeDatepicker($(this), mintime, maxtime); $(this).datetimepicker('refresh'); */ // $(this).datetimepicker('option', {minTime: mintime, maxTime: maxtime}); } } Can you have a look and find out what the Problem is?
      InputfieldDatetime.zip
       
      Kind Regards
      Orkun
    • By teppo
      This module tracks changes, additions, removals etc. of public (as in "not under admin") pages of your site. Like it's name says, it doesn't attempt to be a version control system or anything like that - just a log of what's happened.
      At the moment it's still a work in progress and will most likely be a victim of many ruthless this-won't-work-let's-try-that-instead cycles, but I believe I've nailed basic functionality well enough to post it here.. so, once again, I'll be happy to hear any comments you folks can provide
      https://modules.processwire.com/modules/process-changelog/
      https://github.com/teppokoivula/ProcessChangelog
      How does it work?
      Exactly like it's (sort of) predecessor, Process Changelog actually consists of two modules: Process Changelog and Process Changelog Hooks. Hooks module exists only to serve main module by hooking into various functions within Pages class, collecting data of performed operations, refining it and keeping up a log of events in it's own custom database table (process_changelog.) Visible part is managed by Process Changelog, which provides users a (relatively) pretty view of the contents of said log table.
      How do you use it?
      When installed this module adds new page called Changelog under Admin > Setup which provides you with a table view of collected data and basic filtering tools See attached screenshots to get a general idea about what that page should look like after a while.
      For detailed installation instructions etc. see README.md.
       


    • By Gadgetto
      Status update links (inside this thread) for SnipWire development will be always posted here:
      2019-08-08
      2019-06-15
      2019-06-02
      2019-05-25
      If you are interested, you can test the current state of development:
      https://github.com/gadgetto/SnipWire
      Please note that the software is not yet intended for use in a production system (alpha version).
      If you like, you can also submit feature requests and suggestions for improvement. I also accept pull requests.
      ---- INITIAL POST FROM 2019-05-25 ----
      I wanted to let you know that I am currently working on a new ProcessWire module that fully integrates the Snipcart Shopping Cart System into ProcessWire. (this is a customer project, so I had to postpone the development of my other module GroupMailer).
      The new module SnipWire offers full integration of the Snipcart Shopping Cart System into ProcessWire.
      Here are some highlights:
      simple setup with (optional) pre-installed templates, product fields, sample products (quasi a complete shop system to get started immediately) store dashboard with all data from the snipcart system (no change to the snipcart dashboard itself required) Integrated REST API for controlling and querying snipcart data webhooks to trigger events from Snipcart (new order, new customer, etc.) multi currency support self-defined/configurable tax rates etc. Development is already well advanced and I plan to release the module in the next 2-3 months.
      I'm not sure yet if this will be a "Pro" module or if it will be made available for free.
      I would be grateful for suggestions and hints!
      (please have a look at the screenshots to get an idea what I'm talking about)
       




×
×
  • Create New...