jquery error that I think processwire is making

[benbyf]

anyone know why im getting this error

TypeError: $(...).live is not a function

$("li.PageListActiondelete a").live("click", function(el){
 

 

deleted all the js from the page but its still doing it

[adrian]

Suggests to me that you are running a newer version of jquery that no longer supports "live". Have you replaced the script code for jquery or are you using the default that comes with the default PW profile?

[benbyf]

does it on 1.4.2 and 2.0.3

[benbyf]

ok, worked out the culprit: the module ProcessPageDelete for some reason, uninstall from the modules and now working fine...

[adrian]

Weird. Actually now that I think about it, I assume the error you were getting was in the admin, and not on a front-end page, so it shouldn't matter what version of jquery you set in your front-end templates. Not sure why that module is causing that problem though - it works fine for me.

[ryan]

It looks like the ProcessPageDelete module uses a jQuery live call, and live() was removed from jQuery. They found a better way to do it, but I still miss the more-straightforward-to-use live() calls. We had to change all of our live() calls to on() calls in the core a version or two back. So I think Nico probably needs to do the same thing in this module. 

[kongondo]

It looks like the ProcessPageDelete module uses a jQuery live call, and live() was removed from jQuery. They found a better way to do it, but I still miss the more-straightforward-to-use live() calls. We had to change all of our live() calls to on() calls in the core a version or two back. So I think Nico probably needs to do the same thing in this module. 

Ryan,

Actually, you still have a couple of "live()" in various places in dev version:

/wire/modules/Inputfield/InputfieldFile/InputfieldFile.js - 3 occurrences (lines: 10, 25, 78,)

/wire/modules/Inputfield/InputfieldImage/InputfieldImage.js -  2 occurrences (lines: 3, 7)

/wire/modules/Inputfield/InputfieldPageAutocomplete/InputfieldPageAutocomplete.js - 3 occurrences (lines: 122, 126, 194)

/wire/modules/Inputfield/InputfieldPageListSelect/InputfieldPageListSelectMultiple.js - 3 occurrences (lines: 27, 30, 78)

[Soma]

OK, .live() got remove in jquery 1.9, and PW is still using 1.8.3.

http://api.jquery.com/live/

[kongondo]

Yes, there's that as well...

@Ryan...plans to upgrade jQuery to 1.9+?

[Martijn Geerts]

fancybox isn't compatible with 1.9.

Don't know if other "plug-ins" are compatible.

[ryan]

/wire/modules/Inputfield/InputfieldFile/InputfieldFile.js - 3 occurrences (lines: 10, 25, 78,)

/wire/modules/Inputfield/InputfieldImage/InputfieldImage.js -  2 occurrences (lines: 3, 7)

/wire/modules/Inputfield/InputfieldPageAutocomplete/InputfieldPageAutocomplete.js - 3 occurrences (lines: 122, 126, 194)

/wire/modules/Inputfield/InputfieldPageListSelect/InputfieldPageListSelectMultiple.js - 3 occurrences (lines: 27, 30, 78)

Thanks, it looks like I've got a few more updates to make! Actually just checked, and it looks like I've already made them but just not committed them. Though a couple of those are actually just commented out versions of live() that have already been replaced. I keep the old commented version just because I find live() easier to read and comprehend what's going on. I'll go ahead and commit the rest here shortly. 

@Ryan...plans to upgrade jQuery to 1.9+?

I'm running jQuery 2.x locally, with the migration plugin. I plan to include the latest 2.x jQuery with PW 2.4. 

fancybox isn't compatible with 1.9.

Don't know if other "plug-ins" are compatible.

I haven't yet found any others, though that might be because I'm still using the migration plugin to identify stuff that needs updating. But I'm not married to the fancybox plugin–we'll replace it with something else. 

[Soma]

I haven't yet found any others, though that might be because I'm still using the migration plugin to identify stuff that needs updating. But I'm not married to the fancybox plugin–we'll replace it with something else. 

That's going to be ugly , because there's quite some modules using fancybox and I use it in several project for admin or modules.

[kongondo]

That's going to be ugly , because there's quite some modules using fancybox and I use it in several project for admin or modules.

Maybe better ugly than "married" to older version of fancybox now that the later versions need paid-for-licences for commercial projects

[benbyf]

sure it won't be ugly, there's tons of lightbox options out there, and unless you've written specific admin themes with fancybox specific hooks sure you be fine

[Soma]

I mean ugly in terms of rewriting all modules and code to use another lightbox plugin. They simply will be broken....

[ryan]

What other modules use fancybox? I'm not planning to remove it from the source completely, at least not till 3.0. So if some other module needs to use it, it'll still be there–we can simply add an extra $config->scripts->add('jquery migration plugin') to the top of the JqueryFancybox.module file, and it should continue to work even with the new version of jQuery installed. But ideally I want to switch to a different, more mobile friendly lightbox for our InputfieldImage to use.