Jump to content

Module ImageReference - Pick images from various sources


Recommended Posts

Hi @gebeer, I tested the update this morning and oops...

I don't know what happened this time, but it no longer works at all either inside or outside of a repeater. it just loads a clone of the page currently being edited.

It's hard to explain, so this GIF should illustrate what's happening (this is a test outside of a repeater):

Animated GIF showing module bug

The above demonstrates the "choose an image from page" and "choose any page" options.

  • The field settings are correct - they are same ones that worked (outside of a repeater) previously.
  • There are images available!
  • I tried the other options (from a folder etc) and exactly the same thing happens.
  • I uninstalled all other modules in case there was a JS conflict and still the same thing happens.

In case it helps, here is the console log:

Console log for the module

I'm using ProcessWire version 3.0.147 and PHP 7.2.

Happy New Year! (?)

Link to post
Share on other sites

@all

I just discovered that v2.0.1 is not working correctly when not logged in as superuser. The ajax calls to get the thumbnails are not working.

You can either revert back to v2.0.0 and deactivate the option to get thumbnails or wait for a fix to the master version.

Sorry for the inconvenience!

I have my logic for the ajax calls in the init() method of InputfieldImageReference.module. Until just now I didn't realize that this is not getting called correctly. I read up on how to implement ajax calls to an inputfield module and one of the proposed ways was to do this in init(). Will have to investigate further. If anyone can give me pointers on how to make this work, this would be great.

Link to post
Share on other sites
4 minutes ago, LMD said:

I don't know what happened this time, but it no longer works at all either inside or outside of a repeater

Are you logged in as non superuser when this happens? I just discovered a few minutes before you posted that there is a problem with non superusers. See my last post above. Try to fix this asap.

Link to post
Share on other sites
20 minutes ago, gebeer said:

Are you logged in as non superuser when this happens? I just discovered a few minutes before you posted that there is a problem with non superusers. See my last post above. Try to fix this asap.

No, it's in my dev environment and I'm the only user (superuser).

While I think of it, I also ensured the pages were 'published' and not 'hidden', in case that was the problem (it wasn't).

Edited by LMD
Last minute though
  • Like 1
Link to post
Share on other sites
Just now, LMD said:

No, it's in my dev environment and I'm the only user (superuser).

Thank you for clarifying. I'm currently looking into it. But won't be able to fix this until hopefully tomorrow.

Link to post
Share on other sites

Hi @gebeer,

I think it would be better to name the title of the fieldtype "Image Reference" instead of "Image Reference Fieldtype":

s0WVwtz.png

https://github.com/gebeer/FieldtypeImageReference/blob/2df486396ae58a5ff1687d30434cbfce6f913602/FieldtypeImageReference.module#L32

I guess this was due to a wrong field setup, but I also got these errors:

jyFaXaY.png

 

Regarding your AJAX:

I found it easier and safer to handle my ajax calls via hooking into ProcessPageView::pageNotFound: https://github.com/BernhardBaumrock/RockTabulator/blob/6670f2647fcbbb1f5ad4c5237ea9fd03b8899315/RockTabulator.module.php#L73

https://github.com/BernhardBaumrock/RockTabulator/blob/6670f2647fcbbb1f5ad4c5237ea9fd03b8899315/RockTabulator.module.php#L159-L188

I've taken a similar approch to yours on RockGrid and had some problems with it, because of scripts not being available when the field is collapsed and loaded via ajax or the like...

  • Like 1
Link to post
Share on other sites
8 minutes ago, bernhard said:

I think it would be better to name the title of the fieldtype "Image Reference" instead of "Image Reference Fieldtype":

Yep, will change it.

8 minutes ago, bernhard said:

found it easier and safer to handle my ajax calls via hooking into ProcessPageView::pageNotFound

Thanks for that hint. Will give it a try.

  • Like 1
Link to post
Share on other sites

New version v2.0.2 is available from github.

This version fixes the problems with getting thumbnails displayed via ajax. At least in my extensive testing everything was working. @LMD can you please give it a try now?

While trying to fix the ajax issue, I was running in circles for hours on end. Tried various methods I found in the forum and @bernhard's hook. I always got it working as superuser but got very strange results when logged in as an editor user with page edit permissions. Until I discovered that the problems were due to my module not always loading for ajax requests. I added 'autoload' => 'template=admin' to my module info and suddenly all was working as expected. Still scratching my head why a module's init() method would get called when logged in as superuser but not when logged in as editor. Any ideas here?

New in this version is the feature for uploading files to the predefined folder from within the inputfield. Here's a short preview of that feature.

Now that this is working, I'm thinking about adding the ability to delete them from within the inputfield, too.

As always, I shall be happy to receive your comments and issue reports 🙂

 

 

  • Like 4
Link to post
Share on other sites
3 minutes ago, LMD said:

Works like a charm for me, both outside and inside repeaters

Today I discovered that it doesn't work inside RepeaterMatrix fields, yet. If you have a chance to test this, please report. Thank you.

Link to post
Share on other sites

New version v2.1.0 is available on github.

New features:

Images in folders can now be uploaded and deleted from within the input. I am pretty excited about this feature. It gives you an image field that holds images independent of a page where images can be edited (upload/delete) and outputs PageImage objects in the frontend that can be cropped and resized.

EDIT: forgot to mention that the module install 2 permissions imagereference-folder-upload and imagereference-folder-delte. Any non-superuser role needs those.

Short preview

Also now you can have the folder under either site/templates/ or site/assets/. The module will find it in both locations. If you have folders with same name in both locations, it will pick the one in site/templates/

The module is almost ready to go. One major thing, I need to fix, though, is getting it to work inside RepeaterMatrix fields. It is working fine inside normal repeaters. But eventually I will get there.

Feel free to grab a copy and do some tests. Your feedback is much appreciated.

Edited by gebeer
forgot to mention
  • Like 7
Link to post
Share on other sites

New minor version v2.1.1 with fix for error when using field inside RepeaterMatrix is on github.

This was a strange error and, honestly, I still don't quite understand the root cause. When trying to add a new repeatermatrix item with this field inside, I got the error

Field [fieldname] is not saveable because it is in a specific context

Google brought me to this closed issue in the processwire-issues repo. The issue was related to FieldTypeFile. I just applied the fix for it to my fieldtype module and it worked.

But I'd like to understand the underlying problem. So if anybody has any clue, please let me know. Thank you.

  • Like 1
Link to post
Share on other sites
3 hours ago, gebeer said:

But I'd like to understand the underlying problem. So if anybody has any clue, please let me know. Thank you.

I think it is ok to ask Ryan in the ProFields/RepeaterMatrix forum.

Link to post
Share on other sites
On 1/5/2020 at 10:10 AM, gebeer said:

Today I discovered that it doesn't work inside RepeaterMatrix fields, yet. If you have a chance to test this, please report. Thank you.

Oh, sorry, I don't have a RepeaterMatrix field in operation anywhere at the current time.

  • Like 1
Link to post
Share on other sites
  • 3 weeks later...

New version v2.1.2 is out on github.

This version fixes a problem with images inside a folder that have names not conform with file naming conventions.

When the module loads images from a folder, it converts them to Pageimage objects. When images are added to a Pageimages object file names get sanitized automatically by PW. In my case this resulted in different file names inside the Pageimage object and on disk. Consequently, thumbnails and previews for those images could not be loaded. I fixed this by automatically renaming all folder images to match the sanitized name versions inside a Pagimage object. 

This version also adds the ability to set values to this field via API. You can now do something like this to set a Pageimage object as new value to this fieldtype via API

$p = $pages->get(1001);
$image = $p->image; // returns a Pageimage object
$p->of(false);
$p->set('imagereference', $image); // sets the Pageimage object to the ImageReference field. This gets converted to a JSON string internally for storage
$p->save();

 

  • Like 3
Link to post
Share on other sites
  • 2 weeks later...

@gebeer I've installed your module today for the first time. I was mostly interested in the feature "select from folder". But sadly, that just didn't work. I cleared site/cache several times, refreshed modules etc., but the field always would state that no such folder exists.

I have added that folder after creating the field. Does that matter? Does the folder have to be there before you create an image reference field? Nothing suspicious in the logs, btw (debug mode on).

ProcessWire: 3.0.149
PHP: 7.3.13
Webserver: Apache/2.4.35 (Win64) OpenSSL/1.1.1d
MySQL: 5.7.24

Link to post
Share on other sites
11 hours ago, dragan said:

I have added that folder after creating the field. Does that matter? Does the folder have to be there before you create an image reference field?

It doesn't matter whether you create the folder before or after. The module will pick it up once it is there. If it is not there yet, you will get a warning. Once it is there, the warning normally goes away. If it is empty, you will get a warning to upload images.

Can't reproduce your problem here on PW 3.0.145 PHP 7.2 But versions really shouldn't matter in that case. Did you install latest master?

EDIT: just tested this on PW 3.0.149 and PHP 7.3.2 without problems.

Where did you create the folder? It needs to be either in /site/assets/ or /site/templates/.

Please try and comment out line 680 in FieldtypeImagereference.module and see if the warning message persists. I attached the error to both the field and globally so it is shown at the top of the page when you save the settings. Maybe this is the culprit in your case?

Edited by gebeer
Link to post
Share on other sites
  • 7 months later...

Hi @gebeer I'm trying to use your module within the settingfactory module but I' having some issue initializing it, what are the mandatory parameters to make it work? I tried this config but it shows just the placeholder image. Thanks
 

[
        'name' => 'logotest',
        'label' => __('Logo & Favicon'),
        'type' => 'InputfieldImageReference',
        'width' => '100',
        'fromfolder ' => true,
        'folderpath' => '/site/templates/',
        'description' => __('description'),
        'collapsed' => 0,
    ],
Link to post
Share on other sites

@Sevarf2 you need to specify the folderpath correctly.

When the files are located in /site/templates/images/icons/, the value is 'images/icons/ '

When the files are located in /site/assets/icons/, the value is 'icons/'

Hope that helps

 

Link to post
Share on other sites
40 minutes ago, gebeer said:

@Sevarf2 you need to specify the folderpath correctly.

When the files are located in /site/templates/images/icons/, the value is 'images/icons/ '

When the files are located in /site/assets/icons/, the value is 'icons/'

Hope that helps

 

still not working, I can only see the default image and nothing more
image.png.d6c9eece9e6aaa9ba0784d3941a37d70.png

Link to post
Share on other sites

I just installed tracy and I got this error
image.png.b729d656968f234013386aa669001a5e.png

I'm using php settings not json

[
        'name' => 'logotest',
        'label' => __('Logo & Favicon'),
        'type' => 'InputfieldImageReference',
        'width' => '100',
        'fromfolder ' => true,
        'folderpath' => 'assets/imgs/',
        'description' => __('image upload'),
        'collapsed' => 0,
    ],

Link to post
Share on other sites

@Sevarf2 where do your images live, in site/assets/imgs? Then you need to define just 'imgs/'

I just pushed a fix for the error you mentioned to github. You only need to download and replace https://github.com/gebeer/FieldtypeImageReference/blob/master/InputfieldImageReference.module

Let me know how it goes.

Link to post
Share on other sites

@gebeer Are there plans to allow for multiple images to be used with this module / field-type? Or is there something I've been missing? I don't see anything in the module or field configs. (not that I would need it right now for a real-live project, I'm just curious)

Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
  • Recently Browsing   1 member

  • Similar Content

    • By FireWire
      Hello community!

      I want to share a new module I've been working on that I think could be a big boost for multi-language ProcessWire sites.

      Some background, I was looking for a way for our company website to be efficiently translated as working with human translators was pretty laborious and a lack of updating content created a divergence between languages. I, and several other devs here, have talked about translation integrations and have recognized the power that DeepL has. DeepL is an AI deep learning powered service that delivers translation quality beyond any automated service available. After access to the API was opened up to the US, I built Fluency, a DeepL translation integration for ProcessWire.
      Fluency brings automated translation to every multi-language field in the admin, and also provides a translation tool allowing the user to translate their text to any language without it being inside a template's field. With Fluency you can:
      Translate any plain textarea or text input Translate any CKEditor content (yes, with markup) Translate page names for fully localized URLs on every page Translate your in-template translation function wrapped strings Translate modules Fluency is free, and now so is DeepL
      Since this module was first built DeepL has introduced free Developer accounts that allow anyone to start using Fluency at zero cost and beginning with the version 0.3.0 release Fluency now supports free DeepL accounts. As of June 2021 DeepL supports translation to 26 languages and continues to offer more!
      Installation and usage is completely plug and play. Whether you're building a new multi-language site, need to update a site to multi-language, or simply want to stop manually translating a site and make any language a one-click deal, it could not be easier to do it. Fluency works by having you match the languages configured in ProcessWIre to DeepL's. You can have your site translating to any or all of the languages DeepL translates to in minutes (quite literally).
      Let's break out the screenshots...
      When the default language tab is shown, a message is displayed to let users know that translation is available. Clicking on each tab shows a link that says "Translate from English". Clicking it shows an animated overlay with the word "Translating..." cycling through each language and a light gradient shift. Have a CKEditor field? All good. Fluency will translated it and use DeepL's ability to translate text within HTML tags. CKEditor fields can be translated as easily and accurately as text/textarea fields.

      Repeaters and AJAX created fields also have translation enabled thanks to a JavaScript MutationObserver that searches for multi-language fields and adds translation as they're inserted into the DOM. If there's a multi-language field on the page, it will have translation added.

      Same goes for image description fields. Multi-language SEO friendly images are good to go.

      Creating a new page from one of your templates? Translate your title, and also translate your page name for native language URLs. (Not available for Russian, Chinese, or Japanese languages due to URL limitations). These can be changed in the "Settings" tab for any page as well so whether you're translating new pages or existing pages, you control the URLs everywhere.

      Language configuration pages are no different. Translate the names of your languages and search for both Site Translation Files (including all of your modules)

      Translate all of the static text in your templates as well. Notice that the placeholders are retained. DeepL is pretty good at recognizing and keeping non-translatable strings like that. If it is changed, it's easy to fix manually.

      Fluency adds a "Translate" item to the CMS header. When clicked this opens up a modal with a full translation tool that lets the user translate any language to any language. No need to leave the admin if you need to translate content from a secondary language back to the default ProcessWire language. There is also a button to get the current API usage statistics. DeepL account owners can set billing limitations via character count to control costs. This may help larger sites or sites being retrofitted keep an eye on their usage. Fluency can be used by users having roles given the fluency-translate permission.

      It couldn't be easier to add Fluency to your new or existing website. Simply add your API key and you're shown what languages are currently available for translation from/to as provided by DeepL. This list and all configuration options are taken live from the API so when DeepL releases new languages you can add them to your site without any work. No module updates, just an easy configuration. Just match the language you configured in ProcessWire to the DeepL language you want it to be associated with and you're done. Fluency also allows you to create a list of words/phrases that will not be translated which can prevent items such as brands and company names from being translated when they shouldn't

       
      Limitations:
      No "translate page" - Translating multiple fields can be done by clicking multiple translation links on multiple fields at once but engineering a "one click page translate" is not feasible from a user experience standpoint. The time it takes to translate one field can be a second or two, but cumulatively that may take much longer (CKEditor fields are slower than plain text fields). There may be a workaround in the future but it isn't currently on the roadmap. No "translate site" - Same thing goes for translating an entire website at once. It would be great, but it would be a very intense process and take a very (very) long time. There may be a workaround in the future but it isn't on the roadmap. No current support for Inline CKEditor fields - Handling for CKEditor on-demand hasn't been implemented yet, this is planned for a future release though and can be done. I just forgot about it because I've never really used that feature personally.. Alpha release - This module is in alpha. Releases should be stable and usable, but there may be edge case issues. Test the module thoroughly and please report any bugs via a Github issue on the repository or respond here. Please note that the browser plugin for Grammarly conflicts with Fluency (as it does with many web applications). To address this issue it is recommended that you disable Grammarly when using Fluency, or open the admin to edit pages in a private window where Grammarly may not be loaded. This is an issue that may not have a resolution as creating a workaround may not be possible. If you have insight as to how this may be solved please visit the Github page and file a bugfix ticket.
      Requirements:
      ProcessWire  3.0+ UIKit Admin Theme That's Fluency in a nutshell. A core effort in this module is to create it so that there is nothing DeepL related hard-coded in that would require updating it when DeepL offers new languages. I would like this to be a future-friendly module that doesn't require developer work to keep it up-to-date.
      The Module Is Free
      This is my first real module and I want to give it back to the community as thanks. This is the best CMS I've worked with (thank you Ryan & contributors) and a great community (thank you dear reader).
      DeepL Developer Accounts
      In addition to paid Pro Developer accounts, DeepL now offers no-cost free accounts. Now all ProcessWire developers and users can use Fluency at no cost.
      Learn more about free and paid accounts by visiting the DeepL website. Sign up for a Developer account, get an API key, and start using Fluency today.
      Download & Feedback
      Download the latest version here
      https://github.com/SkyLundy/Fluency-Translation/archive/main.zip
      Github repository:
      https://github.com/SkyLundy/Fluency-Translation
      File issues and feature requests here (your feedback and testing is greatly appreciated):
      https://github.com/SkyLundy/Fluency-Translation/issues
       
      Thank you! ¡Gracias! Ich danke Ihnen! Merci! Obrigado! Grazie! Dank u wel! Dziękuję! Спасибо! ありがとうございます! 谢谢你!

    • By monollonom
      (once again I was surprised to see a work of mine pop up in the newsletter, this time without even listing the module on PW modules website 😅. Thx @teppo !)
      Github: https://github.com/romaincazier/FieldtypeQRCode
      Modules directory: https://processwire.com/modules/fieldtype-qrcode/
      This is a simple module I made so a client could quickly grab a QR Code of the page's url in the admin.
      There's not much to it for now, but if need be you can output anything using a hook:
      $wire->addHookAfter("FieldtypeQRCode::getQRText", function($event) { $event->return = "Your custom text"; }) You can also output the QR code on your front-end by calling the field:
      echo $page->qr_code_field; The module uses the PHP library QR Code Generator by Kazuhiko Arase. When looking for a way to generate a QR Code in PW I came across @ryan's integration in his TFA module. I'm not very familiar with fieldtype/inputfield module development so I blindly followed @bernhard (great) tutorial and his BaseFieldtypeRuntime. At some point I'll take a deeper look to make a module on my own.
      Some ideas for improvements :
      add the ability to choose what to ouput : page's url / editUrl / file(s) / image(s) / ... allow to output multiple QR codes ?
    • By Chris Bennett
      https://github.com/chrisbennett-Bene/AdminThemeTweaker
      Inspired by @bernhard's excellent work on the new customisable LESS CSS getting rolled into the core soon, I thought I would offer up the module for beta testing, if it is of interest to anyone.

      It takes a different approach to admin styling, basically using the Cascade part of CSS to over-ride default UiKit values.
      Values are stored in ModuleConfig Module creates a separate AdminThemeTweaker Folder at root, so it can link to AdminThemeTweaker.php as CSS AdminThemeTweaker.php reads the module values, constructs the CSS variables then includes the CSS framework Can be switched on and off with a click. Uninstall removes everything, thanks to bernhard's wonderful remove dir & contents function.
      It won't touch your core. It won't care if stuff is upgraded. You won't need to compile anything and you don't need to touch CSS unless you want to.

      It won't do much at all apart from read some values from your module config, work out the right CSS variables to use (auto contrast based on selected backgrounds) and throw it on your screen.
      You can configure a lot of stuff, leave it as it comes (dark and curvy), change two main colors (background and content background) or delve deep to configure custom margins, height of mastheads, and all manner of silly stuff I never use.

      Have been developing it for somewhere around 2 years now. It has been (and will continue to be) constantly tweaked over that time, as I click on something and find something else to do.
      That said, it is pretty solid and has been in constant use as my sole Admin styling option for all of those 2 years.

      If nothing else, it would be great if it can provide any assistance to @bernhard or other contributor's who may be looking to solve some of the quirkier UiKit behavior.
      Has (in my opinion) more robust and predictable handling of hidden Inputfields, data-colwidths and showIf wrappers.
      I am very keen to help out with that stuff in any way I can, though LESS (and any css frameworks/tools basically) are not my go.
      I love CSS variables and banging-rocks-together, no-dependency CSS you can write with notepad.



       

    • By opalepatrick
      I see old posts saying that repeaters are not the way to go in Custom Process Modules. If that is the case, when using forms (as I am trying to do) how would one tackle things like repeat contact fields where there can be multiple requirements for contact details with different parameters? (Like point of contact, director, etc) or even telephone numbers that have different uses?
      Just for background I am creating a process module that allows me to create types of financial applications in the admin area (no need to publish any of this, pure admin) that require a lot of personal or company information.
      Maybe I am thinking about this incorrectly?
    • By HMCB
      I ran across a reference to IftRunner module. The post was 6 years ago. I cant find it in available modules. Has it been pulled?
×
×
  • Create New...