Jump to content

tpr

Members
  • Posts

    2,321
  • Joined

  • Last visited

  • Days Won

    44

Everything posted by tpr

  1. Status report: no joy here with the latest version. I'll check your other suggestion soon, thanks!
  2. I think there was a discussion on this, and it was on a (lengthy) todo list. I also think that the default repeaters should be avoided, and I wouldn't mind removing them entirely.
  3. Ok, thanks. Seems that 1.2.6: fail (f8d4ca6c1f8afe31331bdaa94a89b50874371586) 1.2.5: works (TracyDebugger-3f7e1081446ba2d65c8ab2f093f5cb88bfd3bda3)
  4. I've had some bugtracking time because Tracy didn't show up. All I was got is <!-- Tracy Debug Bar --> <div id="tracy-debug"></div> <link rel="stylesheet" href="?_tracy_bar=css&v=2.4-dev" id="tracy-debug-style" /> <script src="?_tracy_bar=js&v=2.4-dev" id="tracy-debug-script"></script> <script src="?_tracy_bar=content.b633f8ba5be45d8f70234e0a83c77ebc"></script> And EOF (html source). First I thought it was the latest devns branch but on another site it worked even with PW 3.015. Second I reverted PHP version to 5.6 (from 7.05), but no joy. Finally I reverted Tracy to 0.9.8 and it's working now. I have no idea what could cause this. No error logs about this at all on the server. I can check versions up from 0.9.8 to see where it starts failing if you provide links to it (or can I find them on GitHub?).
  5. Just created an issue on github: Inline toolbar not showing with Matrix Repeater (+ quick fix) https://github.com/NicoKnoll/LightWire-Skin/issues/6
  6. Check if the module AdminRestrictBranch can help you: https://processwire.com/talk/topic/11499-admin-restrict-branch/
  7. Fixing the config is universally a good thing
  8. I forked the module to make the module settings maxWidth and maxHeight work in Responsive mode: https://github.com/rolandtoth/TextformatterVideoEmbed Basically it adds an extra wrapper div which max-width and max-height inline CSS is set to what you put in module settings. Also the hard-coded 56.25% aspect ratio is calculated from these values.
  9. What if you use include=all, or check role set to false (sorry, on mobile, don't know the correct term for the latter)
  10. I guess too low PHP version.
  11. Please don't forget to share the URL once you got this sorted
  12. Just thinking out loud... a TextformatterNewCar could come handy
  13. Just added a PR to disallow unchecking required radio buttons. It could be simpler but if inputs are in a fieldset then I couldn't find a working jQuery selector to properly target the inputs.
  14. I agree that a template engine is an additional layer of complication but one have to decide whether it's worth or not. For me the benefits compensate the extra overhead - which, as szabesz wrote, is not significant if you have built a workflow that fits. Using them in a wrong way may lead to bad things of course, but this is the case with all the other tools like sass, gulp, etc.
  15. Do you expose Tracy to the public? The validator shouldn't see it at all.
  16. tpr

    MarkupSrcSet

    v002 is up on GitHub: https://github.com/rolandtoth/MarkupSrcSet
  17. Ok, another one for @netcarver // enable unchecking radio buttons // http://stackoverflow.com/questions/6191621/jquery-check-uncheck-radio-button-onclick#answer-13575528 $page->addHookAfter('render', function ($event) { if ($this->page->template != 'admin') return; $js = <<< HTML <script> $(document).ready(function(){ $("input:radio:checked").data("chk",true); $("input:radio").click(function(){ $("input[name='"+$(this).attr("name")+"']:radio").not(this).removeData("chk"); $(this).data("chk",!$(this).data("chk")); $(this).prop("checked",$(this).data("chk")); }); }); </script> HTML;
  18. tpr

    MarkupSrcSet

    There are some pending updates to this, plus I guess I can't help myself to create an image method for rendering the markup instead of the global functions (eg. $img->srcset()).
  19. This is a very beta version of the separate functions I use to generate srcset/bgset markups. There's some similar functions floating around in the forum but this one is a bit different because you can set "named image sets" which you can use easily site-wide. It's definitely work-in-progress so use it at your own risk. MarkupSrcSet Generate srcset and bgset markup for lazysizes. Features generate srcset/bgset markup for lazysizes set image sizes in JSON array add required JavaScripts automatically (optional) fallback to smallest image size if JavaScript is not available Usage Image sets JSON (in module settings): { "hero": [ [640, 210], [1080, null], [1920, null] ], "featured-image": [ [360, 240], 1.333, 2.667 ], "gallery-thumb": [ [240, 120], [480, 300], [800, 576] ] } Image methods $image->srcset(): <img <?php echo $page->featured_image->srcset('featured-image'); ?>> $image->bgset(): <div <?php echo $page->images->first()->bgset('hero'); ?>>Lorem ipsum</div> https://github.com/rolandtoth/MarkupSrcSet
  20. How did you add note_page_id to the page, and how does its rendered markup look like?
  21. Browser extensions? I'm not sure if this feature is worth a (sub)module, unless it provides some benefits over them.
×
×
  • Create New...