Jump to content
apeisa

Release: Thumbnails

Recommended Posts

No problem Hani - I thought it would be quite a useful addition as you don't need to see the thumbnail options where you don't need them, plus it can reduce confusion for clients too if they apply a crop and the crop tool isn't used in a particular template.

Share this post


Link to post
Share on other sites

That's a great addition Pete. Thanks!

Antti, the only issue I have is not being able to see the thumbnail previews when hovering over the thumbnail names in that field.

Regards

Marty

Share this post


Link to post
Share on other sites

On top of that, I'm getting an odd error, but only on ONE site where this is used (all of them updated t the latest version, only one showing the error):

Notice: Undefined variable: cropUrl in C:\xampp\htdocs\blah\site\modules\InputfieldCropImage\InputfieldCropImage.module on line 48

Share this post


Link to post
Share on other sites

Okay, looks like I took out a bit of code accidentally which causes my error.

In InputfieldCropImage.module, before this line:

$page = $this->pages->get($this->input->get->id);

add this

$cropUrl = "../image-crop/";

I don't think this has anything to do with the hover not working to preview thumbnails though - not sure what that is to be honest, possibly something with a newer version of jQuery maybe? I can't figure it out though it is affecting my PW 2.2 site.

I'll commit my latest code change shortly and do another pull request Antti.

Share this post


Link to post
Share on other sites

the only issue I have is not being able to see the thumbnail previews when hovering over the thumbnail names in that field.

Marty - do you happen to have the HelperFieldLinks module installed? If so, the problem might be something with this part of the module's css.

.ui-widget-content{
overflow:hidden; /*clear floats*/
}

If you do have it installed, you can comment that out. I don't think there's a significant problem doing that. From what I saw, the helper link to the field/template that appears below the field simply doesn't have the proper spacing below it.

Share this post


Link to post
Share on other sites

Marty - do you happen to have the HelperFieldLinks module installed?

Hi Hani,

No I don't have that one installed. I'm sure it's just something small that's causing it. To be expected with a new version of PW :)

Regards

Marty

Share this post


Link to post
Share on other sites

I'll hope to find time to take a look at this. I have test case and can repeat this. With quick look I couldn't find what is causing it. JS is not throwing errors, so I think it is changed markup somewhere or some new styles that is causing problems. Probably a quick fix, but now heading to a bed.

Share this post


Link to post
Share on other sites

No problem Antti, and apologies in advance if it was something I did! ;)

Share this post


Link to post
Share on other sites

I've checked this one out on my local PW2.2 isntall. I get the same problem with the hover not working.

I fixed that one by changing the InputfieldCropImage.js a little. The live hover event wasn't working. I changed it from "mouseenter" to "mouseover", and it's working now.

I'm not sure about github. I have the repo local and commited the fix just now, but I don't know if it gets commited or apeisa needs to pull the commit first...

So heres the code for those interested:

$(document).ready(function() {

   $("a.crop").live("hover", function(e) {
       if( e.type === 'mouseover') {
           url = $(this).data('thumburl') + "?timestamp=" + new Date().getTime();
           $(this).append("<img style='position: absolute; z-index: 999;' src="+url+" />");
       }
       else {
           $(this).find("img").remove();
       }
   });

   $(".InputfieldCropImage .InputfieldFileList").live('AjaxUploadDone', function() {
       console.log("it should");
       $("a.InputfieldFileLink", $(this)).fancybox(); 
   }); 

   /* Modal disabled, cropping huge images is very difficult with modals
   $("a.crop").live("click", function() {
       var url = $(this).attr('href');
       var windowHeight = $(window).height() - 120; 
       var windowWidth = $(window).width() - 120; 
       $iframe = $('<iframe id="pwimage_iframe" width="100%" frameborder="0" src="'+url+'"></iframe>');
       $iframe.parent().css('position', 'fixed').end().dialog({
                   title: "Crop Image", 
                   height: windowHeight,
                   width: windowWidth,
                   position: [60, 60], 
                   modal: true,
                   overlay: {
                       opacity: 0.7,
                       background: "black"
                   }
               }).width(windowWidth).height(windowHeight);
       return false;
   });
   */
});

Share this post


Link to post
Share on other sites

I have committed this change at some point: https://github.com/a...135f4fa5824b20f

There are more differences than mouseover/mouseenter (I was using native js-event instead of jQuery), so your fix might well work on all browsers. What I don't understand is why it has broken now? Maybe browser cache with all of us or something like that...?

EDIT: I tested this and it works nice. Thanks Soma for the fix. I merged it in and also removed one unnecessary debug message I had forgotten there.

Share this post


Link to post
Share on other sites

Glad I could help.

TO my understanding, it wasn't working cause you check for "hover" event in the live method, and then e.type will never return "mouseenter". It's unlike the .hover method which binds mouseenter,mouseleave. Dunno why exactly it is like this, but I guess it should work all well.

I haven't tried but maybe it would require to write .live("mouseenter mouseleave", function ... ) { if (e.type=="mouseenter") .. to make it work with those events.

Share this post


Link to post
Share on other sites

Hi,

In Chrome and Safari (OS X) this line works:

if( e.type === 'mouseover')

but this line (in the latest commit) doesn't:

if( e.type === 'mouseenter')

I can't test this is Firefox 9 because I can't even log into PW with it.

Regards

Marty

Share this post


Link to post
Share on other sites
I can't test this is Firefox 9 because I can't even log into PW with it.

Why can't you login into PW with Firefox 9? (FF9 is my native browser). Just curious if I've missed something? :)

Share this post


Link to post
Share on other sites

Hi,

In Chrome and Safari (OS X) this line works:

if( e.type === 'mouseover')

but this line (in the latest commit) doesn't:

if( e.type === 'mouseenter')

I can't test this is Firefox 9 because I can't even log into PW with it.

Regards

Marty

Marty, there shouldn't be any mouseenter left (https://github.com/apeisa/Thumbnails/blob/master/InputfieldCropImage/InputfieldCropImage.js). Are you sure that isn't coming from browser cache?

Share this post


Link to post
Share on other sites

Hi Antti,

I used soma's code line from the previous page. I've double-checked that the InputfieldCropImage.js isn't cached. I just tried that line with 'mouseenter' instead of 'mouseover' in Firefox 10 and I don't get the image hovers.

Scratch that. It appears to be work now. I was at this for an hour yesterday. All's good now.

@ryan I reinstalled it (now to FF10) and it works fine now. No idea why it stopped me logging in even after FF's numerous updates recently.

Regards

Martin

Share this post


Link to post
Share on other sites

I might be taking things a bit far with my latest idea, but I have plenty of scenarios where I on;y want a specific crop to be available to the first image in a list of images and not the rest, and then have a different crop available for the rest and not the first one (so first thumbnail bigger than the rest).

I was thinking of trying to re-jig the code I did to allow crops to be tied to specific templates to something like this:

big_thumbnail,300,200,news:first,article
small_thumbnail,160,100,news:!first,article

So in the code above, for the news template a colon separates the template name from a keyword - first - so the big thumbnail is only available as an option for the first image in the list. In the second config row for the small thumbnail, it is !first, with the exclamation mark meaning NOT (as it does in PHP).

Both crops are available for all images in the article template as no image-specific setting is specified for that template.

I did quickly look into this a few weeks ago and it looked a bit more complicated than the previous code change I did, but I don't think it's impossible.

The only concern I can see here is that as soon as you re-order the images, the first image in a list might be further down the list, so I'm not sure what to do there. Maybe I should just assume that people would click Save once they've re-ordered the page and then they can re-select their crops as normal? I think that that would be a small price to pay for the additional functionality - especially since not a lot of people may find it useful, but I hope others might see the benefits and have some usage scenarios in mind too :)

Anyway, it's not high up my list of priorities, but I thought I'd see who else is interested in this.

Share this post


Link to post
Share on other sites

A site I built in EE a while back had a similar scenario. I had a few rows of images with a check box next to each that, when checked, made that image the hero image. I haven't tried this but could you not use the repeater field with the thumbnails and check box field to say use this image's large thumbnail and use the smaller thumbnail for the remaining images?

I haven't played with the repeater field yet so I might be talking nonsense.

Share this post


Link to post
Share on other sites

That's kind of what I'm trying to do, but hide the thumbnail links when they're not needed to avoid confusion - that's what this next bit of code would do :)

Share this post


Link to post
Share on other sites

I was thinking of trying to re-jig the code I did to allow crops to be tied to specific templates to something like this:

big_thumbnail,300,200,news:first,article
small_thumbnail,160,100,news:!first,article

I think that would be better to set up a a thumbnail by the form field. Configuration would be more flexible.

I have cases where a template has multiple images in different sizes.

In the current approach. I set a thumbnail based on the template. For each field, I get three dimensions.

Maybe it would be better in this way:

// article_tpl template
thumb_100x100,100,100,field_name_img1
thumb_300x300,300,300,field_name_img2
thumb_500x500,500,500,field_name_img3


// and in the news_tpl
thumb_150x150,150,150,field_news_img1
thumb_350x350,350,350,field_news_img2,other_field_name_img2
thumb_550x550,550,550,field_news_img3

Or in this way:

// article template
thumb_100x100,100,100,template_name[field_name_img1]
thumb_300x300,300,300,template_name[field_name_img2],template2_name[field_name2_img2]
thumb_500x500,500,500,template_name[field_name_img3]

It may even be better to move the configuration to the form field settings?

Share this post


Link to post
Share on other sites

That would be nIce, I agree, but not too simple the way the module currently works.

Now that PW has per-field settings for the same field on different templates I can see how something like that could work - I just have no idea how to code it ;)

Share this post


Link to post
Share on other sites

I agree that template level settings would be a nice improvement. Unfortunately I don't have any time in short term with this module (other than possible bug fixes).

Share this post


Link to post
Share on other sites

I made some changes to this module. I moved to CropImage configurations. Own unique configuration for each field. You can have multiple fields in a template with different settings.

Limiting scope to the template is still possible.

thumb,100,200,basic-page is still possible.

Here is fork https://github.com/PawelGIX/Thumbnails

Share this post


Link to post
Share on other sites

Great stuff Pawel, thanks for working on this. Feel free to send pull request. I think this is improvement that everyone wants!

PS: This is module is becoming pretty nice community effort: three different developers + one sponsoring. And also using one third party open source tool, jCrop.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By MoritzLost
      Process Cache Control
      This module provides a simple solution to clearing all your cache layers at once, and an extensible interface to perform various cache-related actions.
      The simple motivation behind this module was that I was tired of manually clearing caches in several places after deploying a change on a live site. The basic purpose of this module is a simple Clear all caches link in the Setup menu which clears out all caches, no matter where they hide. You can customize what exactly the module does through it's configuration menu:
      Expire or delete all cache entries in the database, or selectively clear caches by namespace ($cache API) Clear the the template render cache. Clear out specific folders inside your site's cache directory (/site/assets/cache) Clear the ProCache page render cache (if your site is using ProCache) Refresh version strings for static assets to bust client-side browser caches (this requires some setup, see the full documentation for details). This is the basic function of the module. However, you can also add different cache management action through the API and execute them through the module's interface. For this advanced usage, the module provides:
      An interface to see all available cache actions and execute them. A system log and logging output on the module page to see verify what the module is doing. A CacheControlTools class with utility functions to clear out different caches. An API to add cache actions, execute them programmatically and even modify the default action. Permission management, allowing you granular control over which user roles can execute which actions. The complete documentation can be found in the module's README.
      Plans for improvements
      If there is some interest in this, I plan to expand this to a more general cache management solution. I particular, I would like to add additional cache actions. Some ideas that came to mind:
      Warming up the template render cache for publicly accessible pages. Removing all active user sessions. Let me know if you have more suggestions!
      Links
      https://github.com/MoritzLost/ProcessCacheControl ProcessCacheControl in the Module directory CHANGELOG in the repository Screenshots


    • By Macrura
      PrevNextTabs Module
      Github: https://github.com/outflux3/PrevNextTabs
      Processwire helper modules for adding page navigation within the editor.
      Overview
      This is a very simple module that adds Previous and Next links inline with the tabs on the page editor. Hovering over the tab shows the title of the previous or next page (using the admin's built in jqueryUI tooltips.)
      Usage
      This module is typically used during development where you or your editors need to traverse through pages for the purpose of proofing, flagging and/or commenting. Rather than returning to the page tree or lister, they can navigate with these links.
      Warnings
      If you are using PW version 2.6.1 or later, the system will prevent you from leaving the page if you have unsaved edits.
      For earlier versions, to avoid accidentally losing changes made to a page that might occur if a user accidentally clicks on one of these, make sure to have the Form Save Reminder module installed.
      http://modules.processwire.com/modules/prev-next-tabs/
    • By Gadgetto
      SnipWire - Snipcart integration for ProcessWire
      Snipcart is a powerful 3rd party, developer-first HTML/JavaScript shopping cart platform. SnipWire is the missing link between Snipcart and the content management framework ProcessWire.
      With SnipWire, you can quickly turn any ProcessWire site into a Snipcart online shop. The SnipWire plugin helps you to get your store up and running in no time. Detailed knowledge of the Snipcart system is not required.
      SnipWire is free and open source licensed under Mozilla Public License 2.0! A lot of work and effort has gone into development. It would be nice if you could donate an amount to support further development:

      Status update links (inside this thread) for SnipWire development
      2020-03-21 -- SnipWire 0.8.5 (beta) released! Improves SnipWires webhooks interface and provides some other fixes and additions 2020-03-03 -- SnipWire 0.8.4 (beta) released! Improves compatibility for Windows based Systems. 2020-03-01 -- SnipWire 0.8.3 (beta) released! The installation and uninstallation process has been heavily revised. 2020-02-08 -- SnipWire 0.8.2 (beta) released! Added a feature to change the cart and catalogue currency by GET, POST or SESSION param 2020-02-03 -- SnipWire 0.8.1 (beta) released! All custom classes moved into their own namespaces. 2020-02-01 -- SnipWire is now available via ProcessWire's module directory! 2020-01-30 -- SnipWire 0.8.0 (beta) first public release! (module just submitted to the PW modules directory) 2020-01-28 -- added Custom Order Fields feature (first SnipWire release version is near!) 2020-01-21 -- Snipcart v3 - when will the new cart system be implemented? 2020-01-19 -- integrated taxes provider finished (+ very flexible shipping taxes handling) 2020-01-14 -- new date range picker, discount editor, order notifiactions, order statuses, and more ... 2019-11-15 -- orders filter, order details, download + resend invoices, refunds 2019-10-18 -- list filters, REST API improvements, new docs platform, and more ... 2019-08-08 -- dashboard interface, currency selector, managing Orders, Customers and Products, Added a WireTabs, refinded caching behavior 2019-06-15 -- taxes provider, shop templates update, multiCURL implementation, and more ... 2019-06-02 -- FieldtypeSnipWireTaxSelector 2019-05-25 -- SnipWire will be free and open source Plugin Key Features
      Fast and simple store setup Full integration of the Snipcart dashboard into the ProcessWire backend (no need to leave the ProcessWire admin area) Browse and manage orders, customers, discounts, abandoned carts, and more Multi currency support Custom order and cart fields Process refunds and send customer notifications from within the ProcessWire backend Process Abandoned Carts + sending messages to customers from within the ProcessWire backend Complete Snipcart webhooks integration (all events are hookable via ProcessWire hooks) Integrated taxes provider (which is more flexible then Snipcart own provider) Useful Links
      SnipWire in PW modules directory SnipWire Docs (please note that the documentation is a work in progress) SnipWire @GitHub (feature requests and suggestions for improvement are welcome - I also accept pull requests) Snipcart Website  
      ---- INITIAL POST FROM 2019-05-25 ----
       
    • By horst
      Croppable Image 3
      for PW 3.0.20+
      Module Version 1.2.0
      Sponsored by http://dreikon.de/, many thanks Timo & Niko!
      You can get it in the modules directory!
      Please refer to the readme on github for instructions.
       
      - + - + - + - + - + - + - + - + - + - NEWS - 2020/03/19 - + - + - + - + - + - + - + - + - + - 
      There is a new Version in the pipe, that supports WebP too: 
       
      - + - + - + - + - + - + - + - + - + - NEWS - 2020/03/19 - + - + - + - + - + - + - + - + - + - 
       
       
      -------------------------------------------------------------------------
       
      Updating from prior versions:
       
      Updating from Croppable Image 3 with versions prior to 1.1.7, please do this as a one time step:
      In the PW Admin, go to side -> modules -> new, use "install via ClassName" and use CroppableImage3 for the Module Class Name. This will update your existing CroppableImage3 module sub directory, even if it is called a new install. After that, the module will be recogniced by the PW updater module, what makes it a lot easier on further updates.
      -------------------------------------------------------------------------
       
      For updating from the legacy Thumbnail / CropImage to CroppableImage3 read on here.
       
      -------------------------------------------------------------------------
       
×
×
  • Create New...