Jump to content
apeisa

Release: Thumbnails

Recommended Posts

No problem Hani - I thought it would be quite a useful addition as you don't need to see the thumbnail options where you don't need them, plus it can reduce confusion for clients too if they apply a crop and the crop tool isn't used in a particular template.

Share this post


Link to post
Share on other sites

That's a great addition Pete. Thanks!

Antti, the only issue I have is not being able to see the thumbnail previews when hovering over the thumbnail names in that field.

Regards

Marty

Share this post


Link to post
Share on other sites

On top of that, I'm getting an odd error, but only on ONE site where this is used (all of them updated t the latest version, only one showing the error):

Notice: Undefined variable: cropUrl in C:\xampp\htdocs\blah\site\modules\InputfieldCropImage\InputfieldCropImage.module on line 48

Share this post


Link to post
Share on other sites

Okay, looks like I took out a bit of code accidentally which causes my error.

In InputfieldCropImage.module, before this line:

$page = $this->pages->get($this->input->get->id);

add this

$cropUrl = "../image-crop/";

I don't think this has anything to do with the hover not working to preview thumbnails though - not sure what that is to be honest, possibly something with a newer version of jQuery maybe? I can't figure it out though it is affecting my PW 2.2 site.

I'll commit my latest code change shortly and do another pull request Antti.

Share this post


Link to post
Share on other sites

the only issue I have is not being able to see the thumbnail previews when hovering over the thumbnail names in that field.

Marty - do you happen to have the HelperFieldLinks module installed? If so, the problem might be something with this part of the module's css.

.ui-widget-content{
overflow:hidden; /*clear floats*/
}

If you do have it installed, you can comment that out. I don't think there's a significant problem doing that. From what I saw, the helper link to the field/template that appears below the field simply doesn't have the proper spacing below it.

Share this post


Link to post
Share on other sites

Marty - do you happen to have the HelperFieldLinks module installed?

Hi Hani,

No I don't have that one installed. I'm sure it's just something small that's causing it. To be expected with a new version of PW :)

Regards

Marty

Share this post


Link to post
Share on other sites

I'll hope to find time to take a look at this. I have test case and can repeat this. With quick look I couldn't find what is causing it. JS is not throwing errors, so I think it is changed markup somewhere or some new styles that is causing problems. Probably a quick fix, but now heading to a bed.

Share this post


Link to post
Share on other sites

No problem Antti, and apologies in advance if it was something I did! ;)

Share this post


Link to post
Share on other sites

I've checked this one out on my local PW2.2 isntall. I get the same problem with the hover not working.

I fixed that one by changing the InputfieldCropImage.js a little. The live hover event wasn't working. I changed it from "mouseenter" to "mouseover", and it's working now.

I'm not sure about github. I have the repo local and commited the fix just now, but I don't know if it gets commited or apeisa needs to pull the commit first...

So heres the code for those interested:

$(document).ready(function() {

   $("a.crop").live("hover", function(e) {
       if( e.type === 'mouseover') {
           url = $(this).data('thumburl') + "?timestamp=" + new Date().getTime();
           $(this).append("<img style='position: absolute; z-index: 999;' src="+url+" />");
       }
       else {
           $(this).find("img").remove();
       }
   });

   $(".InputfieldCropImage .InputfieldFileList").live('AjaxUploadDone', function() {
       console.log("it should");
       $("a.InputfieldFileLink", $(this)).fancybox(); 
   }); 

   /* Modal disabled, cropping huge images is very difficult with modals
   $("a.crop").live("click", function() {
       var url = $(this).attr('href');
       var windowHeight = $(window).height() - 120; 
       var windowWidth = $(window).width() - 120; 
       $iframe = $('<iframe id="pwimage_iframe" width="100%" frameborder="0" src="'+url+'"></iframe>');
       $iframe.parent().css('position', 'fixed').end().dialog({
                   title: "Crop Image", 
                   height: windowHeight,
                   width: windowWidth,
                   position: [60, 60], 
                   modal: true,
                   overlay: {
                       opacity: 0.7,
                       background: "black"
                   }
               }).width(windowWidth).height(windowHeight);
       return false;
   });
   */
});

Share this post


Link to post
Share on other sites

I have committed this change at some point: https://github.com/a...135f4fa5824b20f

There are more differences than mouseover/mouseenter (I was using native js-event instead of jQuery), so your fix might well work on all browsers. What I don't understand is why it has broken now? Maybe browser cache with all of us or something like that...?

EDIT: I tested this and it works nice. Thanks Soma for the fix. I merged it in and also removed one unnecessary debug message I had forgotten there.

Share this post


Link to post
Share on other sites

Glad I could help.

TO my understanding, it wasn't working cause you check for "hover" event in the live method, and then e.type will never return "mouseenter". It's unlike the .hover method which binds mouseenter,mouseleave. Dunno why exactly it is like this, but I guess it should work all well.

I haven't tried but maybe it would require to write .live("mouseenter mouseleave", function ... ) { if (e.type=="mouseenter") .. to make it work with those events.

Share this post


Link to post
Share on other sites

Hi,

In Chrome and Safari (OS X) this line works:

if( e.type === 'mouseover')

but this line (in the latest commit) doesn't:

if( e.type === 'mouseenter')

I can't test this is Firefox 9 because I can't even log into PW with it.

Regards

Marty

Share this post


Link to post
Share on other sites
I can't test this is Firefox 9 because I can't even log into PW with it.

Why can't you login into PW with Firefox 9? (FF9 is my native browser). Just curious if I've missed something? :)

Share this post


Link to post
Share on other sites

Hi,

In Chrome and Safari (OS X) this line works:

if( e.type === 'mouseover')

but this line (in the latest commit) doesn't:

if( e.type === 'mouseenter')

I can't test this is Firefox 9 because I can't even log into PW with it.

Regards

Marty

Marty, there shouldn't be any mouseenter left (https://github.com/apeisa/Thumbnails/blob/master/InputfieldCropImage/InputfieldCropImage.js). Are you sure that isn't coming from browser cache?

Share this post


Link to post
Share on other sites

Hi Antti,

I used soma's code line from the previous page. I've double-checked that the InputfieldCropImage.js isn't cached. I just tried that line with 'mouseenter' instead of 'mouseover' in Firefox 10 and I don't get the image hovers.

Scratch that. It appears to be work now. I was at this for an hour yesterday. All's good now.

@ryan I reinstalled it (now to FF10) and it works fine now. No idea why it stopped me logging in even after FF's numerous updates recently.

Regards

Martin

Share this post


Link to post
Share on other sites

I might be taking things a bit far with my latest idea, but I have plenty of scenarios where I on;y want a specific crop to be available to the first image in a list of images and not the rest, and then have a different crop available for the rest and not the first one (so first thumbnail bigger than the rest).

I was thinking of trying to re-jig the code I did to allow crops to be tied to specific templates to something like this:

big_thumbnail,300,200,news:first,article
small_thumbnail,160,100,news:!first,article

So in the code above, for the news template a colon separates the template name from a keyword - first - so the big thumbnail is only available as an option for the first image in the list. In the second config row for the small thumbnail, it is !first, with the exclamation mark meaning NOT (as it does in PHP).

Both crops are available for all images in the article template as no image-specific setting is specified for that template.

I did quickly look into this a few weeks ago and it looked a bit more complicated than the previous code change I did, but I don't think it's impossible.

The only concern I can see here is that as soon as you re-order the images, the first image in a list might be further down the list, so I'm not sure what to do there. Maybe I should just assume that people would click Save once they've re-ordered the page and then they can re-select their crops as normal? I think that that would be a small price to pay for the additional functionality - especially since not a lot of people may find it useful, but I hope others might see the benefits and have some usage scenarios in mind too :)

Anyway, it's not high up my list of priorities, but I thought I'd see who else is interested in this.

Share this post


Link to post
Share on other sites

A site I built in EE a while back had a similar scenario. I had a few rows of images with a check box next to each that, when checked, made that image the hero image. I haven't tried this but could you not use the repeater field with the thumbnails and check box field to say use this image's large thumbnail and use the smaller thumbnail for the remaining images?

I haven't played with the repeater field yet so I might be talking nonsense.

Share this post


Link to post
Share on other sites

That's kind of what I'm trying to do, but hide the thumbnail links when they're not needed to avoid confusion - that's what this next bit of code would do :)

Share this post


Link to post
Share on other sites

I was thinking of trying to re-jig the code I did to allow crops to be tied to specific templates to something like this:

big_thumbnail,300,200,news:first,article
small_thumbnail,160,100,news:!first,article

I think that would be better to set up a a thumbnail by the form field. Configuration would be more flexible.

I have cases where a template has multiple images in different sizes.

In the current approach. I set a thumbnail based on the template. For each field, I get three dimensions.

Maybe it would be better in this way:

// article_tpl template
thumb_100x100,100,100,field_name_img1
thumb_300x300,300,300,field_name_img2
thumb_500x500,500,500,field_name_img3


// and in the news_tpl
thumb_150x150,150,150,field_news_img1
thumb_350x350,350,350,field_news_img2,other_field_name_img2
thumb_550x550,550,550,field_news_img3

Or in this way:

// article template
thumb_100x100,100,100,template_name[field_name_img1]
thumb_300x300,300,300,template_name[field_name_img2],template2_name[field_name2_img2]
thumb_500x500,500,500,template_name[field_name_img3]

It may even be better to move the configuration to the form field settings?

Share this post


Link to post
Share on other sites

That would be nIce, I agree, but not too simple the way the module currently works.

Now that PW has per-field settings for the same field on different templates I can see how something like that could work - I just have no idea how to code it ;)

Share this post


Link to post
Share on other sites

I agree that template level settings would be a nice improvement. Unfortunately I don't have any time in short term with this module (other than possible bug fixes).

Share this post


Link to post
Share on other sites

I made some changes to this module. I moved to CropImage configurations. Own unique configuration for each field. You can have multiple fields in a template with different settings.

Limiting scope to the template is still possible.

thumb,100,200,basic-page is still possible.

Here is fork https://github.com/PawelGIX/Thumbnails

Share this post


Link to post
Share on other sites

Great stuff Pawel, thanks for working on this. Feel free to send pull request. I think this is improvement that everyone wants!

PS: This is module is becoming pretty nice community effort: three different developers + one sponsoring. And also using one third party open source tool, jCrop.

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By gebeer
      Although the PW backend is really intuitive, ever so often my clients need some assistance. Be it they are not so tech savvy or they are not working in the backend often.
      For those cases it is nice to make some help videos available to editors. This is what this module does.
      ProcessHelpVideos Module
      A Process module to display help videos for the ProcessWire CMS. It can be used to make help videos (screencasts) available to content editors.
      This module adds a 'Help Videos" section to the ProcessWire backend. The help videos are accessible through an automatically created page in the Admin page tree. You can add your help videos as pages in the page tree. The module adds a hidden page to the page tree that acts as parent page for the help video pages. All necessary fields and templates will be installed automatically. If there are already a CKEditor field and/or a file field for mp4 files installed in the system, the module will use those. Otherwise it will create the necessary fields. Also the necessary templates for the parent help videos page and it's children are created on module install. The module installs a permission process-helpvideos. Every user role that should have access to the help video section, needs this permission. I use the help video approach on quite a few production sites. It is stable so far and well received by site owners/editors. Up until now I installed required fields, templates and pages manually and then added the module. Now I added all this logic to the install method of the module and it should be ready to share.
      The module and further description on how to use it is available on github: https://github.com/gebeer/ProcessHelpVideos
      If you like to give it a try, I am happy to receive your comments/suggestions here.
    • By Robin S
      A module created in response to the topic here:
      Page List Select Multiple Quickly
      Modifies PageListSelectMultiple to allow you to select multiple pages without the tree closing every time you select a page.
      The screencast says it all:

       
      https://github.com/Toutouwai/PageListSelectMultipleQuickly
      https://modules.processwire.com/modules/page-list-select-multiple-quickly/
    • By gebeer
      Hello all,
      sharing my new module FieldtypeImagePicker. It provides a configurable input field for choosing any type of image from a predefined folder.
      The need for it came up because a client had a custom SVG icon set and I wanted the editors to be able to choose an icon in the page editor.
      It can also be used to offer a choice of images that are used site-wide without having to upload them to individual pages.
      There are no image manipulation methods like with the native PW image field.
      Module and full description can be found on github https://github.com/gebeer/FieldtypeImagePicker
      Kudos to @Martijn Geerts. I used his module FieldTypeSelectFile as a base to build upon.
      Here's how the input field looks like in the page editor:

      Hope it can be of use to someone.
      If you like to give it a try, I'm happy to hear your comments or suggestions for improvement. Eventually this will go in the module directory soon, too.
    • By bernhard
      @Sergio asked about the pdf creation process in the showcase thread about my 360° feedback/survey tool and so I went ahead and set my little pdf helper module to public.
      Description from PW Weekly:
       
      Modules Directory: https://modules.processwire.com/modules/rock-pdf/
      Download & Docs: https://github.com/BernhardBaumrock/RockPDF
       
      You can combine it easily with RockReplacer: 
      See also a little showcase of the RockPdf module in this thread:
       
    • By ukyo
      FieldtypeFontIconPicker
      Supported Icon Libraries
      FontAwesome 4.7.0 Uikit 3.0.34 IonicIcons 2.0.1 Cahangelog
      NOTE: Module store data without prefix, you need to add "prefix" when you want to show your icon on front-end, because some of front-end frameworks using font-awesome with different "prefix".
      Module will search site/modules/**/configs/IconPicker.*.php and site/templates/IconPicker.*.php paths for FieldtypeFontIconPicker config files.
      All config files need to return a PHP ARRAY like examples.
      Example config file : create your own icon set.
      File location is site/configs/IconPicker.example.php
      <?php namespace ProcessWire; /** * IconPicker : Custom Icons */ return [ "name" => "my-custom-icons", "title" => "My Custom Icon Set", "version" => "1.0.0", "styles" => array( wire("config")->urls->templates . "dist/css/my-custom-icons.css" ), "scripts" => array( wire("config")->urls->templates . "dist/js/my-custom-icons.js" ), "categorized" => true, "attributes" => array(), "icons" => array( "brand-icons" => array( "title" => "Brand Icons", "icons" => array( "google", "facebook", "twitter", "instagram" ) ), "flag-icons" => array( "title" => "Flag Icons", "icons" => array( "tr", "gb", "us", "it", "de", "nl", "fr" ) ) ) ]; Example config file : use existing and extend it.
      File location is site/configs/IconPicker.altivebir.php
      <?php namespace ProcessWire; /** * IconPicker : Existing & Extend */ $resource = include wire("config")->paths->siteModules . "FieldtypeFontIconPicker/configs/IconPicker.uikit.php"; $url = wire("config")->urls->templates . "dist"; $resource["scripts"] = array_merge($resource["scripts"], ["{$url}/js/Altivebir.Icon.min.js"]); $resource["icons"]["flag-icons"] = [ "title" => "Flag Icons", "icons" => array("tr", "en", "fr", "us", "it", "de") ]; $resource["icons"]["brand-icons"]["icons"] = array_merge($resource["icons"]["brand-icons"]["icons"], array( "altivebir" )); return $resource; After you add your custom config file, you will see your config file on library select box. Library Title (Location Folder Name).

      If your library categorized and if you have categorized icons set like uikit and fontawesome libraries, you will have category limitation options per icon field or leave it empty for allow all categories (default).

      Example : output
      if ($icon = $page->get("iconField")) { echo "<i class='prefix-{$icon}' />"; } MarkupFontIconPicker Usage
      // MarkupFontIconPicker::render(YourIconField=string, Options=array) echo MarkupFontIconPicker::render($page->YourIconField, [ 'prefix' => 'uk-icon-', // Icon class prefix, if you have different prefix, default is : "fa fa-" 'tag' => 'span', // Icon tag default is : "i" 'class' => 'fa-lg', // If you have extra cutom classes, for example : icons sizes, Array or Sting value 'style' => 'your custom styles if you have' // Array or String Value ]); Theme support

      Search support

      Category support

       
×
×
  • Create New...