Jump to content
adrian

Phone Number Fieldtype

Recommended Posts

@Juergen - so sorry about the label translations - totally my fault - I was so used to pushing to the dev branch lately that I didn't think about breaking changes. I don't think it's worth reverting the change that broke those labels given how new this version is, but I'll be sure not to break that again.The undefined offset on line 322 is a different thing - that happens if you don't define the example numbers in a format - note the:  | 61,07,45673456,123 at the end of the line.

australiaNoCountryAreaCodeLeadingZero | {([phoneAreaCode,0,2])} {[phoneNumber,0,4]} {[phoneNumber,4,4]} {x[phoneExtension]} | 61,07,45673456,123

What I will do though is add default example numbers so you don't get that PHP Notice.

 

  • Like 1

Share this post


Link to post
Share on other sites
2 hours ago, Juergen said:

PHP Notice: Undefined offset: 3 in .../site/modules/FieldtypePhone/FieldtypePhone.module:322

New version fixes this notice.

Sorry once again for the label issues :)

  • Like 1

Share this post


Link to post
Share on other sites

Hello Adrian,

just to clearify: the empty labels problem happens after upgrading to the version with the option of hiding the labels (I think version 2.0.10) not from version 1 to version 2 (major upgrade).

Thanks for the fast fix!!

  • Like 1

Share this post


Link to post
Share on other sites
4 hours ago, Juergen said:

just to clearify: the empty labels problem happens after upgrading to the version with the option of hiding the labels

Yeah, understood - I changed the names of the settings fields to be more semantically correct. I shouldn't have changed them once I pushed v2.x to master, but what's done is done now I think and it's still early days for this new version so I don't think it will affect too many people.

  • Thanks 1

Share this post


Link to post
Share on other sites

@adrian I've just installed the module (2.0.12), I have an issue.

PHP Notice: Undefined offset: 1 in .../site/modules/FieldtypePhone/FieldtypePhone.module:320 when saving the module settings with this:

/*Hungary*/
hungaryAreaCodeOnly {([phoneAreaCode])}-{[phoneNumber,0,3]}-{[phoneNumber,3,4]}

If I add " | 1-21-123-4567" to the end, the notice is gone. You noted this new "part" in a post here and provide an example on the module's config page but it did not seem to be mandatory.

 

Share this post


Link to post
Share on other sites
4 minutes ago, szabesz said:

hungaryAreaCodeOnly {([phoneAreaCode])}-{[phoneNumber,0,3]}-{[phoneNumber,3,4]}

I think I figured it out, I am missing the first pipe character and that is why I got the warning.

  • Like 1

Share this post


Link to post
Share on other sites
4 minutes ago, szabesz said:

@adrian I've just installed the module (2.0.12), I have an issue.

PHP Notice: Undefined offset: 1 in .../site/modules/FieldtypePhone/FieldtypePhone.module:320 when saving the module settings with this:


/*Hungary*/
hungaryAreaCodeOnly {([phoneAreaCode])}-{[phoneNumber,0,3]}-{[phoneNumber,3,4]}

If I add " | 1-21-123-4567" to the end, the notice is gone. You noted this new "part" in a post here and provide an example on the module's config page but it did not seem to be mandatory.

 

The issue you are seeing is actually the missing pipe (|) between the name and the format. Try this:

/*Hungary*/
hungaryAreaCodeOnly | {([phoneAreaCode])}-{[phoneNumber,0,3]}-{[phoneNumber,3,4]}

 

  • Like 1

Share this post


Link to post
Share on other sites
3 minutes ago, adrian said:

The issue you are seeing is actually the missing pipe (|) between the name and the format.

Thanks! These sort of cryptic patterns ARE very useful but only after I have implemented them properly :)

  • Like 1

Share this post


Link to post
Share on other sites

New version:

1) Adds a new option to "Allow Letters in Input" which is to support companies who like to publicize their phone number using letters, like: 1800-CALLNOW - the default is for this to be off so validation still checks that all are digits, but with this on, you can also enter letters.

2) Has some tweaks to prevent a component suffix from displaying if there is no value for the next component. 

 

  • Like 2

Share this post


Link to post
Share on other sites

I just added new options for putting component labels in field placeholder and adding a custom class to each component input (eg. uk-input).

image.png.fc89b054023a72b6f95847809697fea9.png

  • Like 2

Share this post


Link to post
Share on other sites

Hi all - I have started a new 3.0 branch which has some more breaking changes.

This new version moves the country code into it's own "data_country" database field and stores a raw version of the number in the default "data" field. The reason for this is to make it possible to do a:

$pages->find("phone=13727654876")

Before you could only find by component parts, like:

$pages->find("phone.country=1, phone.are_code=372, phone.number=7654876")

My need for this was to find a user by their full raw/unformatted phone number as returned by the Twilio sms service's POST response.

I'll keep the changes in this branch for a while, but I would encourage new installs to try this version.

Let me know how it goes.

  • Like 2

Share this post


Link to post
Share on other sites

Hi Adrian,

I have not yet installed the 3.0 branch because I though before I spend time on it I ask you about an issue we have.

So we still have version 2.0.15 and the field is added to users (dunno if it matter as at all...) When the inputbox of the "core" number (not country, area nor extension)  is empty then Chrome automatically fills it in with the username used for logging into ProcessWire on the standard login screen and letting Chrome save the credentials. In other words, if we have Chrome save the login info, the current user's name gets injected into the inputbox when editing a user with an empty number, and this is an annoying issue because the inputbox must be manually cleared if we want to save the user.

Have you any idea how to stop this behavior?

  • Like 1

Share this post


Link to post
Share on other sites

Hi @szabesz - it can probably be solved quite easily with some autocomplete attributes.

Can you please try adding: 

autocomplete="pw-phone-country"
autocomplete="pw-phone-area-code"
autocomplete="pw-phone-number"
autocomplete="pw-phone-extension"

to the respective subfields. Here is the chunk of code that these need inserting into: https://github.com/adrianbj/FieldtypePhone/blob/ab02ad1a6aafc1b1abce60317cd97ce5a2c35374/InputfieldPhone.module#L98-L116

Let me know if that works as expected and feel free to submit a PR.

  • Like 1

Share this post


Link to post
Share on other sites

Thanks for the quick reply, based on it found this article: https://www.20spokes.com/blog/what-to-do-when-chrome-ignores-autocomplete-off-on-your-form This is also what you suggest, right?

The thing is that it is not my Mac which has this issue but a Windows machine I do not have access to right now. Hopefully I can test it on that machine on Tuesday. I want to make sure I test it with that setup too.

Share this post


Link to post
Share on other sites
19 minutes ago, szabesz said:

This is also what you suggest, right?

Yeah, I think so. Honestly I am not too up on the current state of this autocomplete stuff, but I think my suggestions will work.

Let me know how it goes when you test on Tuesday.

  • Like 1

Share this post


Link to post
Share on other sites

Hello @adrian

is it possible to disable the input field length fe

style="width:60px;"

by entering something into the settings field?

If not, it would be great if you add the possibility to enter fe a "-" to disable the rendering of the style attribute. This could be useful if you are using the UIKit template because there are various input length classes ('uk-form-width-medium'....)  and you dont need the input field length.

Best regards Jürgen

  • Like 1

Share this post


Link to post
Share on other sites

Hi @Juergen - I just added the option to both the master and 3.x branches. Let me know if you have any problems.

@szabesz  did you ever end up testing the autocomplete stuff?

Also, I'd like to move 3.x to master pretty soon because it's definitely much easier to work with raw numbers that way. Does anyone have any ideas for any other improvements that might also be breaking changes so we can get these in for this new version?

  • Like 1

Share this post


Link to post
Share on other sites
19 hours ago, adrian said:

@szabesz  did you ever end up testing the autocomplete stuff?

Yes I did, I just did not have the time to report and later on forgot to. I did not do any extensive testing, I just checked if the issue was gone on that particular machine or not. Since the issue had never showed up again, I guess the changes applied were the cause of it.

Share this post


Link to post
Share on other sites

FYI - I just merged the 3.0 branch to master - be warned that this is a breaking change because of the new data_country db field so please don't update existing installs unless you're prepared to do some DB manipulation - if you want to and can't figure out the required SQL commands, let me know and I can post something here.

  • Like 2

Share this post


Link to post
Share on other sites

Hello,

I have created a standard field type as userphone , then I added this field to the User template. I created a phone field type using Phone Field module. I added this field to the User template also.

image.thumb.png.f40f3d23d3f8849fdf15e13a06ef63b6.png

Now I used the below to create a test user

 $u = new User();
$u->of(false);
$u->name = "saarun";
$u->email = "saarunthomas@example.com";
$u->pass = "123456";
$u->Phone = 9446196667;
$u->userphone = 9446196667;
$u->headline = "hello there";
$u->paid=1;
$u->addRole("registered");
$u->save();
$u->of(true);

and I tried to out put as below

     $item = $users->get("saarun");
echo $item->email;
echo $item->Phone;
echo $item->paid;
echo $item->headline;
echo $item->userphone;

and I got the output a below.  Neither the userphone value nor the Phone value are output ... what am I doing here wrong  ? pls help

and I want to use this field in the Login/Register module. I want know whether this field support in the Login/Register registration form ??

image.png.eee59c5c952dd521d71cb1dd8d23cd22.png

Share this post


Link to post
Share on other sites
11 minutes ago, JeevanisM said:

Hello,

I have created a standard field type as userphone

It's a good idea to limit your support request to only one category. Posting in multiple places makes it very difficult to track the progress.

  • Like 1

Share this post


Link to post
Share on other sites
3 minutes ago, rick said:

It's a good idea to limit your support request to only one category. Posting in multiple places makes it very difficult to track the progress.

I found this thread at last only, will delete all other posts.

Share this post


Link to post
Share on other sites

@JeevanisM - I don't know why the integer phone number isn't working, but for the phone number field you have to set the subfields separately, eg:

$u->Phone->country = 944;
$u->Phone->number = 6196667;

or if you have the field set up to keep the area code in a separate subfield:

$u->Phone->country = 944;
$u->Phone->area_code = 619; 
$u->Phone->number = 6667;

and don't forget to use the field's formatting options to style the output how you want.

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By gebeer
      Although the PW backend is really intuitive, ever so often my clients need some assistance. Be it they are not so tech savvy or they are not working in the backend often.
      For those cases it is nice to make some help videos available to editors. This is what this module does.
      ProcessHelpVideos Module
      A Process module to display help videos for the ProcessWire CMS. It can be used to make help videos (screencasts) available to content editors.
      This module adds a 'Help Videos" section to the ProcessWire backend. The help videos are accessible through an automatically created page in the Admin page tree. You can add your help videos as pages in the page tree. The module adds a hidden page to the page tree that acts as parent page for the help video pages. All necessary fields and templates will be installed automatically. If there are already a CKEditor field and/or a file field for mp4 files installed in the system, the module will use those. Otherwise it will create the necessary fields. Also the necessary templates for the parent help videos page and it's children are created on module install. The module installs a permission process-helpvideos. Every user role that should have access to the help video section, needs this permission. I use the help video approach on quite a few production sites. It is stable so far and well received by site owners/editors. Up until now I installed required fields, templates and pages manually and then added the module. Now I added all this logic to the install method of the module and it should be ready to share.
      The module and further description on how to use it is available on github: https://github.com/gebeer/ProcessHelpVideos
      If you like to give it a try, I am happy to receive your comments/suggestions here.
    • By Robin S
      A module created in response to the topic here:
      Page List Select Multiple Quickly
      Modifies PageListSelectMultiple to allow you to select multiple pages without the tree closing every time you select a page.
      The screencast says it all:

       
      https://github.com/Toutouwai/PageListSelectMultipleQuickly
      https://modules.processwire.com/modules/page-list-select-multiple-quickly/
    • By gebeer
      Hello all,
      sharing my new module FieldtypeImagePicker. It provides a configurable input field for choosing any type of image from a predefined folder.
      The need for it came up because a client had a custom SVG icon set and I wanted the editors to be able to choose an icon in the page editor.
      It can also be used to offer a choice of images that are used site-wide without having to upload them to individual pages.
      There are no image manipulation methods like with the native PW image field.
      Module and full description can be found on github https://github.com/gebeer/FieldtypeImagePicker
      Kudos to @Martijn Geerts. I used his module FieldTypeSelectFile as a base to build upon.
      Here's how the input field looks like in the page editor:

      Hope it can be of use to someone.
      If you like to give it a try, I'm happy to hear your comments or suggestions for improvement. Eventually this will go in the module directory soon, too.
    • By bernhard
      @Sergio asked about the pdf creation process in the showcase thread about my 360° feedback/survey tool and so I went ahead and set my little pdf helper module to public.
      Description from PW Weekly:
       
      Modules Directory: https://modules.processwire.com/modules/rock-pdf/
      Download & Docs: https://github.com/BernhardBaumrock/RockPDF
       
      You can combine it easily with RockReplacer: 
      See also a little showcase of the RockPdf module in this thread:
       
    • By ukyo
      FieldtypeFontIconPicker
      Supported Icon Libraries
      FontAwesome 4.7.0 Uikit 3.0.34 IonicIcons 2.0.1 Cahangelog
      NOTE: Module store data without prefix, you need to add "prefix" when you want to show your icon on front-end, because some of front-end frameworks using font-awesome with different "prefix".
      Module will search site/modules/**/configs/IconPicker.*.php and site/templates/IconPicker.*.php paths for FieldtypeFontIconPicker config files.
      All config files need to return a PHP ARRAY like examples.
      Example config file : create your own icon set.
      File location is site/configs/IconPicker.example.php
      <?php namespace ProcessWire; /** * IconPicker : Custom Icons */ return [ "name" => "my-custom-icons", "title" => "My Custom Icon Set", "version" => "1.0.0", "styles" => array( wire("config")->urls->templates . "dist/css/my-custom-icons.css" ), "scripts" => array( wire("config")->urls->templates . "dist/js/my-custom-icons.js" ), "categorized" => true, "attributes" => array(), "icons" => array( "brand-icons" => array( "title" => "Brand Icons", "icons" => array( "google", "facebook", "twitter", "instagram" ) ), "flag-icons" => array( "title" => "Flag Icons", "icons" => array( "tr", "gb", "us", "it", "de", "nl", "fr" ) ) ) ]; Example config file : use existing and extend it.
      File location is site/configs/IconPicker.altivebir.php
      <?php namespace ProcessWire; /** * IconPicker : Existing & Extend */ $resource = include wire("config")->paths->siteModules . "FieldtypeFontIconPicker/configs/IconPicker.uikit.php"; $url = wire("config")->urls->templates . "dist"; $resource["scripts"] = array_merge($resource["scripts"], ["{$url}/js/Altivebir.Icon.min.js"]); $resource["icons"]["flag-icons"] = [ "title" => "Flag Icons", "icons" => array("tr", "en", "fr", "us", "it", "de") ]; $resource["icons"]["brand-icons"]["icons"] = array_merge($resource["icons"]["brand-icons"]["icons"], array( "altivebir" )); return $resource; After you add your custom config file, you will see your config file on library select box. Library Title (Location Folder Name).

      If your library categorized and if you have categorized icons set like uikit and fontawesome libraries, you will have category limitation options per icon field or leave it empty for allow all categories (default).

      Example : output
      if ($icon = $page->get("iconField")) { echo "<i class='prefix-{$icon}' />"; } MarkupFontIconPicker Usage
      // MarkupFontIconPicker::render(YourIconField=string, Options=array) echo MarkupFontIconPicker::render($page->YourIconField, [ 'prefix' => 'uk-icon-', // Icon class prefix, if you have different prefix, default is : "fa fa-" 'tag' => 'span', // Icon tag default is : "i" 'class' => 'fa-lg', // If you have extra cutom classes, for example : icons sizes, Array or Sting value 'style' => 'your custom styles if you have' // Array or String Value ]); Theme support

      Search support

      Category support

       
×
×
  • Create New...