Jump to content
tpr

AdminOnSteroids

Recommended Posts

Great thanks for this. Efficiency boost a lot!

I have tried a bit to solve the jump and search value removal after selecting. I have changed aos.js(around line 1411) to below. It seems working good for single instance.

var selectScrollTop,searchText;

// this selecting save the scroll position and search value
$(document).on('select2:selecting', '.asmSelect', function (event) {
    selectScrollTop = $(".select2-results__options").scrollTop();
    searchText = $(".select2-search__field").val();

});

$(document).on('select2:select', '.asmSelect', function (event) {
    var $asmSelect = $(this),
        src = event.target || event.srcElement;

    if (src.tagName === 'SELECT') {

        // var inputSelector = '.select2-search__field',
        //     searchTermAttr = 'data-select2-search-term',
        //     searchTerm = $(inputSelector).val();

        // save search term in parent's data attr
        // $asmSelect.parent().attr(searchTermAttr, searchTerm);

        // change and rebuild + reopen
        $asmSelect.val(null).trigger('change.select2');
        $asmSelect.select2('destroy');

        if ($asmSelect.parent().find('[data-asm-placeholder]').length) {
            select2Config.placeholder = $asmSelect.parent().find('[data-asm-placeholder]').attr('data-asm-placeholder');
        }

        $asmSelect.select2(select2Config);
        $asmSelect.select2('open');
        // the below 2 lines are added to restore the scroll position and search result
        $(".select2-search__field").val(searchText).trigger('keyup').trigger('input');
        $(".select2-results__options").scrollTop(selectScrollTop);
        // restore previous search term
        // $(inputSelector).val($asmSelect.parent().attr(searchTermAttr));
        // $(inputSelector).trigger('keyup').select();
    }
});

Edit: I overlooked. You have already made the search term restoration but you have commented them. Any considerations for this?

  • Like 3

Share this post


Link to post
Share on other sites

That's because I wasn't sure that search term restoration is beneficial after trying it. When it's restored, you have to delete it to search for something else. For me this caused more typing because it's very rare that I will add consecutive items starting with the same string. But feel free to prove the opposite, perhaps it's just my own scenario. 

Share this post


Link to post
Share on other sites

It really depends. User like me use prefix on field name would benefit from keeping the search term. The reason why I prefix fields is to distinguish what inputfield the field are using. For page reference field for product I name it page_product, so I can quickly spot the field when I search "product" or "page". I also believe many developers here like you do not use prefix a lot too. It seems like no perfect solution here unless everyone name and use fields in the same way. The best way might be that the keeping search term and scroll position could be toggle on/off. Anyway, they are relatively minor, the search function is already a great efficiency boost for me and also saves me from future client's complaints.:lol:

  • Like 2

Share this post


Link to post
Share on other sites
13 minutes ago, Karl_T said:

The best way might be that the keeping search term and scroll position could be toggle on/off.

I can make them configurable. As for the scroll position I will try your fix and also try something else. 

  • Like 2
  • Thanks 1

Share this post


Link to post
Share on other sites
13 hours ago, tpr said:

and also try something else

Ok, that thing wasn't that successful so @Karl_T's workaround was kept to keep the scroll position, thanks! Works quite well now, that was the missing piece to the cake :)

I haven't made keeping the scroll position optional but did that for the searched term.

  • Like 4

Share this post


Link to post
Share on other sites

Minor update: instead of higlighting the searched term now the cursor is moved to the end of the text in the asmSelect search box. Re-download aos.min.js if you have already updated the module to 1.7.8 as version number haven't changed.

  • Like 1

Share this post


Link to post
Share on other sites

The searchable AsmSelect feature is cool!

Just wanted to add: ajax-loaded inputfields (via inputfield visibility setting or repeater item setting) trigger a "reloaded" event on the inputfield to signal when the field is loaded. So you could use this instead of the requestAnimationFrame trick if you want. See InputfieldAsmSelect.js for an example of how this event can be used.

$(document).on('reloaded', '.InputfieldAsmSelect, .InputfieldPage', function() {
  console.log('The AsmSelect inputfield was ajax-loaded');
});

 

  • Like 2

Share this post


Link to post
Share on other sites

Thanks but this case this signals that the field is ready, but select2.js needs asmSelect to be ready too. I used a 700ms setTimeout to fix (using the reloaded event) but that was less reliable and much slower too. In fact it may work now that I modified my stuff a lot but I think requestanimationframe works just fine, no need to swap out. 

  • Like 3

Share this post


Link to post
Share on other sites

Looks like a bug in the new ASM tweaks.

It's fine if at least one item is selected:

image.png.eb4164a57de5aa6fc4b4b061937b9ceb.png

 

But. if you remove the selection in the first ASM, then the field is broken:

image.png.298e5804fd7ef55f1fdaf085d1597fee.png

Here is the js error:

Uncaught TypeError: Cannot read property 'length' of null
    at HTMLSelectElement.<anonymous> (aos.min.js?ts=1.7.8_2018030213:1)
    at Function.each (JqueryCore.js?v=1519661844:2)
    at init.each (JqueryCore.js?v=1519661844:2)
    at HTMLDocument.<anonymous> (aos.min.js?ts=1.7.8_2018030213:1)
    at l (JqueryCore.js?v=1519661844:2)
    at Object.fireWith [as resolveWith] (JqueryCore.js?v=1519661844:2)
    at Function.ready (JqueryCore.js?v=1519661844:2)
    at HTMLDocument.A (JqueryCore.js?v=1519661844:2)

 

  • Like 2

Share this post


Link to post
Share on other sites

Thanks, but fortunately this one was totally unrelated. It was the case changer in AOS, in the MarkupSEO module the "Inputfield_titleSmart" named field triggered the case changer beause a selector was written like "[id^="Inputfield_title"]. I've also fixed a CSS positioning issue for the case changer. Check 1.7.9 for the fix.

(offtopic)

I got a js error if I remove all the selectors in the MarkupSEO settings, like you did in your second screenshot, on a regular page edit screen:

Uncaught Error: Syntax error, unrecognized expression: ,input[name=seo_title]

In MarkupSEO.php it seems this line assumes there's at least one field selected:

$('{$titleFieldsSelectors},input[name=seo_title]').keyup(function(){

This fixes it:

$('{$titleFieldsSelectors}').add('input[name=seo_title]').keyup(function(){

Could you check this? I'll add the fix to the MarkupSEO github if you (or someone) could confirm this.

  • Like 1

Share this post


Link to post
Share on other sites

Weird - I am not seeing that error in the SEO module after upgrading AOS. I am going to be doing some major enhancements to the SEO module shortly so I'll investigate more as I go along.

Thanks for the case changer fix though!

  • Like 1

Share this post


Link to post
Share on other sites
6 hours ago, adrian said:

in the SEO module

I meant a regular page edit screen, eg editing the Home page. 

6 hours ago, adrian said:

am going to be doing some major enhancements to the SEO module

Sounds great, looking forward to it! 

  • Like 2

Share this post


Link to post
Share on other sites

One question regarding the ASM tweaks - I would like there to be an option to lose focus on the search box after choosing an option. At the moment you need to hit ESC or click off to see the selection. I understand that if you are making lots of selections the current behavior is more efficient, but I think some site editors might be confused. Or maybe I am overthinking it? Any thoughts?

  • Like 1

Share this post


Link to post
Share on other sites

I'll make optional to keep the list open. 

  • Like 2

Share this post


Link to post
Share on other sites

Just made it optional in v1.8.0.

Also the built-in asmSelect placeholder is now kept when asmSearchbox is enabled, eg. the fieldselector on editing a template now retains the placeholder value after adding a field.

  • Like 3

Share this post


Link to post
Share on other sites

I just got a notice whenever I go to the module section:

Quote

Notice: Trying to get property of non-object in /project/site/assets/cache/FileCompiler/site/modules/AdminOnSteroids/AdminOnSteroids.module on line 2605
 

  • PW 3.0.85
  • Updated AOS half an hour ago.
  • Cleared site/assets/cache
  • Refreshed modules + did "clear compiled files"

The notices (the appear twice) remain...

Share this post


Link to post
Share on other sites

Thanks, interestingly I don't get any notices but I see where can it fail. Could you try disabling line 2605 with this?

if (!empty($configData['IUC_enabledTemplates']) && $editedPage->template && !in_array($editedPage->template->name

 

Share this post


Link to post
Share on other sites

@tpr, I noticed that the positioning of the button dropdown is a bit off for the Save button at the bottom of Page Edit (AOS feature "Show save dropdown on hover instead on click"). The one at the top is okay. Seems that both the Default and Uikit themes are affected.

Top button (all good):

2018-03-09_161857.png.b466fc3e994560304d3d57ab49d45549.png

Bottom button (position is off):

2018-03-09_161921.png.12cf60497df558b30184196c239c0f9e.png

Share this post


Link to post
Share on other sites

@Robin S Thanks, I'll have a look.

Input masks

continued from here

I've managed to make it work on multilanguage installs, however, PW doesn't load the non-default field's value automatically (on the field config page). It's only a matter of a few extra lines but I feel this is a bug, or perhaps I'm doing things wrong.

// $this->addHookAfter("Field(type=FieldtypeText|FieldtypeTextLanguage)::getConfigInputfields", $this, "addInputMaskConfigField");

$f = $this->wire('modules')->get("InputfieldTextarea");
$f->attr('name', "inputMask");
$f->label = $this->_("Input Mask");
$f->useLanguages = true;

// setting value here, but this doesn't set for non-default languages
$f->value = $field->inputMask;

// need to iterate on languages and set each separately
if ($this->wire('languages')) {
    foreach ($this->wire('languages') as $lang) {
        if ($lang->isDefault()) continue;
        $f->{'value' . $lang->id} = $field->{'inputMask' . $lang->id};
    }
}

See the comments in the snippet, am I missing something?

File size

Another issue is that Cleave comes with many javascript files for phone masks, one for each country, that's about 3.4 Mb altogether. This would increase AOS size a lot (about 2.5 times as now), which I don't like a lot.

Any idea how to overcome this? Should I load them via cdn? I've found bootcdn.cn only where they are available but I know nothing about that site.

Or perhaps make it somehow available through $config->inputMaskAddons or something, and devs should take care of that if needed?

  • Like 1

Share this post


Link to post
Share on other sites

Hey @tpr - just wondering if you'd had any more thoughts on my idea for a check/unceck all option for multi-checkbox fields? I am going to need some sort of solution for one of my current projects. I can hack something together if need be, but I know you'll do a better job ;)

If you don't have time, or desire for this, just let me know - thanks!

Share this post


Link to post
Share on other sites

Version 1.8.1 adds Input mask feature and the misaligned bottom save button dropdowns should also be fixed.

As for the phone country library for input masks (Cleave.js) I've added the all-in-one library which weighs about 250 Kb.
It's not loaded automatically so you'll need to check it in the module settings page if you need it.

  • Like 2

Share this post


Link to post
Share on other sites
Just now, adrian said:

just wondering if you'd had any more thoughts on my idea for a check/unceck all option for multi-checkbox fields?

Not really, only an addition to yours, that is, showing the "Check all" only on hover. But this of course would be unavailable on mobile which is not that bad imho.

  • Like 1

Share this post


Link to post
Share on other sites
2 minutes ago, tpr said:

Not really, only an addition to yours, that is, showing the "Check all" only on hover. But this of course would be unavailable on mobile which is not that bad imho.

Ok, maybe I was too subtle - by "thoughts", I meant "timeframe for implementing" :)

Honestly not being pushy, just wondering if you are interested in doing shortly, or whether I do need to set up something else. This project has lots of fields with lots of checkboxes and having them all checked will be quite a common need, so it's pretty important for the editor's experience / efficiency. 

  • Like 1

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    No registered users viewing this page.

  • Similar Content

    • By Gadgetto
      SnipWire - Snipcart integration for ProcessWire
      Snipcart is a powerful 3rd party, developer-first HTML/JavaScript shopping cart platform. SnipWire is the missing link between Snipcart and the content management framework ProcessWire.
      With SnipWire, you can quickly turn any ProcessWire site into a Snipcart online shop. The SnipWire plugin helps you to get your store up and running in no time. Detailed knowledge of the Snipcart system is not required.
      SnipWire is free and open source licensed under Mozilla Public License 2.0! A lot of work and effort has gone into development. It would be nice if you could donate an amount to support further development:

      Status update links (inside this thread) for SnipWire development
      2020-01-28 -- added Custom Order Fields feature (first SnipWire release version is near!) 2020-01-21 -- Snipcart v3 - when will the new cart system be implemented? 2020-01-19 -- integrated taxes provider finished (+ very flexible shipping taxes handling) 2020-01-14 -- new date range picker, discount editor, order notifiactions, order statuses, and more ... 2019-11-15 -- orders filter, order details, download + resend invoices, refunds 2019-10-18 -- list filters, REST API improvements, new docs platform, and more ... 2019-08-08 -- dashboard interface, currency selector, managing Orders, Customers and Products, Added a WireTabs, refinded caching behavior 2019-06-15 -- taxes provider, shop templates update, multiCURL implementation, and more ... 2019-06-02 -- FieldtypeSnipWireTaxSelector 2019-05-25 -- SnipWire will be free and open source Plugin Key Features
      Fast and simple store setup Full integration of the Snipcart dashboard into the ProcessWire backend (no need to leave the ProcessWire admin area) Browse and manage orders, customers, discounts, abandoned carts, and more Process refunds and send customer notifications from within the ProcessWire backend Process Abandoned Carts + sending messages to customers from within the ProcessWire backend Complete Snipcart webhooks integration (all events are hookable via ProcessWire hooks) Integrated taxes provider (which is more flexible then Snipcart own provider) Useful Links
      SnipWire in PW modules directory (alpha version only available via GitHub) SnipWire Docs (please note that the documentation is a work in progress) SnipWire @GitHub (feature requests and suggestions for improvement are welcome - I also accept pull requests) Snipcart Website  
      ---- INITIAL POST FROM 2019-05-25 ----
       
    • By d'Hinnisdaël
      Happy new year, everybody 🥬
      I've been sitting on this Dashboard module I made for a client and finally came around to cleaning it up and releasing it to the wider public. This is how it looks.
      ProcessWire Dashboard

      If anyone is interested in trying this out, please go ahead! I'd love to get some feedback on it. If this proves useful and survives some real-world testing, I'll add this to the module directory.
      Download
      You can find the latest release on Github.
      Documentation
      Check out the documentation to get started. This is where you'll find information about included panel types and configuration options.
      Custom Panels
      My goal was to make it really simple to create custom panels. The easiest way to do that is to use the panel type template and have it render a file in your templates folder. This might be enough for 80% of all use cases. For anything more complex (FormBuilder submissions? Comments? Live chat?), you can add new panel types by creating modules that extend the DashboardPanel base class. Check out the documentation on custom panels or take a look at the HelloWorld panel to get started. I'm happy to merge any user-created modules into the main repo if they might be useful to more than a few people.
       Disclaimer
      This is a pre-release version. Please treat it as such — don't install it on production sites. Just making sure 🍇
      Roadmap
      These are the things I'm looking to implement myself at some point. The wishlist is a lot longer, but those are the 80/20 items that I probably won't regret spending time on.
      Improve documentation & add examples ⚙️ Panel types Google Analytics ⚙️ Add new page  🔥 Drafts 🔥 At a glance / Page counter 404s  Layout options Render multiple tabs per panel panel groups with heading and spacing between ✅ panel wrappers as grid item (e.g. stacked notices) ✅ Admin themes support AdminThemeReno and AdminThemeDefault ✅ Shortcuts panel add a table layout with icon, title & summary ✅ Chart panel add default styles for common chart types ✅ load chart data from JS file (currently passed as PHP array) Collection panel support image columns ✅ add buttons: view all & add new ✅
    • By Robin S
      This module is inspired by and similar to the Template Stubs module. The author of that module has not been active in the PW community for several years now and parts of the code for that module didn't make sense to me, so I decided to create my own module. Auto Template Stubs has only been tested with PhpStorm because that is the IDE that I use.
      Auto Template Stubs
      Automatically creates stub files for templates when fields or fieldgroups are saved.
      Stub files are useful if you are using an IDE (e.g. PhpStorm) that provides code assistance - the stub files let the IDE know what fields exist in each template and what data type each field returns. Depending on your IDE's features you get benefits such as code completion for field names as you type, type inference, inspection, documentation, etc.
      Installation
      Install the Auto Template Stubs module.
      Configuration
      You can change the class name prefix setting in the module config if you like. It's good to use a class name prefix because it reduces the chance that the class name will clash with an existing class name.
      The directory path used to store the stub files is configurable.
      There is a checkbox to manually trigger the regeneration of all stub files if needed.
      Usage
      Add a line near the top of each of your template files to tell your IDE what stub class name to associate with the $page variable within the template file. For example, with the default class name prefix you would add the following line at the top of the home.php template file:
      /** @var tpl_home $page */ Now enjoy code completion, etc, in your IDE.

      Adding data types for non-core Fieldtype modules
      The module includes the data types returned by all the core Fieldtype modules. If you want to add data types returned by one or more non-core Fieldtype modules then you can hook the AutoTemplateStubs::getReturnTypes() method. For example, in /site/ready.php:
      // Add data types for some non-core Fieldtype modules $wire->addHookAfter('AutoTemplateStubs::getReturnTypes', function(HookEvent $event) { $extra_types = [ 'FieldtypeDecimal' => 'string', 'FieldtypeLeafletMapMarker' => 'LeafletMapMarker', 'FieldtypeRepeaterMatrix' => 'RepeaterMatrixPageArray', 'FieldtypeTable' => 'TableRows', ]; $event->return = $event->return + $extra_types; }); Credits
      Inspired by and much credit to the Template Stubs module by mindplay.dk.
       
      https://github.com/Toutouwai/AutoTemplateStubs
      https://modules.processwire.com/modules/auto-template-stubs/
    • By Mike Rockett
      Jumplinks for ProcessWire
      Release: 1.5.60
      Composer: rockett/jumplinks
      ⚠️ NOTICE: 1.5.60 is an important security patch-release for an XSS vulnerability discovered by @phlp. It's HIGHLY RECOMMENDED that all Jumplinks users update to the latest version as soon as possible.
      Jumplinks is an enhanced version of the original ProcessRedirects by Antti Peisa.
      The Process module manages your permanent and temporary redirects (we'll call these "jumplinks" from now on, unless in reference to redirects from another module), useful for when you're migrating over to ProcessWire from another system/platform. Each jumplink supports wildcards, shortening the time needed to create them.
      Unlike similar modules for other platforms, wildcards in Jumplinks are much easier to work with, as Regular Expressions are not fully exposed. Instead, parameters wrapped in curly braces are used - these are described in the documentation.
      Under Development: 2.0, to be powered by FastRoute
      As of version 1.5.0, Jumplinks requires at least ProcessWire 2.6.1 to run.
      View on GitLab
      Download via the Modules Directory
      Read the docs
      Features
      The most prominent features include:
      Basic jumplinks (from one fixed route to another) Parameter-based wildcards with "Smart" equivalents Mapping Collections (for converting ID-based routes to their named-equivalents without the need to create multiple jumplinks) Destination Selectors (for finding and redirecting to pages containing legacy location information) Timed Activation (activate and/or deactivate jumplinks at specific times) 404-Monitor (for creating jumplinks based on 404 hits) Additionally, the following features may come in handy:
      Stale jumplink management Legacy domain support for slow migrations An importer (from CSV or ProcessRedirects) Feedback & Feature Requests
      I’d love to know what you think of this module. Please provide some feedback on the module as a whole, or even regarding smaller things that make it whole. Also, please feel free to submit feature requests and their use-cases.
      Note: Features requested so far have been added to the to-do list, and will be added to 2.0, and not the current dev/master branches.
      Open Source

      Jumplinks is an open-source project, and is free to use. In fact, Jumplinks will always be open-source, and will always remain free to use. Forever. If you would like to support the development of Jumplinks, please consider making a small donation via PayPal.
      Enjoy! 🙂
    • By Robin S
      Add Image URLs
      Allows images/files to be added to Image/File fields by pasting URLs.

      Usage
      Install the Add Image URLs module.
      A "Paste URLs" button will be added to all image and file fields. Use the button to show a textarea where URLs may be pasted, one per line. Images/files are added when the page is saved.
       
      https://github.com/Toutouwai/AddImageUrls
      https://modules.processwire.com/modules/add-image-urls/
×
×
  • Create New...