adrian

Thanks - now I understand all the rationale here. My approach is to simply permanently turn on the Mail Interceptor panel in Tracy - it logs calls to send emails rather than sending them. And when you want to test send to yourself instead of the actual recipients, it can handle that as well. Just another option if you think it would be ok in your workflow.

I don't think I know this version. Would you mind linking to it please.

Perhaps you can just grab a copy of leaflet.js and serve it up locally. Then you can edit it to replace those http calls with https

That replacement needs to be inside the foreach. You probably also want to replace with " " instead of ""

Thanks @Soma - so far that looks to be working as expected.

Looks like there are lots of other issues along the same lines. So far I have also come across trying to set the "twitter_params" option. It is not sticking because this line: $params = $this->get($item . "_params"); needs to be: $params = $this->options[$item . "_params"]; but there are lots of other instances like this as well that I think need changing. Thanks again.

Hey @Soma - I just noticed a bug with overriding options. This is my $options array: $options = array( "theme" => "templates/social_themes/ms2s", "outer_wrapper_tag" => "span", "item_wrapper_tag" => "span style='float:left' ", "text" => $page->share_email_text, "char_limit" => 9999 ); However, the char_limit isn't being respected. The problem is these lines: https://github.com/somatonic/MarkupSocialShareButtons/blob/7b25cf4098a23ab79ea423082ecd200bc7a06590/MarkupSocialShareButtons.module#L381 https://github.com/somatonic/MarkupSocialShareButtons/blob/7b25cf4098a23ab79ea423082ecd200bc7a06590/MarkupSocialShareButtons.module#L402 $this->char_limit and $this->char_limit_sypnosis need to be $this->options['char_limit'] and $this->options['char_limit_synopsis'] respectively. Thanks!

Totally OT, but is there any reason this module loads 0.7.3 of leaflet when they are up to 1.3.4?

I don't use this module so maybe not the best person to respond, but it looks like it should load the https version. It was changed to this in this commit: https://github.com/madebymats/FieldtypeLeafletMapMarker/commit/eb0c1e703a0b3eb5bc6c00aaee44eb59a6d22dfe#diff-b979b991c53396a5160add7bfa0c8dcb

No guarantees, but from what I can tell about those changes, I don't think it should affect this module. If you find anything though please let me know and I'll attempt to fix it ASAP.

I don't know - you tell me ? I just took a very quick look and the basic functionality seems ok. Could you point me to what you are having issues with?

I have refactored a few things this morning. 1) On the module config settings page, if you have the Only display for EU visitors setting checked, the check for their status happens on every page load (session is ignored). This does not affect the frontend - users here will still only be checked once per session. 2) There is a new "Clear Local Storage" option to reset stored banner settings so that it's easier to test changes to the banner.

Ok, to help make it easy for you guys to test the vanilla JS version that @tpr put together, I have included a new toggle. It defaults to the jQuery one for now so you can upgrade to this new version without breaking anything. Everything appears to work fine, but I would like the folks that use the module together with Google Tag Manager to test that everything is firing as expected. Once I have some confirmation I will remove the jQuery version and this setting and also ask @tpr for a PR so he gets the Github credit for this. Thanks for helping to test.

Just had a small world experience. I have been emailing with Ueli at https://www.whatwedo.ch/ who are the folks who operate the https://ip.nf/ IP to country API service. He just mentioned that they are partners with https://novu.ch/ (built with PW) and that they use ProcessWire a lot. So anyway, he is keen to support this module and to make sure their service will be able to keep up with any requests made by it to their service ?

Just committed a significant upgrade. The IP to country lookup now has three services it can use - all of which support IPV6. You can specify the order and remove some if you like. They will be used in order and in case one fails, it will move onto the next one. You can now specify an IP address in the config settings to test. Note that saving the module config settings will remove the "FromEU" session variable so the result will be fresh each time. Also, because all of these three services can automatically detect the user's IP address, I am no longer supplying it via the API call (unless you are using the test option), which means that tests from your localhost dev environment will actually work properly. I have also included Tracy bd() calls that return more information. Obviously this will only show if you have Tracy installed, but it tells you which service was used, the results from it, and then the call to the other service to check if the country is in the EU, as well as the result of this test: true/false.

Yeah, looks like you are correct. I have found another free service that support IPv6 and it seems to be working fine now. I have committed a new version with this - I'd appreciate if some others could test and make sure there are no issues at your end. Note these lines: https://github.com/adrianbj/CookieManagementBanner/blob/609617167e476fb5a2d964aa431e2a8e7a749a93/CookieManagementBanner.module#L48-L50 if you want to force an EU IP address for testing - both the IPv4 and IPv6 addresses are German. Interesting point - I don't honestly know the ins and outs of the law, but I have added a note mentioning this to the config setting. A way to partially avoid this is relying on a local IP to Country database, but they are a pain to maintain, so I think for now the warning will have to do and devs can decide what they prefer. OT, but has anyone out there tested the vanilla JS fork by tpr yet? @GhostRider ?

I think Migrator would need to be updated to support these - it might not be too hard because of the similarity to repeaters.

This is much easier ? $u = $users->add('user-name');

I'm not really supporting it anymore because there are too many new fieldtypes to keep up with, but I still find this https://github.com/adrianbj/ProcessMigrator much easier and more reliable than the built in approach. Be sure to use the backup option because I know there are a few situations where it can do some weird things.

Hi @ceberlin - that's strange - for me on localhost the countryCode index is defined, but it is set to a blank string. Assuming you have Tracy installed, can you please replace the lines starting at 37 with this block: if(!$this->wire('session')->userFromEu) { $http = new WireHttp(); bd($this->get_user_ip_addr()); $userLocation = $http->getJSON('https://extreme-ip-lookup.com/json/'.$this->get_user_ip_addr()); bd($userLocation); // test EU IP address Then in the PW Info panel, click the "Clear Session & Cookies" link and then post the output of those two bd() calls. This is what I get:

I knew that request was coming ? I have added all this to the latest version, including the click again on the tab to collapse. Please test and let me know if the behavior is what you are looking for.

Just do it like this: $mail->mailHTML('alex@gmail.com', 'Hello', '<html><body><h1>Message Body</h1></body></html> without redefining $mail

Oh and I also made the dump in the additional tabs open (not collapsed) by default. My thinking on this is that if you dump lots of items, you don't want the default tab to be open by default because it could make for too much scrolling, but for the additional tabs, if you click on them then it's obvious you want to see the content so you shouldn't need to click again to expand the dump. Let me know if you guys don't like this behavior and if you have a preferred approach. See how below I can quickly scroll through to the dump I am looking for (because the default Debug Info tab content is collapsed), but when I switch to the Iterator or Full Object tabs, these are not collapsed.

It's not completely redundant - it still determines how dumps in the RequestInfo panel's Field List & Values sections are output. It also defines the default dump for the dump/barDump output for cases where the separate tabs may not kick in - not sure if there actually are any situations where this will happen. It now also controls the output of field values in the Iterator tab. Also with the new option (described below) to choose what tabs you want, if you choose none, then this setting will be relevant to how the one version of the dump is handled. Good idea - done: Thanks for reporting this undefined variable error - it's fixed now and hopefully there shouldn't be any other cases like this, but please let me know if you come across anything else.

Field pairings is only available when you define configurable pages - then in the Settings tab for those page you can setup the field pairings.