-
Posts
11,265 -
Joined
-
Last visited
-
Days Won
374
Everything posted by adrian
-
Ok, now the tables render correctly with Github's MD parser. Take a look and let me know if you have any suggestions.
-
Except I didn't check the output in Github - I was using another Markdown editor which was rendering the tables correctly, but Github isn't - working on fixing it now.
-
Agreed, that does look nice. I have committed a new version with the following changes. Now we just need to get people using it more regularly ? Each section is structured as a table and with the Server Details not collapsed. The plain text version is basically the same, just with section titles added for clarity. SERVER DETAILS ProcessWire: 3.0.108 PHP: 7.2.6 Webserver: Apache/2.4.33 (Unix) MySQL: 8.0.11 SERVER SETTINGS allow_url_fopen: 1 max_execution_time: 120 (changeable) max_input_nesting_level: 64 max_input_time: 60 max_input_vars: 1000 memory_limit: 128M post_max_size: 8M upload_max_filesize: 50M xdebug: xdebug.max_nesting_level: GD: bundled (2.1.0 compatible) GIF: 1 JPG: 1 PNG: 1 EXIF Support: 1 FreeType: 1 Imagick Extension: MODULE DETAILS AdminOnSteroids: 1.9.8 BatchChildEditor: 1.8.12 BreadcrumbDropdowns: 0.1.0 CookieManagementBanner: 0.2.1 FieldtypeStreetAddress: 0.5.1 FormBuilder: 0.3.4 InputfieldFormBuilderFile: 0.0.2 InputfieldStreetAddress: 0.5.1 JquerySelectize: 1.0.4 MarkupSEO: 0.8.7 MarkupSitemap: 0.4.1 ModuleReleaseNotes: 0.10.7 ModuleSettingsImportExport: 0.2.9 PageRenameOptions: 1.0.4 ProcessAdminActions: 0.6.12 ProcessChildrenCsvExport: 1.7.0 ProcessFormBuilder: 0.3.4 ProcessWireUpgrade: 0.0.7 ProcessWireUpgradeCheck: 0.0.7 RestrictTabView: 1.1.3 TextformatterTagParser: 2.2.0 TracyDebugger: 4.10.25
-
I think that makes most sense. Just like this or do you think that a table layout would help with clarity?
-
Check out the latest version - I think it works pretty nicely! Happy to implement, but not sure the best interface - are you thinking about maybe splitting the the button into two: 1) Copy Simple for Github 2) Copy Detailed for Github Or do you have other ideas?
-
Glad you found the "Version's List" functionality - pretty handy isn't it ? Let me know if you think of any other info that should be added to it. Sorry about the code saving bug - hope you didn't lose too much! It is fixed in the latest commit.
-
Hi Steve, Thanks for the suggestion. I have added it to the just released version. Please let me know if you have any issues with it. PS - I am curious what you are using this panel for - I haven't had much feedback on it thus far.
-
Apologies - you are indeed correct. I can't imagine why it would actually have been changed - not sure why you'd need uppercase chars in a field name, but the description of what is allowed certainly has changed. https://github.com/ryancramerdesign/ProcessWire/blob/a210ba0b5ea67e56fef8a27a620bcfa6f96ca0b8/wire/modules/Process/ProcessField/ProcessField.module#L949 https://github.com/processwire/processwire/blob/48fe0769a4eb3d0f5b4732fd01b4b4ed8262d952/wire/modules/Process/ProcessField/ProcessField.module#L1196
-
I think it has always said this: "Use only ASCII letters (a-z A-Z), numbers (0-9) or underscores." I think it's likely we've just always assumed lowercase only because names suggest lowercase vs labels/titles which is where you expect difference cases, spaces, special chars etc.
-
Thanks @Robin S for picking that up and figuring out what the problem was. I have committed a new version which fixes the issue (the same version you tested via PM).
-
Thanks - I went looking for that flowchart but couldn't manage to find it.
- 6 replies
-
- documentation
- tutorial
-
(and 2 more)
Tagged with:
-
InputfieldPageName phonetic support to create slugs
adrian replied to Sten's topic in Multi-Language Support
I don't know much about this, but what about doing it via JS instead of PHP so that it works more seamlessly with PW's approach which is to slugify in realtime with JS. It would also mean automatic integration with the PageRenameOptions module. Here is some stuff on doing this with JS: https://ourcodeworld.com/articles/read/255/creating-url-slugs-properly-in-javascript-including-transliteration-for-utf-8 On a side note - I guess this doesn't work for your needs, but don't forget that you can change the character replacements by editing the settings for the core InputfieldPageName module. -
I should also add that you can also do: so $roles does contain all the roles, it just doesn't return an array that can be dumped by default, which is different to $templates and $fields - this seems like a bit of an API inconsistency to me. Also to note, you can do:
-
To expand on @netcarver's suggestion with Tracy and the find selector suggested by @kongondo In the Tracy Console panel you can do this. This finds all roles and then builds an array of the names for each of them. PS - you can also do: find('*') if it seems more semantic to you.
-
Interesting. Test this out. 1) Make sure you have: "Force editor links to use Tracy File Editor" checked. 2) Turn on the File Editor panel 3) Load a page and click the edit template icon at the bottom right of the Request Info panel - it should load the File Editor That works for me. Does it work for you?
- 12 replies
-
Hey @tpr - I think the issue with the file-editor.js file is that in Tracy it's not loaded until the File Editor panel is triggered. I don't think I really want to change this behavior because I'd rather Tracy loaded as little as possible on each page load and only bring in panel specific assets when needed. Is that ok? EDIT: actually I don't know why you are having to load it - surely you are still opening the editor panel - not sure why that file isn't loaded. Regarding the page reload - typically in the Tracy File Editor you are editing the template for the page you are viewing, so you actually want to reload the page to see the changes. Saving could be converted to AJAX, but then you'd need to reload the page anyway to see the changes. I understand it's not what you are looking for in this case though, so maybe we need an AJAX save option - maybe two buttons: Save and Save & Reload. Any thoughts?
- 12 replies
-
Hook for when a module's configuration is updated
adrian replied to Marc's topic in Module/Plugin Development
Maybe just use: http://modules.processwire.com/modules/settings-factory/ -
https://github.com/processwire/processwire-requests/issues/212
-
Getting OT, but does anyone know why $field doesn't have an addRole method, but $template does: https://processwire.com/api/ref/template/add-role/ Do we think this is a bug that needs reporting?
-
I went with the JS approach only to start with because I wanted the user to be able to see what the name is in realtime when they change the title of an already existing page - the same as we can when creating a new page. There are also other options like locking the name from being changed etc which I wanted to include in the module which also work best via JS. I only added the saveReady hook later when I realized that I also need to support title changes via the API (and also when the settings tab is hidden and the name isn't added to the content tab). As far as supporting EasySlugger, I think it can be done, but probably differently - maybe I just need to add a check to see if that module is installed and then also use the saveReady hook option rather than the JS one. Or maybe the EasySlugger module can just do that anyway, even after this module has done its thing? Not sure, but let me know what you need and I am happy to support it.
-
I'd be happy to, but I think the problem will be that this module mostly works with JS in realtime as the title is changed. The renameOnSave method that includes that line you referenced is only called by API changes to a page's title. So I guess I would also need to make sure renameOnSave is also called when the new EasySlugger module is installed and activated. Or are you thinking of some other approach to this that I am missing?
-
Yeah, I completely agree - it seems that VentureWeb always adds jQuery to their sites, but I rarely do. Let me check with them and see if they'd be willing to work with a non-jquery version. I have commit access to the Drupal version's repo, so if you or someone else would like to convert the PW version, I'd happily port those changes back to Drupal so things are easier going forward.
-
A little bit to make sure nothing appeared to be broken, but not thoroughly. You probably noticed from the JS that this module is very focused on GoogleTagManager, although you can still use it without GTM.
-
You know what - given that I am not really the author of this logic, I think it's just an easy for you to take a look yourself (in the js file) as it is for me to explain it ? Sorry if that seems lazy, but I don't really have time to maintain this module beyond bug fixes etc - I just want to make sure the PW community has access to it.