-
Posts
10,902 -
Joined
-
Last visited
-
Days Won
349
Everything posted by adrian
-
You can even test as a guest user by clicking the Logout button and the debug bar will still display.
-
That's what the User Switcher panel is for Have you tried it out?
-
Only reason I didn't do this for Tracy is that I doubt many people use this option - just figured it was one extra permission to clog up the list that perhaps only a very small percentage of users will actually apply to a role in their system. Does that seem fair enough? Or are lots of you actually using to to give Tracy access to non-superusers? If so, I can add to the install routine.
-
As @horst said, ImageExtra is the way for now, but Ryan has stated it's in the plans for the core: It's one of the key things I'd like to see implemented ASAP actually.
-
Actually, what do you guys @netcarver @FlorianA @bernhard think about putting 00:00:00 in the placeholder attribute - that way editors know what format to enter, but the value is still blank.
-
Hey @netcarver - using this for the first time - very handy, thank you! Just wondering if the field should be blank by default, rather than 00:00:00 ? I want to check to see if a time has been entered, but the way things are, it doesn't seem possible. I am doing the check against 00:00:00 but of course that is a valid time (fortunately not one that anyone would enter in my case, but in some others in certainly would be). Thanks. EDIT: Oops, looks like @FlorianA is already on this Anyway, looking forward to seeing that merged!
-
Yeah, I think that would be great - I think we need one feature-rich version going forward that has all these improvements. I don't expect Ryan will accept a PR, but I do remember sometime ago he suggested I could take over this module if I wanted - personally I don't really want to because I already have too many to support, but perhaps if we both had commit rights on the main repo we could share the load?
-
Hi @Robin S - glad you're finding the fork useful. 1. I can't see a difference in behavior from the main repo - it looks to me like the lat/lng get populated when creating a new page, but not the address field. I think this actually makes sense to me because I think it's really just designed to give the site editor a local starting view, rather than an exact address. Am I missing something? 2. Happy to incorporate the AJAX fix - thanks. 3. I honestly don't mind the spacing. It is applied differently in default and UiKit themes which makes it a bit of a pain. Probably changing the <p> to <div> as you suggested might make this a little cleaner. Perhaps you'd consider a PR to my repo so you can get it looking how you'd like it - better to have someone tweak this who has a definite opinion on it 4. I am looking at this now - agreed that this should be fixed, but I noticed a bit of a dilemma - currently I trigger the geocode request like this: if($street.val() && $city.val() && $state.val() && $postcode.val() && $country.val()) { $addrComponent.blur(function() { geoCodeAddr(); }); } In other words, don't trigger it until all subfields are complete (except the additional_address which isn't added to the address which gets geocoded anyway). So if you're in a situation where not all subfields are filled out, it won't geocode. I don't really want to have a manual geocode button - would rather it was automatic - what do you think? As for submitting a PR back to the main repo - I don't think there is really much point - I have a 4 year old PR there already which has been ignored Not that I want to have multiple forks of modules floating around either, but not sure what other option there is.
-
PS - Wow - the translation really was super easy
-
Yeah, you're probably right - I just haven't ever translated strings from a module before, but it sounds like it's easy - thanks!
-
Thanks heaps for the speedy service!
-
Thanks @Robin S - I sorted out the width with the Admin CSS feature of AOS. As for the translatable string - I'm a little unsure how to work with the recent change - I see you went from js language files to using PW's: $this->_( but wouldn't that mean I would need multi-language support installed to translate that? It's not a ML site, so that seems like an inefficient solution for me, but I am very tired, so might well be missing something here
-
Super useful module @thetuningspoon and @Macrura - any chance we could have the option for each page reference field whether the links should open in a modal, or straight into the current tab - I am wanting this as more of a navigation tool. Would this be easy enough to implement? Thanks!
-
Yeah, I have been using it here and works great for hiding certain user fields from non-superusers.
-
Hey Robin, I went to use this on the User template without success. Do you see any reason that can't be enabled with: if($this->page->process !== 'ProcessPageEdit' && $this->page->process !== 'ProcessUser') return; in the evaluateCustomDependencies() method?
-
Hey @Robin S - using this for the first time and finding it awesome. Couple of quick questions: Is there any easy way to prevent codes from being truncated in the dropdown? Also, what's the best way to change the name of "Insert Hanna tag" - I see that they are translatable (via separate js files), but what's the suggestion for avoiding having changes overridden with module updates? Thanks!
-
One question regarding the ASM tweaks - I would like there to be an option to lose focus on the search box after choosing an option. At the moment you need to hit ESC or click off to see the selection. I understand that if you are making lots of selections the current behavior is more efficient, but I think some site editors might be confused. Or maybe I am overthinking it? Any thoughts?
-
No - it was a PM that I sent to Ryan - I didn't want to bug him about it publicly. I just tried to add you to the PM, but it said you couldn't be added - not sure, I haven't used that feature before. Thanks for the module link - I'll take a look.
-
Weird - I am not seeing that error in the SEO module after upgrading AOS. I am going to be doing some major enhancements to the SEO module shortly so I'll investigate more as I go along. Thanks for the case changer fix though!
-
Looks like a bug in the new ASM tweaks. It's fine if at least one item is selected: But. if you remove the selection in the first ASM, then the field is broken: Here is the js error: Uncaught TypeError: Cannot read property 'length' of null at HTMLSelectElement.<anonymous> (aos.min.js?ts=1.7.8_2018030213:1) at Function.each (JqueryCore.js?v=1519661844:2) at init.each (JqueryCore.js?v=1519661844:2) at HTMLDocument.<anonymous> (aos.min.js?ts=1.7.8_2018030213:1) at l (JqueryCore.js?v=1519661844:2) at Object.fireWith [as resolveWith] (JqueryCore.js?v=1519661844:2) at Function.ready (JqueryCore.js?v=1519661844:2) at HTMLDocument.A (JqueryCore.js?v=1519661844:2)
-
Hi @Zeka I am not totally sure about why, but from what I can tell errors that show up in PW logs, but are not picked up by Tracy because the error is triggered in PW before Tracy is loaded. I have asked @ryan about adding a special method to allow loading Tracy earlier - he initially sounded supportive, but he hasn't gotten back to me since my follow up request. I think it's only ever a problem when doing something in init() so it doesn't happen that often. How did you go with those snippets to fix the Console panel problem?
-
Just wanted to say how great all these new ASM tweaks are - thanks @tpr and @Karl_T
-
Hey @Zeka - I have a fix for you, although I think you'll have to do it in your module - I haven't figured out how to do it from the Tracy side yet. Add this to the top of your TemplateFile::render hook: if(strpos($event->object->filename, 'TracyDebugger') !== false) return; I haven't had a good look (too busy atm), but if someone else has an idea on how Tracy could remove/cancel a TemplateFile::render hook when running code via Console/Snippet Runner I'd be happy to do it from Tracy's side instead. PS - here's another possible option instead of the above: if(str_replace('site/assets/cache/FileCompiler/', '', $event->object->filename) !== $this->wire('page')->template->filename) return; This will ignore your hook if the template file from the hook event is different to the template file for the current page. I am not sure about this in your situation, but if it works it's obviously more flexible than just blocking Tracy template files.
-
Thanks @Zeka - yeah a bit challenging because of missing methods (and not enough time right now to futz with it). If you want to send me a copy of the module before you post it publicly, I can test and get a fix in place for the Console panel.